On Tue, 6 Feb 2024 03:10:36 GMT, Sergey Bylokhov wrote:
> The ClipShapeTest test is split into 4 different tests which could be
> executed in parallel.
>
> The execution time is changed from:
>
>
> ==
> Test summary
> ==
>TEST
On Fri, 9 Feb 2024 14:23:28 GMT, Alexey Ivanov wrote:
>> As far as I can see, the real problem is that `DWMIsCompositionEnabled`
>> calls a Java method and does not check if an exception occurred. It should
>> do it according to the JNI specification.
>>
>> I can assume `initScreens(env)`
On Wed, 31 Jan 2024 06:05:18 GMT, Christoph Langer wrote:
>> This picks up fixing the issue of
>> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) again. A fix had
>> been integrated with #17224 but @prrace had concerns and so it was backed
>> out.
>>
>> I have now spent quite some
> - new executor modes (buffer & volatile)
> - support parallel rendering on several frames and / or screens
> - added robot calibration + optionally use rounded duration to min frame
> latency (120Hz)
> - give more statistics in verbose (-v)
> - added new command-line arguments
> - added version
On Fri, 9 Feb 2024 14:59:06 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test with 'PassFailJFrame' with programmatically
> generating image and print , please review and let me know your suggestions.
> > > I thought SkippedException looks like a "pass" too ?
>
On Fri, 9 Feb 2024 20:01:50 GMT, Phil Race wrote:
> However, @key printer also covers the condition in this case.
Yes, if we didn't have a keyword, then it would be less reasonable to fail the
test.
Like if a test requires multimon, and we don't have a keyword to support
filtering such tests,
On Fri, 9 Feb 2024 19:27:32 GMT, Alexey Ivanov wrote:
> > I thought SkippedException looks like a "pass" too ?
> > What is effectively different by using it here ?
>
> No, it's not. If a test throws `jtreg.SkippedException`, then it's reported
> as **skipped**. It is neither a failure nor a
On Fri, 9 Feb 2024 19:11:22 GMT, Phil Race wrote:
> I thought SkippedException looks like a "pass" too ?
> What is effectively different by using it here ?
No, it's not. If a test throws `jtreg.SkippedException`, then it's reported as
**skipped**. It is neither a failure nor a success — it
On Fri, 9 Feb 2024 14:59:06 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test with 'PassFailJFrame' with programmatically
> generating image and print , please review and let me know your suggestions.
I thought SkippedException looks like a "pass" too ?
What is
On Fri, 9 Feb 2024 18:13:50 GMT, Alexey Ushakov wrote:
>> Laurent Bourgès has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323695: use Font.DIALOG
>
> test/jdk/performance/client/RenderPerfTest/src/renderperf/RenderPerfTest.java
>
On Thu, 8 Feb 2024 22:12:17 GMT, Laurent Bourgès wrote:
>> - new executor modes (buffer & volatile)
>> - support parallel rendering on several frames and / or screens
>> - added robot calibration + optionally use rounded duration to min frame
>> latency (120Hz)
>> - give more statistics in
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote:
> This is an attempt to finally implement the idea brought forward in
> JDK-8295729: Properties files is essentially source code. It should have the
> same whitespace checks as all other source code, so we don't get spurious
>
On Fri, 9 Feb 2024 14:59:06 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test with 'PassFailJFrame' with programmatically
> generating image and print , please review and let me know your suggestions.
test/jdk/java/awt/PrintJob/ImageTest/ImageTest.java line 151:
On Fri, 9 Feb 2024 14:59:06 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test with 'PassFailJFrame' with programmatically
> generating image and print , please review and let me know your suggestions.
Should we mark `paint` and `imageUpdate` with `@Override`
Hi Reviewers,
I have updated the test with 'PassFailJFrame' with programmatically generating
image and print , please review and let me know your suggestions.
-
Commit messages:
- JDK-8321192 : j.a.PrintJob/ImageTest/ImageTest.java: Fail or skip the test
if there's no printer
On Fri, 9 Feb 2024 13:42:02 GMT, Magnus Ihse Bursie wrote:
>> This is an attempt to finally implement the idea brought forward in
>> JDK-8295729: Properties files is essentially source code. It should have
>> the same whitespace checks as all other source code, so we don't get
>> spurious
I took a look at this file and found a couple of points that I’m not sure about
(unrelated to the RFR):
EventQueue.isDispatchThread
returns true if and only if the calling thread is the
event dispatch thread started by the machinery;
The statement that events are dispatched on
On Fri, 9 Feb 2024 10:52:54 GMT, Prasanta Sadhukhan
wrote:
>> When `` tag is used inside ``, the `line-through` style is lost, and
>> the text is rendered with `underline` only. However, if `` is used,
>> the text is rendered with both `underline` and `line-through` styles.
>>
>> Both `` and
On Fri, 9 Feb 2024 03:12:57 GMT, Phil Race wrote:
>> Yes. However, it's "only" in the assertion callback that only exists in
>> debug VMs. And an original exception isn't lost.
>
> Perhaps what we should do here is
> if (ExceptionCheck) {
> ExceptionDescribe
> ExceptionClear
> }
> So someone
On Fri, 9 Feb 2024 14:20:02 GMT, Alexey Ivanov wrote:
>> Perhaps what we should do here is
>> if (ExceptionCheck) {
>> ExceptionDescribe
>> ExceptionClear
>> }
>> So someone can "see" [yes, this means it isn't propagated but we've printed
>> it and we have the assert coming up anyway] the
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote:
> This is an attempt to finally implement the idea brought forward in
> JDK-8295729: Properties files is essentially source code. It should have the
> same whitespace checks as all other source code, so we don't get spurious
>
On Fri, 9 Feb 2024 10:52:01 GMT, Prasanta Sadhukhan
wrote:
>> When `` tag is used inside ``, the `line-through` style is lost, and
>> the text is rendered with `underline` only. However, if `` is used,
>> the text is rendered with both `underline` and `line-through` styles.
>>
>> Both `` and
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote:
> This is an attempt to finally implement the idea brought forward in
> JDK-8295729: Properties files is essentially source code. It should have the
> same whitespace checks as all other source code, so we don't get spurious
>
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote:
> This is an attempt to finally implement the idea brought forward in
> JDK-8295729: Properties files is essentially source code. It should have the
> same whitespace checks as all other source code, so we don't get spurious
>
This is an attempt to finally implement the idea brought forward in
JDK-8295729: Properties files is essentially source code. It should have the
same whitespace checks as all other source code, so we don't get spurious
trailing whitespace changes or leading tabs instead of spaces.
With Skara
On Fri, 9 Feb 2024 02:17:01 GMT, Phil Race wrote:
> > I ran the test in our CI and I didn't notice an improvement.
>
> Did you run jdk:tier4 like Sergey was doing ?
No, I ran just this single test. I don't know how Sergey is running the test.
> Our CI runs some number of (headless) tests in
> JLabel text is not painted with the LAF defined foreground color in GTK LAF.
> In GTK LAF the foreground color is retrieved by using native system APIs. Fix
> is to return the foreground color if it is set by LAF defined property
> otherwise return the default color by calling native APIs.
>
On Fri, 9 Feb 2024 02:13:16 GMT, Sergey Bylokhov wrote:
>> The ClipShapeTest test is split into 4 different tests which could be
>> executed in parallel.
>>
>> The execution time is changed from:
>>
>>
>> ==
>> Test summary
>> ==
>>
> JTabbedPane's content area, tab area and tab background color are not as
> expected when opaque is set to true or false.
> The proposed fix is to handle the TabbedPane's background color in installed
> LAFs. Manual test is added to support the fix and there is no regression
> caused by the
On Tue, 6 Feb 2024 08:39:01 GMT, Alexey Ivanov wrote:
> Replace _“effect”_ with _“affect”_¹ because the meaning in the phrase “…the
> changes only _effect_ subsequent notification” is to “have an effect on.”
>
> Add a comma to separate a conditional clause from the main one.
>
> Use ``
On Thu, 8 Feb 2024 07:44:18 GMT, Magnus Ihse Bursie wrote:
>> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
>> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
>> native libraries.
>
> Magnus Ihse Bursie has updated the pull request
On Wed, 7 Feb 2024 17:48:41 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Disposed g2D object and similar test parm into one line
>
>
On Wed, 31 Jan 2024 17:08:58 GMT, Alexey Ivanov wrote:
> When `` tag is used inside ``, the `line-through` style is lost, and
> the text is rendered with `underline` only. However, if `` is used,
> the text is rendered with both `underline` and `line-through` styles.
>
> Both `` and `` should
On Thu, 8 Feb 2024 05:17:02 GMT, Abhishek Kumar wrote:
> JLabel text is not painted with the LAF defined foreground color in GTK LAF.
> In GTK LAF the foreground color is retrieved by using native system APIs. Fix
> is to return the foreground color if it is set by LAF defined property
>
> Hi Reviewers,
>
> Updated manual printer test cases with 'PassFailJFrame', also removed unused
> variables. Added 'SkippedException' in case of printer missing or not
> configured.
>
> Please review and let me know your suggestions.
>
> Regards,
> Renjith
Renjith Kannath Pariyangad has
On Fri, 9 Feb 2024 03:21:44 GMT, Phil Race wrote:
>> vtstydev has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Remove trailing whitespace
>> - Done requested fixes 2
>
>> > Revert the changes to the test which limit the pages printed
On Thu, 8 Feb 2024 12:03:19 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Review comments integrated
>
> test/jdk/java/awt/print/PrinterJob/DrawImage.java line 131:
>
>> 129:
> More correct way to take in consideration nonzero PHYSICALOFFSETX,
> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows
> platform under certain conditions real device prints shifted image on paper.
vtstydev has updated the pull request incrementally with one
On Tue, 6 Feb 2024 05:43:26 GMT, Abhishek Kumar wrote:
> JTabbedPane's content area, tab area and tab background color are not as
> expected when opaque is set to true or false.
> The proposed fix is to handle the TabbedPane's background color in installed
> LAFs. Manual test is added to
39 matches
Mail list logo
