Integrated: 8314070: javax.print: Support IPP output-bin attribute extension

2024-06-03 Thread Alexander Scherbatiy
On Thu, 12 Oct 2023 15:39:45 GMT, Alexander Scherbatiy wrote: > The fix adds new public `OutputBin` print attribute class which allow to set > a printer output bin in a `PrinterJob` class. The corresponding internal > `CustomOutputBin` class is added as well. > > -

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v17]

2024-06-03 Thread Alexander Scherbatiy
On Thu, 30 May 2024 18:53:49 GMT, Alexander Scherbatiy wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add Skip test option to the OutputBinAttributePrintDialogTest wi

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-31 Thread Alexander Scherbatiy
On Fri, 31 May 2024 06:41:26 GMT, Prasanta Sadhukhan wrote: >> It is easy to add new constants to a public API but there is no way to >> remove them. >> OutpuBin constants work only if they are listed among the supported output >> bins. >> There is always a way to lookup `tray-n` output bin

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-30 Thread Alexander Scherbatiy
On Thu, 30 May 2024 04:49:21 GMT, Prasanta Sadhukhan wrote: >> I updated the `PrintService.isAttributeValueSupported()` method that it >> always returns true for CustomOutputBin class and returns true for an >> OutputBin constant only if its original name (ipp case) or the name without >>

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v17]

2024-05-30 Thread Alexander Scherbatiy
On Thu, 30 May 2024 18:45:38 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >&

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v17]

2024-05-30 Thread Alexander Scherbatiy
s is set to `PrinterJob.print(...)` attributes a test page is > printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If > `Separator tray` is used a page is printed to the Separator tray. This is > consistent with the printer behavior when a native print dialog is used fro

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v16]

2024-05-30 Thread Alexander Scherbatiy
On Thu, 30 May 2024 07:27:13 GMT, Prasanta Sadhukhan wrote: >> Alexander Scherbatiy has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - Update imports order in CheckSupportedOutputBinsTest >> - Use

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v15]

2024-05-29 Thread Alexander Scherbatiy
On Wed, 29 May 2024 06:52:52 GMT, Prasanta Sadhukhan wrote: >> Alexander Scherbatiy has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Move OutputBin import before PageRanges in RasterPrinterJob >> - Add

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-29 Thread Alexander Scherbatiy
On Wed, 29 May 2024 20:14:06 GMT, Alexander Scherbatiy wrote: >> What about this support? > > Actually it is not clear for me which maximum N should be used for these > constants. > Should only `tray-1`, `tray-2`, and `tray-3` be added, or should there be > constants

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-29 Thread Alexander Scherbatiy
On Wed, 29 May 2024 06:49:31 GMT, Prasanta Sadhukhan wrote: >> src/java.desktop/share/classes/javax/print/attribute/standard/OutputBin.java >> line 154: >> >>> 152: FACE_UP, >>> 153: FACE_DOWN, >>> 154: LARGE_CAPACITY, >> >> What about this support from

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v16]

2024-05-29 Thread Alexander Scherbatiy
s is set to `PrinterJob.print(...)` attributes a test page is > printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If > `Separator tray` is used a page is printed to the Separator tray. This is > consistent with the printer behavior when a native print dialog is used fro

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v13]

2024-05-28 Thread Alexander Scherbatiy
On Tue, 28 May 2024 07:52:54 GMT, Prasanta Sadhukhan wrote: >> The test updated to check if the OutputBin category is supported. > > I think if `isATtributeCategorySupported `returns false, we should not return > OutputBin[0] as that will cause the test to pass with message "SKip the test >

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v14]

2024-05-28 Thread Alexander Scherbatiy
On Tue, 28 May 2024 07:54:40 GMT, Prasanta Sadhukhan wrote: >> Alexander Scherbatiy has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Fix types in tests >> - Fix typos in tests >> - Check if O

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v15]

2024-05-28 Thread Alexander Scherbatiy
s is set to `PrinterJob.print(...)` attributes a test page is > printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If > `Separator tray` is used a page is printed to the Separator tray. This is > consistent with the printer behavior when a native print dialog is used fro

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v13]

2024-05-27 Thread Alexander Scherbatiy
On Sun, 26 May 2024 22:40:29 GMT, Phil Race wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move jtreg tags below the imports in the tests > > I'd like to have at leas

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v13]

2024-05-27 Thread Alexander Scherbatiy
On Sun, 26 May 2024 22:40:29 GMT, Phil Race wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move jtreg tags below the imports in the tests > > I'd like to have at leas

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v14]

2024-05-27 Thread Alexander Scherbatiy
s is set to `PrinterJob.print(...)` attributes a test page is > printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If > `Separator tray` is used a page is printed to the Separator tray. This is > consistent with the printer behavior when a native print dialog is used fro

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v13]

2024-05-27 Thread Alexander Scherbatiy
On Mon, 27 May 2024 07:41:37 GMT, Prasanta Sadhukhan wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move jtreg tags below the imports in the tests > >

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v12]

2024-05-22 Thread Alexander Scherbatiy
On Wed, 22 May 2024 23:29:55 GMT, Alisen Chung wrote: > If output bins are not supported, should the output bin combobox still show > up with a single output bin as the only option? There was a difference between number of output bins reported by cups and and the

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v13]

2024-05-22 Thread Alexander Scherbatiy
s is set to `PrinterJob.print(...)` attributes a test page is > printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If > `Separator tray` is used a page is printed to the Separator tray. This is > consistent with the printer behavior when a native print dialog is used fro

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-22 Thread Alexander Scherbatiy
On Wed, 22 May 2024 18:05:36 GMT, Phil Race wrote: > > Should the tests print "Number of output bins less than 2. The test is > > skipped" or be updated in some other way to reflect the fact that where are > > no enough output bins to test? > > That sound reasonable to me. The messages added

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v12]

2024-05-22 Thread Alexander Scherbatiy
s is set to `PrinterJob.print(...)` attributes a test page is > printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If > `Separator tray` is used a page is printed to the Separator tray. This is > consistent with the printer behavior when a native print dialog is used fro

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-22 Thread Alexander Scherbatiy
On Tue, 21 May 2024 12:46:31 GMT, Prasanta Sadhukhan wrote: > I guess its because of this code where supported output bins is < 1 which > prevents printdialog to popup and the test Passed or rather did not > proceed..Not sure if this should be considered "Passed" or "Skipped" Should the

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-22 Thread Alexander Scherbatiy
On Mon, 20 May 2024 18:03:54 GMT, Alisen Chung wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make OutputBin class sealed > > test/jdk/javax/print/attribute/OutputBinAttribu

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v11]

2024-05-22 Thread Alexander Scherbatiy
s is set to `PrinterJob.print(...)` attributes a test page is > printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If > `Separator tray` is used a page is printed to the Separator tray. This is > consistent with the printer behavior when a native print dialog is used fro

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-21 Thread Alexander Scherbatiy
On Mon, 13 May 2024 19:46:08 GMT, Phil Race wrote: > Why can't we have an automated test that just calls the APIs > service.isAttributeCategorySupported(OutputBin.class) and > service.getSupportedAttributeValues(OutputBin.class, null, null); > > for all printers ? I prepared a simple

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v10]

2024-05-21 Thread Alexander Scherbatiy
On Tue, 21 May 2024 19:01:35 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >&

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v10]

2024-05-21 Thread Alexander Scherbatiy
s is set to `PrinterJob.print(...)` attributes a test page is > printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If > `Separator tray` is used a page is printed to the Separator tray. This is > consistent with the printer behavior when a native print dialog is used fro

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v7]

2024-05-11 Thread Alexander Scherbatiy
On Wed, 8 May 2024 15:47:28 GMT, Phil Race wrote: >> I added the `OutputBin` class and package-info.java changes to the CSR >> `javax.print: Support IPP output-bin attribute extension` description: >> https://bugs.openjdk.org/browse/JDK-8331601 >> >> The `OutputBin` class has two

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-11 Thread Alexander Scherbatiy
s is set to `PrinterJob.print(...)` attributes a test page is > printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If > `Separator tray` is used a page is printed to the Separator tray. This is > consistent with the printer behavior when a native print dialog is used fro

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v7]

2024-05-11 Thread Alexander Scherbatiy
On Mon, 6 May 2024 18:06:18 GMT, Alexander Scherbatiy wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Change 'Page Setup' to 'Appearance' tab in the >> OutputBinAttrib

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v5]

2024-05-11 Thread Alexander Scherbatiy
On Wed, 1 May 2024 19:30:23 GMT, Alexander Scherbatiy wrote: >> src/java.desktop/share/classes/sun/print/resources/serviceui.properties line >> 32: >> >>> 30: border.jobattributes=Job Attributes >>> 31: border.media=Media >>> 32: border.output=Ou

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v5]

2024-05-11 Thread Alexander Scherbatiy
On Sat, 13 Apr 2024 21:33:03 GMT, Phil Race wrote: > I would have assumed "SEPARATORTRAY" was the keyword name you would specify > to the job and "Separator Tray" is just a description - which could be used > in a UI menu. Am I missing something ? This is correct. The `ppdFindOption(...,

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v8]

2024-05-11 Thread Alexander Scherbatiy
s is set to `PrinterJob.print(...)` attributes a test page is > printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If > `Separator tray` is used a page is printed to the Separator tray. This is > consistent with the printer behavior when a native print dialog is used fro

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v7]

2024-05-06 Thread Alexander Scherbatiy
On Thu, 2 May 2024 18:30:23 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >&

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v7]

2024-05-02 Thread Alexander Scherbatiy
s is set to `PrinterJob.print(...)` attributes a test page is > printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If > `Separator tray` is used a page is printed to the Separator tray. This is > consistent with the printer behavior when a native print dialog is used fro

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v6]

2024-05-01 Thread Alexander Scherbatiy
On Wed, 1 May 2024 19:24:24 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >&

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v5]

2024-05-01 Thread Alexander Scherbatiy
On Sat, 13 Apr 2024 22:58:31 GMT, Phil Race wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add output bins support to the common print dialog > > src/java.d

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v5]

2024-05-01 Thread Alexander Scherbatiy
On Sat, 13 Apr 2024 21:26:35 GMT, Phil Race wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add output bins support to the common print dialog > > src/java.desktop/share

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v6]

2024-05-01 Thread Alexander Scherbatiy
s is set to `PrinterJob.print(...)` attributes a test page is > printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If > `Separator tray` is used a page is printed to the Separator tray. This is > consistent with the printer behavior when a native print dialog is used fro

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v5]

2024-03-30 Thread Alexander Scherbatiy
On Fri, 2 Feb 2024 17:38:00 GMT, Alexander Scherbatiy wrote: > This pull request has been inactive for more than 4 weeks and will be > automatically closed if another 4 weeks passes without any activity. To avoid > this, simply add a new comment to the pull request. Feel fr

Re: Setting Chromaticity.MONOCHROME print request attribute on macOS

2024-03-13 Thread Alexander Scherbatiy
1] https://bugs.openjdk.org/browse/JDK-8315113 [2] https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode On 8/28/23 18:00, Alexander Scherbatiy wrote: Hello, I am working on issue "8315113 Print request Chromaticity.MONOCHROME attribute doe

Re: RFR: 8315113: Print request Chromaticity.MONOCHROME attribute does not work on macOS

2024-03-12 Thread Alexander Scherbatiy
On Tue, 12 Mar 2024 16:41:12 GMT, Phil Race wrote: > But I am really surprised to see a PR rather than a discussion first as it is > making a lot of policy decisions and implies we need to support something I am not sure we want to support. There was an email with the issue discussion on the

RFR: 8315113: Print request Chromaticity.MONOCHROME attribute does not work on macOS

2024-03-11 Thread Alexander Scherbatiy
The fix provides ability to print Black & White pages on macOS. Cocoa API has [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode) function but it is marked as deprecated and really does nothing. There is no replacement; this

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v5]

2024-02-02 Thread Alexander Scherbatiy
On Wed, 13 Dec 2023 16:04:44 GMT, Alexander Scherbatiy wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add output bins support to the common print dialog > > The common p

Integrated: 7001133: OutOfMemoryError by CustomMediaSizeName implementation

2023-12-18 Thread Alexander Scherbatiy
On Thu, 12 Oct 2023 15:51:28 GMT, Alexander Scherbatiy wrote: > Each time `CUPSPrinter.initMedia()` method is called it creates new > `CustomMediaSizeName` objects which are all collected in static > `CustomMediaSizeName.customEnumTable` field. A lot of created d

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v5]

2023-12-13 Thread Alexander Scherbatiy
On Wed, 13 Dec 2023 15:58:03 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >&

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v5]

2023-12-13 Thread Alexander Scherbatiy
s is set to `PrinterJob.print(...)` attributes a test page is > printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If > `Separator tray` is used a page is printed to the Separator tray. This is > consistent with the printer behavior when a native print dialog is used fro

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v4]

2023-12-12 Thread Alexander Scherbatiy
s is set to `PrinterJob.print(...)` attributes a test page is > printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If > `Separator tray` is used a page is printed to the Separator tray. This is > consistent with the printer behavior when a native print dialog is used fro

Re: RFR: 7001133: OutOfMemoryError by CustomMediaSizeName implementation

2023-12-12 Thread Alexander Scherbatiy
On Thu, 12 Oct 2023 15:51:28 GMT, Alexander Scherbatiy wrote: > Each time `CUPSPrinter.initMedia()` method is called it creates new > `CustomMediaSizeName` objects which are all collected in static > `CustomMediaSizeName.customEnumTable` field. A lot of created d

Re: RFR: 8318023: Implement IPP output-bin attribute extension on macOS [v3]

2023-12-07 Thread Alexander Scherbatiy
On Wed, 18 Oct 2023 17:36:49 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >&

Re: RFR: 7001133: OutOfMemoryError by CustomMediaSizeName implementation

2023-11-21 Thread Alexander Scherbatiy
On Mon, 20 Nov 2023 10:04:42 GMT, Prasanta Sadhukhan wrote: >> Each time `CUPSPrinter.initMedia()` method is called it creates new >> `CustomMediaSizeName` objects which are all collected in static >> `CustomMediaSizeName.customEnumTable` field. A lot of created duplicated >>

Re: RFR: 8318023: Implement IPP output-bin attribute extension on macOS [v3]

2023-10-18 Thread Alexander Scherbatiy
s is set to `PrinterJob.print(...)` attributes a test page is > printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If > `Separator tray` is used a page is printed to the Separator tray. This is > consistent with the printer behavior when a native print dialog is used fro

Re: RFR: 8318023: Implement IPP output-bin attribute extension on macOS [v2]

2023-10-18 Thread Alexander Scherbatiy
On Tue, 17 Oct 2023 20:28:20 GMT, Phil Race wrote: > Why did you file a new RFE when you know about the existing one ? Close your > new one as a dup. and redirect everything to the existing one. Also I don't > see any UI work to enhance the dialog so it can be selected. And why restrict > it

Re: RFR: 8318023: Implement IPP output-bin attribute extension on macOS [v2]

2023-10-12 Thread Alexander Scherbatiy
s is set to `PrinterJob.print(...)` attributes a test page is > printed to the Main tray of the `Kyocera ECOSYS M8130cidn` printer. If > `Separator tray` is used a page is printed to the Separator tray. This is > consistent with the printer behavior when a native print dialog is used fro

RFR: 7001133: OutOfMemoryError by CustomMediaSizeName implementation

2023-10-12 Thread Alexander Scherbatiy
Each time `CUPSPrinter.initMedia()` method is called it creates new `CustomMediaSizeName` objects which are all collected in static `CustomMediaSizeName.customEnumTable` field. A lot of created duplicated `CustomMediaSizeName` objects wastes java heap space and can lead to

RFR: 8318023: Implement IPP output-bin attribute extension on macOS

2023-10-12 Thread Alexander Scherbatiy
The fix adds new public `OutputBin` print attribute class which allow to set a printer output bin in a `PrinterJob` class. The corresponding internal `CustomOutputBin` class is added as well. - Constants used in `OutputBin` class are based on [Internet Printing Protocol (IPP): “output-bin”

[jdk21] Withdrawn: 8311033: [macos] PrinterJob does not take into account Sides attribute

2023-08-28 Thread Alexander Scherbatiy
On Mon, 28 Aug 2023 18:38:53 GMT, Alexander Scherbatiy wrote: > This is a clean backport of the fix `8311033: [macos] PrinterJob does not > take into account Sides attribute`. > > The fix allows to print pages with DUPLEX and TUMBLE attributes on macOS. > Manual `test/jdk

Re: [jdk21] RFR: 8311033: [macos] PrinterJob does not take into account Sides attribute

2023-08-28 Thread Alexander Scherbatiy
On Mon, 28 Aug 2023 18:38:53 GMT, Alexander Scherbatiy wrote: > This is a clean backport of the fix `8311033: [macos] PrinterJob does not > take into account Sides attribute`. > > The fix allows to print pages with DUPLEX and TUMBLE attributes on macOS. > Manual `test/jdk

Re: [jdk21] RFR: 8311033: [macos] PrinterJob does not take into account Sides attribute

2023-08-28 Thread Alexander Scherbatiy
On Mon, 28 Aug 2023 18:38:53 GMT, Alexander Scherbatiy wrote: > This is a clean backport of the fix `8311033: [macos] PrinterJob does not > take into account Sides attribute`. > > The fix allows to print pages with DUPLEX and TUMBLE attributes on macOS. > Manual `test/jdk

[jdk21] RFR: 8311033: [macos] PrinterJob does not take into account Sides attribute

2023-08-28 Thread Alexander Scherbatiy
This is a clean backport of the fix `8311033: [macos] PrinterJob does not take into account Sides attribute`. The fix allows to print pages with DUPLEX and TUMBLE attributes on macOS. Manual `test/jdk/java/awt/print` and `test/jdk/javax/print` tests were run to check printing on macOS with and

Setting Chromaticity.MONOCHROME print request attribute on macOS

2023-08-28 Thread Alexander Scherbatiy
Hello, I am working on issue "8315113 Print request Chromaticity.MONOCHROME attribute does not work on macOS" [1]. There is PMSetColorMode function in the Apple Developer documentation [2] but it is marked as deprecated   "There is no replacement; this function was included to facilitate

Setting printer output bin

2023-08-04 Thread Alexander Scherbatiy
Hello, "8234393: [macos] printing ignores printer tray" fix [1] allows to set a printer tray by passing a supported MediaTray to PrinterJob.print(attributes) method on macOS. My question is about setting a printer output bin as well. I debugged attributes which

Integrated: 8311033: [macos] PrinterJob does not take into account Sides attribute

2023-07-28 Thread Alexander Scherbatiy
On Fri, 30 Jun 2023 10:00:46 GMT, Alexander Scherbatiy wrote: > To reproduce the issue run the > [JavaSidesAttributePrinting](https://bugs.openjdk.org/secure/attachment/104448/JavaSidesAttributePrinting.java) > java sample with ONE_SIDED and DUPLEX arguments on macOS:

Re: RFR: 8311033: [macos] PrinterJob does not take into account Sides attribute [v3]

2023-07-21 Thread Alexander Scherbatiy
On Thu, 20 Jul 2023 01:30:06 GMT, Sergey Bylokhov wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Local supportedSides variable is used insted of supportedSides field > >

Re: RFR: 8311033: [macos] PrinterJob does not take into account Sides attribute [v4]

2023-07-21 Thread Alexander Scherbatiy
e > - from `PrinterJob` to `NSPrintInfo` in > `CPrinterJob.javaPrinterJobToNSPrintInfo` method > - from `NSPrintInfo` to `PrinterJob` in > `CPrinterJob.nsPrintInfoToJavaPrinterJob` method Alexander Scherbatiy has updated the pull request incrementally with one additional commit since the last revi

Re: RFR: 8311033: [macos] PrinterJob does not take into account Sides attribute [v3]

2023-07-14 Thread Alexander Scherbatiy
On Fri, 14 Jul 2023 14:44:57 GMT, Alexander Scherbatiy wrote: >> To reproduce the issue run the >> [JavaSidesAttributePrinting](https://bugs.openjdk.org/secure/attachment/104448/JavaSidesAttributePrinting.java) >> java sample with ONE_SIDED and DUPLEX arguments on

Re: RFR: 8311033: [macos] PrinterJob does not take into account Sides attribute [v3]

2023-07-14 Thread Alexander Scherbatiy
e > - from `PrinterJob` to `NSPrintInfo` in > `CPrinterJob.javaPrinterJobToNSPrintInfo` method > - from `NSPrintInfo` to `PrinterJob` in > `CPrinterJob.nsPrintInfoToJavaPrinterJob` method Alexander Scherbatiy has updated the pull request incrementally with one additional commit since the last revisi

Re: RFR: 8311033: [macos] PrinterJob does not take into account Sides attribute [v2]

2023-07-14 Thread Alexander Scherbatiy
e > - from `PrinterJob` to `NSPrintInfo` in > `CPrinterJob.javaPrinterJobToNSPrintInfo` method > - from `NSPrintInfo` to `PrinterJob` in > `CPrinterJob.nsPrintInfoToJavaPrinterJob` method Alexander Scherbatiy has updated the pull request incrementally with one additional commit since the last revisi

RFR: 8311033: [macos] PrinterJob does not take into account Sides attribute

2023-06-30 Thread Alexander Scherbatiy
To reproduce the issue run the [JavaSidesAttributePrinting](https://bugs.openjdk.org/secure/attachment/104448/JavaSidesAttributePrinting.java) java sample with ONE_SIDED and DUPLEX arguments on macOS: java JavaSidesAttributePrinting ONE_SIDED java JavaSidesAttributePrinting DUPLEX The sample

Integrated: 8295737: macOS: Print content cut off when width > height with portrait orientation

2023-03-05 Thread Alexander Scherbatiy
On Fri, 21 Oct 2022 08:42:12 GMT, Alexander Scherbatiy wrote: > A printed content is truncated on macOS if the content paper size width > larger than height with portrait orientation or width is less than height > with landscape orientation. > > To reproduce the issue run the

Integrated: 8301254: UNIX sun/font coding does not detect SuSE in openSUSE Leap distribution

2023-03-05 Thread Alexander Scherbatiy
n.font.FontUtilities.getFont2D(FontUtilities.java:151) > at > java.desktop/sun.java2d.SunGraphics2D.checkFontInfo(SunGraphics2D.java:671) > at > java.desktop/sun.java2d.SunGraphics2D.getFontInfo(SunGraphics2D.java:837) > at > java.desktop/sun.java2d.pipe.GlyphList

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation [v7]

2023-02-28 Thread Alexander Scherbatiy
On Tue, 28 Feb 2023 18:20:50 GMT, Alexander Scherbatiy wrote: >> A printed content is truncated on macOS if the content paper size width >> larger than height with portrait orientation or width is less than height >> with landscape orientation. >> >&

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation [v7]

2023-02-28 Thread Alexander Scherbatiy
[after-fix-2.pdf](https://bugs.openjdk.org/secure/attachment/101161/after-fix-2.pdf) > 3. size 100x300, portrait orientation: > [before-fix-3.pdf](https://bugs.openjdk.org/secure/attachment/101155/before-fix-3.pdf), > > [after-fix-3.pdf](https://bugs.openjdk.org/secure/attachment/101160/

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation [v6]

2023-02-27 Thread Alexander Scherbatiy
On Mon, 27 Feb 2023 16:32:02 GMT, Alexander Scherbatiy wrote: >> A printed content is truncated on macOS if the content paper size width >> larger than height with portrait orientation or width is less than height >> with landscape orientation. >> >&

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation [v6]

2023-02-27 Thread Alexander Scherbatiy
[after-fix-2.pdf](https://bugs.openjdk.org/secure/attachment/101161/after-fix-2.pdf) > 3. size 100x300, portrait orientation: > [before-fix-3.pdf](https://bugs.openjdk.org/secure/attachment/101155/before-fix-3.pdf), > > [after-fix-3.pdf](https://bugs.openjdk.org/secure/attachment/101160/

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation [v5]

2023-02-27 Thread Alexander Scherbatiy
[after-fix-2.pdf](https://bugs.openjdk.org/secure/attachment/101161/after-fix-2.pdf) > 3. size 100x300, portrait orientation: > [before-fix-3.pdf](https://bugs.openjdk.org/secure/attachment/101155/before-fix-3.pdf), > > [after-fix-3.pdf](https://bugs.openjdk.org/secure/attachment/101160/af

Re: RFR: 8301254: UNIX sun/font coding does not detect SuSE in openSUSE Leap distribution [v3]

2023-02-07 Thread Alexander Scherbatiy
On Tue, 7 Feb 2023 17:20:19 GMT, Alexander Scherbatiy wrote: >> [JDK-8278549](https://bugs.openjdk.org/browse/JDK-8278549)` UNIX sun/font >> coding misses SUSE distro detection on recent distro SUSE 15` adds SuSE >> detection by checking SLES os name property in `/et

Re: RFR: 8301254: UNIX sun/font coding does not detect SuSE in openSUSE Leap distribution [v3]

2023-02-07 Thread Alexander Scherbatiy
etFont2D(FontUtilities.java:151) > at > java.desktop/sun.java2d.SunGraphics2D.checkFontInfo(SunGraphics2D.java:671) > at > java.desktop/sun.java2d.SunGraphics2D.getFontInfo(SunGraphics2D.java:837) > at > java.desktop/sun.java2d.pipe.GlyphListPipe.drawString(Gly

Re: RFR: 8301254: UNIX sun/font coding does not detect SuSE in openSUSE Leap distribution [v2]

2023-01-31 Thread Alexander Scherbatiy
On Fri, 27 Jan 2023 17:00:48 GMT, Alexander Scherbatiy wrote: >> [JDK-8278549](https://bugs.openjdk.org/browse/JDK-8278549)` UNIX sun/font >> coding misses SUSE distro detection on recent distro SUSE 15` adds SuSE >> detection by checking SLES os name property in `/et

Re: RFR: 8301254: UNIX sun/font coding does not detect SuSE in openSUSE Leap distribution [v2]

2023-01-31 Thread Alexander Scherbatiy
On Fri, 27 Jan 2023 17:00:48 GMT, Alexander Scherbatiy wrote: >> [JDK-8278549](https://bugs.openjdk.org/browse/JDK-8278549)` UNIX sun/font >> coding misses SUSE distro detection on recent distro SUSE 15` adds SuSE >> detection by checking SLES os name property in `/et

Re: RFR: 8301254: UNIX sun/font coding does not detect SuSE in openSUSE Leap distribution [v2]

2023-01-31 Thread Alexander Scherbatiy
On Fri, 27 Jan 2023 17:00:48 GMT, Alexander Scherbatiy wrote: >> [JDK-8278549](https://bugs.openjdk.org/browse/JDK-8278549)` UNIX sun/font >> coding misses SUSE distro detection on recent distro SUSE 15` adds SuSE >> detection by checking SLES os name property in `/et

Re: RFR: 8301254: UNIX sun/font coding does not detect SuSE in openSUSE Leap distributive [v2]

2023-01-27 Thread Alexander Scherbatiy
etFont2D(FontUtilities.java:151) > at > java.desktop/sun.java2d.SunGraphics2D.checkFontInfo(SunGraphics2D.java:671) > at > java.desktop/sun.java2d.SunGraphics2D.getFontInfo(SunGraphics2D.java:837) > at > java.desktop/sun.java2d.pipe.GlyphListPipe.dra

RFR: 8301254: UNIX sun/font coding does not detect SuSE in openSUSE Leap distributive

2023-01-27 Thread Alexander Scherbatiy
[JDK-8278549](https://bugs.openjdk.org/browse/JDK-8278549)` UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15` adds SuSE detection by checking SLES os name property in `/etc/os-release` file. `opensuse/leap:15.4` docker defines os name property as `"openSUSE Leap"` in

Withdrawn: 8298266: "java.home property not set" error in Graal when sun.awt.fontconfig java property is set on Windows

2023-01-20 Thread Alexander Scherbatiy
On Wed, 7 Dec 2022 13:20:10 GMT, Alexander Scherbatiy wrote: > **Environment**: > GraalVM 22.3.0 with jdk 19, Windows OS. > > **Description**: > Create a native image of Swing application using GraalVM and run it with ` > -Dsun.awt.fontconfig=fontconfig.properties.

Re: RFR: 8298266: "java.home property not set" error in Graal when sun.awt.fontconfig java property is set on Windows [v2]

2022-12-30 Thread Alexander Scherbatiy
On Thu, 22 Dec 2022 10:57:15 GMT, Alexander Scherbatiy wrote: >> **Environment**: >> GraalVM 22.3.0 with jdk 19, Windows OS. >> >> **Description**: >> Create a native image of Swing application using GraalVM and run it with ` >> -Dsun.awt.fontconfig=font

Re: RFR: 8298266: "java.home property not set" error in Graal when sun.awt.fontconfig java property is set on Windows [v2]

2022-12-23 Thread Alexander Scherbatiy
On Thu, 22 Dec 2022 10:57:15 GMT, Alexander Scherbatiy wrote: >> **Environment**: >> GraalVM 22.3.0 with jdk 19, Windows OS. >> >> **Description**: >> Create a native image of Swing application using GraalVM and run it with ` >> -Dsun.awt.fontconfig=font

Re: RFR: 8298266: "java.home property not set" error in Graal when sun.awt.fontconfig java property is set on Windows [v2]

2022-12-22 Thread Alexander Scherbatiy
On Thu, 22 Dec 2022 10:57:15 GMT, Alexander Scherbatiy wrote: >> **Environment**: >> GraalVM 22.3.0 with jdk 19, Windows OS. >> >> **Description**: >> Create a native image of Swing application using GraalVM and run it with ` >> -Dsun.awt.fontconfig=font

Re: RFR: 8298266: "java.home property not set" error in Graal when sun.awt.fontconfig java property is set on Windows [v2]

2022-12-22 Thread Alexander Scherbatiy
ngUtilities.invokeAndWait(SwingUtilities.java:1480) > at SwingSample.main(SwingSample.java:7) > Caused by: java.lang.Error: java.home property not set > at > java.desktop@19.0.1/sun.awt.FontConfiguration.findFontConfigFile(FontConfiguration.java:180) > at > j

RFR: 8298266: "java.home property not set" error in Graal when sun.awt.fontconfig java property is set on Windows

2022-12-07 Thread Alexander Scherbatiy
**Environment**: GraalVM 22.3.0 with jdk 19, Windows OS. **Description**: Create a native image of Swing application using GraalVM and run it with ` -Dsun.awt.fontconfig=fontconfig.properties.src` java property. `java.lang.Error: java.home property not set` error is thrown. For more details

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation [v4]

2022-11-29 Thread Alexander Scherbatiy
On Tue, 29 Nov 2022 10:36:32 GMT, Alexander Scherbatiy wrote: >> A printed content is truncated on macOS if the content paper size width >> larger than height with portrait orientation or width is less than height >> with landscape orientation. >> >&

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation [v4]

2022-11-29 Thread Alexander Scherbatiy
[after-fix-2.pdf](https://bugs.openjdk.org/secure/attachment/101161/after-fix-2.pdf) > 3. size 100x300, portrait orientation: > [before-fix-3.pdf](https://bugs.openjdk.org/secure/attachment/101155/before-fix-3.pdf), > > [after-fix-3.pdf](https://bugs.openjdk.org/secure/attachment/101160/

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation [v3]

2022-11-28 Thread Alexander Scherbatiy
[after-fix-2.pdf](https://bugs.openjdk.org/secure/attachment/101161/after-fix-2.pdf) > 3. size 100x300, portrait orientation: > [before-fix-3.pdf](https://bugs.openjdk.org/secure/attachment/101155/before-fix-3.pdf), > > [after-fix-3.pdf](https://bugs.openjdk.org/secure/attachment/101160/

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation [v2]

2022-11-28 Thread Alexander Scherbatiy
[after-fix-2.pdf](https://bugs.openjdk.org/secure/attachment/101161/after-fix-2.pdf) > 3. size 100x300, portrait orientation: > [before-fix-3.pdf](https://bugs.openjdk.org/secure/attachment/101155/before-fix-3.pdf), > > [after-fix-3.pdf](https://bugs.openjdk.org/secure/attachment/101160/

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation

2022-11-07 Thread Alexander Scherbatiy
On Fri, 21 Oct 2022 08:42:12 GMT, Alexander Scherbatiy wrote: > A printed content is truncated on macOS if the content paper size width > larger than height with portrait orientation or width is less than height > with landscape orientation. > > To reproduce the issue run the

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation

2022-11-03 Thread Alexander Scherbatiy
On Fri, 21 Oct 2022 08:42:12 GMT, Alexander Scherbatiy wrote: > A printed content is truncated on macOS if the content paper size width > larger than height with portrait orientation or width is less than height > with landscape orientation. > > To reproduce the issue run the

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation

2022-11-02 Thread Alexander Scherbatiy
On Fri, 21 Oct 2022 08:42:12 GMT, Alexander Scherbatiy wrote: > A printed content is truncated on macOS if the content paper size width > larger than height with portrait orientation or width is less than height > with landscape orientation. > > To reproduce the issue run the

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation

2022-11-01 Thread Alexander Scherbatiy
On Tue, 1 Nov 2022 03:06:16 GMT, Phil Race wrote: > The analysis of the problem sounds fine but then it all gets confusing to me > when I come to the fix. > > So first you capture the intended orientation in the switch but do not set it > to the printer context. The captured orientation is

RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation

2022-10-21 Thread Alexander Scherbatiy
A printed content is truncated on macOS if the content paper size width larger than height with portrait orientation or width is less than height with landscape orientation. To reproduce the issue run the [CutOffImage](https://bugs.openjdk.org/secure/attachment/101145/CutOffImage.java) sample