On Thu, 23 May 2024 19:51:10 GMT, Phil Race wrote:
>> src/demo/share/jfc/Font2DTest/Font2DTest.java line 1440:
>>
>>> 1438: f.addWindowListener( new WindowAdapter() {
>>> 1439: public void windowOpening( WindowEvent e ) {
>>> f2dt.repaint(); }
>>> 1440:
On Tue, 21 May 2024 23:08:17 GMT, Phil Race wrote:
>> Enhance Font2DTest as follows
>>
>> - Add main menu Radio Button options so that you select the font to use as
>> either
>> - (1) Font Family + Style (as now)
>> - (2) Font Family + Menu of all members of the Family, replacing the Style
>>
On Tue, 21 May 2024 23:08:17 GMT, Phil Race wrote:
>> Enhance Font2DTest as follows
>>
>> - Add main menu Radio Button options so that you select the font to use as
>> either
>> - (1) Font Family + Style (as now)
>> - (2) Font Family + Menu of all members of the Family, replacing the Style
>>
On Tue, 21 May 2024 16:51:26 GMT, Phil Race wrote:
> To avoid this I think I can just reset "Style" to "PLAIN" whenever switching
> the UI to use SubFamily.
Changes looks good after the following fix. Save and Load option works as
expected.
-
PR Comment:
On Thu, 9 May 2024 18:47:02 GMT, Damon Nguyen wrote:
> I've tried both the MacOS and Windows instructions. I believe it was fine.
> Still need to follow the Linux instructions unless someone else has already.
> I need to redo my Linux setup again. Then I can re-review completely.
Linux
On Thu, 2 May 2024 09:36:18 GMT, Tejesh R wrote:
>> Instructions set has been updated as per OS specific. JTable keyboard
>> navigation is tested in each OS and according it's current implementation
>> the instructions has been updated (Few has been removed and few has been
>> updated).
>>
On Tue, 23 Apr 2024 07:27:02 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 190:
>>
>>> 188: PassFailJFrame.builder()
>>> 189: .instructions(INSTRUCTIONS)
>>> 190: .rows(11)
>>
>> Suggestion:
>>
>>
On Thu, 2 May 2024 09:36:18 GMT, Tejesh R wrote:
>> Instructions set has been updated as per OS specific. JTable keyboard
>> navigation is tested in each OS and according it's current implementation
>> the instructions has been updated (Few has been removed and few has been
>> updated).
>>
On Thu, 9 May 2024 13:01:57 GMT, Alexey Ivanov wrote:
> The `javax/swing/plaf/basic/BasicDirectoryModel/LoaderThreadCount.java` test
> frequently fails on Windows in CI, which creates noise.
>
> All of the failures on Windows look the same:
>
> Number of snapshots: 20
> Number of snapshots
On Thu, 2 May 2024 22:01:03 GMT, Phil Race wrote:
>> Delete an internal class that has been around for 20 years but never been
>> used.
>> Verified that is true at least as far back as JDK7
>> All platforms build. Tests pass.
>
> Phil Race has updated the pull request incrementally with one
On Mon, 29 Apr 2024 23:24:19 GMT, Harshitha Onkar wrote:
> For the following manual test, more instructions are added as to what to
> expect for "hide,iconify and show" vs "hide,iconify,show and restore" for
> clarity.
This pull request has now been integrated
> For the following manual test, more instructions are added as to what to
> expect for "hide,iconify and show" vs "hide,iconify,show and restore" for
> clarity.
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last
> For the following manual test, more instructions are added as to what to
> expect for "hide,iconify and show" vs "hide,iconify,show and restore" for
> clarity.
Harshitha Onkar has updated the pull request incrementally with one additional
commit sinc
On Tue, 30 Apr 2024 02:02:30 GMT, Alexander Zvegintsev
wrote:
>> Some tests try to get the focus of a window by clicking on its title bar.
>>
>> On XWayland, however, emulating mouse clicks with XTEST currently only
>> affects the XWayland server, not the window decorations, so trying to
> For the following manual test, more instructions are added as to what to
> expect for "hide,iconify and show" vs "hide,iconify,show and restore" for
> clarity.
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the la
> For the following manual test, more instructions are added as to what to
> expect for "hide,iconify and show" vs "hide,iconify,show and restore" for
> clarity.
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last
On Tue, 30 Apr 2024 04:28:22 GMT, Abhishek Kumar wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> test frame size
>
> test/jdk/java/awt/Frame/FrameStateTest/FrameStat
> For the following manual test, more instructions are added as to what to
> expect for "hide,iconify and show" vs "hide,iconify,show and restore" for
> clarity.
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last
On Tue, 30 Apr 2024 10:54:36 GMT, Tejesh R wrote:
> One observation is that, after the updates the size of whole test window is
> slightly increased in height where the second Frame which has options is out
> of the window frame. When the taskbar is at bottom nothing seems to be
> visible.
>
> For the following manual test, more instructions are added as to what to
> expect for "hide,iconify and show" vs "hide,iconify,show and restore" for
> clarity.
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the las
On Thu, 25 Apr 2024 17:22:48 GMT, Alexander Zvegintsev
wrote:
>> This fix adds missing doPrivileged calls in TokenStorage, which is used to
>> help take screenshots in Wayland.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since the last
For the following manual test, more instructions are added as to what to expect
for "hide,iconify and show" vs "hide,iconify,show and restore" for clarity.
-
Commit messages:
- minor update
- added instructions for clarity
Changes: https://git.openjdk.org/jdk/pull/19008/files
On Mon, 29 Apr 2024 10:44:37 GMT, Alexander Zvegintsev
wrote:
> Some tests try to get the focus of a window by clicking on its title bar.
>
> On XWayland, however, emulating mouse clicks with XTEST currently only
> affects the XWayland server, not the window decorations, so trying to click
>
On Mon, 29 Apr 2024 10:44:37 GMT, Alexander Zvegintsev
wrote:
> Some tests try to get the focus of a window by clicking on its title bar.
>
> On XWayland, however, emulating mouse clicks with XTEST currently only
> affects the XWayland server, not the window decorations, so trying to click
>
On Thu, 25 Apr 2024 22:28:06 GMT, Harshitha Onkar wrote:
> Libpng updated from 1.6.40 to 1.6.43
This pull request has now been integrated.
Changeset: 4e422943
Author: Harshitha Onkar
URL:
https://git.openjdk.org/jdk/commit/4e4229438ad2e8ac59ac675465e4d3d4e13bf156
Stats:
> Libpng updated from 1.6.40 to 1.6.43
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last revision:
Updating.txt
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18964/files
- new: https://git.openjdk.org/jdk/pull/18
On Thu, 25 Apr 2024 22:46:23 GMT, Phil Race wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added missing 4 lines of header
>
> src/java.desktop/share/native/libsplashscreen/
> Libpng updated from 1.6.40 to 1.6.43
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last revision:
added missing 4 lines of header
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18964/files
- new: ht
Libpng updated from 1.6.40 to 1.6.43
-
Commit messages:
- .md file update
- libpng update v1.6.43
Changes: https://git.openjdk.org/jdk/pull/18964/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18964=00
Issue: https://bugs.openjdk.org/browse/JDK-8329004
Stats: 694 lines
On Fri, 19 Apr 2024 05:07:19 GMT, Tejesh R wrote:
> > @TejeshR13 Based on the PR description the source code fix looks correct. I
> > was unable to test it on my local Win machine due to printer issues. The
> > Print to PDF option isn't working too. But this is something to do with my
> >
On Thu, 18 Apr 2024 04:47:15 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to
On Thu, 18 Apr 2024 04:47:15 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to
On Thu, 4 Apr 2024 09:38:20 GMT, Prasanta Sadhukhan
wrote:
>> Test issue shows the End and Start buttons are not placed as per
>> instructions due to ComponentOrientation RTL was not honoured, as with
>> `getContentPane()` being removed from `add` call of JFrame, it was also
>> additionally
On Wed, 10 Apr 2024 04:32:53 GMT, Tejesh R wrote:
> Getting a theme for particular dpi failed in windows L during print test.
> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
> was independent of DPI. After the fix
>
On Wed, 10 Apr 2024 04:32:53 GMT, Tejesh R wrote:
> Getting a theme for particular dpi failed in windows L during print test.
> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
> was independent of DPI. After the fix
>
On Wed, 10 Apr 2024 04:32:53 GMT, Tejesh R wrote:
> Getting a theme for particular dpi failed in windows L during print test.
> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
> was independent of DPI. After the fix
>
On Wed, 10 Apr 2024 05:25:37 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to
On Thu, 11 Apr 2024 17:20:12 GMT, Alexey Ivanov wrote:
>> The value of the
>> [`text-decoration`](https://www.w3.org/TR/REC-CSS1/#text-decoration) CSS
>> property is not inherited correctly in Swing. If the `` element is
>> mixed with `` or ``, only the value from the `style` attribute of
>>
On Tue, 9 Apr 2024 20:16:17 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/text/html/HTMLDocument/HTMLTextDecoration.java line 90:
>>
>>> 88: underline +
>>> line-through?
>>> 89:
>>> 90: underline +
>>> line-through?
>>
>> The test fails when multiple CSS classes
On Fri, 29 Mar 2024 15:32:12 GMT, Alexey Ivanov wrote:
> The value of the
> [`text-decoration`](https://www.w3.org/TR/REC-CSS1/#text-decoration) CSS
> property is not inherited correctly in Swing. If the `` element is
> mixed with `` or ``, only the value from the `style` attribute of
> ``
On Fri, 29 Mar 2024 15:32:12 GMT, Alexey Ivanov wrote:
> The value of the
> [`text-decoration`](https://www.w3.org/TR/REC-CSS1/#text-decoration) CSS
> property is not inherited correctly in Swing. If the `` element is
> mixed with `` or ``, only the value from the `style` attribute of
> ``
On Mon, 8 Apr 2024 04:50:44 GMT, Tejesh R wrote:
>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>>
On Fri, 5 Apr 2024 04:35:25 GMT, Tejesh R wrote:
>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>>
On Fri, 5 Apr 2024 04:35:25 GMT, Tejesh R wrote:
>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>>
On Fri, 5 Apr 2024 04:35:25 GMT, Tejesh R wrote:
>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>>
On Thu, 4 Apr 2024 17:05:44 GMT, Tejesh R wrote:
>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>>
On Wed, 3 Apr 2024 16:15:33 GMT, Tejesh R wrote:
>> I meant setting it to one color for all icons instead of default white
>> background at Line#.193. This makes it easier for the user to differentiate
>> between a transparent background icon vs opaque.
>>
>> You might have missed this
On Tue, 2 Apr 2024 04:42:12 GMT, Tejesh R wrote:
>> test/jdk/java/awt/Frame/MegaIconTest/MegaIconTest.java line 194:
>>
>>> 192: setLayout(new BorderLayout());
>>> 193:
>>> 194: //Add the icon graphic and instructions to the Frame
>>
>> The background transparency of different
On Tue, 2 Apr 2024 20:58:34 GMT, Alisen Chung wrote:
>> Removing applet usage from manual JFileChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> equals modifier
LGTM
-
Marked as reviewed by
On Wed, 27 Mar 2024 17:58:06 GMT, Harshitha Onkar wrote:
> Following tests are converted to main and open-sourced:
>
> - /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using
> PassFailJFrame.
> - /java/awt/Frame/MaximizeUndecoratedTest.java - Automated
>
On Tue, 2 Apr 2024 17:06:47 GMT, Alexey Ivanov wrote:
>> It is better to re-throw it as RuntimeException. Updated.
>
>> It is better to re-throw it as RuntimeException. Updated.
>
> Not really…
>
> If saving the image fails, we want to preserve *the original error message*
> which wasn't even
> Following tests are converted to main and open-sourced:
>
> - /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using
> PassFailJFrame.
> - /java/awt/Frame/MaximizeUndecoratedTest.java - Automated
> - /java/awt/Frame/MinimizeUndecoratedTest.java - Automate
On Tue, 2 Apr 2024 17:11:04 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> RuntimeException thrown
>
> test/jdk/java/awt/Frame/MinimizeUndecora
On Thu, 22 Feb 2024 06:35:19 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to
On Fri, 29 Mar 2024 14:37:42 GMT, Alisen Chung wrote:
>> Removing applet usage from manual JFileChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> move var into local, simplified condition check, spacing
On Fri, 29 Mar 2024 12:45:36 GMT, Alexey Ivanov wrote:
> Remove all the leftovers of the _"standard instructions" machinery_ from the
> `NullPaper.java` test.
>
> The test code consists of two lines now: concise and clear.
LGTM.
-
Marked as reviewed by honkar (Reviewer).
PR
On Fri, 29 Mar 2024 04:40:55 GMT, Alisen Chung wrote:
>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update test from feedback
LGTM
-
Marked as
On Wed, 27 Mar 2024 03:31:00 GMT, Tejesh R wrote:
>> Probably waiting for me to OK it off-line. I've now done so.
>
> Pushed it now.
Does the test mean opaque icon background by "opaque icon"? If yes, then should
we use one .gif with opaque background and another with transparent background.
On Fri, 29 Mar 2024 09:49:54 GMT, Tejesh R wrote:
>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>>
On Fri, 29 Mar 2024 09:49:54 GMT, Tejesh R wrote:
>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>>
On Fri, 29 Mar 2024 16:41:13 GMT, Damon Nguyen wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> spacing
>
> test/jdk/java/awt/Frame/MaximizeUndecoratedTest.java line 127:
>
>
> Following tests are converted to main and open-sourced:
>
> - /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using
> PassFailJFrame.
> - /java/awt/Frame/MaximizeUndecoratedTest.java - Automated
> - /java/awt/Frame/MinimizeUndecoratedTest.java - Automate
On Wed, 27 Mar 2024 03:33:57 GMT, Tejesh R wrote:
>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>>
On Wed, 27 Mar 2024 03:33:57 GMT, Tejesh R wrote:
>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>>
On Sun, 24 Mar 2024 12:21:52 GMT, Tejesh R wrote:
>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>>
On Tue, 26 Mar 2024 22:29:32 GMT, Alisen Chung wrote:
>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> instruction string change
Changes requested by honkar
On Wed, 27 Mar 2024 18:39:35 GMT, Damon Nguyen wrote:
> test/jdk/java/awt/print/Dialog/PrintModalDialog.java is too similar in
> functionality to
> test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java.
>
> One test was originally for modality in web browsers, while the other was
> Following tests are converted to main and open-sourced:
>
> - /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using
> PassFailJFrame.
> - /java/awt/Frame/MaximizeUndecoratedTest.java - Automated
> - /java/awt/Frame/MinimizeUndecoratedTest.java - Automate
Following tests are converted to main and open-sourced:
- /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using
PassFailJFrame.
- /java/awt/Frame/MaximizeUndecoratedTest.java - Automated
- /java/awt/Frame/MinimizeUndecoratedTest.java - Automated
-
Commit
On Tue, 26 Mar 2024 22:41:45 GMT, Alisen Chung wrote:
>> Removing applet usage from manual JFileChooser tests
>> The original test is failing (nothing shows up in the JFileChooser), but
>> this change does replace the applet usage with PassFailJFrame
>
> Alisen Chung has updated the pull
On Tue, 26 Mar 2024 00:46:29 GMT, Harshitha Onkar wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> change font
>
> test/jdk/javax/swing/JColorChooser/Test4887836.java line 43:
>
&
On Tue, 26 Mar 2024 20:47:47 GMT, Alisen Chung wrote:
>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> instruction string change
Marked as reviewed by honkar
On Tue, 26 Mar 2024 21:16:15 GMT, Phil Race wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> instruction string change
>
> test/jdk/javax/swing/JColorChooser/Test6977726.java line 42:
>
>> 40: String
On Mon, 25 Mar 2024 16:48:49 GMT, Alisen Chung wrote:
>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> change font
On Mon, 18 Mar 2024 19:54:00 GMT, Alisen Chung wrote:
>> test/jdk/javax/swing/JColorChooser/Test4887836.java line 41:
>>
>>> 39: public static void main(String[] args) throws Exception {
>>> 40: String instructions = "If you do not see white area under the
>>> \"Swatches\" tab,\n"
On Mon, 25 Mar 2024 23:48:14 GMT, Damon Nguyen wrote:
> > @DamonGuy The test in #18362 and the one in this PR test similar
> > functionality -Dialog Modality when using Print functions. Will combining
> > or retaining only one test make more sense instead of 2 separate tests?
>
> Good point.
On Mon, 25 Mar 2024 23:53:55 GMT, Damon Nguyen wrote:
>> Convert
>> java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
>> applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since
On Fri, 22 Mar 2024 17:38:36 GMT, Damon Nguyen wrote:
>> Convert java/awt/print/bug8023392/bug8023392.html applet test to main using
>> PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Move test out of extra
On Mon, 25 Mar 2024 19:53:54 GMT, Damon Nguyen wrote:
>> Convert
>> java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
>> applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since
On Fri, 22 Mar 2024 22:15:48 GMT, Damon Nguyen wrote:
>> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using
>> PassFailJFrame. Also rename the test to PrintModalDialog.java since this is
>> no longer an applet. Added test instructions related to the linked JBS issue.
>
>
On Fri, 22 Mar 2024 15:40:39 GMT, Alisen Chung wrote:
> Removing applet usage from manual JFileChooser tests
> The original test is failing (nothing shows up in the JFileChooser), but this
> change does replace the applet usage with PassFailJFrame
Ideally the Instruction window and Test window
On Fri, 22 Mar 2024 15:40:39 GMT, Alisen Chung wrote:
> The original test is failing (nothing shows up in the JFileChooser), but this
> change does replace the applet usage with PassFailJFrame
@alisenchung The original test works on Windows. Is it on macOS that nothing is
shown ?
On Fri, 22 Mar 2024 08:48:35 GMT, Damon Nguyen wrote:
>> Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to
>> main using PassFailJFrame for the instructions.
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
On Fri, 22 Mar 2024 17:28:10 GMT, Damon Nguyen wrote:
>> test/jdk/javax/swing/JColorChooser/8065098/JColorChooserDnDTest.java line 47:
>>
>>> 45: frame.setContentPane(panel);
>>> 46: frame.pack();
>>> 47: frame.setVisible(true);
>>
>> frame dispose is not
On Fri, 22 Mar 2024 08:45:15 GMT, Damon Nguyen wrote:
> Same for me. Looks like it's not an issue with the test and rather a bug that
> hasn't been fixed yet. I found
> [JDK-8065647](https://bugs.openjdk.org/browse/JDK-8065647) which I think is
> related to this. Seems to be filed after the
On Thu, 14 Mar 2024 19:50:18 GMT, Harshitha Onkar wrote:
> This test is converted to main using PassFailJFrame. It verifies wheel
> rotation value for high-res mouse on windows.
>
> The test requires the updated PassFailJFrame's logArea() feature added in
> this PR https://git
> This test is converted to main using PassFailJFrame. It verifies wheel
> rotation value for high-res mouse on windows.
>
> The test requires the updated PassFailJFrame's logArea() feature added in
> this PR https://github.com/openjdk/jdk/pull/18319
Harshitha Onkar has u
On Fri, 22 Mar 2024 15:31:48 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed the forcePass logic, updated instructions
>
> test/jdk/java/awt/event/Mouse
On Thu, 21 Mar 2024 19:10:40 GMT, Phil Race wrote:
> This previously closed test is cleaned up, opened and fixed to work on hidpi
> at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was
> when it was a closed test).
Problemlist on macOS no longer
On Mon, 18 Mar 2024 20:07:50 GMT, Alisen Chung wrote:
> Removing applet usage from manual JColorChooser tests
Marked as reviewed by honkar (Reviewer).
test/jdk/javax/swing/JColorChooser/Test6348456.java line 45:
> 43:
> 44: private static final DefaultColorSelectionModel WHITE = new
>
On Thu, 21 Mar 2024 16:31:04 GMT, Damon Nguyen wrote:
> Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main
> using PassFailJFrame for the instructions.
@DamonGuy Tested on macOS, JColorChooser DnD doesn't seem to work on it.
On Wed, 20 Mar 2024 08:30:36 GMT, Abhishek Kumar wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comment update
On Wed, 20 Mar 2024 16:38:25 GMT, Harshitha Onkar wrote:
> Following test is converted from applet to main using PassFailJFrame.
>
> The original test had ignore tag - **The fix for this problem was backed out
> for 5057184. Remove this "ignore" tag when it is fixe
On Thu, 21 Mar 2024 19:44:52 GMT, Alexander Zvegintsev
wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor jtreg tag change
>
> test/jdk/java/awt/im/bug4490692.java line 87:
&
rectly on Linux platforms,
> hence ignore tag has been removed.
>
> This is a semi-automated test, the first check is manual and the 2nd one is
> automated. Details in the test instructions.
Harshitha Onkar has updated the pull request incrementally with one additional
commit
rectly on Linux platforms,
> hence ignore tag has been removed.
>
> This is a semi-automated test, the first check is manual and the 2nd one is
> automated. Details in the test instructions.
Harshitha Onkar has updated the pull request incrementally with one additional
commit s
On Thu, 21 Mar 2024 14:47:52 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added preciseWheelRotation logic & updated test
>
> Changes requested by aiv
> This test is converted to main using PassFailJFrame. It verifies wheel
> rotation value for high-res mouse on windows.
>
> The test requires the updated PassFailJFrame's logArea() feature added in
> this PR https://github.com/openjdk/jdk/pull/18319
Harshitha Onkar has u
On Thu, 21 Mar 2024 15:04:18 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added preciseWheelRotation logic & updated test
>
> test/jdk/java/awt/event/M
> This test is converted to main using PassFailJFrame. It verifies wheel
> rotation value for high-res mouse on windows.
>
> The test requires the updated PassFailJFrame's logArea() feature added in
> this PR https://github.com/openjdk/jdk/pull/18319
Harshitha Onkar has u
1 - 100 of 773 matches
Mail list logo
