On Thu, 2 May 2024 18:45:54 GMT, Phil Race wrote:
> Change GPL+CP -> GPL as required for all tests.
Confirmed updated license matches the GPL template:
https://github.com/openjdk/jdk/blob/master/make/data/license-templates/gpl-header
-
Marked as reviewed by iris (Reviewer).
PR
On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote:
>> Please review a set of updates to clean up use of `/**` comments in the
>> vicinity of declarations.
>>
>> There are various categories of update:
>>
>> * "Box comments" beginning with `/**`
>> * Misplaced doc comments before
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or
On Tue, 2 Apr 2024 16:58:19 GMT, Larry Cable wrote:
>> the beancontext package was added (by me) in JDK 1.2 to provide
>> JavaBeans(tm) with a containment and services hierarchy.
>>
>> based upon concepts from OpenDoc, which was a popular component model at the
>> time, the API pre-dated the
On Mon, 1 Apr 2024 22:53:12 GMT, Larry Cable wrote:
> the beancontext package was added (by me) in JDK 1.2 to provide JavaBeans(tm)
> with a containment and services hierarchy.
>
> based upon concepts from OpenDoc, which was a popular component model at the
> time, the API pre-dated the
On Thu, 7 Dec 2023 19:56:07 GMT, Phil Race wrote:
> As can be seen here
> https://docs.oracle.com/en/java/javase/21/docs/api/java.desktop/javax/imageio/ImageReader.html#computeRegions(javax.imageio.ImageReadParam,int,int,java.awt.image.BufferedImage,java.awt.Rectangle,java.awt.Rectangle)
>
>
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using
On Wed, 2 Aug 2023 17:03:40 GMT, Justin Lu wrote:
> Please review this PR (L10N translation update), which is a backport of
> commit
> [9b55e9a7](https://github.com/openjdk/jdk/commit/9b55e9a706de9893b1a71c7a6a4e23c4b8842f18)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
On Mon, 26 Jun 2023 18:38:26 GMT, Jonathan Gibbons wrote:
> Please review a trivial update to normalize an `@since` tag.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14663#pullrequestreview-1499229502
On Tue, 25 Apr 2023 17:02:10 GMT, Phil Race wrote:
>> There were missing platforms in a couple of problem list entries.
>> I verified the intended platforms are still needed and the other platforms
>> pass.
>
> Phil Race has updated the pull request incrementally with one additional
> commit
On Mon, 24 Apr 2023 19:20:54 GMT, Phil Race wrote:
> There were missing platforms in a couple of problem list entries.
> I verified the intended platforms are still needed and the other platforms
> pass.
Marked as reviewed by iris (Reviewer).
test/jdk/ProblemList.txt line 444:
> 442:
On Thu, 5 Jan 2023 03:02:11 GMT, Sergey Bylokhov wrote:
>> Small cleanup, unnecessary semicolons are deleted here and there.
>
> Sergey Bylokhov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> native on win
Marked as reviewed by iris
On Wed, 14 Dec 2022 06:00:43 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which only fixes typos? The
> original PR for this change is https://github.com/openjdk/jdk/pull/10029.
> However, that PR included changes to multiple different files in different
> areas of the
On Tue, 13 Dec 2022 02:31:22 GMT, Prasanta Sadhukhan
wrote:
> Fixed Typo "form" should be "from"
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11640
On Thu, 8 Dec 2022 04:31:06 GMT, Prasanta Sadhukhan
wrote:
> Typo rectified
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11578
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti
wrote:
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
Marked as reviewed by iris (Reviewer).
-
PR:
On Fri, 30 Sep 2022 01:11:45 GMT, Joe Darcy wrote:
>> With the domain change from openjdk.java.net to openjdk.org, references to
>> URLs in the sources should be updated.
>>
>> Updates were made using a shell script. I"ll run a copyright updater before
>> any push.
>
> Joe Darcy has updated
On Tue, 20 Sep 2022 16:38:45 GMT, Alexey Ivanov wrote:
> Remove *the "Classpath" exception* from tests in `javax/awt`. The tests
> should not have it.
The updated license appears to match the GPL header
(https://github.com/openjdk/jdk/blob/master/make/data/license-templates/gpl-header)
as
On Thu, 15 Sep 2022 11:44:10 GMT, Prasanta Sadhukhan
wrote:
> Old SCCS markings removed from the jtreg tag.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10285
On Mon, 11 Jul 2022 08:04:20 GMT, Joe wrote:
> 8289562: Change bugs.java.com and bugreport.java.com URL's to https
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9445
On Fri, 12 Aug 2022 20:14:27 GMT, Phil Race wrote:
> Thread.stop() and ThreadGroup.destroy() are called by
> sun.awt.AppContext.dispose()
>
> These should no longer be called. Both are deprecated for removal.
> ThreadGroup.destroy() does nothing. Thread.stop() throws
>
On Mon, 15 Aug 2022 03:46:34 GMT, Phil Race wrote:
>> src/java.desktop/share/classes/sun/awt/AppContext.java line 406:
>>
>>> 404: Remove all uses of this internal class as soon as possible.
>>> 405: There is no replacement.
>>> 406: """);
>>
>> Should some
On Fri, 12 Aug 2022 20:14:27 GMT, Phil Race wrote:
> Thread.stop() and ThreadGroup.destroy() are called by
> sun.awt.AppContext.dispose()
>
> These should no longer be called. Both are deprecated for removal.
> ThreadGroup.destroy() does nothing. Thread.stop() throws
>
On Wed, 27 Jul 2022 17:47:36 GMT, Naoto Sato wrote:
> Adding an extra c2b mapping for the `%` in `IBM864` charset. The discrepancy
> came from the mapping difference between MS and IBM.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9661
24 matches
Mail list logo
