Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v4]

2024-06-07 Thread Prasanta Sadhukhan
On Fri, 7 Jun 2024 07:20:35 GMT, Prasanta Sadhukhan wrote: >> I believe only MouseEvents can be popup triggers. I checked in MouseEvent >> that there is a field for popup triggers and no such field in KeyEvent. >> >> The isPopupTrigger method here also previously c

Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v5]

2024-06-07 Thread Prasanta Sadhukhan
On Thu, 6 Jun 2024 18:28:12 GMT, Alisen Chung wrote: >> Issue is a mouse drag will trigger a popup in macos, but not in linux or >> windows. >> The solution is to add a check for a mouse pressed event to show popup and >> prevent mouse entered events from triggering the popup > > Alisen Chung

Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v4]

2024-06-07 Thread Prasanta Sadhukhan
On Thu, 6 Jun 2024 18:41:16 GMT, Alisen Chung wrote: >> src/java.desktop/macosx/classes/sun/lwawt/macosx/NSEvent.java line 276: >> >>> 274: && jeventType != MouseEvent.MOUSE_RELEASED) { >>> 275: return false; >>> 276: } >> >> Just to double check, are the

Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v5]

2024-06-07 Thread Prasanta Sadhukhan
On Thu, 6 Jun 2024 18:28:12 GMT, Alisen Chung wrote: >> Issue is a mouse drag will trigger a popup in macos, but not in linux or >> windows. >> The solution is to add a check for a mouse pressed event to show popup and >> prevent mouse entered events from triggering the popup > > Alisen Chung

Re: RFR: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup [v2]

2024-06-06 Thread Prasanta Sadhukhan
On Thu, 6 Jun 2024 05:26:53 GMT, Alisen Chung wrote: >> Issue is a mouse drag will trigger a popup in macos, but not in linux or >> windows. >> The solution is to add a check for a mouse pressed event to show popup and >> prevent mouse entered events from triggering the popup > > Alisen Chung

Re: RFR: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled

2024-06-03 Thread Prasanta Sadhukhan
On Fri, 24 May 2024 08:37:25 GMT, Jayathirth D V wrote: > In IJG library's jmemmgr.c file we can define MEM_STATS(by default this flag > is disabled and we don't see this issue) to enable printing of memory trace > logs when we have OOM. But if we enable it we get crash while disposing IJG >

Integrated: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized

2024-06-03 Thread Prasanta Sadhukhan
On Thu, 30 May 2024 12:05:25 GMT, Prasanta Sadhukhan wrote: > Issue is in macosx, when a JMenu or JPopupmenu is opened and then window is > resized from the lower right corner, then the Menu / JPopupmenu stays open > unlike in native osx apps like Notes, Mail etc.. > > This

Re: RFR: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled

2024-06-03 Thread Prasanta Sadhukhan
On Fri, 24 May 2024 08:37:25 GMT, Jayathirth D V wrote: > In IJG library's jmemmgr.c file we can define MEM_STATS(by default this flag > is disabled and we don't see this issue) to enable printing of memory trace > logs when we have OOM. But if we enable it we get crash while disposing IJG >

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v17]

2024-06-03 Thread Prasanta Sadhukhan
On Thu, 30 May 2024 18:45:38 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >> >> - Constants used in

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-06-03 Thread Prasanta Sadhukhan
On Fri, 31 May 2024 18:57:03 GMT, Alexander Scherbatiy wrote: >> If it's only about adding tray-1 to tray-11 in the above list and not about >> whole lot of changes in other areas, so that supported list contains those >> "tray-N" values, I guess we should add them.. >> I guess

Re: RFR: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized [v2]

2024-06-03 Thread Prasanta Sadhukhan
On Fri, 31 May 2024 14:49:45 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Non-client aread edge area modified, test format > > src/java.desktop/

Re: RFR: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized [v3]

2024-06-03 Thread Prasanta Sadhukhan
ges of the window as non-client area Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Access in EDT - Changes: - all: https://git.openjdk.org/jdk/pull/19474/files - new: https://git.openjdk.org/jdk/pull/194

Re: RFR: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized [v2]

2024-05-31 Thread Prasanta Sadhukhan
On Fri, 31 May 2024 10:51:29 GMT, Abhishek Kumar wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Non-client aread edge area modified, test format > > test/jdk/javax/swing

Re: RFR: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized [v2]

2024-05-31 Thread Prasanta Sadhukhan
On Fri, 31 May 2024 09:55:37 GMT, Alexander Zvegintsev wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Non-client aread edge area modified, test format > > src/java.desktop/

Re: RFR: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized [v2]

2024-05-31 Thread Prasanta Sadhukhan
ges of the window as non-client area Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Non-client aread edge area modified, test format - Changes: - all: https://git.openjdk.org/jdk/pull/19474/files - new: https://

Re: RFR: 8280990: [XWayland] XTest emulated mouse click does not bring window to front

2024-05-31 Thread Prasanta Sadhukhan
On Tue, 28 May 2024 02:25:46 GMT, Alexander Zvegintsev wrote: > Some of the modal tests fail in X11 compatibility mode on Wayland, because a > mouse click emulated with XTEST does not not cause the windows to be > reordered. > > This is a known limitation because these click events do not

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-31 Thread Prasanta Sadhukhan
On Thu, 30 May 2024 20:37:51 GMT, Alexander Scherbatiy wrote: >> What I understood is, it is acceptable to identify or get >> tray-1, tray-2, tray-3 name >> instead of descriptive names like >> TOP, MIDDLE, BOTTOM respectively etc >> so as such it can support upto 11 trays ie FROM TOP till

RFR: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized

2024-05-30 Thread Prasanta Sadhukhan
Issue is in macosx, when a JMenu or JPopupmenu is opened and then window is resized from the lower right corner, then the Menu / JPopupmenu stays open unlike in native osx apps like Notes, Mail etc.. This is because when LMouseButton is pressed on non-client area, the window should get a

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v16]

2024-05-30 Thread Prasanta Sadhukhan
On Wed, 29 May 2024 19:56:37 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >> >> - Constants used in

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-30 Thread Prasanta Sadhukhan
On Wed, 29 May 2024 20:20:00 GMT, Alexander Scherbatiy wrote: >> Actually it is not clear for me which maximum N should be used for these >> constants. >> Should only `tray-1`, `tray-2`, and `tray-3` be added, or should there be >> constants `tray-1` ... `tray-5` or even more? > > I updated

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v15]

2024-05-29 Thread Prasanta Sadhukhan
On Tue, 28 May 2024 16:47:21 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >> >> - Constants used in

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-29 Thread Prasanta Sadhukhan
On Mon, 20 May 2024 06:48:15 GMT, Prasanta Sadhukhan wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make OutputBin class sealed > > src/java.desktop/share/classes/

Integrated: 8332431: NullPointerException in JTable of SwingSet2

2024-05-28 Thread Prasanta Sadhukhan
On Fri, 24 May 2024 05:03:07 GMT, Prasanta Sadhukhan wrote: > Issue is observed in JTable demo in SwingSet2 whereby if we set the focus on > a table cell (or click on a table cell) and Press Ctrl+F1 (show/hide tooltip) > on a cell of JTable then NullpointerException is seen >

Re: RFR: 8332431: NullPointerException in JTable of SwingSet2 [v3]

2024-05-28 Thread Prasanta Sadhukhan
dow to be called trying to access > `mouseEvent` which is null. > Fix is made to check for null in this kind of cases..No regression test is > added as it can be checked easily with SwingSet2.. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit si

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v14]

2024-05-28 Thread Prasanta Sadhukhan
On Mon, 27 May 2024 17:02:35 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >> >> - Constants used in

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v13]

2024-05-28 Thread Prasanta Sadhukhan
On Mon, 27 May 2024 16:59:08 GMT, Alexander Scherbatiy wrote: >> test/jdk/javax/print/attribute/OutputBinAttributePrintDialogTest.java line >> 187: >> >>> 185: return new OutputBin[0]; >>> 186: } >>> 187: >> >> I guess before getting supported Attribute Values, we need

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v14]

2024-05-28 Thread Prasanta Sadhukhan
On Mon, 27 May 2024 17:02:35 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >> >> - Constants used in

Re: RFR: 8332431: NullPointerException in JTable of SwingSet2 [v2]

2024-05-28 Thread Prasanta Sadhukhan
On Tue, 28 May 2024 04:53:08 GMT, Abhishek Kumar wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Additional null check > > src/java.desktop/share/classes/javax/swing/ToolTipMa

Re: RFR: 8332431: NullPointerException in JTable of SwingSet2 [v2]

2024-05-27 Thread Prasanta Sadhukhan
On Mon, 27 May 2024 09:31:51 GMT, Abhishek Kumar wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Additional null check > > src/java.desktop/share/classes/javax/swing/ToolTipMa

Re: RFR: 8332431: NullPointerException in JTable of SwingSet2 [v2]

2024-05-27 Thread Prasanta Sadhukhan
dow to be called trying to access > `mouseEvent` which is null. > Fix is made to check for null in this kind of cases..No regression test is > added as it can be checked easily with SwingSet2.. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit si

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v13]

2024-05-27 Thread Prasanta Sadhukhan
On Thu, 23 May 2024 05:03:35 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >> >> - Constants used in

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771 [v4]

2024-05-24 Thread Prasanta Sadhukhan
On Wed, 22 May 2024 06:38:26 GMT, Alexander Zuev wrote: >> Caching children and selected children of the thee on the native level; >> Caching all children of a specific parent in CAccessibility to enhance >> recursive children selection algorithm; >> Removing fix for JDK-8317771 as no longer

Re: RFR: 8332416: Add more font selection options to Font2DTest [v3]

2024-05-23 Thread Prasanta Sadhukhan
On Tue, 21 May 2024 23:08:17 GMT, Phil Race wrote: >> Enhance Font2DTest as follows >> >> - Add main menu Radio Button options so that you select the font to use as >> either >> - (1) Font Family + Style (as now) >> - (2) Font Family + Menu of all members of the Family, replacing the Style >>

Re: RFR: 8332416: Add more font selection options to Font2DTest [v3]

2024-05-23 Thread Prasanta Sadhukhan
On Tue, 21 May 2024 23:08:17 GMT, Phil Race wrote: >> Enhance Font2DTest as follows >> >> - Add main menu Radio Button options so that you select the font to use as >> either >> - (1) Font Family + Style (as now) >> - (2) Font Family + Menu of all members of the Family, replacing the Style >>

RFR: 8332431: NullPointerException in JTable of SwingSet2

2024-05-23 Thread Prasanta Sadhukhan
Issue is observed in JTable demo in SwingSet2 whereby if we set the focus on a table cell (or click on a table cell) and Press Ctrl+F1 (show/hide tooltip) on a cell of JTable then NullpointerException is seen > Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException: Cannot >

Integrated: 8307193: Several Swing jtreg tests use class.forName on L classes

2024-05-22 Thread Prasanta Sadhukhan
On Wed, 22 May 2024 05:28:01 GMT, Prasanta Sadhukhan wrote: > Opensource couple RTL tests This pull request has now been integrated. Changeset: 9d332e65 Author: Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/commit/9d332e6591334a71335da65a4dd7b2ed0482b6cb Stats: 326 li

Re: RFR: 8307193: Several Swing jtreg tests use class.forName on L classes [v2]

2024-05-22 Thread Prasanta Sadhukhan
> Opensource couple RTL tests Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: spacing - Changes: - all: https://git.openjdk.org/jdk/pull/19341/files - new: https://git.openjdk.org/jdk/pull/19341/files/e9c1d

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v10]

2024-05-21 Thread Prasanta Sadhukhan
On Tue, 21 May 2024 19:01:35 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >> >> - Constants used in

RFR: 8307193: Several Swing jtreg tests use class.forName on L classes

2024-05-21 Thread Prasanta Sadhukhan
Opensource couple RTL tests - Commit messages: - 8307193: Several Swing jtreg tests use class.forName on L classes Changes: https://git.openjdk.org/jdk/pull/19341/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19341=00 Issue: https://bugs.openjdk.org/browse/JDK-8307193

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-21 Thread Prasanta Sadhukhan
On Mon, 20 May 2024 23:29:53 GMT, Alisen Chung wrote: > Are the tests added supposed to be manual tests? I’m not seeing any dialogs > pop up when i run the test on jtreg. Maybe I missed a config setting? I'm > running the tests on mac. I guess its because of this code where supported output

Re: RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L [v9]

2024-05-20 Thread Prasanta Sadhukhan
On Mon, 20 May 2024 08:45:15 GMT, Abhishek Kumar wrote: >> JLabel text is not painted with the LAF defined foreground color in GTK LAF. >> In GTK LAF the foreground color is retrieved by using native system APIs. >> Fix is to return the foreground color if it is set by LAF defined property >>

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-20 Thread Prasanta Sadhukhan
On Sat, 11 May 2024 17:32:37 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >> >> - Constants used in

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v9]

2024-05-20 Thread Prasanta Sadhukhan
On Mon, 20 May 2024 06:30:06 GMT, Prasanta Sadhukhan wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make OutputBin class sealed > > src/java.desktop/share/classes/

Re: RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L [v5]

2024-05-20 Thread Prasanta Sadhukhan
On Tue, 5 Mar 2024 08:20:12 GMT, Prasanta Sadhukhan wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> separate method to get LAF defined color > > test/jdk/javax/swing/plaf/basic/Bas

Integrated: 8332403: Anachronistic reference to Netscape Communicator in Swing API docs

2024-05-18 Thread Prasanta Sadhukhan
On Fri, 17 May 2024 03:37:21 GMT, Prasanta Sadhukhan wrote: > Inadvertent mention of Netscape in Javadoc is removed.. This pull request has now been integrated. Changeset: b92bd671 Author: Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/com

Re: RFR: 8332403: Anachronistic reference to Netscape Communicator in Swing API docs [v3]

2024-05-18 Thread Prasanta Sadhukhan
> Inadvertent mention of Netscape in Javadoc is removed.. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: e.g typo - Changes: - all: https://git.openjdk.org/jdk/pull/19276/files - new: https://git.openjdk.

Re: RFR: 8332403: Anachronistic reference to Netscape Communicator in Swing API docs [v2]

2024-05-17 Thread Prasanta Sadhukhan
> Inadvertent mention of Netscape in Javadoc is removed.. Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision: - doc clarity - doc clarity - Changes: - all: https://git.openjdk.org/jdk/pull/19276/files -

Re: RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L [v6]

2024-05-17 Thread Prasanta Sadhukhan
On Thu, 16 May 2024 08:48:30 GMT, Abhishek Kumar wrote: >> JLabel text is not painted with the LAF defined foreground color in GTK LAF. >> In GTK LAF the foreground color is retrieved by using native system APIs. >> Fix is to return the foreground color if it is set by LAF defined property >>

RFR: 8332403: Anachronistic reference to Netscape Communicator in Swing API docs

2024-05-16 Thread Prasanta Sadhukhan
Inadvertent mention of Netscape in Javadoc is removed.. - Commit messages: - 8332403: Anachronistic reference to Netscape Communicator in Swing API docs - 8332403: Anachronistic reference to Netscape Communicator in Swing API docs Changes:

Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v15]

2024-05-03 Thread Prasanta Sadhukhan
On Fri, 3 May 2024 07:46:07 GMT, Abhishek Kumar wrote: >> JTabbedPane's content area, tab area and tab background color are not as >> expected when opaque is set to true or false. >> The proposed fix is to handle the TabbedPane's background color in installed >> LAFs. Manual test is added to

Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v14]

2024-05-03 Thread Prasanta Sadhukhan
On Fri, 3 May 2024 05:10:15 GMT, Abhishek Kumar wrote: >> JTabbedPane's content area, tab area and tab background color are not as >> expected when opaque is set to true or false. >> The proposed fix is to handle the TabbedPane's background color in installed >> LAFs. Manual test is added to

Re: RFR: 8233177: Remove testcase for JDK-8001470 as fix has been reverted [v3]

2024-05-02 Thread Prasanta Sadhukhan
On Sat, 13 Apr 2024 18:22:07 GMT, Phil Race wrote: > Where are we with this ? Is there a consensus yet ? I guess I have added my explanations in the PR as to why the test should be removed...You can take a call and provide your decision. We have several unresolved bugs in JDK and most, if not

Integrated: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected

2024-05-02 Thread Prasanta Sadhukhan
On Thu, 4 Apr 2024 05:34:18 GMT, Prasanta Sadhukhan wrote: > Test issue shows the End and Start buttons are not placed as per instructions > due to ComponentOrientation RTL was not honoured, as with `getContentPane()` > being removed from `add` call of JFrame, it was also additionall

Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v11]

2024-05-02 Thread Prasanta Sadhukhan
On Thu, 2 May 2024 06:34:52 GMT, Abhishek Kumar wrote: >> src/java.desktop/share/classes/javax/swing/plaf/nimbus/skin.laf line 86: >> >>> 84: >> hueOffset="0.0" saturationOffset="0.0" brightnessOffset="0.0" >>> alphaOffset="0"/> >>> 85: >>> 86: >> >> One more thing >>

Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v12]

2024-05-02 Thread Prasanta Sadhukhan
On Thu, 2 May 2024 06:40:20 GMT, Abhishek Kumar wrote: >> JTabbedPane's content area, tab area and tab background color are not as >> expected when opaque is set to true or false. >> The proposed fix is to handle the TabbedPane's background color in installed >> LAFs. Manual test is added to

Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v11]

2024-05-02 Thread Prasanta Sadhukhan
On Thu, 2 May 2024 06:05:08 GMT, Abhishek Kumar wrote: >> JTabbedPane's content area, tab area and tab background color are not as >> expected when opaque is set to true or false. >> The proposed fix is to handle the TabbedPane's background color in installed >> LAFs. Manual test is added to

Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v10]

2024-04-30 Thread Prasanta Sadhukhan
On Fri, 19 Apr 2024 05:10:15 GMT, Abhishek Kumar wrote: >> JTabbedPane's content area, tab area and tab background color are not as >> expected when opaque is set to true or false. >> The proposed fix is to handle the TabbedPane's background color in installed >> LAFs. Manual test is added to

Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in Nimbus and Aqua LookAndFeel [v3]

2024-04-09 Thread Prasanta Sadhukhan
On Wed, 10 Apr 2024 04:43:29 GMT, Tejesh R wrote: >> Fix suggested in bug >> [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720) >> had a regression in Nimbus L yet it resolved the issue in other L The >> better approach would be to handle

Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in NimbusLookAndFeel [v2]

2024-04-08 Thread Prasanta Sadhukhan
On Thu, 4 Apr 2024 10:35:22 GMT, Tejesh R wrote: >> Fix suggested in bug >> [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720) >> had a regression in Nimbus L yet it resolved the issue in other L The >> better approach would be to handle

Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v7]

2024-04-04 Thread Prasanta Sadhukhan
On Thu, 4 Apr 2024 12:28:36 GMT, Abhishek Kumar wrote: >> src/java.desktop/share/classes/javax/swing/plaf/nimbus/skin.laf line 21653: >> >>> 21651:>> value="true"/> >>> 21652:>> value="true"/> >>> 21653: >> >> SInce you are introducing those 3

Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v7]

2024-04-04 Thread Prasanta Sadhukhan
On Thu, 4 Apr 2024 06:55:29 GMT, Abhishek Kumar wrote: >> JTabbedPane's content area, tab area and tab background color are not as >> expected when opaque is set to true or false. >> The proposed fix is to handle the TabbedPane's background color in installed >> LAFs. Manual test is added to

Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in NimbusLookAndFeel

2024-04-04 Thread Prasanta Sadhukhan
On Thu, 4 Apr 2024 14:43:43 GMT, Tejesh R wrote: > > > > > > Can you please explain why you need to handle MultiResolutionImage > > > > > > for this printing issue for NimbusL and why was it not needed for > > > > > > other L Also, you need to add this bugid to the test > > > > > > > > > > >

Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v7]

2024-04-04 Thread Prasanta Sadhukhan
On Thu, 4 Apr 2024 06:55:29 GMT, Abhishek Kumar wrote: >> JTabbedPane's content area, tab area and tab background color are not as >> expected when opaque is set to true or false. >> The proposed fix is to handle the TabbedPane's background color in installed >> LAFs. Manual test is added to

Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in NimbusLookAndFeel

2024-04-04 Thread Prasanta Sadhukhan
On Thu, 4 Apr 2024 11:30:14 GMT, Tejesh R wrote: > > > > Can you please explain why you need to handle MultiResolutionImage for > > > > this printing issue for NimbusL and why was it not needed for other > > > > L Also, you need to add this bugid to the test > > > > > > > > > The fix is for

Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in NimbusLookAndFeel

2024-04-04 Thread Prasanta Sadhukhan
On Thu, 4 Apr 2024 09:55:27 GMT, Tejesh R wrote: > > Can you please explain why you need to handle MultiResolutionImage for this > > printing issue for NimbusL and why was it not needed for other L Also, > > you need to add this bugid to the test > > The fix is for L other than Nimbus. It is

Re: RFR: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected [v2]

2024-04-04 Thread Prasanta Sadhukhan
d in the RTL not being propagated to its > child. Fix is to add `getContentPane()` to the non-add methods of JFrame as > was done in the applet version of the test.. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: inst

Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in NimbusLookAndFeel

2024-04-04 Thread Prasanta Sadhukhan
On Mon, 11 Mar 2024 10:05:41 GMT, Tejesh R wrote: > Fix suggested in bug > [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720) > had a regression in Nimbus L yet it resolved the issue in other L The > better approach would be to handle

RFR: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected

2024-04-03 Thread Prasanta Sadhukhan
Test issue shows the End and Start buttons are not placed as per instructions due to ComponentOrientation RTL was not honoured, as with `getContentPane()` being removed from `add` call of JFrame, it was also additionally removed from other JFrame calls which resulted in the RTL not being

Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in NimbusLookAndFeel

2024-04-03 Thread Prasanta Sadhukhan
On Mon, 11 Mar 2024 10:05:41 GMT, Tejesh R wrote: > Fix suggested in bug > [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720) > had a regression in Nimbus L yet it resolved the issue in other L The > better approach would be to handle

Re: RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v6]

2024-04-03 Thread Prasanta Sadhukhan
On Tue, 2 Apr 2024 17:32:26 GMT, Abhishek Kumar wrote: >> JTabbedPane's content area, tab area and tab background color are not as >> expected when opaque is set to true or false. >> The proposed fix is to handle the TabbedPane's background color in installed >> LAFs. Manual test is added to

Integrated: 8328541: Remove or update obsolete comment in JRootPane

2024-04-01 Thread Prasanta Sadhukhan
On Fri, 29 Mar 2024 07:21:17 GMT, Prasanta Sadhukhan wrote: > There is an old obsolete comment in JRootPane that is between the main > documentation comment for the class and the declaration of the class itself > which is causing interference with the work to support

Re: RFR: 8328541: Remove or update obsolete comment in JRootPane [v2]

2024-04-01 Thread Prasanta Sadhukhan
(JEP 467) so > removing this comment.. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: copyright year - Changes: - all: https://git.openjdk.org/jdk/pull/18545/files - new: https://git.openjdk.org/jdk/pull/18545

RFR: 8328541: Remove or update obsolete comment in JRootPane

2024-03-29 Thread Prasanta Sadhukhan
There is an old obsolete comment in JRootPane that is between the main documentation comment for the class and the declaration of the class itself which is causing interference with the work to support Markdown in documentation comments using the `///` style of comment. (JEP 467) so removing

Re: RFR: 8328561: test java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used

2024-03-29 Thread Prasanta Sadhukhan
On Thu, 21 Mar 2024 20:00:48 GMT, Phil Race wrote: > I don't know why this file is checked in. It has no @test tag and doesn't do > anything. I am deleting it. ok - Marked as reviewed by psadhukhan (Reviewer). PR Review:

Re: RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L [v5]

2024-03-26 Thread Prasanta Sadhukhan
On Tue, 26 Mar 2024 07:38:39 GMT, Abhishek Kumar wrote: > @aivanov-jdk > > > This looks weird… So you're saying Label[Enabled].textForeground and > > Label[Disabled].textForeground are used for Nimbus (and Synth and GTK) > > instead of Label.foreground and Label.disabledForeground which are

Integrated: 8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only

2024-03-25 Thread Prasanta Sadhukhan
On Fri, 22 Mar 2024 09:55:46 GMT, Prasanta Sadhukhan wrote: > Test is now passing in mac..Several iterations of the test passed in CI > system..link in JBS...deproblemlisted... This pull request has now been integrated. Changeset: f67ec19e Author:Prasanta Sadhukhan URL:

Re: RFR: 8328730: Convert java/awt/print/bug8023392/bug8023392.html applet test to main [v2]

2024-03-23 Thread Prasanta Sadhukhan
On Fri, 22 Mar 2024 17:38:36 GMT, Damon Nguyen wrote: >> Convert java/awt/print/bug8023392/bug8023392.html applet test to main using >> PassFailJFrame > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Move test out of extra

Re: RFR: 8328719: Convert java/awt/print/PageFormat/SetOrient.html applet test to main

2024-03-23 Thread Prasanta Sadhukhan
On Fri, 22 Mar 2024 18:55:01 GMT, Damon Nguyen wrote: > Convert java/awt/print/PageFormat/SetOrient.html applet test to main using > PassFailJFrame. Marked as reviewed by psadhukhan (Reviewer). test/jdk/java/awt/print/PageFormat/SetOrient.java line 106: > 104: pjob.print(); >

Re: RFR: 8328561: test java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used

2024-03-23 Thread Prasanta Sadhukhan
On Thu, 21 Mar 2024 20:00:48 GMT, Phil Race wrote: > I don't know why this file is checked in. It has no @test tag and doesn't do > anything. I am deleting it. Should we also remove test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ModifierPermutation.java which also does not have @test tag and

Re: RFR: 8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only [v2]

2024-03-22 Thread Prasanta Sadhukhan
> Test is now passing in mac..Several iterations of the test passed in CI > system..link in JBS...deproblemlisted... Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: spacing - Changes: - all:

Integrated: 8328673: Convert closed text/html/CSS manual applet test to main

2024-03-22 Thread Prasanta Sadhukhan
On Thu, 21 Mar 2024 09:04:19 GMT, Prasanta Sadhukhan wrote: > Couple closed manual applet text/html/CSS tests are converted to main based > and opensourced This pull request has now been integrated. Changeset: cd534f81 Author:Prasanta Sadhukhan URL: https://git.openjdk.o

Re: RFR: 8328484: Convert and Opensource few JFileChooser applet test to main

2024-03-22 Thread Prasanta Sadhukhan
On Fri, 22 Mar 2024 08:55:26 GMT, Abhishek Kumar wrote: > Few closed manual applet JFileChooser tests convereted to PassFailJFrame > based manual test. Marked as reviewed by psadhukhan (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18447#pullrequestreview-1954414137

RFR: 8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only

2024-03-22 Thread Prasanta Sadhukhan
Test is now passing in mac..Several iterations of the test passed in CI system..link in JBS...deproblemlisted... - Commit messages: - 8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only Changes:

Re: RFR: 8316324: Opensource five miscellaneous Swing tests

2024-03-22 Thread Prasanta Sadhukhan
On Thu, 21 Mar 2024 23:35:58 GMT, Alexander Zuev wrote: > Clean up and opensource five tests. test/jdk/javax/swing/InputVerifier/bug4774166.java line 44: > 42: * @summary InputVerifier should be called after a window loses and then > regains focus > 43: * @library

Re: RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main [v3]

2024-03-22 Thread Prasanta Sadhukhan
On Fri, 22 Mar 2024 05:15:38 GMT, Alexander Zuev wrote: >> Convert test to a main based; >> Move test to an appropriate folder; >> Remove old files; > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Got rid of the test

Re: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java applet test to main [v4]

2024-03-21 Thread Prasanta Sadhukhan
On Thu, 21 Mar 2024 16:11:44 GMT, Damon Nguyen wrote: >> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using >> PassFailJFrame. Also rename the test to PrintModalDialog.java since this is >> no longer an applet. Added test instructions related to the linked JBS issue. > >

Re: RFR: 8328670: Automate and open source few closed manual applet test

2024-03-21 Thread Prasanta Sadhukhan
On Thu, 21 Mar 2024 10:46:41 GMT, Abhishek Kumar wrote: > Few manual closed applet test converted to automated and open sourced. Marked as reviewed by psadhukhan (Reviewer). test/jdk/javax/swing/JInternalFrame/Ctrli.java line 126: > 124: keyecho.addMouseListener(mouseListener); > 125:

Re: RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main [v2]

2024-03-21 Thread Prasanta Sadhukhan
On Tue, 19 Mar 2024 14:10:52 GMT, Alexander Zuev wrote: >> Convert test to a main based; >> Move test to an appropriate folder; >> Remove old files; > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Adding library and

Integrated: 8328570: Convert closed JViewport manual applet tests to main

2024-03-21 Thread Prasanta Sadhukhan
On Thu, 21 Mar 2024 03:44:01 GMT, Prasanta Sadhukhan wrote: > Few closed manual applet JViewport tests are converted to main based and > opensourced This pull request has now been integrated. Changeset: 725d87bb Author:Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/

Re: RFR: 8328570: Convert closed JViewport manual applet tests to main [v3]

2024-03-21 Thread Prasanta Sadhukhan
On Thu, 21 Mar 2024 14:40:30 GMT, Alexander Zuev wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> formatting > > test/jdk/javax/swing/JViewport/bug4137282.java line 86:

Re: RFR: 8328570: Convert closed JViewport manual applet tests to main [v4]

2024-03-21 Thread Prasanta Sadhukhan
> Few closed manual applet JViewport tests are converted to main based and > opensourced Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: formatting - Changes: - all: https://git.openjdk.org/jdk/pull/18418

Re: RFR: 8328673: Convert closed text/html/CSS manual applet test to main [v2]

2024-03-21 Thread Prasanta Sadhukhan
On Thu, 21 Mar 2024 14:00:17 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> library path fix > > test/jdk/javax/swing/text/html/CSS/bug

Re: RFR: 8328673: Convert closed text/html/CSS manual applet test to main [v3]

2024-03-21 Thread Prasanta Sadhukhan
> Couple closed manual applet text/html/CSS tests are converted to main based > and opensourced Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Review comment update - Changes: - all: https://git.openj

Re: RFR: 8328570: Convert closed JViewport manual applet tests to main [v3]

2024-03-21 Thread Prasanta Sadhukhan
> Few closed manual applet JViewport tests are converted to main based and > opensourced Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: formatting - Changes: - all: https://git.openjdk.org/jdk/pull/18418

Re: RFR: 8328673: Convert closed text/html/CSS manual applet test to main [v2]

2024-03-21 Thread Prasanta Sadhukhan
On Thu, 21 Mar 2024 11:01:55 GMT, Abhishek Kumar wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> library path fix > > test/jdk/javax/swing/text/html/CSS/bug4271058.java line

Re: RFR: 8328673: Convert closed text/html/CSS manual applet test to main [v2]

2024-03-21 Thread Prasanta Sadhukhan
> Couple closed manual applet text/html/CSS tests are converted to main based > and opensourced Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: library path fix - Changes: - all: https://git.openjdk.o

Integrated: 8328238: Convert few closed manual applet tests to main

2024-03-21 Thread Prasanta Sadhukhan
On Wed, 20 Mar 2024 05:13:08 GMT, Prasanta Sadhukhan wrote: > Few closed manual applet tests are converted to main based and opensourced This pull request has now been integrated. Changeset: 68170ae2 Author: Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/com

Re: RFR: 8328238: Convert few closed manual applet tests to main [v4]

2024-03-21 Thread Prasanta Sadhukhan
On Thu, 21 Mar 2024 10:56:52 GMT, Alexey Ivanov wrote: >> Thanks for the information, didn't know that..Updatedthere is around >> ~400 occurrence of getContentPane() in swing tests in open still so probably >> something to be optimised in future... > > The tests were probably written

RFR: 8328673: Convert closed text/html/CSS manual applet test to main

2024-03-21 Thread Prasanta Sadhukhan
Couple closed manual applet text/html/CSS tests are converted to main based and opensourced - Commit messages: - 8328673: Convert closed text/html/CSS manual applet test to main Changes: https://git.openjdk.org/jdk/pull/18424/files Webrev:

Re: RFR: 8328570: Convert closed JViewport manual applet tests to main [v2]

2024-03-21 Thread Prasanta Sadhukhan
> Few closed manual applet JViewport tests are converted to main based and > opensourced Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: getCOntentPane removed - Changes: - all: https://git.openjdk.org/jd

  1   2   3   4   5   6   7   8   9   10   >