On Wed, 5 Jun 2024 08:29:11 GMT, Ravi Gupta wrote:
>> This testcase checks for the following assertions for Component events:
>>
>> 1. When components are resized, moved, hidden and shown the respective
>> events are triggered.
>> 2. When the components are hidden/disabled also,the component
On Tue, 4 Jun 2024 15:37:00 GMT, Abhishek Kumar wrote:
>> bug6492108.java test always fails in GTK L in single as well as dual
>> screen linux machines. Since this test was not marked as "_headful_" in it's
>> initial version, it never failed but after the fix of
>>
On Thu, 30 May 2024 06:53:40 GMT, Abhishek Kumar wrote:
>> I verified with debug, its not used in background thread too. Please do
>> verify once and remove if not used..
>
> Actually I can see the debug output in my local run.
> `invoking: onEDT10
> onEDT10
> invoking: onBackgroundThread20
On Thu, 30 May 2024 06:40:43 GMT, Abhishek Kumar wrote:
>> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 159:
>>
>>> 157: }
>>> 158:
>>> 159: public void onBackgroundThread30() {
>>
>> Unused, can be removed?
>
> Actually it is not unused and is run on the background
On Fri, 24 May 2024 06:44:06 GMT, Abhishek Kumar wrote:
> bug6492108.java test always fails in GTK L in single as well as dual screen
> linux machines. Since this test was not marked as "_headful_" in it's initial
> version, it never failed but after the fix of
>
On Tue, 21 May 2024 23:08:17 GMT, Phil Race wrote:
>> Enhance Font2DTest as follows
>>
>> - Add main menu Radio Button options so that you select the font to use as
>> either
>> - (1) Font Family + Style (as now)
>> - (2) Font Family + Menu of all members of the Family, replacing the Style
>>
On Thu, 23 May 2024 20:40:54 GMT, Harshitha Onkar wrote:
>> There's a LOT of such things, that my itchy fingers wanted to fix, but I
>> deliberately resisted temptation and don't see any reason to pick on a few
>> random infractions to fix.
>
> Agreed.
Yeah, agreed on this.
-
On Tue, 21 May 2024 23:05:50 GMT, Phil Race wrote:
> > I think I can just reset "Style" to "PLAIN" whenever switching the UI to
> > use SubFamily.
>
> It was a bit more than that, but I think it is behaving sensibly now. Please
> take another look.
Yeah, it's fine now. The reset is happening
On Thu, 16 May 2024 19:16:26 GMT, Phil Race wrote:
>> Enhance Font2DTest as follows
>>
>> - Add main menu Radio Button options so that you select the font to use as
>> either
>> - (1) Font Family + Style (as now)
>> - (2) Font Family + Menu of all members of the Family, replacing the Style
>>
On Mon, 20 May 2024 08:48:30 GMT, Abhishek Kumar wrote:
>> JLabel text is not painted with the LAF defined foreground color in GTK LAF.
>> In GTK LAF the foreground color is retrieved by using native system APIs.
>> Fix is to return the foreground color if it is set by LAF defined property
>>
On Sat, 11 May 2024 17:52:28 GMT, Nizar Benalla wrote:
> If you're currently reviewing this PR, thank you!
> Most fixes here are according to the reports by the since checker tool in
> #18934 and are pretty simple.
>
> To make reviewing easier
> - `BasicSliderUI` has the constructor `public
On Fri, 19 Apr 2024 07:12:36 GMT, Tejesh R wrote:
> Instructions set has been updated as per OS specific. JTable keyboard
> navigation is tested in each OS and according it's current implementation the
> instructions has been updated (Few has been removed and few has been
On Fri, 10 May 2024 07:30:18 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review updates
>
> test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 192:
>
&g
> Instructions set has been updated as per OS specific. JTable keyboard
> navigation is tested in each OS and according it's current implementation the
> instructions has been updated (Few has been removed and few has been
> updated).
> PassFailJFrame.builder is used.
Tejes
On Fri, 10 May 2024 05:02:36 GMT, Harshitha Onkar wrote:
>> This doesn't work here since the Instruction rows are quite more.
>
> @TejeshR13 Rows can be increased so as to reduce scrolling.
Increased to 30 rows, guess this would be optimal size.
-
PR Review Comment:
On Fri, 10 May 2024 05:06:53 GMT, Harshitha Onkar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix + Eanbled column selection mode
>
> test/jdk/javax/swing/JTable/KeyBoardNavig
> Instructions set has been updated as per OS specific. JTable keyboard
> navigation is tested in each OS and according it's current implementation the
> instructions has been updated (Few has been removed and few has been
> updated).
> PassFailJFrame.builder is used.
Tejes
On Wed, 8 May 2024 19:15:10 GMT, Alisen Chung wrote:
>> Opening closed dnd test
>> Test is green on all platforms
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> button1_down_mask, dispose on edt, replace system err with
On Wed, 8 May 2024 05:53:38 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
On Wed, 8 May 2024 05:53:38 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
On Tue, 7 May 2024 18:03:23 GMT, Alisen Chung wrote:
> Opening closed dnd test
> Test is green on all platforms
test/jdk/java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.java
line 190:
> 188: reset();
> 189: robot.mouseMove(p.x, p.y);
> 190:
On Wed, 8 May 2024 05:29:49 GMT, Tejesh R wrote:
>> Opening closed dnd test
>> Test is green on all platforms
>
> test/jdk/java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.java
> line 190:
>
>> 188: reset();
>> 189:
On Tue, 7 May 2024 18:03:23 GMT, Alisen Chung wrote:
> Opening closed dnd test
> Test is green on all platforms
test/jdk/java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.java
line 169:
> 167:
> 168: public void dispose() {
> 169: frame.dispose();
On Mon, 29 Apr 2024 09:00:46 GMT, Abhishek Kumar wrote:
> In GTK LAF, the menu mnemonics are always displayed which is different from
> the native behavior. In native application **(tested with gedit**), the menu
> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
>
On Tue, 7 May 2024 17:44:18 GMT, Abhishek Kumar wrote:
> > The fix applies to single/first menu, its doesn't apply to other Menu items
> > when there are more than one. Since you have taken _gedit_ as reference
> > where one Menu item is present you might have followed according to it, but
>
On Mon, 29 Apr 2024 09:00:46 GMT, Abhishek Kumar wrote:
> In GTK LAF, the menu mnemonics are always displayed which is different from
> the native behavior. In native application **(tested with gedit**), the menu
> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
>
On Fri, 3 May 2024 05:10:15 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to
On Fri, 3 May 2024 03:31:22 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to
On Thu, 2 May 2024 14:46:24 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java
>> line 128:
>>
>>> 126: private Color selectColor;
>>> 127: // Background color for unselected tabs
>>> 128: private Color unselectedBackground;
On Thu, 2 May 2024 06:40:20 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to
> Instructions set has been updated as per OS specific. JTable keyboard
> navigation is tested in each OS and according it's current implementation the
> instructions has been updated (Few has been removed and few has been
> updated).
> PassFailJFrame.builder is used.
Tejes
On Tue, 23 Apr 2024 07:51:59 GMT, Tejesh R wrote:
>> Instructions set has been updated as per OS specific. JTable keyboard
>> navigation is tested in each OS and according it's current implementation
>> the instructions has been updated (Few has been removed and few ha
On Thu, 25 Apr 2024 10:21:57 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review updates
>
> Default time out may not be sufficient to test, can be increase
On Tue, 30 Apr 2024 20:38:06 GMT, Harshitha Onkar wrote:
>> For the following manual test, more instructions are added as to what to
>> expect for "hide,iconify and show" vs "hide,iconify,show and restore" for
>> clarity.
>
> Harshitha Onkar has updated the pull request incrementally with one
On Thu, 2 May 2024 05:04:00 GMT, Tejesh R wrote:
> > > here
> >
> >
> > There are no changes to the COPYING file in the newest version of giblib so
> > there weren't any changes here either
>
> The latest version has `= MIT LICENSE` instead of `The
On Fri, 26 Apr 2024 21:37:56 GMT, Alisen Chung wrote:
> Updating giflib, clientlibs tests are green on all platforms
Marked as reviewed by tr (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull/18985#pullrequestreview-2034836229
On Tue, 30 Apr 2024 18:45:41 GMT, Alisen Chung wrote:
> > here
>
> There are no changes to the COPYING file in the newest version of giblib so
> there weren't any changes here either
The latest version has `= MIT LICENSE` instead of `The GIFLIB distribution is
Copyright (c) 1997 Eric S.
On Mon, 29 Apr 2024 19:59:18 GMT, Alexey Ivanov wrote:
>> This PR provides a regression test for
>> [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in
>> BasicDirectoryModel.validateFileCache_ reviewed in #18111.
>>
>> The test is inspired and based on
On Thu, 25 Apr 2024 10:06:35 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review updates
>
> test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 222:
>
>
On Mon, 29 Apr 2024 23:24:19 GMT, Harshitha Onkar wrote:
> For the following manual test, more instructions are added as to what to
> expect for "hide,iconify and show" vs "hide,iconify,show and restore" for
> clarity.
One observation is that, after the updates the size of whole test window
On Fri, 26 Apr 2024 21:37:56 GMT, Alisen Chung wrote:
> Updating giflib, clientlibs tests are green on all platforms
I did reviewed the changes against the updated library, everything is Good.
However the copywrite of _COPYING_ file
On Mon, 29 Apr 2024 14:45:43 GMT, Tejesh R wrote:
> > Is it necessary to create dummy files here in this test? Can't we just
> > create JFileChooser without creating dummy files and proceed with loader
> > test? Because I tested without using dummy files and getting exceptio
On Thu, 25 Apr 2024 16:37:39 GMT, Alexey Ivanov wrote:
> This PR provides a regression test for
> [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in
> BasicDirectoryModel.validateFileCache_ reviewed in #18111.
>
> The test is inspired and based on `ConcurrentModification`
On Mon, 29 Apr 2024 13:22:00 GMT, Alexey Ivanov wrote:
> > Is it necessary to create dummy files here in this test? Can't we just
> > create JFileChooser without creating dummy files and proceed with loader
> > test? Because I tested without using dummy files and getting exception
> > without
On Thu, 25 Apr 2024 16:37:39 GMT, Alexey Ivanov wrote:
> This PR provides a regression test for
> [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in
> BasicDirectoryModel.validateFileCache_ reviewed in #18111.
>
> The test is inspired and based on `ConcurrentModification`
On Wed, 10 Apr 2024 04:32:53 GMT, Tejesh R wrote:
> Getting a theme for particular dpi failed in windows L during print test.
> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
> was independent of DPI. After the fix
> (https://github.com/openjd
ut causing any regression (Tested in CI systems and also
> the affected tests).
Tejesh R has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains seven commits:
- Fixing merge conflicts
- Review updates
- Review updates
- Revie
ut causing any regression (Tested in CI systems and also
> the affected tests).
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Review updates
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18706/files
- new: ht
On Tue, 23 Apr 2024 10:34:32 GMT, Alexey Ivanov wrote:
>> Means only till openThemeImpl return value and not further up the hierarchy ?
>
> Yes, only the low-level methods until it's put into a map.
Yeah, sounds good. Will do that.
-
PR Review Comment:
On Tue, 23 Apr 2024 10:24:22 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review updates
>
> src/java.desktop/windows/classes/sun/awt/windows/ThemeR
On Tue, 23 Apr 2024 07:11:30 GMT, Tejesh R wrote:
>> src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java line 117:
>>
>>> 115:if (theme == null || theme == 0) {
>>> 116:theme = openTheme(widget, defaultDPI);
>>> 117:
ut causing any regression (Tested in CI systems and also
> the affected tests).
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Review updates
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18706/files
- new: ht
> Instructions set has been updated as per OS specific. JTable keyboard
> navigation is tested in each OS and according it's current implementation the
> instructions has been updated (Few has been removed and few has been
> updated).
> PassFailJFrame.builder is used.
Tejes
On Tue, 23 Apr 2024 06:44:32 GMT, Abhishek Kumar wrote:
>> Instructions set has been updated as per OS specific. JTable keyboard
>> navigation is tested in each OS and according it's current implementation
>> the instructions has been updated (Few has been removed and few has been
>>
On Mon, 22 Apr 2024 21:49:54 GMT, Damon Nguyen wrote:
>> Instructions set has been updated as per OS specific. JTable keyboard
>> navigation is tested in each OS and according it's current implementation
>> the instructions has been updated (Few has been removed and few has been
>> updated).
On Mon, 22 Apr 2024 21:41:12 GMT, Damon Nguyen wrote:
>> Instructions set has been updated as per OS specific. JTable keyboard
>> navigation is tested in each OS and according it's current implementation
>> the instructions has been updated (Few has been removed and few has been
>> updated).
On Mon, 22 Apr 2024 16:03:12 GMT, Alisen Chung wrote:
>> Instructions set has been updated as per OS specific. JTable keyboard
>> navigation is tested in each OS and according it's current implementation
>> the instructions has been updated (Few has been removed and few has been
>> updated).
On Mon, 22 Apr 2024 15:09:37 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Moved failure handling inside openThemeImpl method
>
> src/java.desktop/windows/classes/su
ut causing any regression (Tested in CI systems and also
> the affected tests).
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Review updates
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18706/files
- new: ht
On Fri, 19 Apr 2024 14:53:09 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Added pageloader cancel before new page creation along with code
>> restructuring. Moved all page loading calls inside synchronize to make it
>> thread safe.
>>
>> Regards,
>> Renjith.
>
> Renjith
On Mon, 22 Apr 2024 15:14:41 GMT, Alexey Ivanov wrote:
> Do you mind if I shorten the subject of the bug? _Printing JTable throws
> InternalError: HTHEME is null_?
Sure, it's better to shorten it.
-
PR Comment: https://git.openjdk.org/jdk/pull/18706#issuecomment-2071413388
On Tue, 9 Apr 2024 18:50:17 GMT, Phil Race wrote:
> The main problem here is that we do not curate what font point size we passed
> to freetype,
> and would pass in one larger than freetype's maximum of FT_USHORT_MAX which
> is USHRT_MAX.
> This isn't documented, SFAICS, and is checked a
On Mon, 22 Apr 2024 07:19:04 GMT, Tejesh R wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Rearranged if based on suggesion
>
> src/java.desktop/share/classes/javax/s
On Fri, 19 Apr 2024 14:53:09 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Added pageloader cancel before new page creation along with code
>> restructuring. Moved all page loading calls inside synchronize to make it
>> thread safe.
>>
>> Regards,
>> Renjith.
>
> Renjith
On Mon, 22 Apr 2024 07:00:52 GMT, Tejesh R wrote:
>> I agree. The current approach calls `openThemeImpl` three times: once or
>> twice with the passed `dpi` and then once with `defaultDPI` as the fallback.
>> Moreover, it *leaks theme handles* if `openThemeImpl` retu
On Fri, 19 Apr 2024 19:46:01 GMT, Alexey Ivanov wrote:
>> src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java line 120:
>>
>>> 118: // this should be called only with writeLock held
>>> 119: private static Long getThemeImpl(String widget, int dpi) {
>>> 120: if
ut causing any regression (Tested in CI systems and also
> the affected tests).
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Moved failure handling inside openThemeImpl method
-
Changes:
- all: https://git.openj
Instructions set has been updated as per OS specific. JTable keyboard
navigation is tested in each OS and according it's current implementation the
instructions has been updated (Few has been removed and few has been updated).
PassFailJFrame.builder is used.
-
Commit messages:
-
On Thu, 18 Apr 2024 15:18:56 GMT, Alexey Ivanov wrote:
> > Since the changes/restructuring is more, it would be better to add more
> > details in description which would help in review process.
>
> What details are you looking for?
>
> The purpose of the changes hasn't changed: make the code
On Thu, 18 Apr 2024 20:44:13 GMT, Harshitha Onkar wrote:
> @TejeshR13 Based on the PR description the source code fix looks correct. I
> was unable to test it on my local Win machine due to printer issues. The
> Print to PDF option isn't working too. But this is something to do with my
>
On Mon, 8 Apr 2024 06:09:16 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> Added pageloader cancel before new page creation along with code
> restructuring. Moved all page loading calls inside synchronize to make it
> thread safe.
>
> Regards,
> Renjith.
Since the
On Tue, 9 Apr 2024 18:50:17 GMT, Phil Race wrote:
> The main problem here is that we do not curate what font point size we passed
> to freetype,
> and would pass in one larger than freetype's maximum of FT_USHORT_MAX which
> is USHRT_MAX.
> This isn't documented, SFAICS, and is checked a
On Wed, 17 Apr 2024 06:18:39 GMT, Tejesh R wrote:
>> The logical || operator doesn't check second condition if first condition is
>> true. It checks second condition only if first one is false.
>> So as per current logic, if RED component is not equal, it doesn't check for
On Wed, 17 Apr 2024 04:31:16 GMT, Abhishek Kumar wrote:
>> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th
>> reason behind this issue was the size of image which is different and that
>> results in incorrect pixel comparison. Fix is to ensure that correct pixel
>> is
On Wed, 17 Apr 2024 06:09:32 GMT, Abhishek Kumar wrote:
>> I meant to use `&&` so that comparisons for failure case fails faster than
>> `||`.
>> Similar to this:
>> ` if ((c1.getRed() == c2.getRed())
>> && (c1.getBlue() == c2.getBlue())
>> && (c1.getGreen() ==
On Wed, 17 Apr 2024 05:17:03 GMT, Abhishek Kumar wrote:
>> test/jdk/javax/swing/JComboBox/DisabledComboBoxFontTestAuto.java line 125:
>>
>>> 123: private static boolean isColorMatching(Color c1, Color c2) {
>>> 124: if ((c1.getRed() != c2.getRed())
>>> 125: ||
On Tue, 16 Apr 2024 04:16:26 GMT, Abhishek Kumar wrote:
>> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th
>> reason behind this issue was the size of image which is different and that
>> results in incorrect pixel comparison. Fix is to ensure that correct pixel
>> is
On Tue, 16 Apr 2024 04:16:26 GMT, Abhishek Kumar wrote:
>> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th
>> reason behind this issue was the size of image which is different and that
>> results in incorrect pixel comparison. Fix is to ensure that correct pixel
>> is
On Thu, 11 Apr 2024 09:33:09 GMT, Alexey Ivanov wrote:
> This clean-up PR removes unused Windows version macro from `ShellFolder2.cpp`.
>
> `IS_WINVISTA` was not used at all.
>
> `IS_WINXP` guarded support for icons with alpha channel. It is now safe to
> assume Java runs on a Windows version
On Mon, 11 Mar 2024 10:05:41 GMT, Tejesh R wrote:
> Fix suggested in bug
> [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720)
> had a regression in Nimbus L yet it resolved the issue in other L The
> better approach would
On Thu, 11 Apr 2024 09:33:09 GMT, Alexey Ivanov wrote:
> This clean-up PR removes unused Windows version macro from `ShellFolder2.cpp`.
>
> `IS_WINVISTA` was not used at all.
>
> `IS_WINXP` guarded support for icons with alpha channel. It is now safe to
> assume Java runs on a Windows version
s://bugs.openjdk.org/browse/JDK-8322135)) introduced in
> 22, yet to investigate on it). And also fix
> [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720)
> has been reverted, retaining the test.
Tejesh R has updated the pull request incremental
On Wed, 10 Apr 2024 11:23:22 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/JTable/JTableScrollPrintTest.java line 45:
>>
>>> 43: * @test
>>> 44: * @key headful
>>> 45: * @bug 8210807 8322140
>>
>> Suggestion:
>>
>> You may
On Wed, 10 Apr 2024 08:56:08 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five
On Wed, 10 Apr 2024 09:05:49 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five
On Wed, 10 Apr 2024 10:27:03 GMT, Abhishek Kumar wrote:
>> I'm sure whether a new Graphics2D object will be created or reference will
>> be passed, just vaguely remember a conversation regarding disposing it and
>> suggested not to dispose since a reference will be passed on. So not sure
>>
On Wed, 10 Apr 2024 09:51:05 GMT, Abhishek Kumar wrote:
>> I'm not sure whether we have to dispose it here at this context.
>
> Since you are creating it locally, I guess you can dispose it.
I'm sure whether a new Graphics2D object will be created or reference will be
passed, just vaguely
On Wed, 10 Apr 2024 08:57:00 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five
On Fri, 22 Mar 2024 09:48:08 GMT, Tejesh R wrote:
> Convert and open source these manual applet test to main based:
> java/awt/Frame/MegaIconTest/MegaIconTest.html
> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.htm
On Mon, 8 Apr 2024 09:42:10 GMT, Prasanta Sadhukhan
wrote:
>> Tejesh R has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Spacing updates
>> - Updated test with BugID and copyright year
&
s://bugs.openjdk.org/browse/JDK-8322135)) introduced in
> 22, yet to investigate on it). And also fix
> [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720)
> has been reverted, retaining the test.
Tejesh R has updated the pull request with a new tar
Getting a theme for particular dpi failed in windows L during print test.
Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
was independent of DPI. After the fix
(https://github.com/openjdk/jdk/commit/a63afa4aa62863d1a199a0fb7d2f56ff8fcd04fd)
getting a theme in
On Thu, 4 Apr 2024 12:07:46 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> I have updated the test with PassFailJFrame along with printer availability
> check. Please review and let me know your suggestions.
>
> Renjith.
Did you test it for other L also?
On Fri, 5 Apr 2024 15:46:06 GMT, Alexey Ivanov wrote:
> Remove unused class `KeyBuilder` and unused field `unusedSets`.
> Update a comment which used javadoc syntax.
> Mark `KeyEnumeration` and `FontKey` classes as *`final`*.
>
> All the client tests are green.
Marked as reviewed by tr
imizedTest.html
>
> Automated the test SizeMinimizedTest.java. Since the test is failing Linux
> arch (Maybe related to the bug -
> [JDK-8305915](https://bugs.openjdk.org/browse/JDK-8305915)), the test is
> problem listed for Linux arch until the issue is fixed/further investigation
&g
On Fri, 5 Apr 2024 17:24:06 GMT, Harshitha Onkar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments updated - SizeMinimizedTest
>
> test/jdk/java/awt/Frame/SizeMinimi
On Fri, 5 Apr 2024 17:46:13 GMT, Harshitha Onkar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments updated - SizeMinimizedTest
>
> test/jdk/ProblemList.txt line 803:
On Thu, 4 Apr 2024 17:18:48 GMT, Prasanta Sadhukhan
wrote:
> > > > > > > Can you please explain why you need to handle
> > > > > > > MultiResolutionImage for this printing issue for NimbusL and
> > > > > > > why was it not needed for other L Also, you need to add this
> > > > > > > bugid to
On Thu, 4 Apr 2024 17:20:14 GMT, Harshitha Onkar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments updated - SizeMinimizedTest
>
> test/jdk/java/awt/Frame/SizeMinimi
imizedTest.html
>
> Automated the test SizeMinimizedTest.java. Since the test is failing Linux
> arch (Maybe related to the bug -
> [JDK-8305915](https://bugs.openjdk.org/browse/JDK-8305915)), the test is
> problem listed for Linux arch until the issue is fixed/further investigation
&g
1 - 100 of 1045 matches
Mail list logo
