[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849386#comment-17849386
]
David Capwell commented on CASSANDRA-14572:
---
For visibility there is a large conversation
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838242#comment-17838242
]
Brandon Williams commented on CASSANDRA-14572:
--
I too see the OOM if I loop 'ant
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838166#comment-17838166
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
[~maedhroz] Do you have a dump or any CI
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837832#comment-17837832
]
Caleb Rackliffe commented on CASSANDRA-14572:
-
Hi [~mmuzaf].
After merging this to
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833682#comment-17833682
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
Rebased the patch at the top of the trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831258#comment-17831258
]
Stefan Miklosovic commented on CASSANDRA-14572:
---
+1
> Expose all table metrics in
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830990#comment-17830990
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
Thanks to Brandon for running the tests:
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827259#comment-17827259
]
Chris Lohfink commented on CASSANDRA-14572:
---
+1 great follow through! I like the
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824412#comment-17824412
]
Stefan Miklosovic commented on CASSANDRA-14572:
---
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824131#comment-17824131
]
Stefan Miklosovic commented on CASSANDRA-14572:
---
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824019#comment-17824019
]
Stefan Miklosovic commented on CASSANDRA-14572:
---
first half of repeated units looks OK
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823217#comment-17823217
]
Stefan Miklosovic commented on CASSANDRA-14572:
---
yeah just put it here as comment or
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823214#comment-17823214
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
[~smiklosovic] I agree, no need to commit
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822308#comment-17822308
]
Stefan Miklosovic commented on CASSANDRA-14572:
---
Overall I have to say this is a great
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822060#comment-17822060
]
Stefan Miklosovic commented on CASSANDRA-14572:
---
Put more comments in there. I still
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821847#comment-17821847
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
Hello [~smiklosovic], thank you for your
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821317#comment-17821317
]
Stefan Miklosovic commented on CASSANDRA-14572:
---
I like non-processor approach more
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820831#comment-17820831
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
These pull requests compare approaches
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811370#comment-17811370
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
[~mck] I've fixed your comments.
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809602#comment-17809602
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
I think we can add a rate limiter or
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809595#comment-17809595
]
Chris Lohfink commented on CASSANDRA-14572:
---
Wouldn't this still be significantly less GC
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809574#comment-17809574
]
Michael Semb Wever commented on CASSANDRA-14572:
What about selecting all metrics ?
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809407#comment-17809407
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
It is implemented so that continuous
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809361#comment-17809361
]
Aleksey Yeschenko commented on CASSANDRA-14572:
---
It should be implemented in a way
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808808#comment-17808808
]
Michael Semb Wever commented on CASSANDRA-14572:
bq. if someone wrote a script to
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800388#comment-17800388
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
Here is the latest benchmark for
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800171#comment-17800171
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
Hi [~djoshi],
You're right, it is better
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800138#comment-17800138
]
Dinesh Joshi commented on CASSANDRA-14572:
--
hi [~mmuzaf] thanks for your patch. This is not
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799887#comment-17799887
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
I think we have a good history of
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799846#comment-17799846
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
I actually have an update for the last
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799592#comment-17799592
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
I have also prepared some benchmarks for
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799585#comment-17799585
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
Ok, so now the changes are completely
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798194#comment-17798194
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
The last CI showed that I'd missed some
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797951#comment-17797951
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
[~djoshi], [~cnlwsu], [~smiklosovic]
Hi
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797247#comment-17797247
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
[~cnlwsu] I like this idea, it also
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797240#comment-17797240
]
Chris Lohfink commented on CASSANDRA-14572:
---
so just nit picking thing, should we put
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792804#comment-17792804
]
Stefan Miklosovic commented on CASSANDRA-14572:
---
By the way, when I do this
{code}
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792800#comment-17792800
]
Stefan Miklosovic commented on CASSANDRA-14572:
---
Looks great, I am not sure when I
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792797#comment-17792797
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
However, the left alignment looks more
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792796#comment-17792796
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
I'd like to share some intermediate
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791175#comment-17791175
]
Chris Lohfink commented on CASSANDRA-14572:
---
Please do!
> Expose all table metrics in
[
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791082#comment-17791082
]
Maxim Muzafarov commented on CASSANDRA-14572:
-
[~cnlwsu] Would you mind if I pick up
42 matches
Mail list logo
