[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030518#comment-17030518
]
Alex Petrov commented on CASSANDRA-15429:
-
[~dcapwell] the [last
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030034#comment-17030034
]
Yifan Cai commented on CASSANDRA-15429:
---
Thanks [~ifesdjeen]! The patch LGTM. +1
Thanks
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030030#comment-17030030
]
David Capwell commented on CASSANDRA-15429:
---
The patch looks fine to me, but I want a
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030029#comment-17030029
]
David Capwell commented on CASSANDRA-15429:
---
The linked Circle run is
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030027#comment-17030027
]
David Capwell commented on CASSANDRA-15429:
---
Based off the patch I did the following greps
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030013#comment-17030013
]
David Capwell commented on CASSANDRA-15429:
---
well, as long as help is working... =D
Ill
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995892#comment-16995892
]
Yifan Cai commented on CASSANDRA-15429:
---
[~djoshi], thanks!
Changes are made to address your
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995177#comment-16995177
]
Dinesh Joshi commented on CASSANDRA-15429:
--
Hi [~yifanc], thanks for the PR. I have left a
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993122#comment-16993122
]
David Capwell commented on CASSANDRA-15429:
---
LGTM +1
> Support NodeTool for in-jvm dtest
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993080#comment-16993080
]
Yifan Cai commented on CASSANDRA-15429:
---
Thanks [~dcapwell]! PRs have been updated to address
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993049#comment-16993049
]
David Capwell commented on CASSANDRA-15429:
---
Did another pass. Mostly LGTM; left a few
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992882#comment-16992882
]
David Capwell commented on CASSANDRA-15429:
---
We should refactor NodeProbe and
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992778#comment-16992778
]
Yifan Cai commented on CASSANDRA-15429:
---
Thanks [~ifesdjeen]
{quote}Can we hide nodetool
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992286#comment-16992286
]
Alex Petrov commented on CASSANDRA-15429:
-
Not an official review, just glanced over the
[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976807#comment-16976807
]
Yifan Cai commented on CASSANDRA-15429:
---
[~drohrer] and I co-worked on it.
The changes in the
15 matches
Mail list logo
