This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 1138b2a68b54 [MINOR][BUILD] Remove duplicate configuration of 
maven-compiler-plugin
1138b2a68b54 is described below

commit 1138b2a68b5408e6d079bdbce8026323694628e5
Author: zml1206 <zhuml1...@gmail.com>
AuthorDate: Thu May 9 20:51:32 2024 -0700

    [MINOR][BUILD] Remove duplicate configuration of maven-compiler-plugin
    
    ### What changes were proposed in this pull request?
    `<release>${java.version}</release>` and 
`<maven.compiler.release>${java.version}</maven.compiler.release>` 
(https://github.com/apache/spark/pull/46024/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R117)
    are equivalent duplicate configuration, so remove 
`<release>${java.version}</release>`.
    
https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html
    
    ### Why are the changes needed?
    Simplify the code and facilitates subsequent configuration iterations.
    
    ### Does this PR introduce _any_ user-facing change?
    No.
    
    ### How was this patch tested?
    Pass the CIs.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    No.
    
    Closes #46024 from zml1206/remove_duplicate_configuration.
    
    Authored-by: zml1206 <zhuml1...@gmail.com>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 pom.xml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index c3ff5d101c22..678455e6e248 100644
--- a/pom.xml
+++ b/pom.xml
@@ -3127,7 +3127,6 @@
           <artifactId>maven-compiler-plugin</artifactId>
           <version>3.13.0</version>
           <configuration>
-            <release>${java.version}</release>
             <skipMain>true</skipMain> <!-- skip compile -->
             <skip>true</skip> <!-- skip testCompile -->
           </configuration>


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to