This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 0154c059cddb [MINOR][DOCS] Remove Java 8/11 at
`IgnoreUnrecognizedVMOptions` description
0154c059cddb is described below
commit 0154c059cddba7cafe74243b3f9eedd9db367b72
Author: Dongjoon Hyun <dh...@apple.com>
AuthorDate: Sat Feb 3 18:47:30 2024 -0800
[MINOR][DOCS] Remove Java 8/11 at `IgnoreUnrecognizedVMOptions` description
### What changes were proposed in this pull request?
This PR aims to remove old Java 8 and Java 11 from
`IgnoreUnrecognizedVMOptions` JVM option description.
### Why are the changes needed?
From Apache Spark 4.0.0, we use `IgnoreUnrecognizedVMOptions` JVM option to
be robust, not for Java 8 and Java 11 support.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manual review.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #45012 from dongjoon-hyun/IgnoreUnrecognizedVMOptions.
Authored-by: Dongjoon Hyun <dh...@apple.com>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
.../src/main/java/org/apache/spark/launcher/JavaModuleOptions.java | 2 +-
.../yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git
a/launcher/src/main/java/org/apache/spark/launcher/JavaModuleOptions.java
b/launcher/src/main/java/org/apache/spark/launcher/JavaModuleOptions.java
index a7a6891746c2..8893f4bcb85a 100644
--- a/launcher/src/main/java/org/apache/spark/launcher/JavaModuleOptions.java
+++ b/launcher/src/main/java/org/apache/spark/launcher/JavaModuleOptions.java
@@ -20,7 +20,7 @@ package org.apache.spark.launcher;
/**
* This helper class is used to place the all `--add-opens` options
* required by Spark when using Java 17. `DEFAULT_MODULE_OPTIONS` has added
- * `-XX:+IgnoreUnrecognizedVMOptions` to be compatible with Java 8 and Java 11.
+ * `-XX:+IgnoreUnrecognizedVMOptions` to be robust.
*
* @since 3.3.0
*/
diff --git
a/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
b/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
index 22037a1111d5..6e3e0a1e644e 100644
---
a/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
+++
b/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
@@ -1031,8 +1031,7 @@ private[spark] class Client(
javaOpts += s"-Djava.net.preferIPv6Addresses=${Utils.preferIPv6}"
// SPARK-37106: To start AM with Java 17,
`JavaModuleOptions.defaultModuleOptions`
- // is added by default. It will not affect Java 8 and Java 11 due to
existence of
- // `-XX:+IgnoreUnrecognizedVMOptions`.
+ // is added by default.
javaOpts += JavaModuleOptions.defaultModuleOptions()
// Set the environment variable through a command prefix
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
