This is an automated email from the ASF dual-hosted git repository.
maxgekk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 26d3eca0a8d3 [SPARK-46009][SQL][DOCS][FOLLOWUP] Change the error code
for invalid inverse distribution function
26d3eca0a8d3 is described below
commit 26d3eca0a8d3303d0bb9450feb6575ed145bbd7e
Author: beliefer <belie...@163.com>
AuthorDate: Sun Jan 21 23:32:28 2024 +0300
[SPARK-46009][SQL][DOCS][FOLLOWUP] Change the error code for invalid
inverse distribution function
### What changes were proposed in this pull request?
This PR follows up https://github.com/apache/spark/pull/43910 and propose
to change the error code for invalid inverse distribution function.
### Why are the changes needed?
Based on the discussion at
https://github.com/apache/spark/pull/43910#discussion_r1460131124
### Does this PR introduce _any_ user-facing change?
'No'.
### How was this patch tested?
GA tests.
### Was this patch authored or co-authored using generative AI tooling?
'No'.
Closes #44811 from beliefer/SPARK-46009_followup.
Authored-by: beliefer <belie...@163.com>
Signed-off-by: Max Gekk <max.g...@gmail.com>
---
common/utils/src/main/resources/error/README.md | 2 +-
common/utils/src/main/resources/error/error-classes.json | 2 +-
...itions-invalid-inverse-distribution-function-error-class.md | 2 +-
docs/sql-error-conditions.md | 2 +-
.../src/test/resources/sql-tests/analyzer-results/mode.sql.out | 8 ++++----
.../resources/sql-tests/analyzer-results/percentiles.sql.out | 10 +++++-----
sql/core/src/test/resources/sql-tests/results/mode.sql.out | 8 ++++----
.../src/test/resources/sql-tests/results/percentiles.sql.out | 10 +++++-----
8 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/common/utils/src/main/resources/error/README.md
b/common/utils/src/main/resources/error/README.md
index b062c7739072..17e5a88cd884 100644
--- a/common/utils/src/main/resources/error/README.md
+++ b/common/utils/src/main/resources/error/README.md
@@ -881,6 +881,7 @@ The following SQLSTATEs are collated from:
|42K0H |42 |Syntax error or Access Rule violation |K0H |A
cyclic invocation has been detected. |Spark |N
|Spark
|
|42K0I |42 |Syntax error or Access Rule violation |K0I
|SQL Config not found. |Spark |N
|Spark
|
|42K0J |42 |Syntax error or Access Rule violation |K0J
|Property not found. |Spark |N
|Spark
|
+|42K0K |IM |Syntax error or Access Rule violation |K0K
|Invalid inverse distribution function |Spark |N
|Spark
|
|42KD0 |42 |Syntax error or Access Rule violation |KD0
|Ambiguous name reference. |Databricks |N
|Databricks
|
|42KD1 |42 |Syntax error or Access Rule violation |KD1
|Operation not supported in READ ONLY session mode. |Databricks |N
|Databricks
|
|42KD2 |42 |Syntax error or Access Rule violation |KD2
|The source and target table names of a SYNC operaton must be the
same.|Databricks |N |Databricks
|
@@ -1310,7 +1311,6 @@ The following SQLSTATEs are collated from:
|HZ320 |HZ |RDA-specific condition |320
|version not supported |RDA/SQL |Y
|RDA/SQL
|
|HZ321 |HZ |RDA-specific condition |321
|TCP/IP error |RDA/SQL |Y
|RDA/SQL
|
|HZ322 |HZ |RDA-specific condition |322
|TLS alert |RDA/SQL |Y
|RDA/SQL
|
-|ID001 |IM |Invalid inverse distribution function |001
|Invalid inverse distribution function |SQL/Foundation |N
|SQL/Foundation PostgreSQL Oracle Snowflake Redshift H2
|
|IM001 |IM |ODBC driver |001
|Driver does not support this function |SQL Server |N
|SQL Server
|
|IM002 |IM |ODBC driver |002
|Data source name not found and no default driver specified |SQL Server |N
|SQL Server
|
|IM003 |IM |ODBC driver |003
|Specified driver could not be loaded |SQL Server |N
|SQL Server
|
diff --git a/common/utils/src/main/resources/error/error-classes.json
b/common/utils/src/main/resources/error/error-classes.json
index 072081f48448..8f4e04ba5456 100644
--- a/common/utils/src/main/resources/error/error-classes.json
+++ b/common/utils/src/main/resources/error/error-classes.json
@@ -2009,7 +2009,7 @@
]
}
},
- "sqlState" : "ID001"
+ "sqlState" : "42K0K"
},
"INVALID_JSON_ROOT_FIELD" : {
"message" : [
diff --git
a/docs/sql-error-conditions-invalid-inverse-distribution-function-error-class.md
b/docs/sql-error-conditions-invalid-inverse-distribution-function-error-class.md
index d2091c72f43c..4a2cf3faaaf1 100644
---
a/docs/sql-error-conditions-invalid-inverse-distribution-function-error-class.md
+++
b/docs/sql-error-conditions-invalid-inverse-distribution-function-error-class.md
@@ -19,7 +19,7 @@ license: |
limitations under the License.
---
-SQLSTATE: ID001
+[SQLSTATE:
42K0K](sql-error-conditions-sqlstates.html#class-42-syntax-error-or-access-rule-violation)
Invalid inverse distribution function `<funcName>`.
diff --git a/docs/sql-error-conditions.md b/docs/sql-error-conditions.md
index 133cfbacb5fa..fa3bd5826214 100644
--- a/docs/sql-error-conditions.md
+++ b/docs/sql-error-conditions.md
@@ -1177,7 +1177,7 @@ For more details see
[INVALID_INLINE_TABLE](sql-error-conditions-invalid-inline-
###
[INVALID_INVERSE_DISTRIBUTION_FUNCTION](sql-error-conditions-invalid-inverse-distribution-function-error-class.html)
-SQLSTATE: ID001
+[SQLSTATE:
42K0K](sql-error-conditions-sqlstates.html#class-42-syntax-error-or-access-rule-violation)
Invalid inverse distribution function `<funcName>`.
diff --git
a/sql/core/src/test/resources/sql-tests/analyzer-results/mode.sql.out
b/sql/core/src/test/resources/sql-tests/analyzer-results/mode.sql.out
index 6fa1dcb4b75d..a0a0c81ef027 100644
--- a/sql/core/src/test/resources/sql-tests/analyzer-results/mode.sql.out
+++ b/sql/core/src/test/resources/sql-tests/analyzer-results/mode.sql.out
@@ -75,7 +75,7 @@ SELECT department, mode(DISTINCT salary) FROM basic_pays
GROUP BY department ORD
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.DISTINCT_UNSUPPORTED",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"funcName" : "`mode`"
},
@@ -380,7 +380,7 @@ FROM basic_pays
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.DISTINCT_UNSUPPORTED",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"funcName" : "`mode`"
},
@@ -402,7 +402,7 @@ FROM basic_pays
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.WITHIN_GROUP_MISSING",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"funcName" : "`mode`"
},
@@ -424,7 +424,7 @@ FROM basic_pays
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.WRONG_NUM_ORDERINGS",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"actualNum" : "1",
"expectedNum" : "0",
diff --git
a/sql/core/src/test/resources/sql-tests/analyzer-results/percentiles.sql.out
b/sql/core/src/test/resources/sql-tests/analyzer-results/percentiles.sql.out
index b5da559901c2..e763ed48b136 100644
--- a/sql/core/src/test/resources/sql-tests/analyzer-results/percentiles.sql.out
+++ b/sql/core/src/test/resources/sql-tests/analyzer-results/percentiles.sql.out
@@ -249,7 +249,7 @@ FROM aggr
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.DISTINCT_UNSUPPORTED",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"funcName" : "`percentile_cont`"
},
@@ -271,7 +271,7 @@ FROM aggr
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.DISTINCT_UNSUPPORTED",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"funcName" : "`percentile_cont`"
},
@@ -343,7 +343,7 @@ FROM aggr
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.WITHIN_GROUP_MISSING",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"funcName" : "`percentile_cont`"
},
@@ -365,7 +365,7 @@ FROM aggr
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.WITHIN_GROUP_MISSING",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"funcName" : "`percentile_cont`"
},
@@ -387,7 +387,7 @@ FROM aggr
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.WRONG_NUM_ORDERINGS",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"actualNum" : "2",
"expectedNum" : "1",
diff --git a/sql/core/src/test/resources/sql-tests/results/mode.sql.out
b/sql/core/src/test/resources/sql-tests/results/mode.sql.out
index 763e8d8c1909..6ae7b2d29e9d 100644
--- a/sql/core/src/test/resources/sql-tests/results/mode.sql.out
+++ b/sql/core/src/test/resources/sql-tests/results/mode.sql.out
@@ -52,7 +52,7 @@ struct<>
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.DISTINCT_UNSUPPORTED",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"funcName" : "`mode`"
},
@@ -380,7 +380,7 @@ struct<>
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.DISTINCT_UNSUPPORTED",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"funcName" : "`mode`"
},
@@ -404,7 +404,7 @@ struct<>
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.WITHIN_GROUP_MISSING",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"funcName" : "`mode`"
},
@@ -428,7 +428,7 @@ struct<>
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.WRONG_NUM_ORDERINGS",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"actualNum" : "1",
"expectedNum" : "0",
diff --git a/sql/core/src/test/resources/sql-tests/results/percentiles.sql.out
b/sql/core/src/test/resources/sql-tests/results/percentiles.sql.out
index fc951308563f..cd95eee186e1 100644
--- a/sql/core/src/test/resources/sql-tests/results/percentiles.sql.out
+++ b/sql/core/src/test/resources/sql-tests/results/percentiles.sql.out
@@ -223,7 +223,7 @@ struct<>
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.DISTINCT_UNSUPPORTED",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"funcName" : "`percentile_cont`"
},
@@ -247,7 +247,7 @@ struct<>
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.DISTINCT_UNSUPPORTED",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"funcName" : "`percentile_cont`"
},
@@ -325,7 +325,7 @@ struct<>
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.WITHIN_GROUP_MISSING",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"funcName" : "`percentile_cont`"
},
@@ -349,7 +349,7 @@ struct<>
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.WITHIN_GROUP_MISSING",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"funcName" : "`percentile_cont`"
},
@@ -373,7 +373,7 @@ struct<>
org.apache.spark.sql.AnalysisException
{
"errorClass" : "INVALID_INVERSE_DISTRIBUTION_FUNCTION.WRONG_NUM_ORDERINGS",
- "sqlState" : "ID001",
+ "sqlState" : "42K0K",
"messageParameters" : {
"actualNum" : "2",
"expectedNum" : "1",
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
