This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 1b966d2eb329 [SPARK-47965][SQL][FOLLOW-UP] Uses `null` as its default 
value for `OptionalConfigEntry`
1b966d2eb329 is described below

commit 1b966d2eb329eed45b258d2134aacc0ea62d75dd
Author: Hyukjin Kwon <gurwls...@apache.org>
AuthorDate: Wed May 8 19:18:06 2024 +0900

    [SPARK-47965][SQL][FOLLOW-UP] Uses `null` as its default value for 
`OptionalConfigEntry`
    
    ### What changes were proposed in this pull request?
    
    This PR partially reverts https://github.com/apache/spark/pull/46197 
because of the behaviour change below:
    
    ```python
    >>> spark.conf.get("spark.sql.optimizer.excludedRules")
    '<undefined>'
    ```
    
    ### Why are the changes needed?
    
    To avoid behaviour change.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No, the main change has not been released out yet.
    
    ### How was this patch tested?
    
    Manually as described above.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    No.
    
    Closes #46472 from HyukjinKwon/SPARK-47965-followup.
    
    Authored-by: Hyukjin Kwon <gurwls...@apache.org>
    Signed-off-by: Hyukjin Kwon <gurwls...@apache.org>
---
 core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala 
b/core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala
index c07f2528ee70..a295ef06a637 100644
--- a/core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala
+++ b/core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala
@@ -227,7 +227,7 @@ private[spark] class OptionalConfigEntry[T](
     prependSeparator,
     alternatives,
     s => Some(rawValueConverter(s)),
-    v => v.map(rawStringConverter).getOrElse(ConfigEntry.UNDEFINED),
+    v => v.map(rawStringConverter).orNull,
     doc,
     isPublic,
     version


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to