This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new d09f174be5e9 [SPARK-48136][INFRA][CONNECT] Always upload Spark Connect 
log files in scheduled build for Spark Connect
d09f174be5e9 is described below

commit d09f174be5e9bf7dee12840526ed8bf6aee07052
Author: Hyukjin Kwon <gurwls...@apache.org>
AuthorDate: Sun May 5 17:49:15 2024 -0700

    [SPARK-48136][INFRA][CONNECT] Always upload Spark Connect log files in 
scheduled build for Spark Connect
    
    ### What changes were proposed in this pull request?
    
    This PR proposes to upload Spark Connect log files in scheduled build for 
Spark Connect
    
    ### Why are the changes needed?
    
    Difficult to debug, e.g., 
https://github.com/apache/spark/actions/runs/8960485641/job/24607044822
    
    ### Does this PR introduce _any_ user-facing change?
    
    No, dev-only.
    
    ### How was this patch tested?
    
    Manually
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    No.
    
    Closes #46393 from HyukjinKwon/SPARK-48136.
    
    Authored-by: Hyukjin Kwon <gurwls...@apache.org>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 .github/workflows/build_python_connect.yml   | 2 +-
 .github/workflows/build_python_connect35.yml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build_python_connect.yml 
b/.github/workflows/build_python_connect.yml
index 3a9ce5115741..639b0d084314 100644
--- a/.github/workflows/build_python_connect.yml
+++ b/.github/workflows/build_python_connect.yml
@@ -118,7 +118,7 @@ jobs:
           name: test-results-spark-connect-python-only
           path: "**/target/test-reports/*.xml"
       - name: Upload Spark Connect server log file
-        if: failure()
+        if: ${{ !success() }}
         uses: actions/upload-artifact@v4
         with:
           name: unit-tests-log-spark-connect-python-only
diff --git a/.github/workflows/build_python_connect35.yml 
b/.github/workflows/build_python_connect35.yml
index 8c9a5fa86996..14edb8bf91ed 100644
--- a/.github/workflows/build_python_connect35.yml
+++ b/.github/workflows/build_python_connect35.yml
@@ -106,7 +106,7 @@ jobs:
           name: test-results-spark-connect-python-only
           path: "**/target/test-reports/*.xml"
       - name: Upload Spark Connect server log file
-        if: failure()
+        if: ${{ !success() }}
         uses: actions/upload-artifact@v4
         with:
           name: unit-tests-log-spark-connect-python-only


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to