This is an automated email from the ASF dual-hosted git repository.

srowen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 85581f6  [SPARK-33925][CORE][FOLLOW-UP] Remove the unused variables 
'secMgr'
85581f6 is described below

commit 85581f6dac5c116d3d83101044cc3a85bfca41bf
Author: PengLei <18066542...@189.cn>
AuthorDate: Mon Mar 22 12:02:25 2021 -0500

    [SPARK-33925][CORE][FOLLOW-UP] Remove the unused variables 'secMgr'
    
    ### What changes were proposed in this pull request?
    Remove the unused variable 'secMgr' in SparkSubmit.scala and 
DriverWrapper.scala
    In jira https://issues.apache.org/jira/browse/SPARK-33925, The last usage 
of SecurityManager in Utils.fetchFile was removed. We don't need the variable 
anymore
    
    ### Why are the changes needed?
    For better readablity of codes
    
    ### Does this PR introduce _any_ user-facing change?
    No,dev-only
    
    ### How was this patch tested?
    Manually complied. Github Actions and Jenkins build should test it out as 
well.
    
    Closes #31928 from Peng-Lei/rm_secMgr.
    
    Authored-by: PengLei <18066542...@189.cn>
    Signed-off-by: Sean Owen <sro...@gmail.com>
---
 core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala          | 1 -
 core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala | 1 -
 2 files changed, 2 deletions(-)

diff --git a/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala 
b/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
index 2a89078..e5fd027 100644
--- a/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
+++ b/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
@@ -366,7 +366,6 @@ private[spark] class SparkSubmit extends Logging {
     args.pyFiles = Option(args.pyFiles).map(resolveGlobPaths(_, 
hadoopConf)).orNull
     args.archives = Option(args.archives).map(resolveGlobPaths(_, 
hadoopConf)).orNull
 
-    lazy val secMgr = new SecurityManager(sparkConf)
 
     // In client mode, download remote files.
     var localPrimaryResource: String = null
diff --git 
a/core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala 
b/core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala
index 61fb929..9176897 100644
--- a/core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala
+++ b/core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala
@@ -74,7 +74,6 @@ object DriverWrapper extends Logging {
 
   private def setupDependencies(loader: MutableURLClassLoader, userJar: 
String): Unit = {
     val sparkConf = new SparkConf()
-    val secMgr = new SecurityManager(sparkConf)
     val hadoopConf = SparkHadoopUtil.newConfiguration(sparkConf)
 
     val ivyProperties = DependencyUtils.getIvyProperties()

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to