This is an automated email from the ASF dual-hosted git repository. dongjoon pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new 2697a9426e1 [SPARK-43654][CONNECT][PS][TESTS] Enable `InternalFrameParityTests.test_from_pandas` 2697a9426e1 is described below commit 2697a9426e174e30c797a27660f20e42cf2faefc Author: Haejoon Lee <haejoon....@databricks.com> AuthorDate: Mon Sep 18 21:26:02 2023 -0700 [SPARK-43654][CONNECT][PS][TESTS] Enable `InternalFrameParityTests.test_from_pandas` ### What changes were proposed in this pull request? This PR proposes to enable `InternalFrameParityTests.test_from_pandas` ### Why are the changes needed? To improve the test coverage for Pandas API with Spark Connect. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added UT for Spark Connect. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42956 from itholic/enable_from_pandas. Authored-by: Haejoon Lee <haejoon....@databricks.com> Signed-off-by: Dongjoon Hyun <dh...@apple.com> --- python/pyspark/pandas/tests/connect/test_parity_internal.py | 4 +--- python/pyspark/pandas/utils.py | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/python/pyspark/pandas/tests/connect/test_parity_internal.py b/python/pyspark/pandas/tests/connect/test_parity_internal.py index d586fec57f7..d90b2b260f4 100644 --- a/python/pyspark/pandas/tests/connect/test_parity_internal.py +++ b/python/pyspark/pandas/tests/connect/test_parity_internal.py @@ -24,9 +24,7 @@ from pyspark.testing.pandasutils import PandasOnSparkTestUtils class InternalFrameParityTests( InternalFrameTestsMixin, PandasOnSparkTestUtils, ReusedConnectTestCase ): - @unittest.skip("TODO(SPARK-43654): Enable InternalFrameParityTests.test_from_pandas.") - def test_from_pandas(self): - super().test_from_pandas() + pass if __name__ == "__main__": diff --git a/python/pyspark/pandas/utils.py b/python/pyspark/pandas/utils.py index ebeb1d69d1b..b647697edf9 100644 --- a/python/pyspark/pandas/utils.py +++ b/python/pyspark/pandas/utils.py @@ -954,7 +954,7 @@ def spark_column_equals(left: Column, right: Column) -> bool: error_class="NOT_COLUMN", message_parameters={"arg_name": "right", "arg_type": type(right).__name__}, ) - return repr(left) == repr(right) + return repr(left).replace("`", "") == repr(right).replace("`", "") else: return left._jc.equals(right._jc) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org