Repository: spark
Updated Branches:
  refs/heads/master f83c0f112 -> a70e849c7


[minor] [build] Set java options when generating mima ignores.

The default java options make the call to GenerateMIMAIgnore take
forever to run since it's gc'ing all the time. Improve things by
setting the perm gen size / max heap size to larger values.

Author: Marcelo Vanzin <van...@cloudera.com>

Closes #5615 from vanzin/gen-mima-fix and squashes the following commits:

f44e921 [Marcelo Vanzin] [minor] [build] Set java options when generating mima 
ignores.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/a70e849c
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/a70e849c
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/a70e849c

Branch: refs/heads/master
Commit: a70e849c7f9e3df5e86113d45b8c4537597cfb29
Parents: f83c0f1
Author: Marcelo Vanzin <van...@cloudera.com>
Authored: Tue Apr 21 16:35:37 2015 -0700
Committer: Patrick Wendell <patr...@databricks.com>
Committed: Tue Apr 21 16:35:37 2015 -0700

----------------------------------------------------------------------
 dev/mima | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/a70e849c/dev/mima
----------------------------------------------------------------------
diff --git a/dev/mima b/dev/mima
index bed5cd0..2952fa6 100755
--- a/dev/mima
+++ b/dev/mima
@@ -27,16 +27,21 @@ cd "$FWDIR"
 echo -e "q\n" | build/sbt oldDeps/update
 rm -f .generated-mima*
 
+generate_mima_ignore() {
+  SPARK_JAVA_OPTS="-XX:MaxPermSize=1g -Xmx2g" \
+    ./bin/spark-class org.apache.spark.tools.GenerateMIMAIgnore
+}
+
 # Generate Mima Ignore is called twice, first with latest built jars
 # on the classpath and then again with previous version jars on the classpath.
 # Because of a bug in GenerateMIMAIgnore that when old jars are ahead on 
classpath
 # it did not process the new classes (which are in assembly jar).
-./bin/spark-class org.apache.spark.tools.GenerateMIMAIgnore
+generate_mima_ignore
 
 export SPARK_CLASSPATH="`find lib_managed \( -name '*spark*jar' -a -type f \) 
| tr "\\n" ":"`"
 echo "SPARK_CLASSPATH=$SPARK_CLASSPATH"
 
-./bin/spark-class org.apache.spark.tools.GenerateMIMAIgnore
+generate_mima_ignore
 
 echo -e "q\n" | build/sbt mima-report-binary-issues | grep -v -e 
"info.*Resolving"
 ret_val=$?


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to