Repository: spark
Updated Branches:
  refs/heads/branch-2.3 9d63e540e -> b8dbfcc57


Fix issue in 'docker-image-tool.sh'

Because of the missing assignment of the variable `BUILD_ARGS` the command 
`./bin/docker-image-tool.sh -r docker.io/myrepo -t v2.3.1 build` fails:

```
docker build" requires exactly 1 argument.
See 'docker build --help'.

Usage:  docker build [OPTIONS] PATH | URL | - [flags]

Build an image from a Dockerfile
```

This has been fixed on the `master` already but, apparently, it has not been 
ported back to the branch `2.3`, leading to the same error even on the latest 
`2.3.1` release (dated 8 June 2018).

Author: Fabrizio Cucci <fabrizio.cu...@gmail.com>

Closes #21551 from fabriziocucci/patch-1.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/b8dbfcc5
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/b8dbfcc5
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/b8dbfcc5

Branch: refs/heads/branch-2.3
Commit: b8dbfcc572bf5f386d21ae0be7b3439d1abed860
Parents: 9d63e54
Author: Fabrizio Cucci <fabrizio.cu...@gmail.com>
Authored: Mon Jun 18 14:40:24 2018 -0700
Committer: mcheah <mch...@palantir.com>
Committed: Mon Jun 18 14:40:24 2018 -0700

----------------------------------------------------------------------
 bin/docker-image-tool.sh | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/b8dbfcc5/bin/docker-image-tool.sh
----------------------------------------------------------------------
diff --git a/bin/docker-image-tool.sh b/bin/docker-image-tool.sh
index 0714063..0d0f564 100755
--- a/bin/docker-image-tool.sh
+++ b/bin/docker-image-tool.sh
@@ -57,6 +57,7 @@ function build {
   else
     # Not passed as an argument to docker, but used to validate the Spark 
directory.
     IMG_PATH="kubernetes/dockerfiles"
+    BUILD_ARGS=()
   fi
 
   if [ ! -d "$IMG_PATH" ]; then


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to