This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
commit 15a6ea65ede6a2bc07824855801573a5d0cad512 Author: Zhen Wang <643348...@qq.com> AuthorDate: Thu Jun 30 11:34:40 2022 +0800 [Improvement] Close coordinatorClients when DelegationRssShuffleManager stops (#205) ### What changes were proposed in this pull request? Close coordinatorClients when DelegationRssShuffleManager stops. ### Why are the changes needed? The coordinatorClients in DelegationRssShuffleManager are never closed. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No --- .../main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java | 1 + .../main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java | 1 + 2 files changed, 2 insertions(+) diff --git a/client-spark/spark2/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java b/client-spark/spark2/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java index e0a30e7..03320c0 100644 --- a/client-spark/spark2/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java +++ b/client-spark/spark2/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java @@ -173,6 +173,7 @@ public class DelegationRssShuffleManager implements ShuffleManager { @Override public void stop() { delegate.stop(); + coordinatorClients.forEach(CoordinatorClient::close); } @Override diff --git a/client-spark/spark3/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java b/client-spark/spark3/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java index 4ed6cce..32d58d2 100644 --- a/client-spark/spark3/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java +++ b/client-spark/spark3/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java @@ -248,6 +248,7 @@ public class DelegationRssShuffleManager implements ShuffleManager { @Override public void stop() { delegate.stop(); + coordinatorClients.forEach(CoordinatorClient::close); } @Override