[GitHub] [hadoop] tomscut commented on pull request #4090: HDFS-16516. Fix Fsshell wrong params

2022-03-21 Thread GitBox
tomscut commented on pull request #4090: URL: https://github.com/apache/hadoop/pull/4090#issuecomment-1074626818 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] tomscut commented on pull request #4087: HDFS-16513. [SBN read] Observer Namenode does not trigger the edits r…

2022-03-21 Thread GitBox
tomscut commented on pull request #4087: URL: https://github.com/apache/hadoop/pull/4087#issuecomment-1074579167 Hi @xkrogen @sunchao , please take a look at this. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] tomscut commented on pull request #4057: HDFS-16498. Fix NPE for checkBlockReportLease

2022-03-21 Thread GitBox
tomscut commented on pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#issuecomment-1074573849 Hi @ayushtkn , I fixed the problem you mentioned, please have a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] hadoop-yetus commented on pull request #4057: HDFS-16498. Fix NPE for checkBlockReportLease

2022-03-21 Thread GitBox
hadoop-yetus commented on pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#issuecomment-1074439142 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #4089: HDFS-16515. Improve ec exception message

2022-03-21 Thread GitBox
hadoop-yetus commented on pull request #4089: URL: https://github.com/apache/hadoop/pull/4089#issuecomment-1074415214 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Created] (HADOOP-18167) Add metrics to track delegation token secret manager operations

2022-03-21 Thread Hector Sandoval Chaverri (Jira)
Hector Sandoval Chaverri created HADOOP-18167: - Summary: Add metrics to track delegation token secret manager operations Key: HADOOP-18167 URL: https://issues.apache.org/jira/browse/HADOOP-18167

[GitHub] [hadoop] hadoop-yetus commented on pull request #4060: YARN-11084. Introduce new config to specify AM default node-label whe…

2022-03-21 Thread GitBox
hadoop-yetus commented on pull request #4060: URL: https://github.com/apache/hadoop/pull/4060#issuecomment-1074331708 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-18154) S3A Authentication to support WebIdentity

2022-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18154?focusedWorklogId=745370=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745370 ] ASF GitHub Bot logged work on HADOOP-18154: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on a change in pull request #4070: HADOOP-18154. S3A Authentication to support WebIdentity

2022-03-21 Thread GitBox
steveloughran commented on a change in pull request #4070: URL: https://github.com/apache/hadoop/pull/4070#discussion_r831445562 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java ## @@ -142,6 +142,10 @@ private Constants() { public

[jira] [Work logged] (HADOOP-18154) S3A Authentication to support WebIdentity

2022-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18154?focusedWorklogId=745369=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745369 ] ASF GitHub Bot logged work on HADOOP-18154: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on a change in pull request #4070: HADOOP-18154. S3A Authentication to support WebIdentity

2022-03-21 Thread GitBox
steveloughran commented on a change in pull request #4070: URL: https://github.com/apache/hadoop/pull/4070#discussion_r831444157 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/OIDCTokenCredentialsProvider.java ## @@ -0,0 +1,79 @@ +package

[jira] [Work logged] (HADOOP-18154) S3A Authentication to support WebIdentity

2022-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18154?focusedWorklogId=745367=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745367 ] ASF GitHub Bot logged work on HADOOP-18154: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #4070: HADOOP-18154. S3A Authentication to support WebIdentity

2022-03-21 Thread GitBox
hadoop-yetus removed a comment on pull request #4070: URL: https://github.com/apache/hadoop/pull/4070#issuecomment-1068099293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Work logged] (HADOOP-18160) `org.wildfly.openssl` should not be shaded by Hadoop build

2022-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18160?focusedWorklogId=745366=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745366 ] ASF GitHub Bot logged work on HADOOP-18160: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #4074: HADOOP-18160 Avoid shading wildfly.openssl runtime dependency

2022-03-21 Thread GitBox
steveloughran commented on pull request #4074: URL: https://github.com/apache/hadoop/pull/4074#issuecomment-1074288070 raised on the list...if nobody objects i will merge (remind me if I don't) -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Work logged] (HADOOP-15566) Support OpenTelemetry

2022-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15566?focusedWorklogId=745363=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745363 ] ASF GitHub Bot logged work on HADOOP-15566: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on a change in pull request #3445: HADOOP-15566 Opentelemetry changes using java agent

2022-03-21 Thread GitBox
steveloughran commented on a change in pull request #3445: URL: https://github.com/apache/hadoop/pull/3445#discussion_r831412903 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/Span.java ## @@ -17,28 +17,54 @@ */ package

[GitHub] [hadoop] hadoop-yetus commented on pull request #4066: YARN-11087. Introduce the config to control the refresh interval in R…

2022-03-21 Thread GitBox
hadoop-yetus commented on pull request #4066: URL: https://github.com/apache/hadoop/pull/4066#issuecomment-1074278520 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-15566) Support OpenTelemetry

2022-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15566?focusedWorklogId=745340=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745340 ] ASF GitHub Bot logged work on HADOOP-15566: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #3445: HADOOP-15566 Opentelemetry changes using java agent

2022-03-21 Thread GitBox
hadoop-yetus removed a comment on pull request #3445: URL: https://github.com/apache/hadoop/pull/3445#issuecomment-920792524 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[jira] [Work logged] (HADOOP-15566) Support OpenTelemetry

2022-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15566?focusedWorklogId=745338=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745338 ] ASF GitHub Bot logged work on HADOOP-15566: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-15566) Support OpenTelemetry

2022-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15566?focusedWorklogId=745339=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745339 ] ASF GitHub Bot logged work on HADOOP-15566: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #3445: HADOOP-15566 Opentelemetry changes using java agent

2022-03-21 Thread GitBox
hadoop-yetus removed a comment on pull request #3445: URL: https://github.com/apache/hadoop/pull/3445#issuecomment-977877431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #3445: HADOOP-15566 Opentelemetry changes using java agent

2022-03-21 Thread GitBox
hadoop-yetus removed a comment on pull request #3445: URL: https://github.com/apache/hadoop/pull/3445#issuecomment-979460747 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[jira] [Work logged] (HADOOP-17428) ABFS: Implementation for getContentSummary

2022-03-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17428?focusedWorklogId=745336=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745336 ] ASF GitHub Bot logged work on HADOOP-17428: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #2549: HADOOP-17428. ABFS: Implementation for getContentSummary

2022-03-21 Thread GitBox
steveloughran commented on pull request #2549: URL: https://github.com/apache/hadoop/pull/2549#issuecomment-1074248757 afraid my manifest committer changes have broken this. can you rebase and we can get this in. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] hadoop-yetus commented on pull request #4077: HDFS-16509. Fix decommission UnsupportedOperationException

2022-03-21 Thread GitBox
hadoop-yetus commented on pull request #4077: URL: https://github.com/apache/hadoop/pull/4077#issuecomment-1074209141 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Updated] (HADOOP-16254) Add proxy address in IPC connection

2022-03-21 Thread Owen O'Malley (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen O'Malley updated HADOOP-16254: --- Resolution: Duplicate Status: Resolved (was: Patch Available) This has been fixed

[GitHub] [hadoop] hadoop-yetus commented on pull request #4078: HDFS-16510. Fix EC decommission when rack is not enough

2022-03-21 Thread GitBox
hadoop-yetus commented on pull request #4078: URL: https://github.com/apache/hadoop/pull/4078#issuecomment-1074208100 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #4081: HDFS-13248: Namenode needs to use the actual client IP when going through RBF proxy.

2022-03-21 Thread GitBox
hadoop-yetus commented on pull request #4081: URL: https://github.com/apache/hadoop/pull/4081#issuecomment-1074128937 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] omalley closed pull request #4081: HDFS-13248: Namenode needs to use the actual client IP when going through RBF proxy.

2022-03-21 Thread GitBox
omalley closed pull request #4081: URL: https://github.com/apache/hadoop/pull/4081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] 9uapaw commented on a change in pull request #4060: YARN-11084. Introduce new config to specify AM default node-label whe…

2022-03-21 Thread GitBox
9uapaw commented on a change in pull request #4060: URL: https://github.com/apache/hadoop/pull/4060#discussion_r831268938 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeLabel.md ## @@ -170,6 +170,14 @@ Applications can use following Java

[GitHub] [hadoop] hadoop-yetus commented on pull request #4090: HDFS-16516. Fix Fsshell wrong params

2022-03-21 Thread GitBox
hadoop-yetus commented on pull request #4090: URL: https://github.com/apache/hadoop/pull/4090#issuecomment-1074003499 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] zuston commented on pull request #4060: YARN-11084. Introduce new config to specify AM default node-label whe…

2022-03-21 Thread GitBox
zuston commented on pull request #4060: URL: https://github.com/apache/hadoop/pull/4060#issuecomment-1073984190 Updated. Could u help review again? @9uapaw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] hadoop-yetus commented on pull request #4088: HDFS-16514. Reduce the failover sleep time if multiple namenode are c…

2022-03-21 Thread GitBox
hadoop-yetus commented on pull request #4088: URL: https://github.com/apache/hadoop/pull/4088#issuecomment-1073958681 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] zuston commented on a change in pull request #4060: YARN-11084. Introduce new config to specify AM default node-label whe…

2022-03-21 Thread GitBox
zuston commented on a change in pull request #4060: URL: https://github.com/apache/hadoop/pull/4060#discussion_r831169268 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml ## @@ -3440,6 +3440,15 @@ 180 + +

[GitHub] [hadoop] 9uapaw commented on a change in pull request #4060: YARN-11084. Introduce new config to specify AM default node-label whe…

2022-03-21 Thread GitBox
9uapaw commented on a change in pull request #4060: URL: https://github.com/apache/hadoop/pull/4060#discussion_r831166584 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml ## @@ -3440,6 +3440,15 @@ 180 + +

[GitHub] [hadoop] 9uapaw commented on pull request #4060: YARN-11084. Introduce new config to specify AM default node-label whe…

2022-03-21 Thread GitBox
9uapaw commented on pull request #4060: URL: https://github.com/apache/hadoop/pull/4060#issuecomment-1073954813 Also, could you address the checkstyle issues as well please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] zuston commented on a change in pull request #4060: YARN-11084. Introduce new config to specify AM default node-label whe…

2022-03-21 Thread GitBox
zuston commented on a change in pull request #4060: URL: https://github.com/apache/hadoop/pull/4060#discussion_r831164915 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml ## @@ -3440,6 +3440,15 @@ 180 + +

[GitHub] [hadoop] zuston commented on a change in pull request #4060: YARN-11084. Introduce new config to specify AM default node-label whe…

2022-03-21 Thread GitBox
zuston commented on a change in pull request #4060: URL: https://github.com/apache/hadoop/pull/4060#discussion_r831163824 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml ## @@ -3440,6 +3440,15 @@ 180 + +

[GitHub] [hadoop] 9uapaw commented on a change in pull request #4060: YARN-11084. Introduce new config to specify AM default node-label whe…

2022-03-21 Thread GitBox
9uapaw commented on a change in pull request #4060: URL: https://github.com/apache/hadoop/pull/4060#discussion_r831157934 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml ## @@ -3440,6 +3440,15 @@ 180 + +

[GitHub] [hadoop] zuston edited a comment on pull request #4060: YARN-11084. Introduce new config to specify AM default node-label whe…

2022-03-21 Thread GitBox
zuston edited a comment on pull request #4060: URL: https://github.com/apache/hadoop/pull/4060#issuecomment-1073944578 Gentle ping @9uapaw @szilard-nemeth . Thanks ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] zuston commented on pull request #4060: YARN-11084. Introduce new config to specify AM default node-label whe…

2022-03-21 Thread GitBox
zuston commented on pull request #4060: URL: https://github.com/apache/hadoop/pull/4060#issuecomment-1073944578 Gentle ping @9uapaw . Thanks ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] zuston commented on pull request #4066: YARN-11087. Introduce the config to control the refresh interval in R…

2022-03-21 Thread GitBox
zuston commented on pull request #4066: URL: https://github.com/apache/hadoop/pull/4066#issuecomment-1073942121 Done. Could u help check again ? @9uapaw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] zuston commented on a change in pull request #4066: YARN-11087. Introduce the config to control the refresh interval in R…

2022-03-21 Thread GitBox
zuston commented on a change in pull request #4066: URL: https://github.com/apache/hadoop/pull/4066#discussion_r831147114 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml ## @@ -3431,15 +3431,27 @@ When

[GitHub] [hadoop] 9uapaw commented on pull request #4021: YARN-10565. Refactor CS queue initialization to simplify weight mode …

2022-03-21 Thread GitBox
9uapaw commented on pull request #4021: URL: https://github.com/apache/hadoop/pull/4021#issuecomment-1073929147 Thank you for the change @brumi1024, committed to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] 9uapaw closed pull request #4021: YARN-10565. Refactor CS queue initialization to simplify weight mode …

2022-03-21 Thread GitBox
9uapaw closed pull request #4021: URL: https://github.com/apache/hadoop/pull/4021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] szilard-nemeth closed pull request #4072: YARN-11089. Fix typo in rm audit log

2022-03-21 Thread GitBox
szilard-nemeth closed pull request #4072: URL: https://github.com/apache/hadoop/pull/4072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] szilard-nemeth closed pull request #4065: YARN-11086. Add space in debug log of ParentQueue

2022-03-21 Thread GitBox
szilard-nemeth closed pull request #4065: URL: https://github.com/apache/hadoop/pull/4065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] szilard-nemeth commented on pull request #4065: YARN-11086. Add space in debug log of ParentQueue

2022-03-21 Thread GitBox
szilard-nemeth commented on pull request #4065: URL: https://github.com/apache/hadoop/pull/4065#issuecomment-1073907958 Thanks @zuston for working on this. Patch LGTM, committed to trunk. Thanks @9uapaw for the review. -- This is an automated message from the Apache Git

[GitHub] [hadoop] 9uapaw commented on a change in pull request #4066: YARN-11087. Introduce the config to control the refresh interval in R…

2022-03-21 Thread GitBox
9uapaw commented on a change in pull request #4066: URL: https://github.com/apache/hadoop/pull/4066#discussion_r831100127 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml ## @@ -3431,15 +3431,27 @@ When

[GitHub] [hadoop] szilard-nemeth commented on pull request #4072: YARN-11089. Fix typo in rm audit log

2022-03-21 Thread GitBox
szilard-nemeth commented on pull request #4072: URL: https://github.com/apache/hadoop/pull/4072#issuecomment-1073886387 Thanks @zuston for working on this. Patch LGTM, committed to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] GuoPhilipse opened a new pull request #4090: HDFS-16516. Fix Fsshell wrong params

2022-03-21 Thread GitBox
GuoPhilipse opened a new pull request #4090: URL: https://github.com/apache/hadoop/pull/4090 Fix wrong param name in FileSystemShell -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #4086: HDFS-16471. Make HDFS ls tool cross platform

2022-03-21 Thread GitBox
hadoop-yetus removed a comment on pull request #4086: URL: https://github.com/apache/hadoop/pull/4086#issuecomment-1073237489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] GuoPhilipse opened a new pull request #4089: HDFS-16515. Improve ec exception message

2022-03-21 Thread GitBox
GuoPhilipse opened a new pull request #4089: URL: https://github.com/apache/hadoop/pull/4089 Currently, if we set an erasure coding policy for a file,it only shows the following message, which is not that clear to user, we can improve it. `RemoteException: Attempt to set an erasure

[jira] [Commented] (HADOOP-18161) [WASB] Retry not getting implemented when using wasb scheme in hadoop-azure 2.7.4

2022-03-21 Thread Aryan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17509811#comment-17509811 ] Aryan commented on HADOOP-18161: [~ste...@apache.org]  Do we have IO retry currently implemented for

[GitHub] [hadoop] liubingxing opened a new pull request #4088: HDFS-16514. Reduce the failover sleep time if multiple namenode are c…

2022-03-21 Thread GitBox
liubingxing opened a new pull request #4088: URL: https://github.com/apache/hadoop/pull/4088 JIRA: [HDFS-16514](https://issues.apache.org/jira/browse/HDFS-16514) Recently, we used the [Standby Read] feature in our test cluster, and deployed 4 namenode as follow: node1 -> active nn

[GitHub] [hadoop] hadoop-yetus commented on pull request #4078: HDFS-16510. Fix EC decommission when rack is not enough

2022-03-21 Thread GitBox
hadoop-yetus commented on pull request #4078: URL: https://github.com/apache/hadoop/pull/4078#issuecomment-1073742232 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] tomscut commented on a change in pull request #4057: HDFS-16498. Fix NPE for checkBlockReportLease

2022-03-21 Thread GitBox
tomscut commented on a change in pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#discussion_r830932014 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java ## @@ -2751,6 +2751,11 @@

[GitHub] [hadoop] hadoop-yetus commented on pull request #4087: HDFS-16513. [SBN read] Observer Namenode does not trigger the edits r…

2022-03-21 Thread GitBox
hadoop-yetus commented on pull request #4087: URL: https://github.com/apache/hadoop/pull/4087#issuecomment-1073667887 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hfutatzhanghb commented on pull request #3976: HDFS-16452. msync RPC should send to acitve namenode directly

2022-03-21 Thread GitBox
hfutatzhanghb commented on pull request #3976: URL: https://github.com/apache/hadoop/pull/3976#issuecomment-1073612305 hi, @xkrogen . So sorry for disturbing you. I have a new idea about what we have discussed. In practice, We usually plan some machines as Observer Namenode before setup

[GitHub] [hadoop] tomscut commented on pull request #4057: HDFS-16498. Fix NPE for checkBlockReportLease

2022-03-21 Thread GitBox
tomscut commented on pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#issuecomment-1073611615 > Had a quick look, prod change makes sense to me, the `datanodeManager.getDatanode(nodeID)` methods shows it can register null, if the node isn't found. > > The test is

[GitHub] [hadoop] ayushtkn commented on a change in pull request #4057: HDFS-16498. Fix NPE for checkBlockReportLease

2022-03-21 Thread GitBox
ayushtkn commented on a change in pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#discussion_r830838309 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockReportLease.java ## @@ -136,6 +137,48

[GitHub] [hadoop] tomscut commented on pull request #4057: HDFS-16498. Fix NPE for checkBlockReportLease

2022-03-21 Thread GitBox
tomscut commented on pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#issuecomment-1073569715 Hi @ayushtkn @Hexiaoqiao @ferhui , please take a look at this. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] tomscut removed a comment on pull request #4057: HDFS-16498. Fix NPE for checkBlockReportLease

2022-03-21 Thread GitBox
tomscut removed a comment on pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#issuecomment-1069166429 Hi @ayushtkn , please take a look. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] tomscut commented on pull request #4067: HDFS-16503. Should verify whether the path name is valid in the WebHDFS

2022-03-21 Thread GitBox
tomscut commented on pull request #4067: URL: https://github.com/apache/hadoop/pull/4067#issuecomment-1073547712 Thanks @ayushtkn . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] ayushtkn merged pull request #4067: HDFS-16503. Should verify whether the path name is valid in the WebHDFS

2022-03-21 Thread GitBox
ayushtkn merged pull request #4067: URL: https://github.com/apache/hadoop/pull/4067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18166) Jenkins jobs intermittently failing in the end

2022-03-21 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17509647#comment-17509647 ] Ayush Saxena commented on HADOOP-18166: --- Created ticket for tracking in case anyone has idea

[jira] [Created] (HADOOP-18166) Jenkins jobs intermittently failing in the end

2022-03-21 Thread Ayush Saxena (Jira)
Ayush Saxena created HADOOP-18166: - Summary: Jenkins jobs intermittently failing in the end Key: HADOOP-18166 URL: https://issues.apache.org/jira/browse/HADOOP-18166 Project: Hadoop Common

[GitHub] [hadoop] ayushtkn commented on pull request #4081: HDFS-13248: Namenode needs to use the actual client IP when going through RBF proxy.

2022-03-21 Thread GitBox
ayushtkn commented on pull request #4081: URL: https://github.com/apache/hadoop/pull/4081#issuecomment-1073536111 +1, TestRouterDistCpProcedure isn't related, we should track that separately -- This is an automated message from the Apache Git Service. To respond to the message, please