[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637062#comment-17637062
]
xinqiu.hu commented on HADOOP-18536:
Thanks for your patience!
> RPC Client Improvement
>
howzi commented on PR #5147:
URL: https://github.com/apache/hadoop/pull/5147#issuecomment-1323243368
> > Actually it is an obvious performance problem, it takes over 3 mins to
refresh the state store cache in our enviroment. Different deployment of ZK may
cause a diffrent choice. For
[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637046#comment-17637046
]
Shilun Fan edited comment on HADOOP-18536 at 11/22/22 7:42 AM:
---
Thank you
[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637046#comment-17637046
]
Shilun Fan commented on HADOOP-18536:
-
Thank you very much for your contribution, let us wait for
howzi commented on PR #5147:
URL: https://github.com/apache/hadoop/pull/5147#issuecomment-1323233078
> @howzi Thanks for your report and this change makes sense.
>
> 1. How about keeping the sync mode and adding a new async mode?
> 2. Can you add one UT to verify the performance
[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637039#comment-17637039
]
Shilun Fan edited comment on HADOOP-18536 at 11/22/22 7:35 AM:
---
Thank you
[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637039#comment-17637039
]
Shilun Fan edited comment on HADOOP-18536 at 11/22/22 7:34 AM:
---
Thank you
[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637039#comment-17637039
]
Shilun Fan commented on HADOOP-18536:
-
Thank you very much for your feedback. Because it is widely
[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637036#comment-17637036
]
xinqiu.hu edited comment on HADOOP-18536 at 11/22/22 7:25 AM:
--
Thank you
[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637036#comment-17637036
]
xinqiu.hu commented on HADOOP-18536:
Thank you very much for reviewing the code, I agree with the
[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18536:
---
Description:
In the RPC Client, before a request (including RpcRequestHeaderProto,
[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637013#comment-17637013
]
Shilun Fan edited comment on HADOOP-18536 at 11/22/22 6:04 AM:
---
Thank you
[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637013#comment-17637013
]
Shilun Fan commented on HADOOP-18536:
-
>From my personal point of view, I think the risk of this
[
https://issues.apache.org/jira/browse/HADOOP-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637012#comment-17637012
]
ASF GitHub Bot commented on HADOOP-18533:
-
huxinqiu closed pull request #5151: HADOOP-18533.
huxinqiu closed pull request #5151: HADOOP-18533. RPC Client performance
improvement
URL: https://github.com/apache/hadoop/pull/5151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18536:
---
Description:
In the RPC Client, before a request (including RpcRequestHeaderProto,
[
https://issues.apache.org/jira/browse/HADOOP-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637011#comment-17637011
]
ASF GitHub Bot commented on HADOOP-18533:
-
hadoop-yetus commented on PR #5151:
URL:
hadoop-yetus commented on PR #5151:
URL: https://github.com/apache/hadoop/pull/5151#issuecomment-1323121288
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18536:
---
Description:
In the RPC Client, before a request (including RpcRequestHeaderProto,
[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637010#comment-17637010
]
xinqiu.hu commented on HADOOP-18536:
HADOOP-18536 is a better approach than HADOOP-18533, with the
[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637009#comment-17637009
]
Shilun Fan commented on HADOOP-18536:
-
Is there any relationship between the three jiras
[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18536:
---
Description:
In the RPC Client, before a request (including RpcRequestHeaderProto,
[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18536:
---
Target Version/s: 3.4.0
Priority: Minor (was: Major)
> RPC Client Improvement
>
[
https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18536:
---
Description:
In the RPC Client, before a request (including RpcRequestHeaderProto,
[
https://issues.apache.org/jira/browse/HADOOP-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637008#comment-17637008
]
ASF GitHub Bot commented on HADOOP-18533:
-
huxinqiu commented on PR #5151:
URL:
huxinqiu commented on PR #5151:
URL: https://github.com/apache/hadoop/pull/5151#issuecomment-1323110323
[HADOOP-18536](https://github.com/apache/hadoop/pull/5156) may be more
suitable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
huxinqiu opened a new pull request, #5156:
URL: https://github.com/apache/hadoop/pull/5156
In the RPC Client, before a request (including RpcRequestHeaderProto,
RequestHeaderProto, Message Payload) is sent, they will be copied to the three
CodedOutputStream internal byte arrays, and then
xinqiu.hu created HADOOP-18536:
--
Summary: RPC Client Improvement
Key: HADOOP-18536
URL: https://issues.apache.org/jira/browse/HADOOP-18536
Project: Hadoop Common
Issue Type: Improvement
hadoop-yetus commented on PR #5145:
URL: https://github.com/apache/hadoop/pull/5145#issuecomment-1323041154
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5145:
URL: https://github.com/apache/hadoop/pull/5145#issuecomment-1323037298
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5145:
URL: https://github.com/apache/hadoop/pull/5145#issuecomment-1323033683
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
GuoPhilipse commented on PR #4602:
URL: https://github.com/apache/hadoop/pull/4602#issuecomment-1322966990
> Did you test it? This behavior is consistent with the local file system.
Thanks for your review @tomscut , actually `chown ` command can be used for
change owner or group
hadoop-yetus commented on PR #5155:
URL: https://github.com/apache/hadoop/pull/5155#issuecomment-1322938837
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
haiyang1987 commented on PR #5129:
URL: https://github.com/apache/hadoop/pull/5129#issuecomment-1322920504
Update PR
@ZanderXu @tomscut @tasanuma please help me to reivew it again, Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
haiyang1987 commented on code in PR #5129:
URL: https://github.com/apache/hadoop/pull/5129#discussion_r1028719428
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java:
##
@@ -81,6 +81,8 @@ public class
haiyang1987 commented on code in PR #5129:
URL: https://github.com/apache/hadoop/pull/5129#discussion_r1028717101
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java:
##
@@ -81,6 +81,8 @@ public class
simbadzina commented on code in PR #5145:
URL: https://github.com/apache/hadoop/pull/5145#discussion_r1028715143
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java:
##
@@ -348,25 +357,28 @@
hadoop-yetus commented on PR #4602:
URL: https://github.com/apache/hadoop/pull/4602#issuecomment-1322882225
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
tomscut commented on PR #4209:
URL: https://github.com/apache/hadoop/pull/4209#issuecomment-1322873539
> I am -1 on the PR as-is. We have publicly exposed the current config
`dfs.journalnode.edit-cache-size.bytes`; we can't just rename it and change the
behavior now. I also think there is
Hector Sandoval Chaverri created HADOOP-18535:
-
Summary: Implement token storage solution based on MySQL
Key: HADOOP-18535
URL: https://issues.apache.org/jira/browse/HADOOP-18535
Project:
[
https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636945#comment-17636945
]
Viraj Jasani commented on HADOOP-18399:
---
[~ste...@apache.org], just checking here if you got some
omalley commented on code in PR #5142:
URL: https://github.com/apache/hadoop/pull/5142#discussion_r1028642292
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/NameNodeProxiesClient.java:
##
@@ -349,6 +349,13 @@ public static ClientProtocol
omalley commented on code in PR #5142:
URL: https://github.com/apache/hadoop/pull/5142#discussion_r1028642292
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/NameNodeProxiesClient.java:
##
@@ -349,6 +349,13 @@ public static ClientProtocol
hadoop-yetus commented on PR #5155:
URL: https://github.com/apache/hadoop/pull/5155#issuecomment-1322844291
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
omalley commented on code in PR #5145:
URL: https://github.com/apache/hadoop/pull/5145#discussion_r1028638870
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java:
##
@@ -88,6 +88,15 @@
slfan1989 commented on PR #5153:
URL: https://github.com/apache/hadoop/pull/5153#issuecomment-1322823190
@ayushtkn Can you help review this PR? Thank you very much! The issue of
checkstyle is not caused by this pr, this issue also existed before.
--
This is an automated message from the
slfan1989 commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1322821848
@ayushtkn Can you help to review this PR again? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
hadoop-yetus commented on PR #5155:
URL: https://github.com/apache/hadoop/pull/5155#issuecomment-1322720740
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
omalley commented on code in PR #5155:
URL: https://github.com/apache/hadoop/pull/5155#discussion_r1028560332
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java:
##
@@ -97,6 +104,7 @@
public class RouterAdmin extends
hadoop-yetus commented on PR #5142:
URL: https://github.com/apache/hadoop/pull/5142#issuecomment-1322676213
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #4949:
URL: https://github.com/apache/hadoop/pull/4949#issuecomment-1322675838
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5145:
URL: https://github.com/apache/hadoop/pull/5145#issuecomment-1322665295
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ayushtkn commented on code in PR #5155:
URL: https://github.com/apache/hadoop/pull/5155#discussion_r1028506972
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java:
##
@@ -97,6 +104,7 @@
public class RouterAdmin extends
simbadzina commented on code in PR #5142:
URL: https://github.com/apache/hadoop/pull/5142#discussion_r1028476373
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/NameNodeProxiesClient.java:
##
@@ -349,6 +349,13 @@ public static ClientProtocol
simbadzina commented on code in PR #5142:
URL: https://github.com/apache/hadoop/pull/5142#discussion_r1028474832
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestObserverWithRouter.java:
##
@@ -439,4 +440,60 @@ public void
hadoop-yetus commented on PR #5145:
URL: https://github.com/apache/hadoop/pull/5145#issuecomment-1322583721
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5145:
URL: https://github.com/apache/hadoop/pull/5145#issuecomment-1322571575
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
omalley opened a new pull request, #5155:
URL: https://github.com/apache/hadoop/pull/5155
### Description of PR
Adds a utility to dump the RBF StateStore.
### How was this patch tested?
It was tested manually against our RBF cluster
--
This is an automated
simbadzina commented on code in PR #5145:
URL: https://github.com/apache/hadoop/pull/5145#discussion_r1028419083
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java:
##
@@ -88,6 +88,15 @@
simbadzina commented on code in PR #5145:
URL: https://github.com/apache/hadoop/pull/5145#discussion_r1028394821
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java:
##
@@ -366,7 +375,7 @@
mkuchenbecker commented on code in PR #5142:
URL: https://github.com/apache/hadoop/pull/5142#discussion_r1028371062
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestObserverWithRouter.java:
##
@@ -122,7 +123,9 @@ public
mkuchenbecker commented on code in PR #5145:
URL: https://github.com/apache/hadoop/pull/5145#discussion_r1028385376
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/store/driver/TestStateStoreDriverBase.java:
##
@@ -234,6 +234,25 @@
xkrogen merged PR #4201:
URL: https://github.com/apache/hadoop/pull/4201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mkuchenbecker commented on code in PR #5145:
URL: https://github.com/apache/hadoop/pull/5145#discussion_r1028382408
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java:
##
@@ -366,7 +375,7
xkrogen commented on PR #4201:
URL: https://github.com/apache/hadoop/pull/4201#issuecomment-1322464405
`TestLeaseRecovery2` indeed seems to be broken; I confirmed that the
behavior is the same before/after applying this PR. Merging to trunk. Thanks
for the contribution @tomscut !
--
mkuchenbecker commented on code in PR #5145:
URL: https://github.com/apache/hadoop/pull/5145#discussion_r1028378298
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java:
##
@@ -88,6 +88,15 @@
mkuchenbecker commented on code in PR #5142:
URL: https://github.com/apache/hadoop/pull/5142#discussion_r1028372645
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestObserverWithRouter.java:
##
@@ -439,4 +440,60 @@ public
mkuchenbecker commented on PR #5142:
URL: https://github.com/apache/hadoop/pull/5142#issuecomment-1322457075
Mostly mechanical review, with some questions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
simbadzina commented on PR #5145:
URL: https://github.com/apache/hadoop/pull/5145#issuecomment-1322414231
I've added a unit test. Without my patch. We write a zero byte file and end
up with the following error when trying to read the state store.
> Caused by: java.io.IOException:
[
https://issues.apache.org/jira/browse/HADOOP-16761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636783#comment-17636783
]
ASF GitHub Bot commented on HADOOP-16761:
-
hadoop-yetus commented on PR #1769:
URL:
hadoop-yetus commented on PR #1769:
URL: https://github.com/apache/hadoop/pull/1769#issuecomment-132241
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
xkrogen commented on PR #4209:
URL: https://github.com/apache/hadoop/pull/4209#issuecomment-1322361104
I am -1 on the PR as-is. We have publicly exposed the current config
`dfs.journalnode.edit-cache-size.bytes`; we can't just rename it and change the
behavior now. I also think there is a
xkrogen commented on code in PR #4744:
URL: https://github.com/apache/hadoop/pull/4744#discussion_r1028281649
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java:
##
@@ -174,6 +175,11 @@ protected FSImage(Configuration conf,
xkrogen merged PR #5099:
URL: https://github.com/apache/hadoop/pull/5099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
xkrogen commented on PR #5099:
URL: https://github.com/apache/hadoop/pull/5099#issuecomment-1322317231
`TestLeaseRecovery2` has been flaky; I am not worried about the failure.
Merging to trunk. Thank you for the contribution @zhengchenyu !
--
This is an automated message from the
szilard-nemeth commented on code in PR #4655:
URL: https://github.com/apache/hadoop/pull/4655#discussion_r1028179146
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:
##
@@ -242,6 +244,10 @@ public class Configuration implements
[
https://issues.apache.org/jira/browse/HADOOP-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636744#comment-17636744
]
ASF GitHub Bot commented on HADOOP-18533:
-
hadoop-yetus commented on PR #5151:
URL:
hadoop-yetus commented on PR #5151:
URL: https://github.com/apache/hadoop/pull/5151#issuecomment-1322263878
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5119:
URL: https://github.com/apache/hadoop/pull/5119#issuecomment-1322241513
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
szilard-nemeth commented on code in PR #4949:
URL: https://github.com/apache/hadoop/pull/4949#discussion_r1028166041
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java:
slfan1989 commented on PR #5146:
URL: https://github.com/apache/hadoop/pull/5146#issuecomment-1322185823
@goiri Can you help review this PR? Thank you very much! The java-doc error
is not caused by this pr code, I submitted 2 prs for repair.
YARN-11380. Fix hadoop-yarn-api module
hadoop-yetus commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1322078791
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5153:
URL: https://github.com/apache/hadoop/pull/5153#issuecomment-1321975381
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ayushtkn commented on code in PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#discussion_r1027903125
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/package-info.java:
##
@@ -1,4 +1,4 @@
-/*
+/**
Review
slfan1989 commented on code in PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#discussion_r1027897718
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/package-info.java:
##
@@ -1,4 +1,4 @@
-/*
+/**
Review
hadoop-yetus commented on PR #5131:
URL: https://github.com/apache/hadoop/pull/5131#issuecomment-1321858433
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636624#comment-17636624
]
Sébastien Burton commented on HADOOP-18523:
---
Hello [~ste...@apache.org], I cannot take the
ahmarsuhail closed pull request #5154: Hadoop 18073 sdk upgrade delete select
mpu
URL: https://github.com/apache/hadoop/pull/5154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
hadoop-yetus commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321831548
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ahmarsuhail opened a new pull request, #5154:
URL: https://github.com/apache/hadoop/pull/5154
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hadoop-yetus commented on PR #5146:
URL: https://github.com/apache/hadoop/pull/5146#issuecomment-1321787296
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636570#comment-17636570
]
ASF GitHub Bot commented on HADOOP-18533:
-
huxinqiu commented on PR #5151:
URL:
huxinqiu commented on PR #5151:
URL: https://github.com/apache/hadoop/pull/5151#issuecomment-1321736995
> @huxinqiu Thank you very much for your contribution!
>
> We need to discuss something:
>
> 1. It seems that the benefit is to avoid declaring this variable
hadoop-yetus commented on PR #5153:
URL: https://github.com/apache/hadoop/pull/5153#issuecomment-1321705500
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on code in PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#discussion_r1027713838
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/package-info.java:
##
@@ -1,4 +1,4 @@
-/*
+/**
Review
slfan1989 commented on code in PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#discussion_r1027713838
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/package-info.java:
##
@@ -1,4 +1,4 @@
-/*
+/**
Review
hadoop-yetus commented on PR #5104:
URL: https://github.com/apache/hadoop/pull/5104#issuecomment-1321684954
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636516#comment-17636516
]
xinqiu.hu commented on HADOOP-18534:
[~slfan1989]
If a connection continues to process requests
hadoop-yetus commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321649048
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
99 matches
Mail list logo
