[GitHub] [hadoop] hadoop-yetus commented on pull request #5123: HDFS-16837. [RBF SBN] ClientGSIContext should merge RouterFederatedStates to get the max state id for each namespaces

hadoop-yetus commented on PR #5123: URL: https://github.com/apache/hadoop/pull/5123#issuecomment-1324647250 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5131: YARN-11350. [Federation] Router Support DelegationToken With ZK.

hadoop-yetus commented on PR #5131: URL: https://github.com/apache/hadoop/pull/5131#issuecomment-1324581269 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18535) Implement token storage solution based on MySQL

[ https://issues.apache.org/jira/browse/HADOOP-18535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637577#comment-17637577 ] ASF GitHub Bot commented on HADOOP-18535: - hadoop-yetus commented on PR #5159: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5158: YARN-11382 ClientRMService forget to record some audit logs after accessCheck

hadoop-yetus commented on PR #5158: URL: https://github.com/apache/hadoop/pull/5158#issuecomment-1324577751 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5159: HADOOP-18535. Implement token storage solution based on MySQL

hadoop-yetus commented on PR #5159: URL: https://github.com/apache/hadoop/pull/5159#issuecomment-1324577713 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5123: HDFS-16837. [RBF SBN] ClientGSIContext should merge RouterFederatedStates to get the max state id for each namespaces

hadoop-yetus commented on PR #5123: URL: https://github.com/apache/hadoop/pull/5123#issuecomment-1324498190 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5153: YARN-11381. Fix hadoop-yarn-common module Java Doc Errors.

slfan1989 commented on PR #5153: URL: https://github.com/apache/hadoop/pull/5153#issuecomment-1324462049 > LGTM Thank you very much for your help in reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] slfan1989 commented on pull request #5152: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors.

slfan1989 commented on PR #5152: URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1324461098 @ayushtkn @aajisaka Can you help to review this PR again? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] brahmareddybattula commented on pull request #5160: HDFS-16852 Swallow IllegalStateException in KeyProviderCache constructor

brahmareddybattula commented on PR #5160: URL: https://github.com/apache/hadoop/pull/5160#issuecomment-1324454278 @xinglin curious to know, did you observe any connection leak b/w KMS and NN here when prelaunch is failed..? how does this will help closing the connection.? -- This is an

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5131: YARN-11350. [Federation] Router Support DelegationToken With ZK.

slfan1989 commented on code in PR #5131: URL: https://github.com/apache/hadoop/pull/5131#discussion_r1029962161 ##

[GitHub] [hadoop] ZanderXu commented on pull request #5063: HDFS-16813. Remove parameter validation logic such as dfs.namenode.decommission.blocks.per.interval in DatanodeAdminManager#activate

ZanderXu commented on PR #5063: URL: https://github.com/apache/hadoop/pull/5063#issuecomment-1324449754 Merged. Thanks @haiyang1987 for your report and thanks @goiri for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] ZanderXu merged pull request #5063: HDFS-16813. Remove parameter validation logic such as dfs.namenode.decommission.blocks.per.interval in DatanodeAdminManager#activate

ZanderXu merged PR #5063: URL: https://github.com/apache/hadoop/pull/5063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

ZanderXu commented on code in PR #5147: URL: https://github.com/apache/hadoop/pull/5147#discussion_r1029955572 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreZooKeeperImpl.java: ## @@ -84,6 +102,20 @@

[GitHub] [hadoop] slfan1989 commented on pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

slfan1989 commented on PR #5147: URL: https://github.com/apache/hadoop/pull/5147#issuecomment-1324415952 @howzi Thank you very much for your contribution, but if there are only a few thousand moutables, this problem should not occur. -- This is an automated message from the Apache Git

[GitHub] [hadoop] ZanderXu commented on pull request #4872: HDFS-16764. ObserverNamenode should throw ObserverRetryOnActiveException instead of FileNotFoundException during processing of addBlock rpc

ZanderXu commented on PR #4872: URL: https://github.com/apache/hadoop/pull/4872#issuecomment-1324397973 @xkrogen Sir, thanks for your explanation. Yeah, ObserverNN also knows the states of DataNodes as well. But the `scheduledSize` is not shared, and almost all datanode chosen are

[GitHub] [hadoop] tomscut commented on pull request #5125: HDFS-16838. Fix NPE in testAddRplicaProcessorForAddingReplicaInMap

tomscut commented on PR #5125: URL: https://github.com/apache/hadoop/pull/5125#issuecomment-1324397671 Hi @ZanderXu , could you please fix the SpotBugs warn. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] goiri commented on a diff in pull request #5131: YARN-11350. [Federation] Router Support DelegationToken With ZK.

goiri commented on code in PR #5131: URL: https://github.com/apache/hadoop/pull/5131#discussion_r1029923406 ##

[GitHub] [hadoop] slfan1989 commented on pull request #5130: YARN-11371. [Federation] Refactor FederationInterceptorREST#createNewApplication\submitApplication Use FederationActionRetry.

slfan1989 commented on PR #5130: URL: https://github.com/apache/hadoop/pull/5130#issuecomment-1324369394 @goiri Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (HADOOP-18535) Implement token storage solution based on MySQL

[ https://issues.apache.org/jira/browse/HADOOP-18535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637501#comment-17637501 ] ASF GitHub Bot commented on HADOOP-18535: - hadoop-yetus commented on PR #5159: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5159: HADOOP-18535. Implement token storage solution based on MySQL

hadoop-yetus commented on PR #5159: URL: https://github.com/apache/hadoop/pull/5159#issuecomment-1324359389 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] goiri commented on a diff in pull request #5155: HDFS-16851: RBF: Add a utility to dump the StateStore.

goiri commented on code in PR #5155: URL: https://github.com/apache/hadoop/pull/5155#discussion_r1029857848 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java: ## @@ -97,6 +106,7 @@ public class RouterAdmin extends

[GitHub] [hadoop] goiri merged pull request #5130: YARN-11371. [Federation] Refactor FederationInterceptorREST#createNewApplication\submitApplication Use FederationActionRetry.

goiri merged PR #5130: URL: https://github.com/apache/hadoop/pull/5130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5145: HDFS-16847: RBF: Prevents StateStoreFileSystemImpl from committing tmp file after encountering an IOException.

hadoop-yetus commented on PR #5145: URL: https://github.com/apache/hadoop/pull/5145#issuecomment-1324316459 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18535) Implement token storage solution based on MySQL

[ https://issues.apache.org/jira/browse/HADOOP-18535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hector Sandoval Chaverri updated HADOOP-18535: -- Description: Hadoop RBF supports custom implementations of secret

[jira] [Updated] (HADOOP-18535) Implement token storage solution based on MySQL

[ https://issues.apache.org/jira/browse/HADOOP-18535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hector Sandoval Chaverri updated HADOOP-18535: -- Description: Hadoop RBF supports custom implementations of secret

[GitHub] [hadoop] hadoop-yetus commented on pull request #5160: HDFS-16852 Swallow IllegalStateException in KeyProviderCache constructor

hadoop-yetus commented on PR #5160: URL: https://github.com/apache/hadoop/pull/5160#issuecomment-1324284486 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5142: HDFS-16845: Adds configuration flag to allow clients to use router observer reads without using the ObserverReadProxyProvider.

hadoop-yetus commented on PR #5142: URL: https://github.com/apache/hadoop/pull/5142#issuecomment-1324273744 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5145: HDFS-16847: Prevents StateStoreFileSystemImpl from committing tmp file after encountering an IOException.

simbadzina commented on code in PR #5145: URL: https://github.com/apache/hadoop/pull/5145#discussion_r1029773799 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java: ## @@ -349,10 +350,12 @@

[GitHub] [hadoop] xinglin commented on pull request #5160: HDFS-16852 Swallow IllegalStateException in KeyProviderCache constructor

xinglin commented on PR #5160: URL: https://github.com/apache/hadoop/pull/5160#issuecomment-1324179644 @xkrogen Can you give a review?  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] xinglin opened a new pull request, #5160: HDFS-16852 Swallow IllegalStateException in KeyProviderCache constructor

xinglin opened a new pull request, #5160: URL: https://github.com/apache/hadoop/pull/5160 ### Description of PR Swallow IllegalStateException in KeyProviderCache instead of throwing it. For more details, please check HDFS-16852. ### How was this patch tested? `mvn

[GitHub] [hadoop] hadoop-yetus commented on pull request #5125: HDFS-16838. Fix NPE in testAddRplicaProcessorForAddingReplicaInMap

hadoop-yetus commented on PR #5125: URL: https://github.com/apache/hadoop/pull/5125#issuecomment-1324166051 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] xkrogen commented on pull request #4872: HDFS-16764. ObserverNamenode should throw ObserverRetryOnActiveException instead of FileNotFoundException during processing of addBlock rpc

xkrogen commented on PR #4872: URL: https://github.com/apache/hadoop/pull/4872#issuecomment-1324135159 But the ObserverNN should be aware of the states of DataNodes as well, right? Staleness, maintenance state, etc. It might be slightly stale, but I don't immediately see why that would

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocatoin

[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637425#comment-17637425 ] ASF GitHub Bot commented on HADOOP-18399: - virajjasani commented on PR #5054: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

virajjasani commented on PR #5054: URL: https://github.com/apache/hadoop/pull/5054#issuecomment-1324125156 No worries, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (HADOOP-18146) ABFS: Add changes for expect hundred continue header with append requests

[ https://issues.apache.org/jira/browse/HADOOP-18146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637418#comment-17637418 ] ASF GitHub Bot commented on HADOOP-18146: - steveloughran commented on code in PR #4039: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4039: HADOOP-18146: ABFS: Added changes for expect hundred continue header

steveloughran commented on code in PR #4039: URL: https://github.com/apache/hadoop/pull/4039#discussion_r1029705420 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/contracts/services/AppendRequestParameters.java: ## @@ -72,4 +75,12 @@ public boolean

[jira] [Commented] (HADOOP-18535) Implement token storage solution based on MySQL

[ https://issues.apache.org/jira/browse/HADOOP-18535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637416#comment-17637416 ] ASF GitHub Bot commented on HADOOP-18535: - hchaverri opened a new pull request, #5159: URL:

[jira] [Updated] (HADOOP-18535) Implement token storage solution based on MySQL

[ https://issues.apache.org/jira/browse/HADOOP-18535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18535: Labels: pull-request-available (was: ) > Implement token storage solution based on

[GitHub] [hadoop] hchaverri opened a new pull request, #5159: HADOOP-18535. Implement token storage solution based on MySQL

hchaverri opened a new pull request, #5159: URL: https://github.com/apache/hadoop/pull/5159 ### Description of PR These changes follow the same logic used in the existing ZK based secret manager implementation. 1. Minor changes to DelegationTokenInformation class so it's

[GitHub] [hadoop] hadoop-yetus commented on pull request #5119: YARN-5607. Document TestContainerResourceUsage#waitForContainerCompletion

hadoop-yetus commented on PR #5119: URL: https://github.com/apache/hadoop/pull/5119#issuecomment-1324102873 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] omalley commented on a diff in pull request #5145: HDFS-16847: Prevents StateStoreFileSystemImpl from committing tmp file after encountering an IOException.

omalley commented on code in PR #5145: URL: https://github.com/apache/hadoop/pull/5145#discussion_r1029681091 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java: ## @@ -349,10 +350,12 @@

[GitHub] [hadoop] hadoop-yetus commented on pull request #5158: YARN-11382 ClientRMService forget to record some audit logs after accessCheck

hadoop-yetus commented on PR #5158: URL: https://github.com/apache/hadoop/pull/5158#issuecomment-1324012152 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5123: HDFS-16837. [RBF SBN] ClientGSIContext should merge RouterFederatedStates to get the max state id for each namespaces

hadoop-yetus commented on PR #5123: URL: https://github.com/apache/hadoop/pull/5123#issuecomment-1324006809 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5142: HDFS-16845: Adds configuration flag to allow clients to use router observer reads without using the ObserverReadProxyProvider.

simbadzina commented on code in PR #5142: URL: https://github.com/apache/hadoop/pull/5142#discussion_r1029625039 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/NameNodeProxiesClient.java: ## @@ -349,6 +349,13 @@ public static ClientProtocol

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5145: HDFS-16847: Prevents StateStoreFileSystemImpl from committing tmp file after encountering an IOException.

simbadzina commented on code in PR #5145: URL: https://github.com/apache/hadoop/pull/5145#discussion_r1029624340 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/store/driver/TestStateStoreDriverBase.java: ## @@ -234,6 +234,25 @@

[jira] [Commented] (HADOOP-18498) [ABFS]: Error introduced when SAS Token containing '?' prefix is passed

[ https://issues.apache.org/jira/browse/HADOOP-18498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637363#comment-17637363 ] ASF GitHub Bot commented on HADOOP-18498: - steveloughran commented on code in PR #5136: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5136: HADOOP-18498. ABFS: Removing unwanted ? prefix from SAS Tokens

steveloughran commented on code in PR #5136: URL: https://github.com/apache/hadoop/pull/5136#discussion_r1029603628 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/extensions/MockWithPrefixSASTokenProvider.java: ## @@ -0,0 +1,46 @@ +/** + * Licensed to

[GitHub] [hadoop] slfan1989 commented on pull request #5131: YARN-11350. [Federation] Router Support DelegationToken With ZK.

slfan1989 commented on PR #5131: URL: https://github.com/apache/hadoop/pull/5131#issuecomment-1323873187 @goiri Can you help to review this PR again? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5158: YARN-11382 ClientRMService forget to record some audit logs after accessCheck

slfan1989 commented on code in PR #5158: URL: https://github.com/apache/hadoop/pull/5158#discussion_r1029487315 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5158: YARN-11382 ClientRMService forget to record some audit logs after accessCheck

slfan1989 commented on code in PR #5158: URL: https://github.com/apache/hadoop/pull/5158#discussion_r1029486994 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java:

[GitHub] [hadoop] slfan1989 commented on pull request #5158: YARN-11382 ClientRMService forget to record some audit logs after accessCheck

slfan1989 commented on PR #5158: URL: https://github.com/apache/hadoop/pull/5158#issuecomment-1323854909 @curie71 Thanks for your contribution, LGTM. Can you help to check again whether there is still auditlog missing in the method of ClientRMService? -- This is an automated

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5158: YARN-11382 ClientRMService forget to record some audit logs after accessCheck

slfan1989 commented on code in PR #5158: URL: https://github.com/apache/hadoop/pull/5158#discussion_r1029477113 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/yarn-error.log: ## @@ -0,0 +1,52

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5158: YARN-11382 ClientRMService forget to record some audit logs after accessCheck

slfan1989 commented on code in PR #5158: URL: https://github.com/apache/hadoop/pull/5158#discussion_r1029475376 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java:

[GitHub] [hadoop] curie71 opened a new pull request, #5158: YARN-11382 ClientRMService forget to record some audit logs after accessCheck

curie71 opened a new pull request, #5158: URL: https://github.com/apache/hadoop/pull/5158 ClientRMService forget to record some audit logs after accessCheck and just throw an YarnException("User does not have privilege to do something……"). Here is an example in method "getContainers":

[GitHub] [hadoop] hadoop-yetus commented on pull request #4602: HDFS-16673. Fix usage of chown

hadoop-yetus commented on PR #4602: URL: https://github.com/apache/hadoop/pull/4602#issuecomment-1323728242 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ZanderXu commented on pull request #5098: HDFS-16831. [RBF SBN] GetNamenodesForNameserviceId should shuffle Observer NameNodes every time

ZanderXu commented on PR #5098: URL: https://github.com/apache/hadoop/pull/5098#issuecomment-1323707490 @goiri Sir, can help me review this PR again? Thanks so much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] ZanderXu commented on pull request #4872: HDFS-16764. ObserverNamenode should throw ObserverRetryOnActiveException instead of FileNotFoundException during processing of addBlock rpc

ZanderXu commented on PR #4872: URL: https://github.com/apache/hadoop/pull/4872#issuecomment-1323677572 > Sorry for being late to the party here. The changes to `getAdditionalBlock` look fine to me -- we already check for `WRITE` operation later in the same method, this just moves the

[GitHub] [hadoop] ZanderXu commented on pull request #5125: HDFS-16838. Fix NPE in testAddRplicaProcessorForAddingReplicaInMap

ZanderXu commented on PR #5125: URL: https://github.com/apache/hadoop/pull/5125#issuecomment-1323653147 Sorry for the late update, @xinglin @aajisaka please help me review it again. Thanks so much. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] szilard-nemeth closed pull request #4949: YARN-8262. get_executable in container-executor should provide meaningful error codes

szilard-nemeth closed pull request #4949: YARN-8262. get_executable in container-executor should provide meaningful error codes URL: https://github.com/apache/hadoop/pull/4949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] szilard-nemeth commented on pull request #4949: YARN-8262. get_executable in container-executor should provide meaningful error codes

szilard-nemeth commented on PR #4949: URL: https://github.com/apache/hadoop/pull/4949#issuecomment-1323617448 Thanks @susheel-gupta for working on this. Latest patch LGTM, committed to trunk. Thanks @K0K0V0K for the review. -- This is an automated message from the Apache Git

[GitHub] [hadoop] hadoop-yetus commented on pull request #5157: MAPREDUCE-7427 Parent directory permission could be wrong while create done_intermediate directory

hadoop-yetus commented on PR #5157: URL: https://github.com/apache/hadoop/pull/5157#issuecomment-1323550976 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Resolved] (HADOOP-18523) Allow to retrieve an object from MinIO (S3 API) with a very restrictive policy

[ https://issues.apache.org/jira/browse/HADOOP-18523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18523. - Resolution: Won't Fix > Allow to retrieve an object from MinIO (S3 API) with a very

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637183#comment-17637183 ] ASF GitHub Bot commented on HADOOP-18501: - hadoop-yetus commented on PR #5109: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data: DRAFT

hadoop-yetus commented on PR #5109: URL: https://github.com/apache/hadoop/pull/5109#issuecomment-1323505745 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5142: HDFS-16845: Adds configuration flag to allow clients to use router observer reads without using the ObserverReadProxyProvider.

hadoop-yetus commented on PR #5142: URL: https://github.com/apache/hadoop/pull/5142#issuecomment-1323455565 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5142: HDFS-16845: Adds configuration flag to allow clients to use router observer reads without using the ObserverReadProxyProvider.

hadoop-yetus commented on PR #5142: URL: https://github.com/apache/hadoop/pull/5142#issuecomment-1323448865 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5129: HDFS-16840. Enhance the usage description about oiv in HDFSCommands.md and OfflineImageViewerPB

hadoop-yetus commented on PR #5129: URL: https://github.com/apache/hadoop/pull/5129#issuecomment-1323447710 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18526) Leak of S3AInstrumentation instances via hadoop Metrics references

[ https://issues.apache.org/jira/browse/HADOOP-18526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637132#comment-17637132 ] ASF GitHub Bot commented on HADOOP-18526: - steveloughran commented on PR #5144: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5144: HADOOP-18526. Leak of S3AInstrumentation instances via hadoop Metrics references

steveloughran commented on PR #5144: URL: https://github.com/apache/hadoop/pull/5144#issuecomment-1323403552 testing ideas * scale test to create many fs instances in parallel and verify all is good...need to make sure metrics is turned on first * add probe method for state of s3a

[GitHub] [hadoop] skysiders opened a new pull request, #5157: MAPREDUCE-7427 Parent directory permission could be wrong while create done_intermediate directory

skysiders opened a new pull request, #5157: URL: https://github.com/apache/hadoop/pull/5157 ### Description of PR When creating "history/done_intermediate", we seem to assume that the parent directory of the folder exists and has the correct permissions. But when I run it, it doesn't

[GitHub] [hadoop] hadoop-yetus commented on pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

hadoop-yetus commented on PR #5147: URL: https://github.com/apache/hadoop/pull/5147#issuecomment-1323369890 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637113#comment-17637113 ] ASF GitHub Bot commented on HADOOP-18501: - pranavsaxena-microsoft closed pull request #5109:

[GitHub] [hadoop] pranavsaxena-microsoft closed pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data: DRAFT

pranavsaxena-microsoft closed pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data: DRAFT URL: https://github.com/apache/hadoop/pull/5109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637112#comment-17637112 ] ASF GitHub Bot commented on HADOOP-18501: - pranavsaxena-microsoft opened a new pull request,

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637111#comment-17637111 ] ASF GitHub Bot commented on HADOOP-18501: - pranavsaxena-microsoft closed pull request #5109:

[GitHub] [hadoop] pranavsaxena-microsoft closed pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

pranavsaxena-microsoft closed pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data URL: https://github.com/apache/hadoop/pull/5109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] hadoop-yetus commented on pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

hadoop-yetus commented on PR #5147: URL: https://github.com/apache/hadoop/pull/5147#issuecomment-1323366400 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

hadoop-yetus commented on PR #5147: URL: https://github.com/apache/hadoop/pull/5147#issuecomment-1323365838 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18536) RPC Client Improvement

[ https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18536: Labels: pull-request-available (was: ) > RPC Client Improvement >

[jira] [Commented] (HADOOP-18536) RPC Client Improvement

[ https://issues.apache.org/jira/browse/HADOOP-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637106#comment-17637106 ] ASF GitHub Bot commented on HADOOP-18536: - hadoop-yetus commented on PR #5156: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5156: HADOOP-18536. RPC Client Improvement

hadoop-yetus commented on PR #5156: URL: https://github.com/apache/hadoop/pull/5156#issuecomment-1323347401 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |