[GitHub] [hadoop] cxzl25 opened a new pull request, #5686: MAPREDUCE-7439. JHS MoveIntermediateToDone thread pool should override CallerContext

2023-05-22 Thread via GitHub
cxzl25 opened a new pull request, #5686: URL: https://github.com/apache/hadoop/pull/5686 ### Description of PR Now the job history server provides RPC services. If the Client passes the CallerContext, the RPC will create a MoveIntermediateToDone thread. The CallerContext supports

[GitHub] [hadoop] hadoop-yetus commented on pull request #5683: HDFS-17023. RBF: Record proxy time when call invokeConcurrent method.

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5683: URL: https://github.com/apache/hadoop/pull/5683#issuecomment-1558495073 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5683: HDFS-17023. RBF: Record proxy time when call invokeConcurrent method.

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5683: URL: https://github.com/apache/hadoop/pull/5683#issuecomment-1558494300 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5683: HDFS-17023. RBF: Record proxy time when call invokeConcurrent method.

2023-05-22 Thread via GitHub
hfutatzhanghb commented on PR #5683: URL: https://github.com/apache/hadoop/pull/5683#issuecomment-1558469632 > @ayushtkn , Sir, thanks for your reviewing. I am so sorry about forcing push. The failed unit tests is related to my modification. The reason is proxyOpComplete method

[GitHub] [hadoop] ayushtkn merged pull request #5423: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-05-22 Thread via GitHub
ayushtkn merged PR #5423: URL: https://github.com/apache/hadoop/pull/5423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] goiri merged pull request #5674: HDFS-17020. RBF: mount table addAll should print failed records in std error

2023-05-22 Thread via GitHub
goiri merged PR #5674: URL: https://github.com/apache/hadoop/pull/5674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hfutatzhanghb commented on a diff in pull request #5683: HDFS-17023. RBF: Record proxy time when call invokeConcurrent method.

2023-05-22 Thread via GitHub
hfutatzhanghb commented on code in PR #5683: URL: https://github.com/apache/hadoop/pull/5683#discussion_r1201396660 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -1572,7 +1572,9 @@ public Map

[jira] [Updated] (HADOOP-18740) s3a prefetch cache blocks should be accessed by RW locks

2023-05-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HADOOP-18740: -- Status: Patch Available (was: In Progress) > s3a prefetch cache blocks should be accessed

[GitHub] [hadoop] virajjasani commented on pull request #5674: HDFS-17020. RBF: mount table addAll should print failed records in std error

2023-05-22 Thread via GitHub
virajjasani commented on PR #5674: URL: https://github.com/apache/hadoop/pull/5674#issuecomment-1557826982 Addressed comments with the latest revision -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5681: YARN-11497 : Support removal of only selective node states in untracked removal flow

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5681: URL: https://github.com/apache/hadoop/pull/5681#issuecomment-1557778631 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5663: YARN-11478. [Federation] SQLFederationStateStore Support Store ApplicationSubmitData.

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5663: URL: https://github.com/apache/hadoop/pull/5663#issuecomment-1557710427 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5644: YARN-11490. Reverting YARN-11211 and eliminating the use of DefaultMetricsSystem during configuration validation

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5644: URL: https://github.com/apache/hadoop/pull/5644#issuecomment-1557700693 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] goiri commented on a diff in pull request #5683: HDFS-17023. RBF: Record proxy time when call invokeConcurrent method.

2023-05-22 Thread via GitHub
goiri commented on code in PR #5683: URL: https://github.com/apache/hadoop/pull/5683#discussion_r1200874532 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -1572,7 +1572,9 @@ public Map

[jira] [Commented] (HADOOP-18613) Upgrade ZooKeeper to version 3.8.1

2023-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725049#comment-17725049 ] ASF GitHub Bot commented on HADOOP-18613: - jojochuang commented on code in PR #5345: URL:

[GitHub] [hadoop] jojochuang commented on a diff in pull request #5345: HADOOP-18613. Upgrade ZooKeeper to version 3.8.1

2023-05-22 Thread via GitHub
jojochuang commented on code in PR #5345: URL: https://github.com/apache/hadoop/pull/5345#discussion_r1200819683 ## hadoop-project/pom.xml: ## @@ -37,7 +37,7 @@ true true -9.4.48.v20220622 +9.4.49.v20220914 Review Comment: This is unrelated. Are you

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725029#comment-17725029 ] ASF GitHub Bot commented on HADOOP-18207: - virajjasani commented on code in PR #5503: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5503: HADOOP-18207. Introduce hadoop-logging module

2023-05-22 Thread via GitHub
virajjasani commented on code in PR #5503: URL: https://github.com/apache/hadoop/pull/5503#discussion_r1200771313 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java: ## @@ -220,27 +219,21 @@ public void testFinalWarnings() throws

[jira] [Commented] (HADOOP-18748) Configuration.get is slow

2023-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725021#comment-17725021 ] ASF GitHub Bot commented on HADOOP-18748: - hadoop-yetus commented on PR #5685: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5685: HADOOP-18748 Optimize Configuration.handleDeprecation

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5685: URL: https://github.com/apache/hadoop/pull/5685#issuecomment-1557526809 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18748) Configuration.get is slow

2023-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725020#comment-17725020 ] ASF GitHub Bot commented on HADOOP-18748: - hadoop-yetus commented on PR #5685: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5685: HADOOP-18748 Optimize Configuration.handleDeprecation

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5685: URL: https://github.com/apache/hadoop/pull/5685#issuecomment-1557525853 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18748) Configuration.get is slow

2023-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725018#comment-17725018 ] ASF GitHub Bot commented on HADOOP-18748: - hadoop-yetus commented on PR #5685: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5685: HADOOP-18748 Optimize Configuration.handleDeprecation

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5685: URL: https://github.com/apache/hadoop/pull/5685#issuecomment-1557524541 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18652) Path.suffix raises NullPointerException

2023-05-22 Thread Patrick Grandjean (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724994#comment-17724994 ] Patrick Grandjean commented on HADOOP-18652: Thank you :) > Path.suffix raises

[GitHub] [hadoop] mudit-97 commented on a diff in pull request #5681: YARN-11497 : Support removal of only selective node states in untracked removal flow

2023-05-22 Thread via GitHub
mudit-97 commented on code in PR #5681: URL: https://github.com/apache/hadoop/pull/5681#discussion_r1200618609 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java: ## @@ -1209,6 +1209,19 @@ public static boolean

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5681: YARN-11497 : Support removal of only selective node states in untracked removal flow

2023-05-22 Thread via GitHub
slfan1989 commented on code in PR #5681: URL: https://github.com/apache/hadoop/pull/5681#discussion_r1200610275 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/NodesListManager.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5681: YARN-11497 : Support removal of only selective node states in untracked removal flow

2023-05-22 Thread via GitHub
slfan1989 commented on code in PR #5681: URL: https://github.com/apache/hadoop/pull/5681#discussion_r1200608735 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java: ## @@ -1209,6 +1209,19 @@ public static boolean

[GitHub] [hadoop] slfan1989 commented on pull request #5676: YARN-6648. BackPort [GPG] Add SubClusterCleaner in Global Policy Generator.

2023-05-22 Thread via GitHub
slfan1989 commented on PR #5676: URL: https://github.com/apache/hadoop/pull/5676#issuecomment-1557332260 @goiri Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5597: HDFS-16993. Datanode supports configure TopN DatanodeNetworkCounts

2023-05-22 Thread via GitHub
hfutatzhanghb commented on PR #5597: URL: https://github.com/apache/hadoop/pull/5597#issuecomment-1557331945 The failed unit tests seems to have no relation with this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] slfan1989 commented on pull request #5663: YARN-11478. [Federation] SQLFederationStateStore Support Store ApplicationSubmitData.

2023-05-22 Thread via GitHub
slfan1989 commented on PR #5663: URL: https://github.com/apache/hadoop/pull/5663#issuecomment-1557330840 > Let's fix the checktyles and get a clean build (the failed unit tests look unrelated). @goiri Thank you very much for helping to review the code. I have fixed the Checkstyle

[GitHub] [hadoop] tomicooler commented on a diff in pull request #5644: YARN-11490. Reverting YARN-11211 and eliminating the use of DefaultMetricsSystem during configuration validation

2023-05-22 Thread via GitHub
tomicooler commented on code in PR #5644: URL: https://github.com/apache/hadoop/pull/5644#discussion_r1200597052 ##

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2023-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724966#comment-17724966 ] ASF GitHub Bot commented on HADOOP-18073: - hadoop-yetus commented on PR #5684: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5684: HADOOP-18073. Upgrade to AWS SDK V2.

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5684: URL: https://github.com/apache/hadoop/pull/5684#issuecomment-1557300368 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5663: YARN-11478. [Federation] SQLFederationStateStore Support Store ApplicationSubmitData.

2023-05-22 Thread via GitHub
slfan1989 commented on PR #5663: URL: https://github.com/apache/hadoop/pull/5663#issuecomment-1557243630 - Mysql > Mysql 5.7 - sp_addApplicationHomeSubCluster ``` federationstatestore> CREATE PROCEDURE sp_addApplicationHomeSubCluster( IN

[jira] [Created] (HADOOP-18749) AWS SDK V2 - ITestS3AHugeFilesNoMultipart failure

2023-05-22 Thread Ahmar Suhail (Jira)
Ahmar Suhail created HADOOP-18749: - Summary: AWS SDK V2 - ITestS3AHugeFilesNoMultipart failure Key: HADOOP-18749 URL: https://issues.apache.org/jira/browse/HADOOP-18749 Project: Hadoop Common

[jira] [Updated] (HADOOP-18748) Configuration.get is slow

2023-05-22 Thread Alkis Evlogimenos (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alkis Evlogimenos updated HADOOP-18748: --- Description: `Configuration.get` is slow mainly because of the overhead of

[GitHub] [hadoop] alkis opened a new pull request, #5685: HADOOP-18748 Optimize Configuration.handleDeprecation

2023-05-22 Thread via GitHub
alkis opened a new pull request, #5685: URL: https://github.com/apache/hadoop/pull/5685 ### Description of PR Optimize `Configuration.handleDeprecation` by adding a fastpath for when a property is not deprecated. While at it factor out property propagation so that it can be reused by

[jira] [Created] (HADOOP-18748) Configuration.get is slow

2023-05-22 Thread Alkis Evlogimenos (Jira)
Alkis Evlogimenos created HADOOP-18748: -- Summary: Configuration.get is slow Key: HADOOP-18748 URL: https://issues.apache.org/jira/browse/HADOOP-18748 Project: Hadoop Common Issue Type:

[jira] [Updated] (HADOOP-18748) Configuration.get is slow

2023-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18748: Labels: pull-request-available (was: ) > Configuration.get is slow >

[jira] [Commented] (HADOOP-18748) Configuration.get is slow

2023-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724947#comment-17724947 ] ASF GitHub Bot commented on HADOOP-18748: - alkis opened a new pull request, #5685: URL:

[jira] [Commented] (HADOOP-18709) Add curator based ZooKeeper communication support over SSL/TLS into the common library

2023-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724943#comment-17724943 ] ASF GitHub Bot commented on HADOOP-18709: - ferdelyi commented on code in PR #5638: URL:

[GitHub] [hadoop] ferdelyi commented on a diff in pull request #5638: HADOOP-18709. Add curator based ZooKeeper communication support over…

2023-05-22 Thread via GitHub
ferdelyi commented on code in PR #5638: URL: https://github.com/apache/hadoop/pull/5638#discussion_r1200468351 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/curator/ZKCuratorManager.java: ## @@ -503,4 +644,50 @@ private void

[GitHub] [hadoop] leixm commented on pull request #5677: [YARN-11496] Improve TimelineService log format.

2023-05-22 Thread via GitHub
leixm commented on PR #5677: URL: https://github.com/apache/hadoop/pull/5677#issuecomment-1557126366 @slfan1989 @ayushtkn Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] leixm commented on pull request #5668: HDFS-17018. Improve dfsclient log format

2023-05-22 Thread via GitHub
leixm commented on PR #5668: URL: https://github.com/apache/hadoop/pull/5668#issuecomment-1557125933 @slfan1989 @ayushtkn Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] leixm commented on pull request #4797: YARN-11277. Trigger log-dir deletion by size for NonAggregatingLogHandler

2023-05-22 Thread via GitHub
leixm commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1557124921 cc @aajisaka @slfan1989 PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] hadoop-yetus commented on pull request #4797: YARN-11277. Trigger log-dir deletion by size for NonAggregatingLogHandler

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1557095104 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5663: YARN-11478. [Federation] SQLFederationStateStore Support Store ApplicationSubmitData.

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5663: URL: https://github.com/apache/hadoop/pull/5663#issuecomment-1557071726 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5028: MAPREDUCE-7419. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-common

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5028: URL: https://github.com/apache/hadoop/pull/5028#issuecomment-1557065707 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5683: HDFS-17023. Record proxy time when call invokeConcurrent method.

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5683: URL: https://github.com/apache/hadoop/pull/5683#issuecomment-1557042604 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2023-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724890#comment-17724890 ] ASF GitHub Bot commented on HADOOP-18073: - ahmarsuhail opened a new pull request, #5684: URL:

[GitHub] [hadoop] ahmarsuhail opened a new pull request, #5684: HADOOP-18073. Upgrade to AWS SDK V2.

2023-05-22 Thread via GitHub
ahmarsuhail opened a new pull request, #5684: URL: https://github.com/apache/hadoop/pull/5684 ### Description of PR JIRA: https://issues.apache.org/jira/browse/HADOOP-18073 This PR upgrades S3A to use AWS Java SDK V2. Changes made are detailed in `aws_sdk_v2_changelog.md`.

[jira] [Created] (HADOOP-18747) AWS SDK V2 - sigv2 support

2023-05-22 Thread Ahmar Suhail (Jira)
Ahmar Suhail created HADOOP-18747: - Summary: AWS SDK V2 - sigv2 support Key: HADOOP-18747 URL: https://issues.apache.org/jira/browse/HADOOP-18747 Project: Hadoop Common Issue Type: Sub-task

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #3618: YARN-11000. Replace queue resource calculation logic in updateClusterResource

2023-05-22 Thread via GitHub
K0K0V0K commented on code in PR #3618: URL: https://github.com/apache/hadoop/pull/3618#discussion_r1200322180 ##

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #3618: YARN-11000. Replace queue resource calculation logic in updateClusterResource

2023-05-22 Thread via GitHub
K0K0V0K commented on code in PR #3618: URL: https://github.com/apache/hadoop/pull/3618#discussion_r1200321624 ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #5682: YARN-7898. [FederationStateStore] [FederationStateStore] Create a proxy chain for FederationStateStore API in the Router.

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5682: URL: https://github.com/apache/hadoop/pull/5682#issuecomment-1556967946 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5672: YARN-7720. Race condition between second app attempt and UAM timeout when first attempt node is down.

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5672: URL: https://github.com/apache/hadoop/pull/5672#issuecomment-1556951749 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #3618: YARN-11000. Replace queue resource calculation logic in updateClusterResource

2023-05-22 Thread via GitHub
K0K0V0K commented on code in PR #3618: URL: https://github.com/apache/hadoop/pull/3618#discussion_r1200304407 ##

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #3618: YARN-11000. Replace queue resource calculation logic in updateClusterResource

2023-05-22 Thread via GitHub
K0K0V0K commented on code in PR #3618: URL: https://github.com/apache/hadoop/pull/3618#discussion_r1200303971 ##

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #3618: YARN-11000. Replace queue resource calculation logic in updateClusterResource

2023-05-22 Thread via GitHub
K0K0V0K commented on code in PR #3618: URL: https://github.com/apache/hadoop/pull/3618#discussion_r1200299886 ##

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #3618: YARN-11000. Replace queue resource calculation logic in updateClusterResource

2023-05-22 Thread via GitHub
K0K0V0K commented on code in PR #3618: URL: https://github.com/apache/hadoop/pull/3618#discussion_r1200293092 ##

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #3618: YARN-11000. Replace queue resource calculation logic in updateClusterResource

2023-05-22 Thread via GitHub
K0K0V0K commented on code in PR #3618: URL: https://github.com/apache/hadoop/pull/3618#discussion_r1200292301 ##

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #3618: YARN-11000. Replace queue resource calculation logic in updateClusterResource

2023-05-22 Thread via GitHub
K0K0V0K commented on code in PR #3618: URL: https://github.com/apache/hadoop/pull/3618#discussion_r1200291957 ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #5681: YARN-11497 : Support removal of only selective node states in untracked removal flow

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5681: URL: https://github.com/apache/hadoop/pull/5681#issuecomment-1556904683 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18724) Open file fails with NumberFormatException for S3AFileSystem

2023-05-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724852#comment-17724852 ] ASF subversion and git services commented on HADOOP-18724: -- Commit

[jira] [Commented] (HADOOP-18565) AWS SDK V2 - Complete outstanding items

2023-05-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724858#comment-17724858 ] ASF subversion and git services commented on HADOOP-18565: -- Commit

[jira] [Commented] (HADOOP-18688) S3A audit header to include count of items in delete ops

2023-05-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724854#comment-17724854 ] ASF subversion and git services commented on HADOOP-18688: -- Commit

[jira] [Commented] (HADOOP-18724) Open file fails with NumberFormatException for S3AFileSystem

2023-05-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724855#comment-17724855 ] ASF subversion and git services commented on HADOOP-18724: -- Commit

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2023-05-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724857#comment-17724857 ] ASF subversion and git services commented on HADOOP-18073: -- Commit

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2023-05-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724856#comment-17724856 ] ASF subversion and git services commented on HADOOP-18073: -- Commit

[jira] [Commented] (HADOOP-18724) Open file fails with NumberFormatException for S3AFileSystem

2023-05-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724853#comment-17724853 ] ASF subversion and git services commented on HADOOP-18724: -- Commit

[GitHub] [hadoop] slfan1989 commented on pull request #5663: YARN-11478. [Federation] SQLFederationStateStore Support Store ApplicationSubmitData.

2023-05-22 Thread via GitHub
slfan1989 commented on PR #5663: URL: https://github.com/apache/hadoop/pull/5663#issuecomment-1556879293 > SQLServer2008 - sp_addApplicationHomeSubCluster ``` FederationStateStore> CREATE PROCEDURE [dbo].[sp_addApplicationHomeSubCluster]

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5683: HDFS-17023. Record proxy time when call invokeConcurrent method.

2023-05-22 Thread via GitHub
hfutatzhanghb commented on PR #5683: URL: https://github.com/apache/hadoop/pull/5683#issuecomment-1556877276 @goiri Hi, sir. I am not sure whether we should add metrics here. could you help me figure it out? Thanks a lot. -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] hfutatzhanghb opened a new pull request, #5683: HDFS-17023. Record proxy time when call invokeConcurrent method.

2023-05-22 Thread via GitHub
hfutatzhanghb opened a new pull request, #5683: URL: https://github.com/apache/hadoop/pull/5683 ### Description of PR please see HDFS-17023 ### How was this patch tested? No need new unit tests. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] haiyang1987 commented on pull request #5667: HDFS-17017. Fix the issue of arguments number limit in report command in DFSAdmin

2023-05-22 Thread via GitHub
haiyang1987 commented on PR #5667: URL: https://github.com/apache/hadoop/pull/5667#issuecomment-1556804800 > we can live with that 150 checkstlye warning, some tests are indeed huge, didn't like this checkstyle warning itself, should relax this a bit for atleast for test code.

[GitHub] [hadoop] hadoop-yetus commented on pull request #5597: HDFS-16993. Datanode supports configure TopN DatanodeNetworkCounts

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5597: URL: https://github.com/apache/hadoop/pull/5597#issuecomment-1556776968 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 opened a new pull request, #5682: YARN-7898. [FederationStateStore] [FederationStateStore] Create a proxy chain for FederationStateStore API in the Router.

2023-05-22 Thread via GitHub
slfan1989 opened a new pull request, #5682: URL: https://github.com/apache/hadoop/pull/5682 ### Description of PR JIRA: YARN-7898. [FederationStateStore] [FederationStateStore] Create a proxy chain for FederationStateStore API in the Router. ### How was this patch tested?

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-05-22 Thread via GitHub
hfutatzhanghb commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1556708182 ![image](https://github.com/apache/hadoop/assets/25115709/a181d152-e642-4b41-a770-03b7f8d693f2) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1556699136 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5636: YARN-11492. Improve createJerseyClient#setConnectTimeout Code.

2023-05-22 Thread via GitHub
hadoop-yetus commented on PR #5636: URL: https://github.com/apache/hadoop/pull/5636#issuecomment-1556619161 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |