Re: [PR] HDFS-17383:Datanode current block token should come from active NameNode in HA mode [hadoop]

2024-04-11 Thread via GitHub
hadoop-yetus commented on PR #6562: URL: https://github.com/apache/hadoop/pull/6562#issuecomment-205102 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19129) ABFS: Fixing Test Script Bug and Some Known test Failures in ABFS Test Suite

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836410#comment-17836410 ] ASF GitHub Bot commented on HADOOP-19129: - anujmodi2021 commented on code in PR #6676: URL:

Re: [PR] HDFS-17383:Datanode current block token should come from active NameNode in HA mode [hadoop]

2024-04-11 Thread via GitHub
hadoop-yetus commented on PR #6562: URL: https://github.com/apache/hadoop/pull/6562#issuecomment-2050991527 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19129) ABFS: Fixing Test Script Bug and Some Known test Failures in ABFS Test Suite

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836409#comment-17836409 ] ASF GitHub Bot commented on HADOOP-19129: - anujmodi2021 commented on code in PR #6676: URL:

Re: [PR] HADOOP-19129: [ABFS] Test Fixes and Test Script Bug Fixes [hadoop]

2024-04-11 Thread via GitHub
anujmodi2021 commented on code in PR #6676: URL: https://github.com/apache/hadoop/pull/6676#discussion_r1562021413 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStreamStatistics.java: ## @@ -136,10 +136,10 @@ public void testAbfsStreamOps()

Re: [PR] HADOOP-19129: [ABFS] Test Fixes and Test Script Bug Fixes [hadoop]

2024-04-11 Thread via GitHub
anujmodi2021 commented on code in PR #6676: URL: https://github.com/apache/hadoop/pull/6676#discussion_r1562021850 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsClient.java: ## @@ -102,11 +103,31 @@ public void

Re: [PR] HDFS-17461. Fix spotbugs in PeerCache#getInternal [hadoop]

2024-04-11 Thread via GitHub
hadoop-yetus commented on PR #6721: URL: https://github.com/apache/hadoop/pull/6721#issuecomment-2050962070 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19129) ABFS: Fixing Test Script Bug and Some Known test Failures in ABFS Test Suite

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836404#comment-17836404 ] ASF GitHub Bot commented on HADOOP-19129: - anujmodi2021 commented on code in PR #6676: URL:

Re: [PR] HADOOP-19129: [ABFS] Test Fixes and Test Script Bug Fixes [hadoop]

2024-04-11 Thread via GitHub
anujmodi2021 commented on code in PR #6676: URL: https://github.com/apache/hadoop/pull/6676#discussion_r1561990652 ## hadoop-tools/hadoop-azure/src/site/markdown/index.md: ## @@ -18,8 +18,8 @@ See also: -* [ABFS](./abfs.html) -* [Testing](./testing_azure.html) +*

Re: [PR] HDFS-17397. Choose another DN as soon as possible, when encountering network issues [hadoop]

2024-04-11 Thread via GitHub
tangphucnhan commented on PR #6591: URL: https://github.com/apache/hadoop/pull/6591#issuecomment-2050879234 Thanks! On Thu, Mar 28, 2024 at 4:17 PM Apache Hadoop Yetus Account < ***@***.***> wrote: >  *-1 overall* > Vote Subsystem Runtime Logfile Comment > +0  reexec

Re: [PR] HDFS-17424 [FGL] DelegationTokenSecretManager supports fine-grained lock [hadoop]

2024-04-11 Thread via GitHub
ferhui commented on code in PR #6696: URL: https://github.com/apache/hadoop/pull/6696#discussion_r1561943317 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenSecretManager.java: ## @@ -401,7 +402,10 @@ protected

Re: [PR] HDFS-17461. Fix spotbugs in PeerCache#getInternal [hadoop]

2024-04-11 Thread via GitHub
haiyang1987 commented on code in PR #6721: URL: https://github.com/apache/hadoop/pull/6721#discussion_r1561931239 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/PeerCache.java: ## @@ -155,7 +155,7 @@ public Peer get(DatanodeID dnId, boolean

Re: [PR] HDFS-17461. Fix spotbugs in PeerCache#getInternal [hadoop]

2024-04-11 Thread via GitHub
ayushtkn commented on code in PR #6721: URL: https://github.com/apache/hadoop/pull/6721#discussion_r1561813524 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/PeerCache.java: ## @@ -155,7 +155,7 @@ public Peer get(DatanodeID dnId, boolean

Re: [PR] MAPREDUCE-7474. Improve Manifest committer resilience [hadoop]

2024-04-11 Thread via GitHub
hadoop-yetus commented on PR #6716: URL: https://github.com/apache/hadoop/pull/6716#issuecomment-2050651681 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18235. vulnerability: we may leak sensitive information in LocalKeyStoreProvider [hadoop]

2024-04-11 Thread via GitHub
hadoop-yetus commented on PR #4998: URL: https://github.com/apache/hadoop/pull/4998#issuecomment-2050626727 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18235) vulnerability: we may leak sensitive information in LocalKeyStoreProvider

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836365#comment-17836365 ] ASF GitHub Bot commented on HADOOP-18235: - hadoop-yetus commented on PR #4998: URL:

Re: [PR] MAPREDUCE-7474. Improve Manifest committer resilience [hadoop]

2024-04-11 Thread via GitHub
hadoop-yetus commented on PR #6716: URL: https://github.com/apache/hadoop/pull/6716#issuecomment-2050579864 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19146) noaa-cors-pds bucket access with global endpoint fails

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836358#comment-17836358 ] ASF GitHub Bot commented on HADOOP-19146: - hadoop-yetus commented on PR #6723: URL:

Re: [PR] HADOOP-19146 noaa-cors-pds bucket access with global endpoint fails [hadoop]

2024-04-11 Thread via GitHub
hadoop-yetus commented on PR #6723: URL: https://github.com/apache/hadoop/pull/6723#issuecomment-2050515997 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17439. Support -nonSuperUser for NNThroughputBenchmark: useful f… [hadoop]

2024-04-11 Thread via GitHub
fateh288 commented on PR #6677: URL: https://github.com/apache/hadoop/pull/6677#issuecomment-2050492580 Requesting review on this patch. The style check failures are from legacy code and not introduced in this patch specifically. The unit test failures are also unrelated (the same

[jira] [Commented] (HADOOP-19124) Update org.ehcache from 3.3.1 to 3.8.2.

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836333#comment-17836333 ] ASF GitHub Bot commented on HADOOP-19124: - slfan1989 commented on PR #6705: URL:

Re: [PR] HADOOP-19124. Update org.ehcache from 3.3.1 to 3.8.2. (#6665) [hadoop]

2024-04-11 Thread via GitHub
slfan1989 commented on PR #6705: URL: https://github.com/apache/hadoop/pull/6705#issuecomment-2050376220 @steveloughran > you don't have to: for anything complex i push up so yetus runs all the tests. I just cherrypick on the terminal to get things over fast, running any new tests

[jira] [Commented] (HADOOP-18708) AWS SDK V2 - Implement CSE

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836332#comment-17836332 ] ASF GitHub Bot commented on HADOOP-18708: - steveloughran commented on code in PR #6164: URL:

Re: [PR] HADOOP-18708. AWS SDK V2 - Implement CSE [hadoop]

2024-04-11 Thread via GitHub
steveloughran commented on code in PR #6164: URL: https://github.com/apache/hadoop/pull/6164#discussion_r1561533019 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/EncryptionS3ClientFactory.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (HADOOP-18708) AWS SDK V2 - Implement CSE

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836329#comment-17836329 ] ASF GitHub Bot commented on HADOOP-18708: - steveloughran commented on PR #6164: URL:

[jira] [Commented] (HADOOP-19146) noaa-cors-pds bucket access with global endpoint fails

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836328#comment-17836328 ] ASF GitHub Bot commented on HADOOP-19146: - virajjasani commented on PR #6723: URL:

Re: [PR] HADOOP-18708. AWS SDK V2 - Implement CSE [hadoop]

2024-04-11 Thread via GitHub
steveloughran commented on PR #6164: URL: https://github.com/apache/hadoop/pull/6164#issuecomment-2050354049 > java.util.concurrent.TimeoutException easily added to the check > ITestS3AContractVectoredRead.testEOFRanges416Handling fails because S3EC does not throw an exception

[jira] [Updated] (HADOOP-19146) noaa-cors-pds bucket access with global endpoint fails

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19146: Labels: pull-request-available (was: ) > noaa-cors-pds bucket access with global

[jira] [Commented] (HADOOP-19124) Update org.ehcache from 3.3.1 to 3.8.2.

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836326#comment-17836326 ] ASF GitHub Bot commented on HADOOP-19124: - steveloughran commented on PR #6705: URL:

[jira] [Commented] (HADOOP-19146) noaa-cors-pds bucket access with global endpoint fails

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836327#comment-17836327 ] ASF GitHub Bot commented on HADOOP-19146: - virajjasani opened a new pull request, #6723: URL:

Re: [PR] HADOOP-19146 noaa-cors-pds bucket access with global endpoint fails [hadoop]

2024-04-11 Thread via GitHub
virajjasani commented on PR #6723: URL: https://github.com/apache/hadoop/pull/6723#issuecomment-2050352353 Tested with scale profile, with and without global endpoint setting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (HADOOP-19146) noaa-cors-pds bucket access with global endpoint fails

2024-04-11 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HADOOP-19146: -- Component/s: test > noaa-cors-pds bucket access with global endpoint fails >

Re: [PR] HADOOP-19124. Update org.ehcache from 3.3.1 to 3.8.2. (#6665) [hadoop]

2024-04-11 Thread via GitHub
steveloughran commented on PR #6705: URL: https://github.com/apache/hadoop/pull/6705#issuecomment-2050349164 > I will backport pr on the command line in the future. you don't have to: for anything complex i push up so yetus runs all the tests. I just cherrypick on the terminal to

[jira] [Created] (HADOOP-19146) noaa-cors-pds bucket access with global endpoint fails

2024-04-11 Thread Viraj Jasani (Jira)
Viraj Jasani created HADOOP-19146: - Summary: noaa-cors-pds bucket access with global endpoint fails Key: HADOOP-19146 URL: https://issues.apache.org/jira/browse/HADOOP-19146 Project: Hadoop Common

[jira] [Assigned] (HADOOP-19146) noaa-cors-pds bucket access with global endpoint fails

2024-04-11 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HADOOP-19146: - Assignee: Viraj Jasani > noaa-cors-pds bucket access with global endpoint fails >

[jira] [Commented] (HADOOP-19081) move ssh/sftp code out of hadoop-common into a dedicated jar

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836323#comment-17836323 ] ASF GitHub Bot commented on HADOOP-19081: - steveloughran commented on code in PR #6693: URL:

Re: [PR] HADOOP-19081. Move some hadoop-common code to new hadoop-ftp module [hadoop]

2024-04-11 Thread via GitHub
steveloughran commented on code in PR #6693: URL: https://github.com/apache/hadoop/pull/6693#discussion_r1561513799 ## hadoop-tools/hadoop-ftp/src/main/conf/log4j.properties: ## @@ -0,0 +1,337 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment:

Re: [PR] MAPREDUCE-7474. Improve Manifest committer resilience [hadoop]

2024-04-11 Thread via GitHub
steveloughran commented on PR #6716: URL: https://github.com/apache/hadoop/pull/6716#issuecomment-2050326218 Reviews invited from @mukund-thakur @anmolanmol1234 @anujmodi2021 @HarshitGupta11 -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HADOOP-19079) HttpExceptionUtils to check that loaded class is really an exception before instantiation

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836315#comment-17836315 ] ASF GitHub Bot commented on HADOOP-19079: - steveloughran commented on PR #6557: URL:

Re: [PR] HADOOP-19079. Check class is an exception class before constructing an instance [hadoop]

2024-04-11 Thread via GitHub
steveloughran commented on PR #6557: URL: https://github.com/apache/hadoop/pull/6557#issuecomment-2050311828 > Junit has assertThrows though. Would that be a bit more Java friendly? one thing intercept does, which I haven't seen the others to, is include the toString() value of

[jira] [Resolved] (HADOOP-19079) HttpExceptionUtils to check that loaded class is really an exception before instantiation

2024-04-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-19079. - Fix Version/s: 3.3.9 3.5.0 3.4.1

[jira] [Commented] (HADOOP-19079) HttpExceptionUtils to check that loaded class is really an exception before instantiation

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836311#comment-17836311 ] ASF GitHub Bot commented on HADOOP-19079: - steveloughran commented on PR #6557: URL:

Re: [PR] HADOOP-19079. Check class is an exception class before constructing an instance [hadoop]

2024-04-11 Thread via GitHub
steveloughran commented on PR #6557: URL: https://github.com/apache/hadoop/pull/6557#issuecomment-2050296398 merged to trunk; cherrypicking to branch-3.4. branch-3.3 as well, perhaps -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HADOOP-19079) HttpExceptionUtils to check that loaded class is really an exception before instantiation

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836310#comment-17836310 ] ASF GitHub Bot commented on HADOOP-19079: - steveloughran merged PR #6557: URL:

Re: [PR] HADOOP-19079. Check class is an exception class before constructing an instance [hadoop]

2024-04-11 Thread via GitHub
steveloughran merged PR #6557: URL: https://github.com/apache/hadoop/pull/6557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HADOOP-19079) HttpExceptionUtils to check that loaded class is really an exception before instantiation

2024-04-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19079: Summary: HttpExceptionUtils to check that loaded class is really an exception before

Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-04-11 Thread via GitHub
mukund-thakur commented on code in PR #6494: URL: https://github.com/apache/hadoop/pull/6494#discussion_r1561315131 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/BulkDeleteOperationCallbacksImpl.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836273#comment-17836273 ] ASF GitHub Bot commented on HADOOP-18679: - mukund-thakur commented on code in PR #6494: URL:

[jira] [Commented] (HADOOP-18296) Memory fragmentation in ChecksumFileSystem Vectored IO implementation.

2024-04-11 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836272#comment-17836272 ] Mukund Thakur commented on HADOOP-18296: Yes, it is. Although direct buffers are not used in

[jira] [Commented] (HADOOP-19140) [ABFS, S3A] Add IORateLimiter api to hadoop common

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836245#comment-17836245 ] ASF GitHub Bot commented on HADOOP-19140: - steveloughran commented on code in PR #6703: URL:

[jira] [Commented] (HADOOP-19140) [ABFS, S3A] Add IORateLimiter api to hadoop common

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836243#comment-17836243 ] ASF GitHub Bot commented on HADOOP-19140: - steveloughran commented on code in PR #6703: URL:

Re: [PR] HADOOP-19140. [ABFS, S3A] Add IORateLimiter API [hadoop]

2024-04-11 Thread via GitHub
steveloughran commented on code in PR #6703: URL: https://github.com/apache/hadoop/pull/6703#discussion_r1561220101 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/IORateLimiterSupport.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache

Re: [PR] HADOOP-19140. [ABFS, S3A] Add IORateLimiter API [hadoop]

2024-04-11 Thread via GitHub
steveloughran commented on code in PR #6703: URL: https://github.com/apache/hadoop/pull/6703#discussion_r1561216836 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/IORateLimiter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836215#comment-17836215 ] ASF GitHub Bot commented on HADOOP-18679: - steveloughran commented on code in PR #6494: URL:

Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-04-11 Thread via GitHub
steveloughran commented on code in PR #6494: URL: https://github.com/apache/hadoop/pull/6494#discussion_r1561126867 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/BulkDeleteOperationCallbacksImpl.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache

[jira] [Commented] (HADOOP-16822) Provide source artifacts for hadoop-client-api

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836212#comment-17836212 ] ASF GitHub Bot commented on HADOOP-16822: - steveloughran commented on PR #6719: URL:

Re: [PR] (3.3) Revert "HADOOP-16822. Provide source artifacts for hadoop-client-api" [hadoop]

2024-04-11 Thread via GitHub
steveloughran commented on PR #6719: URL: https://github.com/apache/hadoop/pull/6719#issuecomment-2049829358 thanks, merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] (3.3) Revert "HADOOP-16822. Provide source artifacts for hadoop-client-api" [hadoop]

2024-04-11 Thread via GitHub
steveloughran merged PR #6719: URL: https://github.com/apache/hadoop/pull/6719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-16822) Provide source artifacts for hadoop-client-api

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836211#comment-17836211 ] ASF GitHub Bot commented on HADOOP-16822: - steveloughran merged PR #6719: URL:

Re: [PR] HDFS-17461. Fix spotbugs in PeerCache#getInternal [hadoop]

2024-04-11 Thread via GitHub
hadoop-yetus commented on PR #6721: URL: https://github.com/apache/hadoop/pull/6721#issuecomment-2049777273 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17458. Remove unnecessary BP lock in ReplicaMap. [hadoop]

2024-04-11 Thread via GitHub
hadoop-yetus commented on PR #6717: URL: https://github.com/apache/hadoop/pull/6717#issuecomment-2049744473 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HDFS-17462. Fix NPE in Router concat when trg is an empty ile [hadoop]

2024-04-11 Thread via GitHub
fannaihao opened a new pull request, #6722: URL: https://github.com/apache/hadoop/pull/6722 ### Description of PR When trg of Router concat is an empty file, it will trigger NPE in Router, and the concat will fail, example:

Re: [PR] HDFS-17458. Remove unnecessary BP lock in ReplicaMap. [hadoop]

2024-04-11 Thread via GitHub
hfutatzhanghb commented on PR #6717: URL: https://github.com/apache/hadoop/pull/6717#issuecomment-2049700613 > @hfutatzhanghb Thanks for your works. We should be careful to remove BP lock here. List one of the changes as example, it will return one definite value before this PR because

[jira] [Commented] (HADOOP-19129) ABFS: Fixing Test Script Bug and Some Known test Failures in ABFS Test Suite

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836174#comment-17836174 ] ASF GitHub Bot commented on HADOOP-19129: - steveloughran commented on code in PR #6676: URL:

Re: [PR] HADOOP-19129: [ABFS] Test Fixes and Test Script Bug Fixes [hadoop]

2024-04-11 Thread via GitHub
steveloughran commented on code in PR #6676: URL: https://github.com/apache/hadoop/pull/6676#discussion_r1561011696 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsClient.java: ## @@ -102,11 +103,31 @@ public void

[jira] [Resolved] (HADOOP-19096) [ABFS] Enhancing Client-Side Throttling Metrics Updation Logic

2024-04-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-19096. - Fix Version/s: 3.5.0 Resolution: Fixed > [ABFS] Enhancing Client-Side

[jira] [Commented] (HADOOP-19096) [ABFS] Enhancing Client-Side Throttling Metrics Updation Logic

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836168#comment-17836168 ] ASF GitHub Bot commented on HADOOP-19096: - steveloughran merged PR #6720: URL:

[jira] [Commented] (HADOOP-19096) [ABFS] Enhancing Client-Side Throttling Metrics Updation Logic

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836169#comment-17836169 ] ASF GitHub Bot commented on HADOOP-19096: - steveloughran commented on PR #6720: URL:

Re: [PR] HADOOP-19096: [Backport to 3.4][ABFS] [CST Optimization] Enhancing Client-Side Throttling Metrics Updating Logic [hadoop]

2024-04-11 Thread via GitHub
steveloughran commented on PR #6720: URL: https://github.com/apache/hadoop/pull/6720#issuecomment-2049664824 +1, merged to 3.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HADOOP-19096: [Backport to 3.4][ABFS] [CST Optimization] Enhancing Client-Side Throttling Metrics Updating Logic [hadoop]

2024-04-11 Thread via GitHub
steveloughran merged PR #6720: URL: https://github.com/apache/hadoop/pull/6720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HADOOP-19105) S3A: Recover from Vector IO read failures

2024-04-11 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19105: Environment: s3a vector IO doesn't try to recover from read failures the way read()

[jira] [Commented] (HADOOP-19096) [ABFS] Enhancing Client-Side Throttling Metrics Updation Logic

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836145#comment-17836145 ] ASF GitHub Bot commented on HADOOP-19096: - hadoop-yetus commented on PR #6720: URL:

Re: [PR] HADOOP-19096: [Backport to 3.4][ABFS] [CST Optimization] Enhancing Client-Side Throttling Metrics Updating Logic [hadoop]

2024-04-11 Thread via GitHub
hadoop-yetus commented on PR #6720: URL: https://github.com/apache/hadoop/pull/6720#issuecomment-2049551471 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HDFS-17461. Fix spotbugs in PeerCache#getInternal [hadoop]

2024-04-11 Thread via GitHub
haiyang1987 opened a new pull request, #6721: URL: https://github.com/apache/hadoop/pull/6721 ### Description of PR https://issues.apache.org/jira/browse/HDFS-17461 Fix spotbugs in PeerCache#getInternal Spotbugs warnings:

Re: [PR] HDFS-17455. Fix Client throw IndexOutOfBoundsException in DFSInputStream#fetchBlockAt [hadoop]

2024-04-11 Thread via GitHub
haiyang1987 commented on PR #6710: URL: https://github.com/apache/hadoop/pull/6710#issuecomment-2049510136 Thanks @ZanderXu @Hexiaoqiao for your review and merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (HADOOP-19129) ABFS: Fixing Test Script Bug and Some Known test Failures in ABFS Test Suite

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836129#comment-17836129 ] ASF GitHub Bot commented on HADOOP-19129: - anujmodi2021 commented on code in PR #6676: URL:

Re: [PR] HADOOP-19129: [ABFS] Test Fixes and Test Script Bug Fixes [hadoop]

2024-04-11 Thread via GitHub
anujmodi2021 commented on code in PR #6676: URL: https://github.com/apache/hadoop/pull/6676#discussion_r1560869308 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsIntegrationTest.java: ## @@ -532,4 +528,36 @@ protected long

Re: [PR] HDFS-17458. Remove unnecessary BP lock in ReplicaMap. [hadoop]

2024-04-11 Thread via GitHub
hadoop-yetus commented on PR #6717: URL: https://github.com/apache/hadoop/pull/6717#issuecomment-2049462537 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19096) [ABFS] Enhancing Client-Side Throttling Metrics Updation Logic

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836110#comment-17836110 ] ASF GitHub Bot commented on HADOOP-19096: - anujmodi2021 commented on PR #6720: URL:

Re: [PR] HADOOP-19096: [Backport to 3.4][ABFS] [CST Optimization] Enhancing Client-Side Throttling Metrics Updating Logic [hadoop]

2024-04-11 Thread via GitHub
anujmodi2021 commented on PR #6720: URL: https://github.com/apache/hadoop/pull/6720#issuecomment-2049412232 @steveloughran This is good to merge. The test failures here are known and fixed in PR: https://github.com/apache/hadoop/pull/6676 -- This is an automated message from the

[jira] [Commented] (HADOOP-19096) [ABFS] Enhancing Client-Side Throttling Metrics Updation Logic

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836109#comment-17836109 ] ASF GitHub Bot commented on HADOOP-19096: - anujmodi2021 commented on PR #6720: URL:

[jira] [Commented] (HADOOP-19096) [ABFS] Enhancing Client-Side Throttling Metrics Updation Logic

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836108#comment-17836108 ] ASF GitHub Bot commented on HADOOP-19096: - anujmodi2021 opened a new pull request, #6720: URL:

Re: [PR] HADOOP-19096: [Backport to 3.4][ABFS] [CST Optimization] Enhancing Client-Side Throttling Metrics Updating Logic [hadoop]

2024-04-11 Thread via GitHub
anujmodi2021 commented on PR #6720: URL: https://github.com/apache/hadoop/pull/6720#issuecomment-2049411445 -- AGGREGATED TEST RESULT HNS-OAuth

[PR] HADOOP-19096: [Backport to 3.4][ABFS] [CST Optimization] Enhancing Client-Side Throttling Metrics Updating Logic [hadoop]

2024-04-11 Thread via GitHub
anujmodi2021 opened a new pull request, #6720: URL: https://github.com/apache/hadoop/pull/6720 Description of PR Jira: https://issues.apache.org/jira/browse/HADOOP-19096 Commit in trunk: https://github.com/apache/hadoop/commit/dbe2d612586d7b78d61ef64c706eccf7fbf6f35c ABFS has

Re: [PR] HDFS-17458. Remove unnecessary BP lock in ReplicaMap. [hadoop]

2024-04-11 Thread via GitHub
Hexiaoqiao commented on PR #6717: URL: https://github.com/apache/hadoop/pull/6717#issuecomment-2049395174 @hfutatzhanghb Thanks for your works. We should be careful to remove BP lock here. List one of the changes as example, it will return one definite value before this PR because hold RW

Re: [PR] HDFS-17455. Fix Client throw IndexOutOfBoundsException in DFSInputStream#fetchBlockAt [hadoop]

2024-04-11 Thread via GitHub
Hexiaoqiao commented on PR #6710: URL: https://github.com/apache/hadoop/pull/6710#issuecomment-2049353263 Committed to trunk. Thanks @haiyang1987 and @ZanderXu . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HDFS-17455. Fix Client throw IndexOutOfBoundsException in DFSInputStream#fetchBlockAt [hadoop]

2024-04-11 Thread via GitHub
Hexiaoqiao merged PR #6710: URL: https://github.com/apache/hadoop/pull/6710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-11 Thread via GitHub
hadoop-yetus commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2049341199 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836084#comment-17836084 ] ASF GitHub Bot commented on HADOOP-19139: - hadoop-yetus commented on PR #6699: URL:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-11 Thread via GitHub
hadoop-yetus commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2049242814 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836073#comment-17836073 ] ASF GitHub Bot commented on HADOOP-19139: - hadoop-yetus commented on PR #6699: URL:

Re: [PR] HADOOP-19096: [ABFS] [CST Optimization] Enhancing Client-Side Throttling Metrics Updating Logic [hadoop]

2024-04-11 Thread via GitHub
anujmodi2021 commented on PR #6276: URL: https://github.com/apache/hadoop/pull/6276#issuecomment-2049233977 > thanks, in trunk. @anmolanmol1234 can you do a pr and retest for 3.4? I'll rebase my work on this and see how it goes That would be me, not anmol. Will do a retest for 3.4

[jira] [Commented] (HADOOP-19096) [ABFS] Enhancing Client-Side Throttling Metrics Updation Logic

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836071#comment-17836071 ] ASF GitHub Bot commented on HADOOP-19096: - anujmodi2021 commented on PR #6276: URL:

[jira] [Commented] (HADOOP-18656) ABFS: Support for Pagination in Recursive Directory Delete

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836067#comment-17836067 ] ASF GitHub Bot commented on HADOOP-18656: - anujmodi2021 commented on PR #6718: URL:

Re: [PR] HADOOP-18656: [Backport to 3.4] [ABFS] Adding Support for Paginated Delete for Large Directories in HNS Account [hadoop]

2024-04-11 Thread via GitHub
anujmodi2021 commented on PR #6718: URL: https://github.com/apache/hadoop/pull/6718#issuecomment-2049231207 @steveloughran This is good to merge. The test failures here are known and fixed in PR: https://github.com/apache/hadoop/pull/6676 -- This is an automated message from the

[jira] [Commented] (HADOOP-18656) ABFS: Support for Pagination in Recursive Directory Delete

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836069#comment-17836069 ] ASF GitHub Bot commented on HADOOP-18656: - anujmodi2021 commented on PR #6718: URL:

Re: [PR] HADOOP-18656: [Backport to 3.4] [ABFS] Adding Support for Paginated Delete for Large Directories in HNS Account [hadoop]

2024-04-11 Thread via GitHub
anujmodi2021 commented on PR #6718: URL: https://github.com/apache/hadoop/pull/6718#issuecomment-2049229760 -- AGGREGATED TEST RESULT HNS-OAuth

[jira] [Commented] (HADOOP-19079) check that class that is loaded is really an exception

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836064#comment-17836064 ] ASF GitHub Bot commented on HADOOP-19079: - pjfanning commented on code in PR #6557: URL:

Re: [PR] HADOOP-19079. Check class is an exception class before constructing an instance [hadoop]

2024-04-11 Thread via GitHub
pjfanning commented on code in PR #6557: URL: https://github.com/apache/hadoop/pull/6557#discussion_r1560660038 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/LambdaTestUtils.java: ## @@ -823,6 +922,19 @@ public static E verifyCause( } }

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836053#comment-17836053 ] ASF GitHub Bot commented on HADOOP-19139: - hadoop-yetus commented on PR #6699: URL:

  1   2   >