Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) StrictMath.ceil(double)

2009-12-14 Thread Joseph D. Darcy
Hello. Please review my fix for 6908131 Pure Java implementations of StrictMath.floor(double) StrictMath.ceil(double) http://cr.openjdk.java.net/~darcy/6908131.0/ I've asked Doug Priest, one of Sun's numerical experts, to review the floor/ceil algorithm and testing. I've incorporated his

Re: Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) StrictMath.ceil(double)

2009-12-14 Thread Christian Thalinger
On Mon, 2009-12-14 at 01:31 -0800, Joseph D. Darcy wrote: Hello. Please review my fix for 6908131 Pure Java implementations of StrictMath.floor(double) StrictMath.ceil(double) http://cr.openjdk.java.net/~darcy/6908131.0/ I've asked Doug Priest, one of Sun's numerical experts, to

Re: Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) StrictMath.ceil(double)

2009-12-14 Thread Alan Bateman
Joseph D. Darcy wrote: Hello. Please review my fix for 6908131 Pure Java implementations of StrictMath.floor(double) StrictMath.ceil(double) http://cr.openjdk.java.net/~darcy/6908131.0/ I've asked Doug Priest, one of Sun's numerical experts, to review the floor/ceil algorithm and testing.

Re: Review request for 6898747: Allow JNDI cosnaming provider to be used when java.applet is not present

2009-12-14 Thread Alan Bateman
Mandy Chung wrote: The JNDI cosnaming provider currently has a static dependency on java.applet.Applet that is only needed in an applet environment. This fix will allow JNDI cosnaming provider to be used when java.applet is not present. Webrev:

Re: Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) StrictMath.ceil(double)

2009-12-14 Thread Joseph D. Darcy
Christian Thalinger wrote: On Mon, 2009-12-14 at 01:31 -0800, Joseph D. Darcy wrote: Hello. Please review my fix for 6908131 Pure Java implementations of StrictMath.floor(double) StrictMath.ceil(double) http://cr.openjdk.java.net/~darcy/6908131.0/ I've asked Doug Priest, one of Sun's

Re: Review request for 6898747: Allow JNDI cosnaming provider to be used when java.applet is not present

2009-12-14 Thread Mandy Chung
Alan Bateman wrote: Mandy - what is the existing behavior for when the environment property is null or a non-Applet type? I don't know the COS Naming Service Provider but I assume it will throw CCE if the property value is not an Applet. With the proposed change it looks like it will throw an

Re: Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) StrictMath.ceil(double)

2009-12-14 Thread Christian Thalinger
On Mon, 2009-12-14 at 10:16 -0800, Joseph D. Darcy wrote: Not a review, but did you think about implementing the whole FDLIBM in Java, as done here: http://mail.openjdk.java.net/pipermail/hotspot-dev/2009-August/001970.html Yes, porting FDLIBM to Java has been an oft-delayed nice

Re: Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) StrictMath.ceil(double)

2009-12-14 Thread Joseph D. Darcy
Alan Bateman wrote: Joseph D. Darcy wrote: Hello. Please review my fix for 6908131 Pure Java implementations of StrictMath.floor(double) StrictMath.ceil(double) http://cr.openjdk.java.net/~darcy/6908131.0/ I've asked Doug Priest, one of Sun's numerical experts, to review the floor/ceil

Re: Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) StrictMath.ceil(double)

2009-12-14 Thread Dmitry Nadezhin
The current specification of the interesting methods in StrictMath, such as sin/cos, log, etc. are to use the FDLIBM algorithms. Thank you. I forgot about these lines in java.lang.StrictMath . * pTo help ensure portability of Java programs, the definitions of * some of the numeric functions