Hi,
This is a quick fix on a regression caused by 8016648. The new property
manager added to handle the new jaxp 1.5 properties is only created for
the input and event factories. For the output factory therefore, there
should have a null-check. I've run the tests used in the nightly build
On 07/12/2013 01:14 AM, Zhong Yu wrote:
On Thu, Jul 11, 2013 at 4:08 PM, Peter Levart peter.lev...@gmail.com wrote:
Hi Paul,
I think the MayHoldCloseableResource extends AutoClosable is correct and
AutoClosable extends MayHoldCloseableResource would be wrong.
And exactly because of Liskov:
The source changes look fine to me.
The tests should be located elsewhere, otherwise they will collide with an
Oracle internal repo. Say jdk/test/jaxp?
As an aside, I plan to move the jaxws tests to a similar holding area,
jdk/test/jaxws. They can then follow the appropriate package structure.
The fix looks fine to me Joe as does the test. I assume you will go with
Chris's plan below for the test locations?
Best
Lance
On Jul 12, 2013, at 5:44 AM, Chris Hegarty wrote:
The source changes look fine to me.
The tests should be located elsewhere, otherwise they will collide with an
Changeset: 858c75eb83b5
Author:mchung
Date: 2013-07-08 14:05 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/858c75eb83b5
8014890: (ref) Reference queues may return more entries than expected
Summary: When enqueuing references check whether the j.l.r.Reference has
already
Hi,
On Fri, 2013-07-12 at 19:22 +0800, Mandy Chung wrote:
Hi Thomas,
On 7/1/2013 7:51 PM, Thomas Schatzl wrote:
I changed this in
http://cr.openjdk.java.net/~tschatzl/8014890/webrev.refactor to that
version now, using a temporary variable that stores r.queue before the
checks to
On 12/07/2013 6:22 AM, Paul Benedict wrote:
Paul S.'s said the negative of using AutoCloseable is it is no longer
clear whether a stream should be closed or not (6/20). That's true because
the semantics of AutoCloseable indicates you have a resource that requires
closing.
However, the choice to
Hi Thomas,
On 7/1/2013 7:51 PM, Thomas Schatzl wrote:
I changed this in
http://cr.openjdk.java.net/~tschatzl/8014890/webrev.refactor to that
version now, using a temporary variable that stores r.queue before the
checks to avoid the double volatile reads.
This looks good. I have pushed this
The recent 8000450 has caused issue for JCK testing and some RMI/JMX
testing also.The CORBA package interaction between org.omg,
com.sun.corba.se.spi, javax.rmi and other packages into
com.sun.corba.se.impl classes needs better analysis and won't be
complete for 7u40.
It's rare to have
I see closeability as a postcondition. A subtype can't weaken it. The
contract of AutoCloseable says its a resource that must be closed. Now
MHCR says it can/should/doesn't have to be closed -- so it is backwards.
On Fri, Jul 12, 2013 at 6:22 AM, David Holmes david.hol...@oracle.comwrote:
On
Changeset: 5106d43feed7
Author:hannesw
Date: 2013-07-08 19:34 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5106d43feed7
8019963: empty char range in regex
Reviewed-by: jlaskey, sundar
! src/jdk/nashorn/internal/runtime/regexp/joni/CodeRangeBuffer.java
!
On Fri, Jul 12, 2013 at 4:30 AM, Peter Levart peter.lev...@gmail.com wrote:
On 07/12/2013 01:14 AM, Zhong Yu wrote:
On Thu, Jul 11, 2013 at 4:08 PM, Peter Levart peter.lev...@gmail.com
wrote:
Hi Paul,
I think the MayHoldCloseableResource extends AutoClosable is correct and
AutoClosable
On Fri, Jul 12, 2013 at 6:22 AM, David Holmes david.hol...@oracle.com wrote:
On 12/07/2013 6:22 AM, Paul Benedict wrote:
Paul S.'s said the negative of using AutoCloseable is it is no longer
clear whether a stream should be closed or not (6/20). That's true
because
the semantics of
[Also posted on concurrency-interest.]
Thanks to all those sending quick feedback, both on and off lists!
We're increasingly confident about the value of adding
SplittableRandom, so will proceed with integration request. I'm sure
that we'll introduce incremental improvements during OpenJDK8
On 7/12/2013 2:44 AM, Chris Hegarty wrote:
The source changes look fine to me.
The tests should be located elsewhere, otherwise they will collide with an
Oracle internal repo. Say jdk/test/jaxp?
Ah, I accidentally placed them together with those original tests.
There's a place holder for
On 7/12/2013 3:30 AM, Lance Andersen - Oracle wrote:
The fix looks fine to me Joe as does the test. I assume you will go with
Chris's plan below for the test locations?
It will be jdk/test/javax/xml/jaxp, that is the location for all jaxp
tests for now. We will look into migrating jaxp
Hi,
Thanks Doug.
Here is the webrev:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8020292-splittable-random/webrev/
Paul.
On Jul 12, 2013, at 7:07 PM, Doug Lea d...@cs.oswego.edu wrote:
[Also posted on concurrency-interest.]
Thanks to all those sending quick feedback, both on and off
The whole reflection thing is a red herring. As is the performance thing.
The reason not to call close() has nothing to do with the expensive of
calling close; it is about not mucking up your code for no reason.
Consider:
list.stream()
.filter(s - s.startsWith(foo))
Hi
Please help review the update for the JSR310 DateTime API updates IV
http://cr.openjdk.java.net/~sherman/8016025/webrev/
Here is the summary of the updates included in this round of API update:
- Remove type parameter from ChronoLocalDate as unnecessary to
simplify API and usage
-
On Jul 12, 2013, at 7:26 PM, Paul Sandoz paul.san...@oracle.com wrote:
Hi,
Thanks Doug.
Here is the webrev:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8020292-splittable-random/webrev/
In my haste i forgot to mention this patch is based off:
On 12 Jul 2013, at 18:09, huizhe wang huizhe.w...@oracle.com wrote:
On 7/12/2013 3:30 AM, Lance Andersen - Oracle wrote:
The fix looks fine to me Joe as does the test. I assume you will go with
Chris's plan below for the test locations?
It will be jdk/test/javax/xml/jaxp, that is the
Thanks Chris!
On 7/12/2013 10:59 AM, Chris Hegarty wrote:
On 12 Jul 2013, at 18:09, huizhe wang huizhe.w...@oracle.com wrote:
On 7/12/2013 3:30 AM, Lance Andersen - Oracle wrote:
The fix looks fine to me Joe as does the test. I assume you will go with
Chris's plan below for the test
The ? extends Optional is unnecessary in flatMap as Optional is final.
Otherwise this looks good.
Mike
On Jul 5 2013, at 14:37 , Henry Jen wrote:
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8015317.0/webrev/
Which adds following method to Optional,
Changeset: aabe15fc346f
Author:joehw
Date: 2013-07-12 11:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/aabe15fc346f
8020430: NullPointerException in xml sqe nightly result on 2013-07-12
Reviewed-by: chegar, lancea
!
Changeset: 2504f01bc83f
Author:joehw
Date: 2013-07-12 11:14 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2504f01bc83f
8020430: NullPointerException in xml sqe nightly result on 2013-07-12
Reviewed-by: chegar, lancea
+ test/javax/xml/jaxp/common/8020430/JAXP15RegTest.java
Looks good and I agree that the issues mentioned in Paul's response can be
addressed in follow-on issues.
Mike
On Jul 4 2013, at 00:31 , Henry Jen wrote:
Hi,
I updated the test, and split the ConcatTest.java so we don't encounter
the ClassNotFoundException issue on test-ng.
Please
Changeset: af62c6175f92
Author:darcy
Date: 2013-07-12 11:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af62c6175f92
8010679: Clarify present and annotation ordering in Core Reflection for
Annotations
Reviewed-by: abuckley, jfranck
!
Changeset: be096613bfb5
Author:psandoz
Date: 2013-07-03 21:43 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/be096613bfb5
8019395: Consolidate StreamSupport.{stream,parallelStream} into a single method
Reviewed-by: henryjen, briangoetz
!
Changeset: b3ca5fb77e2c
Author:vinnie
Date: 2013-07-12 20:44 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b3ca5fb77e2c
8019627: RuntimeException gets obscured during OCSP cert revocation checking
Reviewed-by: mullan
!
Changeset: fe6e4e2c367d
Author:mduigou
Date: 2013-07-12 11:11 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe6e4e2c367d
7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}
Reviewed-by: dmocek, martin, smarks
!
On 07/12/13 14:29, Mike Duigou wrote:
Most specifically, do we want to commit to a seeded version promising a
deterministic sequence that would preclude future changes
Thanks, this a good spec clarification question, about the scope of:
* Creates a new SplittableRandom instance using
On 7/12/2013 9:14 PM, Seán Coffey wrote:
The recent 8000450 has caused issue for JCK testing and some RMI/JMX
testing also.The CORBA package interaction between org.omg,
com.sun.corba.se.spi, javax.rmi and other packages into
com.sun.corba.se.impl classes needs better analysis and won't be
Looks good to me as well.
Mike
On Jul 9 2013, at 17:14 , Henry Jen wrote:
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8020062/0/webrev/index.html
This webrev does as the bug suggested, is a refactoring that moves
StreamBuilder interfaces implementations
Looks good (with Paul's @implNote change).
Mike
On Jul 9 2013, at 15:52 , Henry Jen wrote:
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8015320.0/webrev/
This allows turning an Iterable into a stream with spliterator() methods
if the implementation
Changeset: 9b17939958e7
Author:henryjen
Date: 2013-07-12 15:01 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9b17939958e7
8015320: Pull spliterator() up from Collection to Iterable
Reviewed-by: psandoz, mduigou
Contributed-by: brian.go...@oracle.com
!
FWIW, I really like the idea of migrating the jaxp tests to the jaxp repo.
I've always thought it odd that the code change and the test for it aren't in
the same changeset.
Thanks,
iris
-Original Message-
From: huizhe wang
Sent: Friday, July 12, 2013 10:10 AM
To: Lance Andersen -
Changeset: 5f2a8db78aca
Author:weijun
Date: 2013-07-13 08:47 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5f2a8db78aca
8019410: sun/security/krb5/auto/ReplayCacheTestProc.java
Reviewed-by: mullan
! test/sun/security/krb5/auto/ReplayCacheTestProc.java
37 matches
Mail list logo
