Re: RFR (JAXP): 8033980 : Xerces Update: datatype XMLGregorianCalendarImpl and DurationImpl

2014-02-13 Thread huizhe wang
Hi Alan, Lance, and Daniel, The Xerces serialization revision meant to create a serialization form that would help maintain future serialization compatibility. But in reality it itself is causing significant incompatibility as Alan pointed out below and we discussed previously. I've removed

Re: RFR: JDK-8032050: TEST_BUG: java/rmi/activation/Activatable/shutdownGracefully/ShutdownGracefully.java fails intermittently

2014-02-13 Thread Tristan Yan
Thank you Stuart I have fixed comment in JavaVM.java. Dealing with different cases in ShutdownGracefully.java, two variables were added. One is a flag indicate test passed or not. Other variable keeps the error message when test failed. I put TestLibrary.bomb in the bottom of the main method

Re: RFR (S): JDK-8034000 lack of /othervm option can cause some RMI tests to fail

2014-02-13 Thread Alan Bateman
On 13/02/2014 07:08, Stuart Marks wrote: Webrev: http://cr.openjdk.java.net/~smarks/reviews/8034000/webrev.0/ Looks good to me too. -Alan

Fwd: Re: Fwd: Improve large array allocation / gc intrinsics

2014-02-13 Thread Laurent Bourgès
Comments opinions from core-libs, please ? Laurent -- Message transféré -- De : Thomas Schatzl thomas.scha...@oracle.com Date : 11 févr. 2014 11:28 Objet : Re: Fwd: Improve large array allocation / gc intrinsics À : Laurent Bourgès bourges.laur...@gmail.com Cc :

Re: RFR (JAXP): 8033980 : Xerces Update: datatype XMLGregorianCalendarImpl and DurationImpl

2014-02-13 Thread Daniel Fuchs
Hi Joe, Couldn't all the new orig_* fields in XMLGregorianCalendarImpl be made transient? It looks as if they shouldn't be serialized anyway. Should they? Not making them transient would change the serialization form, and I'm not sure where that would take us... best regards, -- daniel On

Re: JEP 187: Serialization 2.0

2014-02-13 Thread Florian Weimer
On 01/23/2014 03:30 PM, Chris Hegarty wrote: On 22 Jan 2014, at 15:14, Florian Weimer fwei...@redhat.com wrote: On 01/22/2014 03:47 PM, Chris Hegarty wrote: On 22/01/14 13:57, Florian Weimer wrote: On 01/14/2014 01:26 AM, mark.reinh...@oracle.com wrote: Posted:

Re: RFR for JDK-8031563: TEST_BUG: java/nio/channels/Selector/ChangingInterests.java failed once

2014-02-13 Thread Alan Bateman
On 12/02/2014 13:34, michael cui wrote: : Comments from Shura : I have concern about two areas which might make your version and original version not equivalent. one is code changes in verification logic are different. the other is old version called selectNow()

Re: RFR (JAXP): 8033980 : Xerces Update: datatype XMLGregorianCalendarImpl and DurationImpl

2014-02-13 Thread Alan Bateman
On 13/02/2014 08:18, huizhe wang wrote: Hi Alan, Lance, and Daniel, The Xerces serialization revision meant to create a serialization form that would help maintain future serialization compatibility. But in reality it itself is causing significant incompatibility as Alan pointed out below

Re: A hole in the serialization spec

2014-02-13 Thread Chris Hegarty
On 12 Feb 2014, at 15:24, David M. Lloyd david.ll...@redhat.com wrote: That's a quote from the serialization spec. I take it to mean, Don't write fields and everything might go to hell. In practice, if the reading side doesn't read fields, things end up more or less OK, as evidenced by

Re: A hole in the serialization spec

2014-02-13 Thread David M. Lloyd
On 02/13/2014 10:29 AM, Chris Hegarty wrote: On 12 Feb 2014, at 15:24, David M. Lloyd david.ll...@redhat.com wrote: That's a quote from the serialization spec. I take it to mean, Don't write fields and everything might go to hell. In practice, if the reading side doesn't read fields, things

Re: RFR: 7152892: some jtreg tests fail with permission denied

2014-02-13 Thread Rob McKenna
Sorry Mandy, I totally missed your reply. I'll get this resolved separately. -Rob On 10/02/14 15:43, Mandy Chung wrote: On 2/7/2014 10:44 AM, Rob McKenna wrote: Hi folks, When files are copied by our test harness the permissions are left unchanged. This can cause trouble for a few

Re: RFR: 7152892: some jtreg tests fail with permission denied

2014-02-13 Thread Mandy Chung
On 2/13/14 9:54 AM, Rob McKenna wrote: Sorry Mandy, I totally missed your reply. I'll get this resolved separately. No worries. It's fine to do it separately. Mandy -Rob On 10/02/14 15:43, Mandy Chung wrote: On 2/7/2014 10:44 AM, Rob McKenna wrote: Hi folks, When files are copied by

RFR 8034896, clean up typo in Clob.free

2014-02-13 Thread Lance Andersen
Hi all, Need a reviewer for this trivial change to remove the redundant the resources from Clob.free. I will be going through all of the java[x]/sql classes at a later time to clean up the use of code/code so I did not touch for now. Best Lance hg diff diff -r 4711a64b6a13

Re: RFR 8034896, clean up typo in Clob.free

2014-02-13 Thread Daniel Fuchs
Hi Lance, Looks good, -- daniel On 2/13/14 8:59 PM, Lance Andersen wrote: Hi all, Need a reviewer for this trivial change to remove the redundant the resources from Clob.free. I will be going through all of the java[x]/sql classes at a later time to clean up the use of code/code so I did

RFR 9: 8034903: Add Logging of Process.start arguments and resulting pid

2014-02-13 Thread roger riggs
Hi, Having folks stumbling over process creation and problems of quoting, especially on windows, it seems useful to log the native commands and arguments. They are proposed to be logged using the PlatformLogger at Level.FINE which will not be logged by default. The environment is useful in

Re: RFR 9: 8034903: Add Logging of Process.start arguments and resulting pid

2014-02-13 Thread Paul Benedict
Roger, I only have two suggested improvements: 1) solaris/../ProcessImpl.java should use Objects.toString() rather than the tenary operator for a string choice. You did this alright in /windows/../ProcessImpl.java 2) /windows/../ProcessImpl.java doesn't need to specify null for

Re: RFR: (8031737) CHECK_NULL and CHECK_EXCEPTION macros cleanup

2014-02-13 Thread Phil Race
That worked on Mac but I just found it doesn't build on Linux because a macro-redefinition warning is treated as an error there. https://bugs.openjdk.java.net/browse/JDK-8034912 The early/original fix had removed the duplicate definition in src/share/native/java/net/net_util.h So the fix is

Re: RFR (S): JDK-8034000 lack of /othervm option can cause some RMI tests to fail

2014-02-13 Thread Stuart Marks
Thanks guys. And Joe, you know that I *always* look good! :-) s'marks On 2/12/14 11:31 PM, Joe Darcy wrote: Look good Stuart, -Joe On 02/12/2014 11:08 PM, Stuart Marks wrote: Hi all, The RMI test directories were removed from TEST.ROOT's othervm.dirs by JDK-8031179 so that individual RMI

Re: RFR for JDK-8030844:sun/rmi/rmic/classpath/RMICClassPathTest.java timeout in same binaries run

2014-02-13 Thread Stuart Marks
Great, pushed: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/2cecdf7fbc90 Having the full changeset in the webrev was quite convenient. I was able to hg import it directly. s'marks On 2/12/14 7:21 PM, Tristan Yan wrote: Thank you Stuart This is a very nice tutorial. I did try both ways.

Re: RFR: (8031737) CHECK_NULL and CHECK_EXCEPTION macros cleanup

2014-02-13 Thread Roger Riggs
Hi Phil, There was an earlier commit that updated java.net 8030875: Macros for checking and returning on exceptions Maybe it will apply as a backport too? Roger On 2/13/14 4:50 PM, Phil Race wrote: That worked on Mac but I just found it doesn't build on Linux because a

Re: RFR: (8031737) CHECK_NULL and CHECK_EXCEPTION macros cleanup

2014-02-13 Thread Mandy Chung
Looks good. Sorry I didn't catch this earlier and I was counting on the test build :) Mandy [1] http://hg.openjdk.java.net/jdk9/dev/jdk/rev/c58c6b0fbe34 On 2/13/2014 1:50 PM, Phil Race wrote: That worked on Mac but I just found it doesn't build on Linux because a macro-redefinition

Re: RFR: (8031737) CHECK_NULL and CHECK_EXCEPTION macros cleanup

2014-02-13 Thread Phil Race
I did look closely at that today. It has 3 parts - removing the ones in net_util - moving these macros to jni_util - however these new versions are already superseded by the ones we have, so we can' t apply that. - updating some 'pack' code to use the new macros instead of its own ones (no

Re: RFR: (8031737) CHECK_NULL and CHECK_EXCEPTION macros cleanup

2014-02-13 Thread Phil Race
Yeah sorry about that. It built on Windows and Mac but not Linux as i found out today. -phil. On 2/13/14 5:36 PM, Mandy Chung wrote: Looks good. Sorry I didn't catch this earlier and I was counting on the test build :) Mandy [1] http://hg.openjdk.java.net/jdk9/dev/jdk/rev/c58c6b0fbe34 On