Re: Review request 8153895 (proxy) redundant read edges to superinterfaces of proxy interfaces

+1 -Sundar On 4/13/2016 9:24 AM, Mandy Chung wrote: > Updated webrev to skip the static methods: >http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8153895/webrev.01/ > > Mandy

Re: Review request 8153895 (proxy) redundant read edges to superinterfaces of proxy interfaces

Updated webrev to skip the static methods: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8153895/webrev.01/ Mandy

JDK 9 RFR of JDK-4851642: Add fused mac to Java math library

Hello, Please review the changes for JDK-4851642: Add fused mac to Java math library http://cr.openjdk.java.net/~darcy/4851642.0/ Fused mac (multiply-accumulate) is a ternary floating-point operation which accepts three inputs, a, b, c, and computes a * b + c with a single

Re: Review request 8153912: StackFrame::getFileName and StackFrame::getLineNumber not needed

> On Apr 12, 2016, at 1:34 AM, Rémi Forax wrote: > > Hi Mandy, > I really don't like this patch. > > Being forced to call toStackElement to get the line number is counter > intuitive. > I would prefer the two methods to not return Optional but an int and a String > with

Re: Review request 8153895 (proxy) redundant read edges to superinterfaces of proxy interfaces

> On Apr 12, 2016, at 6:16 AM, Peter Levart wrote: > > Hi Mandy, > > There's another redundant validation and read edge addition I think. When > deriving referenced types from methods of interfaces, static methods could be > skipped as they are not implemented or

Re: RFR JDK 9 (JAXP) 8151162: Public entries not searched when prefer='system'

Thanks Lance! On 4/12/2016 12:28 PM, Lance Andersen wrote: Looks OK Joe. Best Lance On Apr 8, 2016, at 4:49 PM, huizhe wang > wrote: Hi, Please review a fix for the issue that caused public entries not being searched when

Re: RFR: JDK-8153781 Issue in XMLScanner: EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET when skipping large DOCTYPE section with CRLF at wrong place

On 4/12/2016 11:50 AM, Langer, Christoph wrote: Hi Joe, thanks as always for your suggestions and I'll try to work it in. It will probably take me a little while as I'm currently busy with another thing. I'll update my webrev eventually and add a testcase, too. Ok. But one question: I

Re: RFR: 8153293 - Stream API: Preserve SORTED and DISTINCT characteristics for boxed() and asLongStream() operations

Hi Tagir, thanks! Looks fine to me now - especially the new testSortDistinct() methods. But note: I'm only a participant, not a reviewer of any sort. Thanks, Stefan 2016-04-12 18:37 GMT+02:00 Tagir F. Valeev : > Hello! > > Thank you, Stefan and Paul for review. Here's

Re: RFR JDK 9 (JAXP) 8151162: Public entries not searched when prefer='system'

Looks OK Joe. Best Lance > On Apr 8, 2016, at 4:49 PM, huizhe wang wrote: > > Hi, > > Please review a fix for the issue that caused public entries not being > searched when prefer='system'. When prefer='system', the Catalog standard > only required that public entries

Re: RFR: 8154067: Avoid early use of limited privilege escalation in InnerClassLambdaMetafactory

Mandy, Sean, Alan, Brian, thanks for reviewing this! /Claes On 2016-04-12 20:29, Brian Goetz wrote: No problem with this change. +1. On Apr 12, 2016, at 8:38 AM, Claes Redestad wrote: Hi, the first usage of limited doPrivileged appears to have a small startup

RE: RFR: JDK-8153781 Issue in XMLScanner: EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET when skipping large DOCTYPE section with CRLF at wrong place

Hi Joe, thanks as always for your suggestions and I'll try to work it in. It will probably take me a little while as I'm currently busy with another thing. I'll update my webrev eventually and add a testcase, too. But one question: I understand that the fix in skipDTD will be sufficient to

Re: RFR: 8154067: Avoid early use of limited privilege escalation in InnerClassLambdaMetafactory

No problem with this change. +1. > On Apr 12, 2016, at 8:38 AM, Claes Redestad wrote: > > Hi, > > the first usage of limited doPrivileged appears to have a small startup > penalty (loads 8 permission-related classes and does some reflection), and is > arguably

Re: RFR: 8154067: Avoid early use of limited privilege escalation in InnerClassLambdaMetafactory

On 04/12/2016 12:58 PM, Mandy Chung wrote: On Apr 12, 2016, at 5:38 AM, Claes Redestad wrote: Hi, the first usage of limited doPrivileged appears to have a small startup penalty (loads 8 permission-related classes and does some reflection), and is arguably

Re: RFR: JDK-8153781 Issue in XMLScanner: EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET when skipping large DOCTYPE section with CRLF at wrong place

Also, EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET was a wrong msg id. It would be good to change that to DoctypedeclNotClosed and add a message to XMLMessages.properties right before DoctypedeclUnterminated, sth. like the following: DoctypedeclNotClosed = The document type declaration

Re: RFR: 8154067: Avoid early use of limited privilege escalation in InnerClassLambdaMetafactory

> On Apr 12, 2016, at 5:38 AM, Claes Redestad wrote: > > Hi, > > the first usage of limited doPrivileged appears to have a small startup > penalty (loads 8 permission-related classes and does some reflection), and is > arguably excessive for this particular

Re: RFR: 8153293 - Stream API: Preserve SORTED and DISTINCT characteristics for boxed() and asLongStream() operations

Hello! Thank you, Stefan and Paul for review. Here's updated webrev: http://cr.openjdk.java.net/~tvaleev/webrev/8153293/r2/ Changes: - all new mapToObj are private and not final - IntStream.asDoubleStream preserves distinct now - Tests fixed according to Stefan's suggestions - Additional tests

Request for comments -- resource reification vs. mrjar scheme for runtime versioning of multi-release jar files

We’ve identified two possible ways to address issue JDK-8151542. One way is to append a #runtime fragment to the input URL in URLClassPath to convey to URLJarFile that we want to have the JarFile opened with the parameter Release.RUNTIME, so

Re: RFR: 8153334: Replace BufferedInputStreams use of AtomicReferenceFieldUpdater with Unsafe

> On 6 Apr 2016, at 16:45, Claes Redestad wrote: > > On 04/06/2016 04:09 PM, Paul Sandoz wrote: >>> small streams become big rivers (i don't know the idiomatic sentence in >>> English, so it's a rough translation from a French idiom), >>> "Death by a thousand cuts"

Re: RFR: 8153334: Replace BufferedInputStreams use of AtomicReferenceFieldUpdater with Unsafe

> On 6 Apr 2016, at 16:52, Vitaly Davidovich wrote: > > So are there any bootstrap issues with VH that would preclude using it in > BufferedInputStream? FWIW I did a quick perf experiment a while ago modifying A*FU to use VHs underneath and the VM booted just fine. > Is

Re: Review request 8153895 (proxy) redundant read edges to superinterfaces of proxy interfaces

Mandy, On 04/12/2016 03:16 PM, Peter Levart wrote: The problem is of course with the setup procedure of the dynamic module where you have to add exports from modules/packages of those referenced types and read edges to modules of those references types upfront. But this problem is resolvable.

Re: RFR [9] 8150829: Enhanced drop-args, identity and default constant, varargs adjustment

Hi, Just minor comments, below. Paul. MethodHandle — 972 /** 973 * Adapts this method handle to be {@linkplain #asVarargsCollector variable arity} 974 * if the boolean flag is true, else {@linkplain #asFixedArity fixed arity}. 975 * If the method handle is already

Re: RFR: 8154067: Avoid early use of limited privilege escalation in InnerClassLambdaMetafactory

On 12/04/2016 13:38, Claes Redestad wrote: Hi, the first usage of limited doPrivileged appears to have a small startup penalty (loads 8 permission-related classes and does some reflection), and is arguably excessive for this particular instance. Unrestricted doPrivileged allows for a small

Re: Review request 8153895 (proxy) redundant read edges to superinterfaces of proxy interfaces

Hi Mandy, There's another redundant validation and read edge addition I think. When deriving referenced types from methods of interfaces, static methods could be skipped as they are not implemented or overridden by Proxy class:

RFR: 8154067: Avoid early use of limited privilege escalation in InnerClassLambdaMetafactory

Hi, the first usage of limited doPrivileged appears to have a small startup penalty (loads 8 permission-related classes and does some reflection), and is arguably excessive for this particular instance. Unrestricted doPrivileged allows for a small reduction of lambda init cost. Webrev:

Re: Review request 8153895 (proxy) redundant read edges to superinterfaces of proxy interfaces

Hi Mandy, This is OK, but the whole loop could be simplified. No need for Dequeue any more: // set up proxy class access to proxy interfaces Set visited = new HashSet<>(interfaces); for (Class c : visited) { ensureAccess(target, c);

Re: RFR: 8153213: Jar manifest attribute "Multi-Release" accepts any value

> On 12 Apr 2016, at 10:18, Claes Redestad wrote: > > Hi Steve, > > On 2016-04-11 23:21, Steve Drach wrote: >> Hi, >> >> I’ve updated the following patch, incorporating code by Claes Redestad to >> handle some corner cases while processing the attribute value.

RE: RFR: 8151876: (tz) Support tzdata2016c

Hi Roger, I don't think this is covered in any alternate tests, because this Displayname format is newly introduced with tzdata2016b for the newly added TimeZones. Anyway, I will double check on this to see if any test already covers this scenario otherwise I will update or add a new test case

Re: Review request 8153912: StackFrame::getFileName and StackFrame::getLineNumber not needed

Hi Mandy, I really don't like this patch. Being forced to call toStackElement to get the line number is counter intuitive. I would prefer the two methods to not return Optional but an int and a String with the same convention as StackElement if the point of this patch is to remove the

Re: RFR: 8153213: Jar manifest attribute "Multi-Release" accepts any value

Hi Steve, On 2016-04-11 23:21, Steve Drach wrote: Hi, I’ve updated the following patch, incorporating code by Claes Redestad to handle some corner cases while processing the attribute value. Note that we’ve limited the location of the value part of the attribute to accommodate startup

Re: Review request 8153895 (proxy) redundant read edges to superinterfaces of proxy interfaces

Looks ok Mandy. -Chris. On 12 Apr 2016, at 00:45, Mandy Chung wrote: > Peter spots the redundant read edges are added to dynamic module when > creating a proxy class. Proxy class does not access super interfaces of > proxy interfaces. I have verified this simple