Re: RFR 8159821 "PrimitiveStream.iterateFinite" methods contain incorrect code sample

+1. Good catch. > On Jun 17, 2016, at 12:48 PM, Paul Sandoz wrote: > > Hi, > > Please review minor corrections to the JavaDoc of the finite (predicate > accepting) iterate methods of Int/Long/DoubleStream. > > Thanks, > Paul. > > diff -r 6e55599ce242 >

RFR 8159821 "PrimitiveStream.iterateFinite" methods contain incorrect code sample

Hi, Please review minor corrections to the JavaDoc of the finite (predicate accepting) iterate methods of Int/Long/DoubleStream. Thanks, Paul. diff -r 6e55599ce242 src/java.base/share/classes/java/util/stream/DoubleStream.java ---

Re: RFR 9: 8155808: Process.getInputStream().skip() method is faulty

Hi Pavel, @Override added. Thanks, Roger On 6/17/2016 9:57 AM, Pavel Rappo wrote: Roger, On 17 Jun 2016, at 14:14, Roger Riggs wrote: Subclassing is the normal (one) way to override/augment behavior of an existing class. And I was looking for a minimal change

Re: RFR 9: 8155808: Process.getInputStream().skip() method is faulty

Hi Daniel, Webrev updated in place. http://cr.openjdk.java.net/~rriggs/webrev-skip-8155808/index.html On 6/17/2016 9:41 AM, Daniel Fuchs wrote: Hi Roger, Should PipeInputStream be final? It is extended by DeferredCloseInputStream, used on Solaris, and is private to the implementation so

Re: Review Request: JDK-8159524 jdeps -jdkinternals throws NPE when no replacement is known

Hi Mandy, JdepsTask.java: 616 .filter(e -> e.getValue() != null) is this still needed? I thought the use of optional at line 602 already filtered out the null values. 617 .sorted(Map.Entry.comparingByKey()) I believe you could get rid of

Re: RFR 9: 8155808: Process.getInputStream().skip() method is faulty

Hi Pavel, On 6/17/2016 5:03 AM, Pavel Rappo wrote: Hi Roger, Do we need PipeInputStream to be a java.io.FileInputStream? Can we get away with it being an InputStream? If so, then we could use a simple delegation which would allow us to avoid code duplication (the implementation of `skip` is

Re: RFR: 8159590: Remove deprecated methods from jdk.internal.misc.VM

On 2016-06-17 03:35, David Holmes wrote: Hi Claes, On 17/06/2016 8:20 AM, Claes Redestad wrote: Isn't this variable unused now: 63 boolean vmAllowSuspension; Interestingly enough there are hooks in hotspot to compute offsets of various fields in j.l.ThreadGroup, so even though the

RE: RFR: 8153955: java.util.logging.FileHandler can not create file synchronously over 101 access

Hi All, Gentle reminder... Regards, Ramanand. -Original Message- From: Ramanand Patil Sent: Tuesday, June 14, 2016 9:51 PM To: Daniel Fuchs; Bernd Eckenfels; core-libs-dev@openjdk.java.net Subject: RE: RFR: 8153955: java.util.logging.FileHandler can not create file synchronously over

Re: RFR of JDK-8159785: Add test that tests ClassLoader.getResource/getResources in Multi-Release Jar

On 17/06/2016 08:38, Hamlin Li wrote: Would you please review the following patch? bug: https://bugs.openjdk.java.net/browse/JDK-8159785 webrev: http://cr.openjdk.java.net/~mli/8159785/webrev.00/ JDK-8151542 fixed bugs and added test to

RFR of JDK-8159785: Add test that tests ClassLoader.getResource/getResources in Multi-Release Jar

Would you please review the following patch? bug: https://bugs.openjdk.java.net/browse/JDK-8159785 webrev: http://cr.openjdk.java.net/~mli/8159785/webrev.00/ JDK-8151542 fixed bugs and added test to verify Class.getResource works as expected,