Collectors.toSet() small performance improvement

2016-08-08 Thread Tagir F. Valeev
Hello! I'd like to propose a simple performance patch for Collectors.toSet(): --- a/src/java.base/share/classes/java/util/stream/Collectors.java Tue Aug 02 07:19:06 2016 +0530 +++ b/src/java.base/share/classes/java/util/stream/Collectors.java Tue Aug 09 11:47:20 2016 +0700 @@ -295,7

Re: RFR: 8156500: deadlock provoked by new stress test com/sun/jdi/OomDebugTest.java

2016-08-08 Thread Kim Barrett
> On Aug 8, 2016, at 8:16 AM, Per Liden wrote: > > Hi Kim, > > On 2016-08-01 20:47, Kim Barrett wrote: >> This updated webrev addresses concerns about the performance of the VM >> API used by the reference processor thread in the original webrev. >> >> New webrevs: >>

Re: RFE to re-purpose option --version:

2016-08-08 Thread Kumar Srinivasan
Hello Paul, There is a light weight method to get the version from the launcher, "-fullversion" noting that, this does not invoke the VM, and obtains the version string set at build time in the launcher itself. However you would have to exec java twice, once to get the version, another to

Re: RFR (XS): 8162815: unnecessary object creation in reflection

2016-08-08 Thread Paul Sandoz
> On 4 Aug 2016, at 12:02, Claes Redestad wrote: > > Hi, > > I'd like to sponsor this bug fix provided by Tomáš Hůrka to remove a new and > dup left behind in generated accessor methods after moving these to use > appropriate valueOf methods for boxing primitive

Re: RFR: JDK-8161230 - Create java.util.stream.Stream from Iterator / Enumeration

2016-08-08 Thread Patrick Reinhart
> Am 08.08.2016 um 18:55 schrieb Alan Bateman : > > On 08/08/2016 17:29, Patrick Reinhart wrote: > >> : >> I tried to integrate your suggested changes here: >> http://cr.openjdk.java.net/~reinhapa/reviews/8161230/ClassLoader_StreamMethods.01 >> > I should have been

Re: What's correct: "--modulepath" or "--module-path"?

2016-08-08 Thread Alan Bateman
On 08/08/2016 18:17, Volker Simonis wrote: Hi, currently (in jdk9/dev), tools like jlink/jmod support only "--modulepath" but not "--module-path". But notice that they support "--class-path" and "--module-version". As far as I can see, JEP 293: Guidelines for JDK Command-Line Tool Options [1]

NIO Path enhancements?

2016-08-08 Thread Stephen Colebourne
I've been using the java.nio.file.Path API in the last few days and have found it a little tricky to use. I'd like to understand if the following ideas were ever considered (to consider whether an issue should be raised). Currently, developers create a Path instance and it contains various

What's correct: "--modulepath" or "--module-path"?

2016-08-08 Thread Volker Simonis
Hi, currently (in jdk9/dev), tools like jlink/jmod support only "--modulepath" but not "--module-path". But notice that they support "--class-path" and "--module-version". As far as I can see, JEP 293: Guidelines for JDK Command-Line Tool Options [1] recommends "--module-path". Also, the current

Re: RFR: JDK-8161230 - Create java.util.stream.Stream from Iterator / Enumeration

2016-08-08 Thread Alan Bateman
On 08/08/2016 17:29, Patrick Reinhart wrote: : I tried to integrate your suggested changes here: http://cr.openjdk.java.net/~reinhapa/reviews/8161230/ClassLoader_StreamMethods.01 I should have been clearer. A lazy implementation of resources/systemResources methods won't throw any exceptions,

Re: Executors enhancement

2016-08-08 Thread Andrew Thompson
Christian, A number of years ago I put together two small libraries to provide access to Apple's Grand Central Dispatch from Java. My thought was precisely to play nicely with the host operating system, power management etc. I've often thought something similar to fork-join's common pool that

Re: RFR: JDK-8161230 - Create java.util.stream.Stream from Iterator / Enumeration

2016-08-08 Thread Patrick Reinhart
On 05.08.2016 06:18, Alan Bateman wrote: > On 04/08/2016 10:33, Patrick Reinhart wrote: > >> I was quit busy lately and this comes a bit late, I guess you do not >> have less work ;-) >> >> On 15.07.2016 17:10, Paul Sandoz wrote: When I understand you correctly here we should concentrate on

RFE to re-purpose option --version:

2016-08-08 Thread Paul Benedict
Dear Committers, In Java 9, the --version: has been deprecated. The error message returned to me is: Error: Specifying an alternate JDK/JRE version is no longer supported. The use of the flag '-version:' is no longer valid. Please download and execute the appropriate version. Unrecognized

Re: RFR: 8163369: Enable generating DMH classes at link time

2016-08-08 Thread Aleksey Shipilev
On 08/08/2016 04:18 PM, Claes Redestad wrote: > http://cr.openjdk.java.net/~redestad/8163369/webrev.02/ Looks good. -Aleksey

Re: RFR: 8163369: Enable generating DMH classes at link time

2016-08-08 Thread Claes Redestad
On 2016-08-08 14:28, Aleksey Shipilev wrote: On 08/08/2016 02:46 PM, Claes Redestad wrote: Hi, please review this change to add the ability to generate DirectMethodHandles to the --generate-jli-classes jlink plugin. The implementation generates all the specified DMHs as methods into a single

Re: RFR: 8163369: Enable generating DMH classes at link time

2016-08-08 Thread Aleksey Shipilev
On 08/08/2016 02:46 PM, Claes Redestad wrote: > Hi, > > please review this change to add the ability to generate > DirectMethodHandles to the --generate-jli-classes jlink plugin. > > The implementation generates all the specified DMHs as methods into a > single class,

Re: RFR: 8156500: deadlock provoked by new stress test com/sun/jdi/OomDebugTest.java

2016-08-08 Thread Per Liden
Hi Kim, On 2016-08-01 20:47, Kim Barrett wrote: This updated webrev addresses concerns about the performance of the VM API used by the reference processor thread in the original webrev. New webrevs: full: http://cr.openjdk.java.net/~kbarrett/8156500/jdk.03/

RFR: 8163369: Enable generating DMH classes at link time

2016-08-08 Thread Claes Redestad
Hi, please review this change to add the ability to generate DirectMethodHandles to the --generate-jli-classes jlink plugin. The implementation generates all the specified DMHs as methods into a single class, java.lang.invoke.DirectMethodHandle$DMH. At runtime when a DMH's LF is set up, we

RE: RFR (JAXP) JDK-8067170: Enable security manager on JAXP unit tests

2016-08-08 Thread Frank Yuan
Thank you! I pushed the change into jaxp repo. Frank > -Original Message- > From: Joe Wang [mailto:huizhe.w...@oracle.com] > Sent: Saturday, August 06, 2016 1:59 AM > To: Frank Yuan > Cc: 'Daniel Fuchs'; 'core-libs-dev' > Subject: Re: RFR (JAXP) JDK-8067170: Enable security manager on