Re: RFR of JDK 8168505: Remove the intermittent keyword from java/util/Arrays/ParallelPrefix.java

Reviewed! On Mon, Oct 24, 2016 at 6:22 PM, Hamlin Li wrote: > bug: https://bugs.openjdk.java.net/browse/JDK-8168505 > > webrev: http://cr.openjdk.java.net/~mli/8168505/webrev.00/ > > Test ( java/util/Arrays/ParallelPrefix.java) was failing intermittently, > related bug

Re: RFR of JDK 8168505: Remove the intermittent keyword from java/util/Arrays/ParallelPrefix.java

+1 (Official reviewer :-) -Joe On 10/24/2016 6:31 PM, Amy Lu wrote: Looks fine. (I'm not an official reviewer.) Thanks, Amy On 10/25/16 9:22 AM, Hamlin Li wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8168505 webrev: http://cr.openjdk.java.net/~mli/8168505/webrev.00/ Test (

Re: RFR of JDK 8168505: Remove the intermittent keyword from java/util/Arrays/ParallelPrefix.java

Looks fine. (I'm not an official reviewer.) Thanks, Amy On 10/25/16 9:22 AM, Hamlin Li wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8168505 webrev: http://cr.openjdk.java.net/~mli/8168505/webrev.00/ Test ( java/util/Arrays/ParallelPrefix.java) was failing intermittently, related

RFR of JDK 8168505: Remove the intermittent keyword from java/util/Arrays/ParallelPrefix.java

bug: https://bugs.openjdk.java.net/browse/JDK-8168505 webrev: http://cr.openjdk.java.net/~mli/8168505/webrev.00/ Test ( java/util/Arrays/ParallelPrefix.java) was failing intermittently, related bug (JDK-8080165 ) has been proved not

Re: RFR: 8160213: tools/pack200/Utils.java should clean up javac*.tmp files

Looks fine Kumar; thanks, -Joe On 10/24/2016 5:59 PM, Kumar Srinivasan wrote: Hello, Please review fix for: https://bugs.openjdk.java.net/browse/JDK-8160213 Webrev: http://cr.openjdk.java.net/~ksrini/8160213/webrev.00/ Now the temporary javac argument file will be written to the working

RFR: 8160213: tools/pack200/Utils.java should clean up javac*.tmp files

Hello, Please review fix for: https://bugs.openjdk.java.net/browse/JDK-8160213 Webrev: http://cr.openjdk.java.net/~ksrini/8160213/webrev.00/ Now the temporary javac argument file will be written to the working directory of the test which will be purged upon completion. The test for

Re: RFR: 8168512: (tz) Support tzdata2016h

+1 Masayoshi On 10/24/2016 11:14 PM, Martin Buchholz wrote: Looks good to me! On Mon, Oct 24, 2016 at 12:28 AM, Ramanand Patil wrote: Hi all, Please review the latest TZDATA integration (tzdata2016h) to JDK9. Bug:

Re: RFR 9: [testbug] Disable CORBA com.sun.corba.serialization.ObjectStreamTest.echoObjects

Looks fine Roger; thanks, -Joe On 10/24/2016 2:00 PM, Roger Riggs wrote: Please review the disable of a problematic test bug due to address in use errors. Only the ObjectStreamTest.echoObjects test needs to be disabled. The ProblemList.txt is not used in the case. webrev:

Re: RFR: 8164805: Fail to create a MR modular JAR with a versioned entry in base-versioned empty package

There is a new webrev at http://cr.openjdk.java.net/~sdrach/8164805/webrev.01/ >>> >>> sun/tools/jar/Main.java >>> >>> Thanks for refactoring and adding the findConcealedPackages method. What I >>> actually meant was to move out this line: >>> concealedPackages =

Re: RFR: 8164805: Fail to create a MR modular JAR with a versioned entry in base-versioned empty package

> On Oct 24, 2016, at 1:39 PM, Steve Drach wrote: > >>> There is a new webrev at >>> http://cr.openjdk.java.net/~sdrach/8164805/webrev.01/ >> >> sun/tools/jar/Main.java >> >> Thanks for refactoring and adding the findConcealedPackages method. What I >> actually

RFR 9: [testbug] Disable CORBA com.sun.corba.serialization.ObjectStreamTest.echoObjects

Please review the disable of a problematic test bug due to address in use errors. Only the ObjectStreamTest.echoObjects test needs to be disabled. The ProblemList.txt is not used in the case. webrev: http://cr.openjdk.java.net/~rriggs/webrev-echoobjects-8166814/ Issue:

Re: XMLReader secure processing

On 10/24/16, 10:40 AM, Bernd wrote: Hello, I am somewhat lost on how to enable or control the secure processing in the XMLReader. You can use XMLConstants.FEATURE_SECURE_PROCESSING and/or XMLConstants.ACCESS_EXTERNAL_{DTD,SCHEMA} only on the SAXParserFactory, but not XMLReader(Factory). Is

Re: RFR: 8164805: Fail to create a MR modular JAR with a versioned entry in base-versioned empty package

>> There is a new webrev at >> http://cr.openjdk.java.net/~sdrach/8164805/webrev.01/ > > sun/tools/jar/Main.java > > Thanks for refactoring and adding the findConcealedPackages method. What I > actually meant was to move out this line: >concealedPackages = findConcealedPackages(rd); > >

Iterator.forEachRemaining and Iterator.remove

It doesn't make a lot of sense for users to call Iterator.remove after calling Iterator.forEachRemaining. The default implementation has no choice but to do while (hasNext()) action.accept(next()); upon which remove() removes the last element. What should overriding

Re: RFR: 8164805: Fail to create a MR modular JAR with a versioned entry in base-versioned empty package

> On Oct 24, 2016, at 10:28 AM, Steve Drach wrote: > > There is a new webrev at > http://cr.openjdk.java.net/~sdrach/8164805/webrev.01/ sun/tools/jar/Main.java Thanks for refactoring and adding the findConcealedPackages method. What I actually meant was to move out

Re: RFR: 8160954: (spec) Runtime.Version regex and $PRE/$OPT issues

> On 20 Oct 2016, at 20:34, Iris Clark wrote: > > Hi. > > Please review changes to address the following closely related bugs: > >8160954: (spec) Runtime.Version regex and $PRE/$OPT issues >https://bugs.openjdk.java.net/browse/JDK-8160954 > >8148822: (spec)

XMLReader secure processing

Hello, I am somewhat lost on how to enable or control the secure processing in the XMLReader. You can use XMLConstants.FEATURE_SECURE_PROCESSING and/or XMLConstants.ACCESS_EXTERNAL_{DTD,SCHEMA} only on the SAXParserFactory, but not XMLReader(Factory). Is this an oversight or am I missing

Re: RFR: 8164805: Fail to create a MR modular JAR with a versioned entry in base-versioned empty package

There is a new webrev at http://cr.openjdk.java.net/~sdrach/8164805/webrev.01/ that addresses the issues raised by Mandy. Comments inline. >> issue: https://bugs.openjdk.java.net/browse/JDK-8164805 >> webrev:

Re: RFR: 8164805: Fail to create a MR modular JAR with a versioned entry in base-versioned empty package

On 19/10/16 19:34, Steve Drach wrote: Hi, Please review the following changeset. This fix allows jar tool to add a new public class in a versioned directory in a modular multi-release jar file if the class is in a concealed package. When this event takes place, a warning message is emitted

Re: Request/discussion: BufferedReader reading using async API while providing sync API

Attached and sending! On 24/10/2016 13:48, Pavel Rappo wrote: Could you please send a new email on this list with the source attached as a text file? On 23 Oct 2016, at 19:14, Brunoais wrote: Here's my poc/prototype: http://pastebin.com/WRpYWDJF I've implemented the

Re: JDK 9 RFR of JDK-8168524: Remove two jdk_nio tests from ProblemList: BashStreams and DeleteInterference.java

+1 for the DeleteInterference portion. Brian On Oct 24, 2016, at 1:08 AM, Amy Lu wrote: > Please review the patch to bring back two tests: > > java/nio/file/WatchService/DeleteInterference.java 8156511 linux-all >More debug info has been added to this test

Re: RFR: 8168512: (tz) Support tzdata2016h

Looks good to me! On Mon, Oct 24, 2016 at 12:28 AM, Ramanand Patil wrote: > Hi all, > > Please review the latest TZDATA integration (tzdata2016h) to JDK9. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8168512 > > Webrev:

Re: Request/discussion: BufferedReader reading using async API while providing sync API

Could you please send a new email on this list with the source attached as a text file? > On 23 Oct 2016, at 19:14, Brunoais wrote: > > Here's my poc/prototype: > http://pastebin.com/WRpYWDJF > > I've implemented the bare minimum of the class that follows the same contract

JDK 9 RFR of JDK-8168524: Remove two jdk_nio tests from ProblemList: BashStreams and DeleteInterference.java

Please review the patch to bring back two tests: java/nio/file/WatchService/DeleteInterference.java 8156511 linux-all More debug info has been added to this test (JDK-8162902). It's hard to reproduce the failure. Let's bring back this test. Once test failure happen again, the debug info

RFR: 8168512: (tz) Support tzdata2016h

Hi all, Please review the latest TZDATA integration (tzdata2016h) to JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8168512 Webrev: http://cr.openjdk.java.net/~rpatil/8168512/webrev.00/ All the TimeZone related tests are passed after integration. Regards, Ramanand.