RE: XALAN: Text node of value 'null' - Is this illegal or does XSLTC have an issue here?

Hi Joe, thanks for your comments. Yes the customer does not really want to insert a null value but create an empty text node. So they'll fix their code anyway. However, I thought it would be a good Idea to make the Serializer more robust with regards to such null data. Especially given that

Re: XALAN: Text node of value 'null' - Is this illegal or does XSLTC have an issue here?

Looks like a null check-in is desirable. If the intention is to add a text node, which I assume was his intention, he wouldn't want a null node. If the intention is to create an empty element, then he didn't need the line that added the null text node. As far as DOM goes, it would have been

Re: RFR: 8169191: (tz) Support tzdata2016i

+1 On 11/8/2016 1:36 AM, Martin Buchholz wrote: Looks good to me! On Mon, Nov 7, 2016 at 2:43 AM, Ramanand Patil wrote: Hi all, Please review the latest TZDATA integration (tzdata2016i) to JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8169191 Webrev:

Re: RFR[9] JDK-8158916: ProblemList.txt update for com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java

Hi Daniel, Thanks for your comments. On 2016/11/7 19:21, Daniel Fuchs wrote: Hi John, Maybe you should reach out to Rob who fixed JDK-8141370 to make sure this is the right thing to do. just cc Rob Mckenna It seems the exclusion on problematic platforms [1] was deliberate: Basically I've

Re: 8169001: Remove launcher's built-in ergonomics

Hi Kumar, On 8/11/2016 4:47 AM, Kumar Srinivasan wrote: Hello, Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8169001 Webrev at: http://cr.openjdk.java.net/~ksrini/8169001/webrev.00/ Overall this looks like a complete eradication of the launcher ergonomics. A few

Re: RFR 8160036: Java API doc for method minusMonths in LocalDateTime class needs correction

Looks good, Thanks, Roger On 11/7/2016 7:27 AM, Bhanu Gopularam wrote: Thanks Nadeesh. Here is the updated webrev: http://cr.openjdk.java.net/~bgopularam/8160036/webrev.01 Thanks, Bhanu -Original Message- From: nadeesh tv Sent: Monday, November 07, 2016 5:38 PM To:

Re: RFR: 8159035: com/sun/crypto/provider/Cipher/CTS/CTSMode.java test crashed due to unhandled case of cipher length value as 0

change in 8859-1 looks good. sherman On 11/7/16 3:21 AM, Rahul Raghavan wrote: Hi, Request review for closed bug fix - JDK-8159035. - http://cr.openjdk.java.net/~rraghavan/8159035/webrev.03/ Notes: 1. - https://bugs.openjdk.java.net/browse/JDK-8159035 -

8169001: Remove launcher's built-in ergonomics

Hello, Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8169001 Webrev at: http://cr.openjdk.java.net/~ksrini/8169001/webrev.00/ Background: Launcher ergonomics was introduced last decade to help determine if the execution system is "Server Class", this was necessary to

Re: RFR: 8159035: com/sun/crypto/provider/Cipher/CTS/CTSMode.java test crashed due to unhandled case of cipher length value as 0

Looks good. Thanks, Vladimir On 11/7/16 3:21 AM, Rahul Raghavan wrote: Hi, Request review for closed bug fix - JDK-8159035. - http://cr.openjdk.java.net/~rraghavan/8159035/webrev.03/ Notes: 1. - https://bugs.openjdk.java.net/browse/JDK-8159035 -

Re: RFR: 8169191: (tz) Support tzdata2016i

Looks good to me! On Mon, Nov 7, 2016 at 2:43 AM, Ramanand Patil wrote: > Hi all, > Please review the latest TZDATA integration (tzdata2016i) to JDK9. > Bug: https://bugs.openjdk.java.net/browse/JDK-8169191 > Webrev:

XALAN: Text node of value 'null' - Is this illegal or does XSLTC have an issue here?

Hi Xalan experts, I've recently handled a customer issue about Text Nodes of value 'null' inside a DOM, causing an exception during XALAN XSLT transformation. The repro case is quite simple. Consider the following small Java sample [1] which creates a DOM from a very basic XML, inserts a text

Re: RFR: JDK-8167618: DateTimeFormatter.format() uses exceptions for flow control.

Looks good, thanks. I'm sure it will make some cases faster, I just hope it doesn't make cases that don't throw an exception significantly slower. Stephen On 7 November 2016 at 12:35, Anubhav Meena wrote: > Thanks for the review! > > Here is the updated webrev >

Re: RFR: JDK-8167618: DateTimeFormatter.format() uses exceptions for flow control.

Thanks for the review! Here is the updated webrev http://cr.openjdk.java.net/~ntv/others/anubhav/webrev.01/ -Anubhav > On Nov 2, 2016, at 4:04 PM, Stephen Colebourne wrote: > > I agree with Nadeesh, the

RE: RFR 8160036: Java API doc for method minusMonths in LocalDateTime class needs correction

Thanks Nadeesh. Here is the updated webrev: http://cr.openjdk.java.net/~bgopularam/8160036/webrev.01 Thanks, Bhanu -Original Message- From: nadeesh tv Sent: Monday, November 07, 2016 5:38 PM To: core-libs-dev@openjdk.java.net Subject: Re: RFR 8160036: Java API doc for method

Re: RFR 8160036: Java API doc for method minusMonths in LocalDateTime class needs correction

Hi Bhanu, Same issues with OffsetDateTime minusWeeks and minusDays Thanks and Regards, Nadeesh On 11/7/2016 5:31 PM, Bhanu Gopularam wrote: Hi all, Could you please review fix for following issue? Bug id: https://bugs.openjdk.java.net/browse/JDK-8160036 Solution: Corrected documentation for

RFR 8160036: Java API doc for method minusMonths in LocalDateTime class needs correction

Hi all, Could you please review fix for following issue? Bug id: https://bugs.openjdk.java.net/browse/JDK-8160036 Solution: Corrected documentation for couple of methods in LocalDateTime and OffsetDateTime classes Webrev: http://cr.openjdk.java.net/~bgopularam/8160036/webrev.00 Thanks, Bhanu

Re: RFR[9] JDK-8158916: ProblemList.txt update for com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java

Hi John, Maybe you should reach out to Rob who fixed JDK-8141370 to make sure this is the right thing to do. It seems the exclusion on problematic platforms [1] was deliberate: Basically I've separated the failing subtest out into its own file and excluded it on the (intermittently) failing

RFR: 8159035: com/sun/crypto/provider/Cipher/CTS/CTSMode.java test crashed due to unhandled case of cipher length value as 0

Hi, Request review for closed bug fix - JDK-8159035. - http://cr.openjdk.java.net/~rraghavan/8159035/webrev.03/ Notes: 1. - https://bugs.openjdk.java.net/browse/JDK-8159035 - (com/sun/crypto/provider/Cipher/CTS/CTSMode.java test crashed due to unhandled case of cipher length value as 0)

RFR: 8169191: (tz) Support tzdata2016i

Hi all, Please review the latest TZDATA integration (tzdata2016i) to JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8169191 Webrev: http://cr.openjdk.java.net/~rpatil/8169191/webrev.00/ All the TimeZone related tests are passed after integration. Regards, Ramanand.

Re: Proposal for adding O_DIRECT support into JDK 9

On Sun, Nov 6, 2016 at 6:04 PM, Alan Bateman wrote: > On 06/11/2016 15:51, Lu, Yingqi wrote: > > Another approach might be use ioctl to get the block size and use that as > the alignment value. I think ioctl is available on UNIX based OSes (please > chime in if I miss