Re: RFR: 8186314: code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change

Hi Vicente, It looks good to me. Regards, Eric (Shihua Guo) On 17/08/2017 04:47, Vicente Romero wrote: Hi, Please review the fix for issue [1]. The fix can be found at [2]. The fix is minimal, reproduced below: ---

Re: RFR: JDK-8133680 add Stream.foldLeft() terminal operation

On Aug 17, 2017, at 6:32 PM, John Rose wrote: > > Better to make the buffering required for > that reversal explicit to the user, IMO. I know it's a case of > brief notation vs. "picky" explicitness; in this case the pickiness > wins because there is an extra O(N) copy

Re: RFR: JDK-8133680 add Stream.foldLeft() terminal operation

On Aug 13, 2017, at 6:27 AM, Tagir Valeev wrote: > > Please review the preliminary implementation for Stream foldLeft and > foldRight operations: > > http://cr.openjdk.java.net/~tvaleev/webrev/8133680/r1/ I think s.foldLeft(op) is the same as s.sequential().reduce(op). If

"""error: module testng reads package test from both test and testng"""

When I run the jtreg test java/lang/ModuleTests/addXXX I fail with direct: error: module testng reads package test from both test and testng In the javac command line I see: --add-modules testng,jcommander but ... testng and jcommander aren't modules; they're just garden variety jar files.

Re: RFR: JDK8U Backport of 8185346: Relax RMI Registry Serial Filter to allow arrays of any type

Hi Ramanand, Looks fine. Thanks for the cleanup around the shared secrets. Roger On 8/17/2017 3:06 PM, Ramanand Patil wrote: Hi All, Please review this webrev for jdk8u backport. Webrev: http://cr.openjdk.java.net/~rpatil/8185346/jdk8u-dev/webrev.00/ Main Bug:

RFR: JDK8U Backport of 8185346: Relax RMI Registry Serial Filter to allow arrays of any type

Hi All, Please review this webrev for jdk8u backport. Webrev: http://cr.openjdk.java.net/~rpatil/8185346/jdk8u-dev/webrev.00/ Main Bug: https://bugs.openjdk.java.net/browse/JDK-8185346 JDK10 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-August/048738.html JDK10

Re: [10] RFR(M) 8182701: Modify JVMCI to allow Graal Compiler to expose platform MBean

Hi Jaroslav, What we should do with 8182701? Do you still need JVMCI changes? Note, your changes to Graal [GR-5435] were integrated recently into JDK (jdk10/hs): https://bugs.openjdk.java.net/browse/JDK-8186158 Thanks, Vladimir On 8/14/17 10:06 AM, Jaroslav Tulach wrote: On čtvrtek 3. srpna

Re: RFR: 8186314: code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change

Looks OK > On Aug 16, 2017, at 4:47 PM, Vicente Romero wrote: > > Hi, > > Please review the fix for issue [1]. The fix can be found at [2]. The fix is > minimal, reproduced below: > > --- >

Re: RFR: 8186314: code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change

Hi Vicente, The change looks good to me (not a reviewer). Best, Aleksei On 08/16/2017 09:47 PM, Vicente Romero wrote: Hi, Please review the fix for issue [1]. The fix can be found at [2]. The fix is minimal, reproduced below: ---

Re: RFR: JDK-8133680 add Stream.foldLeft() terminal operation

Hello, Rémi! People don't use forEachOrdered not because they don't care about order, but because they don't care about parallelism and forEach does the same (for sequential stream) with a shorter name. Similar to foldLeft. Currently people often use reduce instead of missing foldLeft, feeding