Re: RFR: 8185925 & 8153682 (footprint reduction of java.lang.StackFrameInfo)

Hi Brent, if you declare retainClassRef as a byte, you can even compress the data structure a little bit more, no ? a boolean (as a field) uses 4 bytes while a byte uses welll 1 byte. Given that bci is a short, the VM will put both bci and retainClassRef on the same 32 bits slot. cheers, Rémi

Re: RFR: jsr166 jdk10 integration wave 5

On 7/11/2017 8:17 AM, Martin Buchholz wrote: Thanks for the review! On Mon, Nov 6, 2017 at 1:36 PM, David Holmes > wrote: 8189764: Miscellaneous changes imported from jsr166 CVS 2017-11 All seem okay. Though I'm curious

RFR: 8185925 & 8153682 (footprint reduction of java.lang.StackFrameInfo)

Hi, There are a couple opportunities to reduce the memory footprint of java.lang.StackFrameInfo (the internal implementation of java.lang.StackWalker.StackFrame): 8153682[1] : StackFrameInfo.declaringClass could be removed 8185925[2] : StackFrameInfo::walker field can be replaced with bitmap

Re: JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c

Hi Ramanand, In java/time/format/ZoneName.java, should the zid for Africa_Central map to "Africa/Maputo"? Naoto On 11/6/17 6:06 AM, Ramanand Patil wrote: Hi all, Please review the latest TZDATA integration (tzdata2017c) to JDK10. Bugs: https://bugs.openjdk.java.net/browse/JDK-8190258

Re: RFR 8187281 : Remove @intermittent from OnExitTest

looking good Roger > On Nov 6, 2017, at 5:18 PM, Roger Riggs wrote: > > Please review the removal of the @intermittent keyword from OnExitTest. > The failure has not occurred since it was fixed on 9/21. > > --- old/test/jdk/java/lang/ProcessHandle/OnExitTest.java

RFR 8187281 : Remove @intermittent from OnExitTest

Please review the removal of the @intermittent keyword from OnExitTest. The failure has not occurred since it was fixed on 9/21. --- old/test/jdk/java/lang/ProcessHandle/OnExitTest.java2017-11-06 16:45:40.762305867 -0500 +++ new/test/jdk/java/lang/ProcessHandle/OnExitTest.java

Re: RFR: jsr166 jdk10 integration wave 5

Thanks for the review! On Mon, Nov 6, 2017 at 1:36 PM, David Holmes wrote: > > 8189764: Miscellaneous changes imported from jsr166 CVS 2017-11 >> > > All seem okay. Though I'm curious about the changes from "catch(Throwable" > to "catch(Exception" ? > There's a

Re: RFR: jsr166 jdk10 integration wave 5

On Mon, Nov 6, 2017 at 1:36 PM, David Holmes wrote: > > src/java.base/share/classes/java/util/concurrent/ConcurrentL > inkedDeque.java > > final Node pred(Node p) { > ! Node q = p.prev; > ! return (p == q) ? last() : q; > } > > /** >

Re: RFR: jsr166 jdk10 integration wave 5

Hi Martin, On 7/11/2017 6:00 AM, Martin Buchholz wrote: The notable thing this time around is the embarrassing number of rare races being fixed, all of which are second tries.  This time for sure! There's a large number of boring changes to appease errorprone, notably

RFR: jsr166 jdk10 integration wave 5

The notable thing this time around is the embarrassing number of rare races being fixed, all of which are second tries. This time for sure! There's a large number of boring changes to appease errorprone, notably http://errorprone.info/bugpattern/RandomModInteger

Re: RFR - 8190482: InnocuousThread creation should not require the caller to possess enableContextClassLoaderOverride

Looks fine to me. Mandy On 11/5/17 2:02 AM, Chris Hegarty wrote: Currently JDK code that wants to create innocuous threads is required to do so within a privileged context that has the "enableContextClassLoaderOverride" RuntimePermission ( since the InnocuousThread class overrides

Re: [Patch][JDK10] Use Class.getPackageName() where possible

On 11/3/17 6:52 PM, Bernd Eckenfels wrote: The private static helper in ObjectStreamClass became a oneliner and can be removed and the callsites can transform from getPackageName(c) to c.getPackageName(). Good catch.   we should clean that up. Christoph - can you send a updated patch to

Re: RFR - 8190482: InnocuousThread creation should not require the caller to possess enableContextClassLoaderOverride

Hi Chris, Looks fine Roger On 11/5/2017 5:02 AM, Chris Hegarty wrote: Currently JDK code that wants to create innocuous threads is required to do so within a privileged context that has the "enableContextClassLoaderOverride" RuntimePermission ( since the InnocuousThread class overrides

JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c

Hi all, Please review the latest TZDATA integration (tzdata2017c) to JDK10. Bugs: https://bugs.openjdk.java.net/browse/JDK-8190258 https://bugs.openjdk.java.net/browse/JDK-8190259 Webrev: http://cr.openjdk.java.net/~rpatil/8190258+8190259/webrev.00/ All the TimeZone related tests are passed