Re: RFR (JDK11) 8137326: Methods for comparing CharSequence, StringBuilder, and StringBuffer

Hi Tagir, Thanks for the comment. I will consider adding that to the javadoc emphasizing that the comparison is performed from 0 to length() - 1 of the two sequences. Best, Joe On 1/29/18, 8:07 PM, Tagir Valeev wrote: Hello! An AbstractStringBuilder#compareTo implementation is wrong. You

Re: [11] RFR 8195694: ConstantBootstraps.invoke does not preserve variable arity

> On Jan 31, 2018, at 3:49 PM, John Rose wrote: > > On second thought, you should also use invokeWithArguments to support jumbo > arities. > It does, but non-selectively based on the arity: 245 return handle.invokeWithArguments(args); > This tricky idiom

Re: [11] RFR 8196533 Update CondyNestedTest.java to compile jcod file

Looks okay. Mandy On 1/31/18 4:28 PM, Paul Sandoz wrote: Hi, Please review an update to a constant dynamic test that updates to compile the jcod file rather than loading a class from class file bytes encoded in a base64 string:

[11] RFR 8196533 Update CondyNestedTest.java to compile jcod file

Hi, Please review an update to a constant dynamic test that updates to compile the jcod file rather than loading a class from class file bytes encoded in a base64 string: http://cr.openjdk.java.net/~psandoz/jdk/JDK-8196533-CondyNestedTest-compile-jcod/webrev/

Re: [11] RFR 8195694: ConstantBootstraps.invoke does not preserve variable arity

On second thought, you should also use invokeWithArguments to support jumbo arities. This tricky idiom should be put into a utility method, package private for starters. A version of it also appears in BSM invocation code. > On Jan 31, 2018, at 3:23 PM, John Rose

Re: [11] RFR 8195694: ConstantBootstraps.invoke does not preserve variable arity

If you remove the old asType call it’s good! > On Jan 31, 2018, at 3:15 PM, Paul Sandoz wrote: > > Hi, > > Please review this fix to the invoke BSM so that it preserves variable arity, > if any: > > >

[11] RFR 8195694: ConstantBootstraps.invoke does not preserve variable arity

Hi, Please review this fix to the invoke BSM so that it preserves variable arity, if any: http://cr.openjdk.java.net/~psandoz/jdk/JDK-8195694-constant-bsms-invoke-arity/webrev/ This will be pushed to

Re: Possible addition of a default 'getOne' method on Iterable?

See also Stream.findFirst and findAny. Stream is the place we have and I think we should primarily focus effort on rather than Iterable for such features. I believe a related feature some have requested is the ability to obtain an only, or at most, one element. On Stream this might manifest as:

Re: RFR JDK-8193802: NullPointerException from JarFileSystem.getVersionMap()

Looks fine to me. Mandy On 1/31/18 11:54 AM, Xueming Shen wrote: Hi Please help review the change for JDK-8193802. Issue: https://bugs.openjdk.java.net/browse/JDK-8193802 Webrev: http://cr.openjdk.java.net/~sherman/8193802/webrev To add a "null" check when building mr lookup tables. The use

RFR JDK-8193802: NullPointerException from JarFileSystem.getVersionMap()

Hi Please help review the change for JDK-8193802. Issue: https://bugs.openjdk.java.net/browse/JDK-8193802 Webrev: http://cr.openjdk.java.net/~sherman/8193802/webrev To add a "null" check when building mr lookup tables. The use scenario here is that the jar file and the jarfs env are

Re: JDK 11 RFR of 8194070 : Update various tests to pass under JDK 11

+1 On 01/30/2018 11:59 PM, joe darcy wrote: Hello, Please review the changes to address 8194070 : Update various tests to pass under JDK 11 http://cr.openjdk.java.net/~darcy/8194070.2/ which are updates to the various and sundry multi-release jar files tests so that they can after

Re: JDK 11 RFR of 8194070 : Update various tests to pass under JDK 11

Looks ok, Paul. > On Jan 30, 2018, at 11:59 PM, joe darcy wrote: > > Hello, > > Please review the changes to address > > 8194070 : Update various tests to pass under JDK 11 > http://cr.openjdk.java.net/~darcy/8194070.2/ > > which are updates to the various and

Re: JDK 11 RFR of 8194070 : Update various tests to pass under JDK 11

On 31/01/2018 07:59, joe darcy wrote: Hello, Please review the changes to address     8194070 : Update various tests to pass under JDK 11     http://cr.openjdk.java.net/~darcy/8194070.2/ which are updates to the various and sundry multi-release jar files tests so that they can after both

Re: RFR 8195059: Update java.net Socket and DatagramSocket implementations to use Cleaner

Adding net-...@openjdk.java.net On 1/30/2018 5:08 PM, Roger Riggs wrote: Please review changes to replace finalizers in socket, datagram, and multicast networking with Cleaner based release of the raw file descriptors.  Each FileDescriptor is registered for cleanup after the raw fd (or handle)

Re: [PATCH] GPU Exploitation Infrastructure

Thank you Alan and David. In light of your responses, I'll take this to the Valhalla project. Thanks, Ben From: David Holmes To: Alan Bateman , Ben Walsh , core-libs-dev@openjdk.java.net Date: 31/01/2018

Re: JDK-8166339,Code conversion working behavior was changed for x-IBM834

Looks fine to me Sherman. regards, Sean. On 30/01/2018 22:59, Xueming Shen wrote: Hi, Please help review the change for JDK-8166339. issue: https://bugs.openjdk.java.net/browse/JDK-8166339 webrev: http://cr.openjdk.java.net/~sherman/8166339/webrev This is a regression triggered by issue:

JDK 11 RFR of 8194070 : Update various tests to pass under JDK 11

Hello, Please review the changes to address     8194070 : Update various tests to pass under JDK 11     http://cr.openjdk.java.net/~darcy/8194070.2/ which are updates to the various and sundry multi-release jar files tests so that they can after both before and after the JDK version is