Hi Sherman,
The change looks fine
> On Oct 2, 2018, at 4:04 PM, Xueming Shen wrote:
>
> Hi,
>
> Please help review the change for JDK-8211585.
>
> issue: https://bugs.openjdk.java.net/browse/JDK-8211385
> webrev: http://cr.openjdk.java.net/~sherman/8211385/webrev
>
>
> Thanks,
> Sherman
Hi Tagir,
Thanks for doing this! This looks like a good optimization. I can sponsor it for
you.
The preliminary patch looks fine. Too bad there's some code duplication. If this
weren't HashMap, I'd suggest refactoring it and using a lambda expression.
However, HashMap is used early in JDK
On 10/1/18 10:46 AM, Martin Buchholz wrote:
This is one example of a change that should leave zero
impact on the generated bytecode, and that should be testable, if only by
comparing the .class files for identical size.
This is a good point. I did something similar when I did the "diamond"
Dear all,
I am pleased to announce that we have finished work on 'Merge jdk and hotspot
test libraries' and achieved the big milestone in our work on improving test
libraries. Since this project started a long time, I think it's worth it to
reiterate why we are doing it, what has been done,
+1
-Sherman
btw, since gb18030.decodeArrayLoop() is right I would assume it's just a
"typo" in decodeBufferLoop()
On 10/2/18, 2:21 AM, Ichiroh Takiguchi wrote:
Hello,
IBM would like to contribute NIO converter patch to OpenJDK project.
Bug:
*Chuckle* at the long-obsolete reference in test/langtools/Makefile
292 apt:JTREG_TESTDIRS = tools/apt
Otherwise, apart from other overdue cleanup, test/langtools/Makefile
looks OK.
-- Jon
On 10/02/2018 12:21 AM, Mikael Vidstedt wrote:
Please review this change which removes
Looks good. Ship it!
David
On 3/10/2018 4:17 AM, Mikael Vidstedt wrote:
Thanks for the reviews. I’ve reverted the changes related to Helper and “just”
adjusted the comments instead.
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.01/open/webrev/
incremental (from
Hi,
Please help review the change for JDK-8211585.
issue: https://bugs.openjdk.java.net/browse/JDK-8211385
webrev: http://cr.openjdk.java.net/~sherman/8211385/webrev
Thanks,
Sherman
Class::newInstance maintains its separate cache of the caller
class after access check. This leak has been there for a long
time and unnoticed.
This patch changes Class::newInstance to use the code path
for Constructor::newInstance doing the access check and
caching the caller class. It will
On 02/10/2018 19:17, Mikael Vidstedt wrote:
Thanks for the reviews. I’ve reverted the changes related to Helper and “just”
adjusted the comments instead.
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.01/open/webrev/
incremental (from webrev.00):
Looks good to me.
/Erik
On 2018-10-02 11:17, Mikael Vidstedt wrote:
Thanks for the reviews. I’ve reverted the changes related to Helper and “just”
adjusted the comments instead.
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.01/open/webrev/
incremental (from webrev.00):
+1
Mandy
On 10/2/18 11:17 AM, Mikael Vidstedt wrote:
Thanks for the reviews. I’ve reverted the changes related to Helper
and “just” adjusted the comments instead.
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.01/open/webrev/
Raffaello and Ulf should talk.
It seems like Ulf's ryu project is trying to solve the same problem.
ryu is also still being worked on, but there is already a published paper
and ryu is being adopted by various core libraries.
https://github.com/ulfjack/ryu
Thanks for the reviews. I’ve reverted the changes related to Helper and “just”
adjusted the comments instead.
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.01/open/webrev/
incremental (from webrev.00):
Build changes look good to me.
/Erik
On 2018-10-02 00:21, Mikael Vidstedt wrote:
Please review this change which removes support for, and references to, the
(Oracle internal) JPRT system.
bug: https://bugs.openjdk.java.net/browse/JDK-8211350
webrev:
On 10/2/18 12:21 AM, Mikael Vidstedt wrote:
Please review this change which removes support for, and references to, the
(Oracle internal) JPRT system.
bug: https://bugs.openjdk.java.net/browse/JDK-8211350
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.00/open/webrev/
Hi Bob,
no problem , we can wait a few days until the final version of Win
server 2019 is out, and check the buildNumber again :
https://cloudblogs.microsoft.com/windowsserver/2018/09/24/windows-server-2019-announcing-general-availability-in-october/
says :
"In October, customers
Matthias,
We don’t usually add logic to the JDK related to unreleased operating system
previews.
Has the ReleaseID been updated on the system you are testing on?
This is the documented way of determining the OS version you are running on?
The latest preview release is build 17744. Are you
Hello, please review change 8211106 .
It updates the Windows OS detection code to recognize Windows Server 2019 .
For this we have to look at the build number (dwBuildNumber of
OSVERSIONINFOEX),
https://docs.microsoft.com/en-us/windows/desktop/api/Winnt/ns-winnt-_osversioninfoexa
Hi,
On 2018-10-01 19:35, Martin Buchholz wrote:
We probably want to check in the jmh benchmark, but not sure where - there
have been recent discussions ... """Reviving JEP 230: Microbenchmark
Suite"""
we have a prototype up and running in the sandbox[1] and I hope to move
forward with the
On 2/10/2018 6:34 PM, Alan Bateman wrote:
On 02/10/2018 08:21, Mikael Vidstedt wrote:
Please review this change which removes support for, and references
to, the (Oracle internal) JPRT system.
bug: https://bugs.openjdk.java.net/browse/JDK-8211350
webrev:
Hello,
IBM would like to contribute NIO converter patch to OpenJDK project.
Bug: https://bugs.openjdk.java.net/browse/JDK-8211382
Change: https://cr.openjdk.java.net/~itakiguchi/8211382/webrev.00/
Issue:
ISO2022JP decoder and GB18030 decoder (for decodeBufferLoop()) have code
range
On 02/10/2018 08:21, Mikael Vidstedt wrote:
Please review this change which removes support for, and references to, the
(Oracle internal) JPRT system.
bug: https://bugs.openjdk.java.net/browse/JDK-8211350
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.00/open/webrev/
Does
> On 2 Oct 2018, at 02:09, Prasadrao Koppula
> wrote:
>
> ..
> Webrev: http://cr.openjdk.java.net/~pkoppula/8211107/webrev.01/
Looks good.
-Chris.
Hi Mikael,
This all looks fine to me.
Thanks for cleaning it up!
David
On 2/10/2018 5:21 PM, Mikael Vidstedt wrote:
Please review this change which removes support for, and references to, the
(Oracle internal) JPRT system.
bug: https://bugs.openjdk.java.net/browse/JDK-8211350
webrev:
Correction looks good to me.
regards,
Sean.
On 02/10/2018 02:09, Prasadrao Koppula wrote:
Hi,
Could you please review this patch. This patch fixes the regression caused by
LDAP fixes in JDK11, JDK8u181, JDK7u191
Webrev: http://cr.openjdk.java.net/~pkoppula/8211107/webrev.01/
Please review this change which removes support for, and references to, the
(Oracle internal) JPRT system.
bug: https://bugs.openjdk.java.net/browse/JDK-8211350
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.00/open/webrev/
* Background (from the issue)
The Oracle
27 matches
Mail list logo
