Hi Roger,
Please find my comments belowand check the updated webrev.
http://cr.openjdk.java.net/~nishjain/8177552/webrevs/webrev.02/
Regards,
Nishit Jain
On 22-11-2018 00:04, Roger Riggs wrote:
Hi Nishit,
Comments on the tests:
- The tests looks to be quite complete.
- Have the locale
Currently, CopiesList.hashCode() is inherited from AbstractList which:
- calls hashCode() for each element,
- creates a new Iterator every time.
However, for Collections.nCopies():
- All elements are the same. So hashCode() can be called only once.
- An Iterator is unnecessary.
So,
ping !
Rémi
- Mail original -
> De: "Remi Forax"
> À: "core-libs-dev"
> Envoyé: Mardi 13 Novembre 2018 15:47:54
> Objet: Both Collector.of() are not correctly typed
> Last year,
> a student of mine as remarked that the two variants of Collector.of() are not
> correctly typed (the
Hi Martin,
Just to add to Ichiroh's comments, if an AIX machine is configured with a
default OS charset of IBM-964 or IBM-29626C, then the OpenJDK VM(Hotspot)
will be unable to start as the VM initialization during the bootstrap
phase will try to load the charset. Thus it must be in the