Re: RFR: 8237465: JDK 14 L10N resource files update - msg drop 10

Hi Naoto, Thank you for reviewing. The eol characters were removed by t9n system, if I correct the format manually the next time we run the msg drop it would be back. Considering we need to kick off the next msg drop soon, I prefer not to fix it this time. Regards, Leo On 1/18/20 2:31 AM,

Re: Depth and String handling in ObjectInputFilter

Hi Robert, first this is the wrong mailing list, this mailing list is about how to implement the JDK, not how it works, usually stackoverflow is better for the kind of questions you are asking. - Mail original - > De: "Robert Olofsson" > À: "core-libs-dev" > Envoyé: Vendredi 17 Janvier

Depth and String handling in ObjectInputFilter

Hi! I hope this is the correct mailing list, if not please tell me. I was looking into using a ObjectInputFilter and try to improve the security in some old code that uses serialization. After reading and testing a bit I think the filtering works a bit strange and that it does not provide enough

Re: RFR: 8218021: jarsigner strips the execute permission when signing a .zip file

Am 2020-01-17 um 11:59 schrieb Seán Coffey: Hi, Looking to introduce some JDK private functionality which will help preserve internal zip file attribute permissions when jarsigner is run on a zip file. Some of the logic is taken from the recent work carried out in this area for zipfs API.

Re: RFR 8236034 : Use optimized Ques node for curly {0,1} quantifier

Hi Ivan, This refactoring looks fine. Sorry for the long time to get to looking at this. Thanks, Roger On 12/16/19 7:03 PM, Ivan Gerasimov wrote: Hello! In the regular expressions, the quantifier ? can be equally written as {0,1}. While for the former variant an optimized algorithm is

Re: [15] RFR: 8187987: Add a mechanism to configure custom variants in HijrahChronology

Hi Naoto, Looks good.  Thanks for the updates. Roger On 1/16/20 4:08 PM, naoto.s...@oracle.com wrote: Hi Roger, Thanks. My comments are embedded below. On 1/16/20 12:06 PM, Roger Riggs wrote: Hi Naoto, A couple of comments in the tests. HijrahConfigTest: 72:  Since onExit() starts a

Re: RFR: 8218021: jarsigner strips the execute permission when signing a .zip file

HI Sean, I think the change looks reasonable and I would keep it focused on its current intent for zip files given the problem you were addressing. The test also looks reasonable. Did you give any consideration to throwing a SkippedException if posixAttributes are not supported? Also

Re: RFR: 8237465: JDK 14 L10N resource files update - msg drop 10

On 1/17/20 10:31 AM, naoto.s...@oracle.com wrote: Hi Leo, The l10n files for HelpResources_*.properties in jpackage discard the format in the original English resource file where lines are nicely aligned. Can you please preserve the format? Also, I find it odd to observe duplicated

Re: [14] 8237368: Problem with NullPointerException in RMI TCPEndpoint.read

On 17/01/2020 18:25, Roger Riggs wrote: Please review this fix to correctly allow null for a custom socket factory in TCPEndpoint. issue: https://bugs.openjdk.java.net/browse/JDK-8237368 webrev: http://cr.openjdk.java.net/~rriggs/webrev-proxy-8237368/ Looks good. As this is a P2 and regression

Re: RFR: 8237465: JDK 14 L10N resource files update - msg drop 10

Hi Leo, The l10n files for HelpResources_*.properties in jpackage discard the format in the original English resource file where lines are nicely aligned. Can you please preserve the format? Also, I find it odd to observe duplicated String literals in every XPATHErrorResources_*.java files.

[14] 8237368: Problem with NullPointerException in RMI TCPEndpoint.read

Please review this fix to correctly allow null for a custom socket factory in TCPEndpoint. issue: https://bugs.openjdk.java.net/browse/JDK-8237368 webrev: http://cr.openjdk.java.net/~rriggs/webrev-proxy-8237368/ Thanks, Roger

Re: [14] 8237368: Problem with NullPointerException in RMI TCPEndpoint.read

This looks fine to me. Mandy On 1/17/20 10:25 AM, Roger Riggs wrote: Please review this fix to correctly allow null for a custom socket factory in TCPEndpoint. issue: https://bugs.openjdk.java.net/browse/JDK-8237368 webrev: http://cr.openjdk.java.net/~rriggs/webrev-proxy-8237368/ Thanks,

Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

On 1/17/20 5:31 AM, Severin Gehwolf wrote: If I understand you correctly, then we'd have to change how -XshowSettings:system works currently with it. Not all metrics as currently printed via LauncherHelper.java are supported in both worlds (cgroup v1 & v2). It would make handling of cgroup

Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

Hi Mandy, On Thu, 2020-01-16 at 17:43 -0800, Mandy Chung wrote: > Hi Bob, Severin, > > On 1/9/20 11:51 AM, Severin Gehwolf wrote: > > Thanks for the review! Should all be fixed now. Updated webrev: > > > > incremental: > >

Re: RFR: 8218021: jarsigner strips the execute permission when signing a .zip file

Hi Philipp, On 17/01/2020 12:40, Philipp Kunz wrote: Hi Sean, Nice patch. I wonder why permissions should be preserved only in zip files. Jar files also are zip files, according to the jar file specs, and hence, shouldn't jar files benefit of preserving permissions, too? Thanks for your

Re: RFR: 8218021: jarsigner strips the execute permission when signing a .zip file

Hi Sean, Nice patch. I wonder why permissions should be preserved only in zip files. Jar files also are zip files, according to the jar file specs, and hence, shouldn't jar files benefit of preserving permissions, too? The file name extension is most often zip for zip files and jar for jar files

Re: RFR [15/java.xml] 8235368 : Update BCEL to Version 6.4.1

On 16/01/2020 18:22, Joe Wang wrote: It's because the class itself is declared final (at least on the few files I've taken a look), so final on a method is redundant. Ah! I had missed that. Thaks Rémi! Meanwhile, I noticed I missed the new classes in the webrev. I used a changelist to create

RFR: 8237465: JDK 14 L10N resource files update - msg drop 10

Hi, Please review the L10N resource files update for JDK 14 msg drop 10. https://bugs.openjdk.java.net/browse/JDK-8237465 http://cr.openjdk.java.net/~ljiang/8237465/webrev/read/ This is the first msg drop for JDK 14 L10N resources files update, so this webrev would cover most of update for

RFR: 8218021: jarsigner strips the execute permission when signing a .zip file

Hi, Looking to introduce some JDK private functionality which will help preserve internal zip file attribute permissions when jarsigner is run on a zip file. Some of the logic is taken from the recent work carried out in this area for zipfs API.