On Tue, 14 Sep 2021 18:11:00 GMT, Roger Riggs wrote:
> Since there is no longer a need to format an arbitrary date, I'd suggest
> going back to the original Date.toString() code. It removes the need to
> replicate the format using DateTimeBuilder and is known to be the same as
> before.
> The commit in this PR implements the proposal for enhancement that was
> discussed in the core-libs-dev mailing list recently[1], for
> https://bugs.openjdk.java.net/browse/JDK-8231640
>
> At a high level - the `store()` APIs in `Properties` have been modified to
> now look for the
On Wed, 15 Sep 2021 01:54:40 GMT, Florent Guillaume
wrote:
> FWIW `.z` is the extension of the old Unix `compress` program.
Thank you Florent, I wasn't aware of that.
-
PR: https://git.openjdk.java.net/jdk/pull/5505
On Tue, 14 Sep 2021 15:56:53 GMT, Julia Boes wrote:
>> I think you can ignore my comment above. I went and checked the
>> `content-types.properties` in their current state for both unix and windows
>> and they already have a separate `application/zip` which is mapped to
>> `.zip`. So I think
On Wed, 8 Sep 2021 06:30:34 GMT, wxiang
wrote:
>> wxiang has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Some minor changes
>>
>> Include:
>> 1. remove public for INDEX_NAME in JarFile
>> 2. recover the definition for
On Tue, 14 Sep 2021 15:49:36 GMT, Aleksey Shipilev wrote:
>> It isn't the "formal governance" I'm concerned about, more about the folk
>> who use/rely on Zero being the ones to evaluate the impact of a change like
>> this. People, like myself, who do not use Zero in any way cannot evaluate
>>
On Wed, 1 Sep 2021 01:05:32 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For the
On Tue, 14 Sep 2021 21:47:36 GMT, Alexey Semenyuk wrote:
>> Fix jpackage error output when "--type" CLI option is missing and jpackage
>> detects that it can't build native packages in the environment.
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit
On Wed, 1 Sep 2021 01:05:32 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For the
> Fix jpackage error output when "--type" CLI option is missing and jpackage
> detects that it can't build native packages in the environment.
Alexey Semenyuk has updated the pull request incrementally with one additional
commit since the last revision:
dummy commit
-
Changes:
On Tue, 14 Sep 2021 20:34:21 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/util/Properties.java line 929:
>>
>>> 927: @SuppressWarnings("unchecked")
>>> 928: var entries = new ArrayList<>(((Map) (Map)
>>> map).entrySet());
>>> 929:
On Tue, 14 Sep 2021 18:53:27 GMT, Roger Riggs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Introduce a test to make sure backslash character in the system property
>> value doesn't cause unexpected output.
>>
On Wed, 1 Sep 2021 01:05:32 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For the
On Tue, 14 Sep 2021 19:33:38 GMT, Peter Levart wrote:
> Just another question: Is migrating from Unsafe based FieldAccessor(s) to
> VarHandle based an important step to final goal of Unsafe elimination because
> I don't think it is a necessary step for Loom.
No. We could continue to use
On Wed, 1 Sep 2021 01:05:32 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For the
On Wed, 1 Sep 2021 01:05:32 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For the
On Wed, 1 Sep 2021 01:05:32 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For the
On Wed, 1 Sep 2021 01:05:32 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For the
> Sorting:
>
> - adopt radix sort for sequential and parallel sorts on int/long/float/double
> arrays (almost random and length > 6K)
> - fix tryMergeRuns() to better handle case when the last run is a single
> element
> - minor javadoc and comment changes
>
> Testing:
> - add new data inputs
On Tue, 14 Sep 2021 18:58:16 GMT, stefan-zobel
wrote:
> The package javadoc of java.util.random says that `mixLea32` is used as a
> mixing function in the L64 and L128 generators which doesn't seem to be
> correct. That should probably read `mixLea64`
See
On Mon, 5 Apr 2021 14:20:56 GMT, Jim Laskey wrote:
>> This PR is to introduce a new random number API for the JDK. The primary API
>> is found in RandomGenerator and RandomGeneratorFactory. Further description
>> can be found in the JEP https://openjdk.java.net/jeps/356 .
>>
>> javadoc can be
On Tue, 14 Sep 2021 14:02:10 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in
On Tue, 14 Sep 2021 14:02:10 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in
On Tue, 14 Sep 2021 17:25:05 GMT, Ioi Lam wrote:
> Maybe it should be "any_integer"?
+1
-
PR: https://git.openjdk.java.net/jdk/pull/5437
On Tue, 14 Sep 2021 17:21:29 GMT, Alexey Semenyuk wrote:
> Fix jpackage error output when "--type" CLI option is missing and jpackage
> detects that it can't build native packages in the environment.
Marked as reviewed by herrick (Reviewer).
-
PR:
On Tue, 14 Sep 2021 14:02:10 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in
Fix jpackage error output when "--type" CLI option is missing and jpackage
detects that it can't build native packages in the environment.
-
Commit messages:
- 8272815: jpackage --type rpm produces an error: Invalid or unsupported type:
[null]
Changes:
On Tue, 14 Sep 2021 13:38:42 GMT, Andy Herrick wrote:
> JDK-8273040: Turning off JpAllowDowngrades (or Upgrades)
This pull request has now been integrated.
Changeset: 22a7191f
Author:Andy Herrick
URL:
https://git.openjdk.java.net/jdk/commit/22a7191f700c6966c59dcd12476f01452243542b
On Tue, 14 Sep 2021 16:36:24 GMT, Ioi Lam wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Simplify coding following Severins advice
>
> test/hotspot/jtreg/containers/docker/TestPids.java line 97:
>
>> 95:
On Tue, 14 Sep 2021 16:47:45 GMT, Daniel Fuchs wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote:
> This change implements a simple web server that can be run on the
> command-line with `java -m jdk.httpserver`.
>
> This is facilitated by adding an entry point for the `jdk.httpserver` module,
> an implementation class whose main method
On Tue, 14 Sep 2021 12:38:19 GMT, Jim Laskey wrote:
>> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpHandlers.java
>> line 128:
>>
>>> 126: * {@code headers} are the effective headers of the response.
>>> The
>>> 127: * response body bytes are a {@code UTF-8} encoded
On Tue, 14 Sep 2021 14:27:36 GMT, Matthias Baesken wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8266490
>> extended the OSContainer API in order to also support the pids controller of
>> cgroups. However only pids.max output was added with 8266490.
>> There is a second parameter
On Tue, 14 Sep 2021 14:27:36 GMT, Matthias Baesken wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8266490
>> extended the OSContainer API in order to also support the pids controller of
>> cgroups. However only pids.max output was added with 8266490.
>> There is a second parameter
On Tue, 14 Sep 2021 12:36:28 GMT, Jim Laskey wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote:
> This change implements a simple web server that can be run on the
> command-line with `java -m jdk.httpserver`.
>
> This is facilitated by adding an entry point for the `jdk.httpserver` module,
> an implementation class whose main method
On Tue, 14 Sep 2021 16:07:21 GMT, Julia Boes wrote:
>> src/jdk.httpserver/share/classes/com/sun/net/httpserver/Headers.java line
>> 288:
>>
>>> 286: }
>>> 287:
>>> 288: private static final Headers EMPTY = new UnmodifiableHeaders(new
>>> Headers());
>>
>> IDEA warns here:
On Tue, 14 Sep 2021 13:38:42 GMT, Andy Herrick wrote:
> JDK-8273040: Turning off JpAllowDowngrades (or Upgrades)
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5509
On Tue, 14 Sep 2021 13:47:48 GMT, Andrey Turbanov
wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose
On Tue, 14 Sep 2021 15:42:06 GMT, Jaikiran Pai wrote:
>> src/java.base/windows/classes/sun/net/www/content-types.properties line 30:
>>
>>> 28: application/octet-stream: \
>>> 29: description=Generic Binary Stream;\
>>> 30:
On Fri, 10 Sep 2021 10:02:43 GMT, David Holmes wrote:
>> Currently, the build system defaults the libjvm.so location to "server".
>> This makes looking for `libjvm.so` awkward, see JDK-8273487 for example. We
>> need to see if moving the libjvm.so to a proper location breaks anything.
>>
>>
On Tue, 14 Sep 2021 15:30:31 GMT, Jaikiran Pai wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote:
> This change implements a simple web server that can be run on the
> command-line with `java -m jdk.httpserver`.
>
> This is facilitated by adding an entry point for the `jdk.httpserver` module,
> an implementation class whose main method
On Mon, 13 Sep 2021 20:06:08 GMT, Andrey Turbanov
wrote:
> 8273711: Remove redundant stream() call before forEach in jdk.jlink
In some cases you can use a method ref (no need for another review if you
update those).
On Thu, 9 Sep 2021 22:02:55 GMT, Aleksei Efimov wrote:
> Hi,
> The following fix changes type of exception thrown when an LDAP operation
> fails for reasons like read timeout or connection closure/cancellation:
> instead of throwing a general `NamingException`, the internal LDAP connection
>
On Fri, 10 Sep 2021 11:07:52 GMT, Matthias Baesken wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8266490
>> extended the OSContainer API in order to also support the pids controller of
>> cgroups. However only pids.max output was added with 8266490.
>> There is a second parameter
> https://bugs.openjdk.java.net/browse/JDK-8266490
> extended the OSContainer API in order to also support the pids controller of
> cgroups. However only pids.max output was added with 8266490.
> There is a second parameter pids.current , see
>
On Fri, 10 Sep 2021 17:04:58 GMT, Michael Osipov
wrote:
>> Hi,
>> The following fix changes type of exception thrown when an LDAP operation
>> fails for reasons like read timeout or connection closure/cancellation:
>> instead of throwing a general `NamingException`, the internal LDAP
>>
On Tue, 14 Sep 2021 13:28:24 GMT, Daniel Fuchs wrote:
>> There has been no change in how we deal with this aspect. The existing
>> specification (stated in the `load` method) says:
>>
>>
>>> * Properties are processed in terms of lines. There are two
>>> * kinds of line, natural lines
> The commit in this PR implements the proposal for enhancement that was
> discussed in the core-libs-dev mailing list recently[1], for
> https://bugs.openjdk.java.net/browse/JDK-8231640
>
> At a high level - the `store()` APIs in `Properties` have been modified to
> now look for the
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote:
> This change implements a simple web server that can be run on the
> command-line with `java -m jdk.httpserver`.
>
> This is facilitated by adding an entry point for the `jdk.httpserver` module,
> an implementation class whose main method
JDK-8273040: Turning off JpAllowDowngrades (or Upgrades)
-
Commit messages:
- JDK-8273040: Turning off JpAllowDowngrades (or Upgrades)
- JDK-8273040: Turning off JpAllowDowngrades (or Upgrades)
Changes: https://git.openjdk.java.net/jdk/pull/5509/files
Webrev:
On Tue, 14 Sep 2021 13:19:17 GMT, Andrey Turbanov
wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose
On Tue, 14 Sep 2021 13:24:55 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/Properties.java line 822:
>>
>>> 820: * {@link System#lineSeparator() line separator} and if the next
>>> 821: * character in comments is not character {@code #} or character
>>> {@code !}
On Tue, 14 Sep 2021 13:17:42 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add a @implNote to specify the order in which the properties are written
>> out
>> - update the javadoc to clarify
On Tue, 14 Sep 2021 13:15:18 GMT, Jaikiran Pai wrote:
>> I would leave it as an `@implNote` - or possibly `@implSpec`: depending on
>> whether or not we want all implementations of the spec to behave in this
>> way. However I don't think we would want to prevent subclasses from
>> overriding
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote:
> This change implements a simple web server that can be run on the
> command-line with `java -m jdk.httpserver`.
>
> This is facilitated by adding an entry point for the `jdk.httpserver` module,
> an implementation class whose main method
On Tue, 14 Sep 2021 12:56:28 GMT, Daniel Fuchs wrote:
>> Hello Daniel, you are right - I missed discussing whether or not to include
>> a `@implNote` to explain the natural sorted order of the property keys. When
>> we started this whole PR proposal, Alan had hinted that maybe we should
>>
On Tue, 14 Sep 2021 11:43:25 GMT, Magnus Ihse Bursie wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> unused imports
>
> src/java.base/share/classes/java/util/Properties.java line 828:
>
>> 826: * a comment
On Tue, 14 Sep 2021 13:19:25 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in
> The commit in this PR implements the proposal for enhancement that was
> discussed in the core-libs-dev mailing list recently[1], for
> https://bugs.openjdk.java.net/browse/JDK-8231640
>
> At a high level - the `store()` APIs in `Properties` have been modified to
> now look for the
On Tue, 14 Sep 2021 11:59:56 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/Properties.java line 836:
>>
>>> 834: *
>>> 835: * Then every entry in this {@code Properties} table is
>>> 836: * written out, one per line. For each entry the key string is
>>
>>
On Thu, 9 Sep 2021 23:29:24 GMT, Naoto Sato wrote:
> Small spec clarification. Corresponding CSR has also been drafted.
This pull request has now been integrated.
Changeset: 31667daa
Author:Naoto Sato
URL:
On Tue, 14 Sep 2021 02:30:01 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in
On Thu, 9 Sep 2021 10:17:02 GMT, Aleksey Shipilev wrote:
> Currently, the build system defaults the libjvm.so location to "server".
> This makes looking for `libjvm.so` awkward, see JDK-8273487 for example. We
> need to see if moving the libjvm.so to a proper location breaks anything.
>
>
On Wed, 8 Sep 2021 06:30:34 GMT, wxiang
wrote:
>> wxiang has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Some minor changes
>>
>> Include:
>> 1. remove public for INDEX_NAME in JarFile
>> 2. recover the definition for
On Thu, 8 Jul 2021 11:51:18 GMT, Yi Yang wrote:
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
>
> As Mandy suggested, I create this PR for changes
On Tue, 14 Sep 2021 10:47:34 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> unused imports
>
> src/java.base/share/classes/java/util/Properties.java line 836:
>
>> 834: *
>> 835: *
On Tue, 14 Sep 2021 10:57:17 GMT, Alan Bateman wrote:
>>> Hi @iaroslavski I'm unconvinced that this work was from 14/06/2020 - I
>>> believe this work derives from an unsigned radix sort I implemented on
>>> 10/04/2021
>>>
On Tue, 14 Sep 2021 02:30:01 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in
On Thu, 9 Sep 2021 10:17:02 GMT, Aleksey Shipilev wrote:
> Currently, the build system defaults the libjvm.so location to "server".
> This makes looking for `libjvm.so` awkward, see JDK-8273487 for example. We
> need to see if moving the libjvm.so to a proper location breaks anything.
>
>
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote:
> This change implements a simple web server that can be run on the
> command-line with `java -m jdk.httpserver`.
>
> This is facilitated by adding an entry point for the `jdk.httpserver` module,
> an implementation class whose main method
On Mon, 13 Sep 2021 19:57:14 GMT, Andrey Turbanov
wrote:
> 8273710: Remove redundant stream() call before forEach in jdk.jdeps
LGTM
-
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5498
On Tue, 14 Sep 2021 10:57:17 GMT, Alan Bateman wrote:
>>> Hi @iaroslavski I'm unconvinced that this work was from 14/06/2020 - I
>>> believe this work derives from an unsigned radix sort I implemented on
>>> 10/04/2021
>>>
On Tue, 14 Sep 2021 09:23:23 GMT, Alan Bateman wrote:
>> @richardstartin And one more addon: my first version of Radix sort, see my
>> github https://github.com/iaroslavski/sorting/tree/master/radixsort uses
>> another name, like skipBytes, then renamed to passLevel.
>> So, the common part is
On Wed, 8 Sep 2021 09:26:33 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in
On Tue, 14 Sep 2021 02:30:01 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in
On 14/09/2021 03:28, Jaikiran Pai wrote:
Hello Roger,
I've now updated the PR to implement these suggested changes. I think
at this point all suggestions have been implemented and I don't think
there are any open questions.
If the latest PR looks fine, I think the next step will be a CSR
On Tue, 14 Sep 2021 09:23:23 GMT, Alan Bateman wrote:
>> @richardstartin And one more addon: my first version of Radix sort, see my
>> github https://github.com/iaroslavski/sorting/tree/master/radixsort uses
>> another name, like skipBytes, then renamed to passLevel.
>> So, the common part is
This change implements a simple web server that can be run on the command-line
with `java -m jdk.httpserver`.
This is facilitated by adding an entry point for the `jdk.httpserver` module,
an implementation class whose main method is run when the above command is
executed. This is the first
On Mon, 13 Sep 2021 20:06:08 GMT, Andrey Turbanov
wrote:
> 8273711: Remove redundant stream() call before forEach in jdk.jlink
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5500
On Thu, 13 May 2021 11:31:49 GMT, iaroslavski
wrote:
>> Perhaps we can resolve this issue in private - my email address is on my
>> profile (or in the commits in `radix-sort-benchmark`)?
>
> @richardstartin And one more addon: my first version of Radix sort, see my
> github
8273710: Remove redundant stream() call before forEach in jdk.jdeps
-
Commit messages:
- [PATCH] Remove redundant stream() call before forEach in jdk.jdeps
Changes: https://git.openjdk.java.net/jdk/pull/5498/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5498=00
Issue:
8273711: Remove redundant stream() call before forEach in jdk.jlink
-
Commit messages:
- [PATCH] Remove redundant stream() call before forEach in jdk.jlink
Changes: https://git.openjdk.java.net/jdk/pull/5500/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5500=00
Issue:
84 matches
Mail list logo
