Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v3]

2022-04-16 Thread Jaikiran Pai
On Fri, 15 Apr 2022 11:45:01 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v3]

2022-04-16 Thread Jaikiran Pai
On Fri, 15 Apr 2022 11:45:01 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v3]

2022-04-16 Thread Jaikiran Pai
On Sat, 16 Apr 2022 14:34:01 GMT, Alan Bateman wrote: >> src/java.base/share/classes/jdk/internal/misc/Blocker.java line 76: >> >>> 74: && currentCarrierThread() instanceof CarrierThread ct >>> && !ct.inBlocking()) { >>> 75: ct.beginBlocking(); >>> 76:

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v3]

2022-04-16 Thread Alan Bateman
On Sat, 16 Apr 2022 09:25:20 GMT, Jaikiran Pai wrote: >> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >>

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v2]

2022-04-16 Thread Alan Bateman
On Fri, 15 Apr 2022 22:01:10 GMT, Paul Sandoz wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refresh > > src/java.base/share/classes/jdk/internal/vm/ThreadContainers.java line 184: > >> 182: * with the

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v2]

2022-04-16 Thread Alan Bateman
On Sat, 16 Apr 2022 12:31:41 GMT, ExE Boss wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refresh > > src/java.base/share/classes/jdk/internal/misc/Blocker.java line 111: > >> 109: methodType =

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v3]

2022-04-16 Thread Alan Bateman
On Sat, 16 Apr 2022 11:05:47 GMT, Jaikiran Pai wrote: >> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >>

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v2]

2022-04-16 Thread ExE Boss
On Wed, 13 Apr 2022 14:21:20 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v3]

2022-04-16 Thread Alan Bateman
On Sat, 16 Apr 2022 10:25:56 GMT, Jaikiran Pai wrote: >> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >>

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v3]

2022-04-16 Thread Alan Bateman
On Sat, 16 Apr 2022 10:29:36 GMT, Jaikiran Pai wrote: >> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >>

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v2]

2022-04-16 Thread Alan Bateman
On Fri, 15 Apr 2022 20:39:51 GMT, Paul Sandoz wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refresh > > src/java.base/share/classes/jdk/internal/misc/Blocker.java line 126: > >> 124: static void

Re: RFR: 8284642: Unexpected behavior of -XX:MaxDirectMemorySize=0

2022-04-16 Thread David Holmes
On Wed, 13 Apr 2022 12:24:46 GMT, Harold Seigel wrote: > Please review this small fix for JDK-8284642. The fix was tested by running > Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux > x64. Additionally, the modified test and the test in the bug report were run >

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v3]

2022-04-16 Thread Jaikiran Pai
On Fri, 15 Apr 2022 11:45:01 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v3]

2022-04-16 Thread Jaikiran Pai
On Fri, 15 Apr 2022 11:45:01 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in

Re: RFR: 8186958: Need method to create pre-sized HashMap [v22]

2022-04-16 Thread XenoAmess
On Thu, 14 Apr 2022 21:27:16 GMT, XenoAmess wrote: >> 8186958: Need method to create pre-sized HashMap > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > java.xml.crypto's usage downgrade grammar to 1.8 So is there any other

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v3]

2022-04-16 Thread Jaikiran Pai
On Fri, 15 Apr 2022 11:45:01 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in

Re: OpenJDK or SE Java Floating Point Options?

2022-04-16 Thread Andrew Haley
On 4/16/22 09:04, sminervini.prism wrote: > It is still the case that I and others need Java floating point and StrictMath > (the key double type calculator class) to be repaired. If you are going to pursue this line of reasoning, you must be aware of some things. Firstly, it is not possible to

OpenJDK or SE Java Floating Point Options?

2022-04-16 Thread sminervini.prism
To core-libs-dev, and Glavo, given this inner nature of C++, which I had not seen, I do renege those code snippets. It is still the case that I and others need Java floating point and StrictMath (the key double type calculator class) to be repaired. It has been made clear to us by a number of