On Tue, 31 May 2022 20:32:13 GMT, Joe Darcy wrote:
>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull
On Wed, 18 May 2022 14:56:47 GMT, Christian Stein wrote:
> This PR adds an optional description accessor on `ToolProvider` interface.
>
> This PR also adds short description for each of the listed tool:
> - `jar`
> - `javac`
> - `javadoc`
> - `javap` and `jdeps`
> - `jlink` and `jmod`
> -
On Wed, 18 May 2022 14:56:47 GMT, Christian Stein wrote:
> This PR adds an optional description accessor on `ToolProvider` interface.
>
> This PR also adds short description for each of the listed tool:
> - `jar`
> - `javac`
> - `javadoc`
> - `javap` and `jdeps`
> - `jlink` and `jmod`
> -
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
javac and javadoc changes look OK
On Fri, 6 May 2022 23:30:44 GMT, Jonathan Gibbons wrote:
> Please review a small doc fix to update incorrect use of `{@link}` on arrays
> of primitive types.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/8584
On Sat, 7 May 2022 01:27:57 GMT, Joe Darcy wrote:
> Looks fine in and of itself, but not sure how it will interact with the
> (presumed) integration of JEP 424: "Foreign Function & Memory API (Preview)"
> which will at least move the file, if not otherwise modify it.
I assume the changes are
Please review a small doc fix to update incorrect use of `{@link}` on arrays of
primitive types.
-
Commit messages:
- JDK-8286347: incorrect use of `{@link}`
Changes: https://git.openjdk.java.net/jdk/pull/8584/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8584=00
On Mon, 2 May 2022 22:55:43 GMT, Joe Darcy wrote:
> Please review the addition of @-see links from classes that mention the IEEE
> 754 floating-point standard to an IEEE page about the standard. The URL in
> the initial version of the PR is the top search result on the IEEE home page
> for
On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote:
> To enable more complete doclint checking (courtesy @jonathan-gibbons), please
> review this PR to add type-level @param tags where they are missing.
>
> To the maintainers of java.util.concurrent, those changes could be sepa
On Tue, 22 Mar 2022 00:01:59 GMT, Joe Darcy wrote:
> As part of updating the core libraries to be sealed, the package-access
> AbstractStringBuilder, implementation superclass of StringBuilder and
> StringBuffer, can be marked as sealed with those two subclasses on its
> permits list.
Marked
On Mon, 21 Mar 2022 16:29:25 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Wed, 16 Mar 2022 00:33:57 GMT, Joe Darcy wrote:
> Improve some semantic links into JLS with actual links.
Marked as reviewed by jjg (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7831
On Thu, 10 Feb 2022 11:24:23 GMT, Lance Andersen wrote:
>> Perhaps like this?
>>
>>
>> /**
>> * ...
>> * @provides java.util.spi.ToolProvider
>> * Module {@code jdk.jartool} provides a tool named {@code "jar"}.
>> * Invoke {@link java.util.spi.ToolProvider#findFirst
>>
On Wed, 9 Feb 2022 20:33:02 GMT, Alan Bateman wrote:
>> A number of modules declare that the "provide" ToolProvider.
>>
>> These modules now specify the "name" of the argument used by
>> `ToolProvider.findFirst` to access an instance of the tool provider within
>> the description part of a
On Wed, 9 Feb 2022 16:37:00 GMT, Christian Stein wrote:
> A number of modules declare that the "provide" ToolProvider.
>
> These modules now specify the "name" of the argument used by
> `ToolProvider.findFirst` to access an instance of the tool provider within
> the description part of a
On Wed, 9 Feb 2022 16:37:00 GMT, Christian Stein wrote:
> A number of modules declare that the "provide" ToolProvider.
>
> These modules now specify the "name" of the argument used by
> `ToolProvider.findFirst` to access an instance of the tool provider within
> the description part of a
On Fri, 21 Jan 2022 18:37:50 GMT, Jonathan Gibbons wrote:
> Please review this semi-automated update to the nroff man pages from the
> upstream repo.
This pull request has now been integrated.
Changeset: 7d2ef9d9
Author:Jonathan Gibbons
URL:
https://git.openjdk.java.net
Please review this semi-automated update to the nroff man pages from the
upstream repo.
-
Commit messages:
- JDK-8279179: Update nroff pages in JDK 18 before RC
Changes: https://git.openjdk.java.net/jdk18/pull/112/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk18=112=00
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in
On Thu, 13 Jan 2022 11:40:20 GMT, Lance Andersen wrote:
>> OK, so lines 264, 295, 329, 364, 431 are arguably wrong as well?
>> Separating the [] completely looks quite rare.
>> I'll leave it up to you. 8-)
>
> I think that can be a follow on clean up.
The strange formatting of `long
On Sat, 11 Dec 2021 11:29:50 GMT, Christian Stein wrote:
>> Prior to this PR, `toUri()` of class `ZipPath` in module `jdk.zipfs` and
>> class `PathFileObject` in module `jdk.compiler` were always composed by base
>> path names. Even for versioned entries of a multi-release JAR file.
>>
>>
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote:
> Please review this semi-automatic update for the nroff man pages for JDK 18.
> The changes update the version number, copyright year, and incorporate the
> changes from the latest upstream files.
hmmm, I thought we had t
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote:
> Please review this semi-automatic update for the nroff man pages for JDK 18.
> The changes update the version number, copyright year, and incorporate the
> changes from the latest upstream files.
This pull request has
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote:
> Please review this semi-automatic update for the nroff man pages for JDK 18.
> The changes update the version number, copyright year, and incorporate the
> changes from the latest upstream files.
Hi David,
The copyr
Please review this semi-automatic update for the nroff man pages for JDK 18.
The changes update the version number, copyright year, and incorporate the
changes from the latest upstream files.
-
Commit messages:
- JDK-8273179: Update nroff pages in JDK 18 before RC
Changes:
On Thu, 18 Nov 2021 03:22:50 GMT, Tim Prinzing wrote:
> JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
Remarkable to have not been noticed for so long!
-
Marked as reviewed by jjg (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6443
On Wed, 24 Nov 2021 20:08:50 GMT, Lance Andersen wrote:
> HI all,
>
> Attached is a patch for 4 failing MR tests due the issue that was resolved
> via JDK-8272728
>
> Best
> Lance
Marked as reviewed by jjg (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6546
On Mon, 1 Nov 2021 16:10:26 GMT, Ichiroh Takiguchi
wrote:
>> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13.
>> After JDK18-b13, javac and some other langtool command's usage were garbled
>> on Japanese Windows.
>> These commands use PrintWriter instead of standard out/err with
On Wed, 10 Nov 2021 19:46:09 GMT, Alan Bateman wrote:
> If there is resistance to fixing the tools then we might have to re-visit
> this.
It's not just the JDK tools that are an issue. I think that wrapping some
PrintStream into a PrintWriter is a common enough idiom that it is not
On Wed, 10 Nov 2021 20:00:39 GMT, Alan Bateman wrote:
> > 1. `PrintStream(OutputStream)` and `PrintStream(OutputStream, boolean)`
> > should be redefined so that they internally check if the stream arg is a
> > PrintStream, in which case they use the encoding from the `PrinStream`
> >
On Mon, 1 Nov 2021 16:10:26 GMT, Ichiroh Takiguchi
wrote:
>> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13.
>> After JDK18-b13, javac and some other langtool command's usage were garbled
>> on Japanese Windows.
>> These commands use PrintWriter instead of standard out/err with
On Mon, 1 Nov 2021 16:10:26 GMT, Ichiroh Takiguchi
wrote:
>> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13.
>> After JDK18-b13, javac and some other langtool command's usage were garbled
>> on Japanese Windows.
>> These commands use PrintWriter instead of standard out/err with
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote:
>> As a follow up of JEP 411, we will soon disallow security manager by
>> default. jtreg 6.1 does not set its own security manager if JDK version is
>> >= 18.
>
> Weijun Wang has updated the pull request incrementally with one additional
>
On Wed, 6 Oct 2021 05:04:28 GMT, Ichiroh Takiguchi
wrote:
>> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13.
>> After JDK18-b13, javac and some other langtool command's usage were garbled
>> on Japanese Windows.
>> These commands use PrintWriter instead of standard out/err with
AM, Pavel Rappo wrote:
On 24 Aug 2021, at 15:38, Jonathan Gibbons wrote:
IIRC, the one in javadoc CommentUtils has recently been fixed.
It might be worth a javac -Xlint option to detect/report such dangling comments.
How would you currently implement that? Aren't comments on non-documentable
IIRC, the one in javadoc CommentUtils has recently been fixed.
It might be worth a javac -Xlint option to detect/report such dangling
comments.
-- Jon
On 8/23/21 11:50 PM, Andrey Turbanov wrote:
Hello.
I found a few internal classes in the JDK codebase which don't have
proper javadoc, but
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons wrote:
> Please review a semi-automatic update of the nroff man pages from the
> upstream files.
This pull request has now been integrated.
Changeset: dfacda48
Author:Jonathan Gibbons
URL:
https://git.openjdk.java.net/jdk17/
On Thu, 5 Aug 2021 19:57:59 GMT, Naoto Sato wrote:
>> Please review a semi-automatic update of the nroff man pages from the
>> upstream files.
>
> src/jdk.hotspot.agent/share/man/jhsdb.1 line 1:
>
>> 1: .\" Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights
>> reserved.
>
>
Please review a semi-automatic update of the nroff man pages from the upstream
files.
-
Commit messages:
- JDK-8270872: Final nroff manpage update for JDK 17
Changes: https://git.openjdk.java.net/jdk17/pull/303/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk17=303=00
On Tue, 29 Jun 2021 04:39:28 GMT, Jonathan Gibbons wrote:
> Please review a trivial `noreg-doc` fix for some javadoc tags for
> `java.lang.Runtime` for JDK17
This pull request has now been integrated.
Changeset: 25f9f19a
Author:Jonathan Gibbons
URL:
https://git.openjdk.ja
Please review a trivial `noreg-doc` fix for some javadoc tags for
`java.lang.Runtime` for JDK17
-
Commit messages:
- JDK-8249646: Runtime.exec(String, String[], File) documentation contains
literal {@link ...}
Changes: https://git.openjdk.java.net/jdk17/pull/167/files
Webrev:
On Tue, 15 Jun 2021 15:35:14 GMT, Maurizio Cimadamore
wrote:
> I can push to 17 if desired, but I'll need a new PR for that
pushing to 17 would be nice; the script is equally broken and unusable there.
-
PR: https://git.openjdk.java.net/jdk/pull/4492
On Tue, 15 Jun 2021 14:04:56 GMT, Maurizio Cimadamore
wrote:
> As the title says (please also refer to the JBS issue which describes all the
> issues in more details), the IDE support for IntelliJ has been updated with
> many enhancements as part of a seemingly innocuous "path handling" fix.
On Thu, 3 Jun 2021 00:47:45 GMT, Jonathan Gibbons wrote:
> Please review a small test fix, to include hamcrest.jar, as required by the
> latest version of JUnit in jtreg 6.
This pull request has now been integrated.
Changeset: ef01e478
Author:Jonathan Gibbons
URL:
Please review a small test fix, to include hamcrest.jar, as required by the
latest version of JUnit in jtreg 6.
-
Commit messages:
- JDK-8268150: tier2: test/jdk/tools/jpackage/junit/junit.java needs updating
for jtreg 6
Changes: https://git.openjdk.java.net/jdk/pull/4328/files
On Wed, 2 Jun 2021 22:22:22 GMT, Jonathan Gibbons wrote:
> Please review a test fix to refer to the new name of the TestNG module.
This pull request has now been integrated.
Changeset: d46a2c8e
Author: Jonathan Gibbons
URL:
https://git.openjdk.java.net/jdk/com
Please review a test fix to refer to the new name of the TestNG module.
-
Commit messages:
- JDK-8268147: need to update reference to testng module for jtreg6
Changes: https://git.openjdk.java.net/jdk/pull/4325/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4325=00
.ROOT`
> files.
>
> All the tests that could be updated ahead of time have been updated. There
> are a few tests remaining that need to be done at this time, because of the
> change in the module name for TestNG 7.3. It changed from a default of
> `testng` to and explicit `org.testn
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
I
Please review the change to update to using jtreg 6.
The primary change is to the jib-profiles.js file, which specifies the version
of jtreg to use, for those systems that rely on this file. In addition, the
`requiredVersion` has been updated in the various `TEST.ROOT` files.
All the tests
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
The
On Tue, 1 Jun 2021 22:20:25 GMT, Nikita Gubarkov
wrote:
>> The fix fails on a Mac, where `realpath` is not available by default.
>
> @jonathan-gibbons this can be fixed with `brew install coreutils`. We
> probably need to check `realpath` availability in idea.sh and sugges
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
The
On Mon, 26 Apr 2021 17:14:29 GMT, Pavel Rappo wrote:
>> I had been looking for an example of a "properties" file when spotted a typo
>> in `logging.properties`. I decided to proofread the file. That resulted in
>> finding a few other issues.
>
> Pavel Rappo has updated the pull request
On Sat, 6 Mar 2021 07:31:09 GMT, Bradford Wetmore wrote:
> Fix various things pointed out by the most recent doclint run in the
> security-libs area.
>
> This is docs only: I will be checking doccheck/doclint, and will be running
> tier1/tier2 tests. Minor spot checks on generated files.
Please review some simple cleanup for empty `` tags.
Two of the tags are completely redundant, and simply deleted.
The other three, in _package.html_ files are generally undesirable. Although
the presumed intent of the `id` declaration is to label the `@see` info,
proximity in the source code
On Tue, 2 Mar 2021 22:01:49 GMT, Jonathan Gibbons wrote:
> Please review a trivial fix to insert a missing word.
This pull request has now been integrated.
Changeset: 93ffe6a6
Author: Jonathan Gibbons
URL: https://git.openjdk.java.net/jdk/commit/93ffe6a6
Stats: 1 line in 1 f
Please review a trivial fix to insert a missing word.
-
Commit messages:
- JDK-8262892: minor typo in implSpec comment
Changes: https://git.openjdk.java.net/jdk/pull/2798/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2798=00
Issue:
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote:
> Please review some minor doc fixes, for issues found by _doccheck_.There
> are two kinds of errors that are addressed.
>
> 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a
> paragraph. It is not a term
Please review some minor doc fixes, for issues found by _doccheck_.There
are two kinds of errors that are addressed.
1. Incorrect use of ``. In HTML, `` marks the *beginning* of a paragraph.
It is not a terminator, to mark the end of a paragraph, or a separator to mark
the boundary between
On Fri, 26 Feb 2021 00:41:18 GMT, Jonathan Gibbons wrote:
> Please review a simple fix to ensure that a link reference is resolved and
> displayed correctly.
This pull request has now been integrated.
Changeset: fce57656
Author:Jonathan Gibbons
URL: https://git.openjdk.java.n
Please review a simple fix to ensure that a link reference is resolved and
displayed correctly.
-
Commit messages:
- JDK-8262433: doclint: reference error in module jdk.incubator.foreign
Changes: https://git.openjdk.java.net/jdk/pull/2739/files
Webrev:
On Thu, 25 Feb 2021 22:41:46 GMT, Jonathan Gibbons wrote:
> Please review a small doc fix to remove some superfluous `` tags and an
> erroneous `` tag, all reported by doclint..
This pull request has now been integrated.
Changeset: 059ede0d
Author:Jonathan Gibbons
URL:
Please review a small doc fix to remove some superfluous `` tags and an
erroneous `` tag, all reported by doclint..
-
Commit messages:
- JDK-8262428: doclint warnings in java.xml module
Changes: https://git.openjdk.java.net/jdk/pull/2733/files
Webrev:
On Fri, 8 Jan 2021 01:58:07 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 57 commits:
>>
>> - Fixing tests after a merge.
>> - Merging master into JD
On Thu, 7 Jan 2021 20:23:16 GMT, Jan Lahoda wrote:
>> This is an update to javac and javadoc, to introduce support for Preview
>> APIs, and generally improve javac and javadoc behavior to more closely
>> adhere to JEP 12.
>>
>> The notable changes are:
>>
>> * adding support for Preview
On 10/31/20 8:37 AM, Kartik Ohri wrote:
Further investigation reveals that some JavaFX specific code is also present in
the `javadoc` tool. For instance,
https://github.com/openjdk/jdk/blob/master/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseOptions.java#L90-L96
On Mon, 21 Dec 2020 14:37:57 GMT, Сергей Цыпанов
wrote:
>> I don't think so, the code is fine, for me.
>
> @forax I've sent a mail into compiler-dev list:
> http://mail.openjdk.java.net/pipermail/compiler-dev/2020-December/015857.html
>
> Let's see what they decide.
FYI, despite the
On Sun, 13 Dec 2020 00:19:59 GMT, Jonathan Gibbons wrote:
> This is for JDK16, as a precursor to fixing JDK-8258002.
>
> While it is good to be using localized strings in the generated output, the
> significance for JDK-8258002 is that the strings are now obtained from a
>
e in the file's extension, two
> makefiles are updated to accommodate the new extension: one is for the
> "interim" javadoc used to generate the API docs; the other is for the primary
> javadoc in the main JDK image.
Jonathan Gibbons has updated the pull request incrementally wi
e in the file's extension, two
> makefiles are updated to accommodate the new extension: one is for the
> "interim" javadoc used to generate the API docs; the other is for the primary
> javadoc in the main JDK image.
Jonathan Gibbons has updated the pull request incrementally wi
e in the file's extension, two
> makefiles are updated to accommodate the new extension: one is for the
> "interim" javadoc used to generate the API docs; the other is for the primary
> javadoc in the main JDK image.
Jonathan Gibbons has updated the pull request with a new target
On Mon, 14 Dec 2020 09:11:31 GMT, Hannes Wallnöfer wrote:
>> This is for JDK16, as a precursor to fixing JDK-8258002.
>>
>> While it is good to be using localized strings in the generated output, the
>> significance for JDK-8258002 is that the strings are now obtained from a
>> resource file,
This is for JDK16, as a precursor to fixing JDK-8258002.
While it is good to be using localized strings in the generated output, the
significance for JDK-8258002 is that the strings are now obtained from a
resource file, and not hardcoded in JavaScript file itself.
The source file `search.js`
On Sun, 13 Dec 2020 00:19:59 GMT, Jonathan Gibbons wrote:
> This is for JDK16, as a precursor to fixing JDK-8258002.
>
> While it is good to be using localized strings in the generated output, the
> significance for JDK-8258002 is that the strings are now obtained from a
>
On Thu, 3 Dec 2020 09:22:18 GMT, Jan Lahoda wrote:
>> Adding support for record classes in the historical data for ct.sym. This
>> includes a few changes not strictly needed for the change:
>> -updating and moving tests into test/langtools, so that it is easier to run
>> them.
>> -fixing
On Mon, 7 Dec 2020 20:30:07 GMT, Andrey Turbanov
wrote:
> 6882207: Convert javap to use diamond operator internally
Nice; thanks
-
Marked as reviewed by jjg (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1677
On Mon, 7 Dec 2020 19:38:41 GMT, Joe Darcy wrote:
>> Start of JDK 17 updates.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains eight
On Mon, 7 Dec 2020 14:27:45 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Fri, 6 Nov 2020 18:41:15 GMT, Jan Lahoda wrote:
>> This is an update to javac and javadoc, to introduce support for Preview
>> APIs, and generally improve javac and javadoc behavior to more closely
>> adhere to JEP 12.
>>
>> The notable changes are:
>>
>> * adding support for Preview
On Tue, 10 Nov 2020 17:41:28 GMT, Mandy Chung wrote:
> @ExpectedExceptions is no longer available in TestNG 7.*. Update the tests
> to use @Test(expectedExceptions = "...") instead.
Marked as reviewed by jjg (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1145
On Thu, 5 Nov 2020 12:43:03 GMT, Jan Lahoda wrote:
>> Thanks @jonathan-gibbons for your comments! I've tried to update the code
>> based on them, mostly in
>> https://github.com/lahodaj/jdk/commit/743f516c660b577035cdda4510a0bb97937fd9b2
>> and
>> https:/
On Tue, 27 Oct 2020 16:09:45 GMT, Jan Lahoda wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractExecutableMemberWriter.java
>> line 88:
>>
>>> 86:
>>> 87: @Override
>>> 88: protected Content getDeprecatedOrPreviewLink(Element member) {
>>
>>
On Fri, 16 Oct 2020 16:07:41 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK-8250768.
>> - Updating
On Mon, 2 Nov 2020 18:15:09 GMT, Jan Lahoda wrote:
>> This is an update to javac and javadoc, to introduce support for Preview
>> APIs, and generally improve javac and javadoc behavior to more closely
>> adhere to JEP 12.
>>
>> The notable changes are:
>>
>> * adding support for Preview
On Thu, 29 Oct 2020 09:26:05 GMT, Jan Lahoda wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ElementsTable.java
>> line 1288:
>>
>>> 1286: case FIELD: case INSTANCE_INIT: case LOCAL_VARIABLE:
>>> case PARAMETER:
>>> 1287: case
On Thu, 29 Oct 2020 09:43:56 GMT, Jan Lahoda wrote:
>> I don't think there should be much interaction with -source .
>> We don't support preview features from previous version or preview class
>> files from previous versions, so I think it should be enough to handle the
>> currently present
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java
line 1039:
> 1037: } else if (utils.isVariableElement(element) ||
> utils.isTypeElement(element)) {
> 1038: return getLink(new LinkInfoImpl(configuration, context,
> typeEl
On Wed, 21 Oct 2020 12:43:51 GMT, Hannes Wallnöfer wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 35 commits:
>>
>> - Merge branch 'JDK-8250768-dev' of https://github.com/lahodaj/jdk into
>> JDK-8250768
>>
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
This pull request has now been integrated.
Changeset: 0aa3c925
Author: Jonathan Gibbons
URL: https://git.openjdk.java.net/jdk/commit/0aa3c925
St
The change is (just) to remove legacy usages of a JDK-private custom tag.
-
Commit messages:
- JDK-8255262: Remove use of legacy custom @spec tag
Changes: https://git.openjdk.java.net/jdk/pull/814/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=814=00
Issue:
On Fri, 16 Oct 2020 15:20:03 GMT, Jan Lahoda wrote:
> This is an update to javac and javadoc, to introduce support for Preview
> APIs, and generally improve javac and javadoc
> behavior to more closely adhere to JEP 12.
> The notable changes are:
>
> * adding support for Preview APIs (javac
On Wed, 23 Sep 2020 14:20:12 GMT, Hannes Wallnöfer wrote:
>> This pull request is identical with the RFR previously sent for the
>> Mercurial repository:
>>
>> https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html
>>
>> I'm copy-pasting the comments from the original RFR
On Mon, 21 Sep 2020 10:47:40 GMT, Hannes Wallnöfer wrote:
>> This pull request is identical with the RFR previously sent for the
>> Mercurial repository:
>>
>> https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html
>>
>> I'm copy-pasting the comments from the original RFR
On Tue, 22 Sep 2020 17:24:19 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Merge pull request #1 from lahodaj/JDK-8216497
>>
>>Automatic
On Thu, 10 Sep 2020 12:04:48 GMT, Dmitriy Dumanskiy
wrote:
> I have in mind dozens of improvements all over the code like this one.
That sounds scary. Broad updates like these cause unnecessary churn in the
codebase, and can make merging and back
porting harder. Changes should be discussed
On 8/13/20 10:13 AM, Sean Mullan wrote:
On 8/13/20 11:05 AM, Julia Boes wrote:
Hi Vipin,
Thanks for providing this fix, I'm happy to sponsor your change. To
complete the review, we still need someone to green light the
remaining changes below. I'm looping in net-dev and security-dev to
Please review a couple of trivial fixes for a couple of issues in
java.xml, reported by doclint.
I realize we typically don't touch upstream code, but I'm hoping this is
small enough to
be reasonable.
In the first case, there is an unnecessary `` before a ``.
In the second case, there's a
Please review some fixes to address issues found by doclint.
In a couple of places, imports were required in order to resolve symbols.
In another case, the name also had a typo in it.
In the last case, the incorrect syntax was used for a type parameter in
@param.
-- Jon
JBS:
Please review this trivial fix to some minor issues reported by doclint.
In the first change, the `` contained a hangover of some HTML 4
attributes
which are not supported in HTML5. They are simply deleted.
In the second change, a paragraph just contained a comment. While it might
be
1 - 100 of 889 matches
Mail list logo
