Re: Adding SocketChannel toString to connection exception messages

2018-01-03 Thread David Lloyd
On Fri, Dec 29, 2017 at 11:15 AM, Chris Hegarty wrote: > On 29 Dec 2017, at 00:33, Steven Schlansker > wrote: >> Thanks for the discussion! >> >> So, it sounds like amending the message by default is going to be a >> non-starter -- but at

Re: Adding SocketChannel toString to connection exception messages

2018-01-03 Thread Alan Bateman
On 02/01/2018 21:25, Steven Schlansker wrote: : This would definitely be better than nothing! But it's still difficult, for example a common allocation pattern for us would be to assign networks to availability zones: 10.0.1.0/24 10.0.2.0/24 10.0.3.0/24 then if you pick the same last number

Re: Adding SocketChannel toString to connection exception messages

2018-01-02 Thread Peter Levart
Hi Steven, Steven Schlansker je 02. 01. 2018 ob 22:25 napisal: On Jan 2, 2018, at 8:35 AM, Alan Bateman wrote: On 29/12/2017 00:33, Steven Schlansker wrote: Thanks for the discussion! So, it sounds like amending the message by default is going to be a non-starter

Re: Adding SocketChannel toString to connection exception messages

2018-01-02 Thread Steven Schlansker
On Dec 31, 2017, at 7:24 AM, Peter Levart wrote: > > Hi, >> >> I believe there are concerns with too much information that can be >> considered "sensitive" (like host names and IP addresses) appearing in error >> messages due to them ending up in log files and bug

Re: Adding SocketChannel toString to connection exception messages

2018-01-02 Thread Alan Bateman
On 29/12/2017 00:33, Steven Schlansker wrote: Thanks for the discussion! So, it sounds like amending the message by default is going to be a non-starter -- but at least adding the information otherwise might be possible. There are examples in other area where exceptions include detail

Re: Adding SocketChannel toString to connection exception messages

2017-12-31 Thread Peter Levart
Hi, David Holmes je 22. 12. 2017 ob 01:35 napisal: On 22/12/2017 10:29 AM, Steven Schlansker wrote: On Dec 21, 2017, at 11:11 AM, Steven Schlansker wrote: What if ConnectException included the attempted hostname / IP / port SocketAddress?

Re: Adding SocketChannel toString to connection exception messages

2017-12-29 Thread Chris Hegarty
___ >> From: net-dev <net-dev-boun...@openjdk.java.net> on behalf of Chris Hegarty >> <chris.hega...@oracle.com> >> Sent: Friday, December 22, 2017 4:17:31 PM >> To: Seán Coffey; David Holmes; Steven Schlansker >> Cc: core-libs-dev; net-...@openjd

Re: Adding SocketChannel toString to connection exception messages

2017-12-28 Thread Steven Schlansker
Holmes; Steven Schlansker > Cc: core-libs-dev; net-...@openjdk.java.net > Subject: Re: Adding SocketChannel toString to connection exception messages > > > On 22/12/17 14:59, Seán Coffey wrote: >> As someone who works with alot of log files, I'd like to chime in and >>

Re: Adding SocketChannel toString to connection exception messages

2017-12-22 Thread Bernd Eckenfels
ibs-dev; net-...@openjdk.java.net Subject: Re: Adding SocketChannel toString to connection exception messages On 22/12/17 14:59, Seán Coffey wrote: > As someone who works with alot of log files, I'd like to chime in and > support Steven's end goal. Looking at a "Connection refused" error i

Re: Adding SocketChannel toString to connection exception messages

2017-12-22 Thread Remi Forax
at.com> > À: "David Holmes" <david.hol...@oracle.com> > Cc: "core-libs-dev" <core-libs-dev@openjdk.java.net> > Envoyé: Vendredi 22 Décembre 2017 16:22:41 > Objet: Re: Adding SocketChannel toString to connection exception messages > On Thu, Dec 21,

Re: Adding SocketChannel toString to connection exception messages

2017-12-22 Thread David Lloyd
On Thu, Dec 21, 2017 at 6:35 PM, David Holmes wrote: > I believe there are concerns with too much information that can be > considered "sensitive" (like host names and IP addresses) appearing in error > messages due to them ending up in log files and bug reports. I tend

Re: Adding SocketChannel toString to connection exception messages

2017-12-22 Thread Chris Hegarty
On 22/12/17 14:59, Seán Coffey wrote: As someone who works with alot of log files, I'd like to chime in and support Steven's end goal. Looking at a "Connection refused" error in the middle of a log file that possibly extends to millions of lines is near useless. In the era of cloud compute,

Re: Adding SocketChannel toString to connection exception messages

2017-12-22 Thread Seán Coffey
As someone who works with alot of log files, I'd like to chime in and support Steven's end goal. Looking at a "Connection refused" error in the middle of a log file that possibly extends to millions of lines is near useless. In the era of cloud compute, diagnosing network issues is sure to

Re: Adding SocketChannel toString to connection exception messages

2017-12-22 Thread Chris Hegarty
On 22/12/17 01:27, David Holmes wrote: cc'ing net-dev as that might be the more appropriate list. On 22/12/2017 10:59 AM, Steven Schlansker wrote: On Dec 21, 2017, at 4:35 PM, David Holmes wrote: On 22/12/2017 10:29 AM, Steven Schlansker wrote: On Dec 21, 2017, at

Re: Adding SocketChannel toString to connection exception messages

2017-12-21 Thread David Holmes
cc'ing net-dev as that might be the more appropriate list. On 22/12/2017 10:59 AM, Steven Schlansker wrote: On Dec 21, 2017, at 4:35 PM, David Holmes wrote: On 22/12/2017 10:29 AM, Steven Schlansker wrote: On Dec 21, 2017, at 11:11 AM, Steven Schlansker

Re: Adding SocketChannel toString to connection exception messages

2017-12-21 Thread Steven Schlansker
> On Dec 21, 2017, at 4:35 PM, David Holmes wrote: > > On 22/12/2017 10:29 AM, Steven Schlansker wrote: >>> On Dec 21, 2017, at 11:11 AM, Steven Schlansker >>> wrote: >>> >>> What if ConnectException included the attempted hostname / IP /

Re: Adding SocketChannel toString to connection exception messages

2017-12-21 Thread David Holmes
On 22/12/2017 10:29 AM, Steven Schlansker wrote: On Dec 21, 2017, at 11:11 AM, Steven Schlansker wrote: What if ConnectException included the attempted hostname / IP / port SocketAddress? java.net.ConnectException: Connection to 'foo.mycorp.com[10.x.x.x]:12345'

Re: Adding SocketChannel toString to connection exception messages

2017-12-21 Thread Steven Schlansker
> On Dec 21, 2017, at 11:11 AM, Steven Schlansker > wrote: > > What if ConnectException included the attempted hostname / IP / port > SocketAddress? > java.net.ConnectException: Connection to 'foo.mycorp.com[10.x.x.x]:12345' > refused > Much more useful! This

Adding SocketChannel toString to connection exception messages

2017-12-21 Thread Steven Schlansker
Hi core-libs-dev, While tracking down a connectivity issue, we identified that two of our hosts are unable to talk to each other due to a misconfiguration of the network. This manifested as: 2017-12-21T11:00:34.840Z DEBUG <> [default-pool-34] o.e.j.client.AbstractConnectionPool - Connection