Hi Joe, all,
the logic looks good to me.
In the tests I'm wondering whether to include an annotated wildcard
bound. There is:
307 public @AnnotType(11) Set<@AnnotType(13) ? extends Number>
fooNumberSet2() {return null;}
but nothing like
Set fooNumberSet2() {return null;}
I wouldn't
Hi Werner,
On 10/10/2018 1:23 PM, Werner Dietl wrote:
Hi Joe, all,
the logic looks good to me.
In the tests I'm wondering whether to include an annotated wildcard
bound. There is:
307 public @AnnotType(11) Set<@AnnotType(13) ? extends Number>
fooNumberSet2() {return null;}
but
Hej Joe,
New version looks good!
Thanks for the explanations, makes sense to me.
Cheers
/Joel
On Wed, 10 Oct 2018 at 08:27, joe darcy wrote:
> Hi Joel,
>
> Thanks for the review; slightly revised version at
>
> http://cr.openjdk.java.net/~darcy/8058202.3/
>
> Comments below.
>
>
> On
Hi Joel,
Thanks for the review; slightly revised version at
http://cr.openjdk.java.net/~darcy/8058202.3/
Comments below.
On 10/9/2018 11:00 AM, Joel Borggrén-Franck wrote:
Hi Joe,
Good to see this happening. In general looks good to me, a few nits below.
AnnotatedTypeBaseImpl contains
Hi Joe,
Good to see this happening. In general looks good to me, a few nits below.
AnnotatedTypeBaseImpl contains comments indicating from which
superclass or interface the overridden methods comes. I'd either add
// Object at line 207 or delete line 145 and 177 for consistency.
Even though
Hello,
Please review the changes to address:
JDK-8058202 : AnnotatedType implementations don't override
toString(), equals(), hashCode()
http://cr.openjdk.java.net/~darcy/8058202.2/
Some discussion and explanation of the changes:
The java.lang.reflect.AnnotatedType interface
