+1
On 7/9/19 9:07 AM, naoto.s...@oracle.com wrote:
Looks good, Ramanand.
Naoto
On 7/9/19 5:09 AM, Ramanand Patil wrote:
Hi Naoto,
Thank you for the review. Revised webrev:
http://cr.openjdk.java.net/~rpatil/8224560/webrev.02/
I plan to push the changes tomorrow, if there are no further
Looks good, Ramanand.
Naoto
On 7/9/19 5:09 AM, Ramanand Patil wrote:
Hi Naoto,
Thank you for the review. Revised webrev:
http://cr.openjdk.java.net/~rpatil/8224560/webrev.02/
I plan to push the changes tomorrow, if there are no further comments.
Regards,
Ramanand.
-Original
Hi Naoto,
Thank you for the review. Revised webrev:
http://cr.openjdk.java.net/~rpatil/8224560/webrev.02/
I plan to push the changes tomorrow, if there are no further comments.
Regards,
Ramanand.
> -Original Message-
> From: Naoto Sato
> Sent: Monday, July 8, 2019 11:19 PM
> To:
Hi Ramanand,
As to the change in ZoneInfoFile.java, I would put that special handling
of Gaza/Hebron in line 577, as well as merging the comment in 575,576,
so that it won't duplicate the code.
Otherwise looks good.
Naoto
On 7/8/19 3:35 AM, Ramanand Patil wrote:
Hi Andrew,
Thank you for
Hi Andrew,
Thank you for your review.
Updated webrev: http://cr.openjdk.java.net/~rpatil/8224560/webrev.01/
Regards,
Ramanand.
> -Original Message-
> From: Andrew John Hughes
> Sent: Saturday, July 6, 2019 9:53 PM
> To: Ramanand Patil ; core-libs-
> d...@openjdk.java.net;
On 05/07/2019 15:16, Ramanand Patil wrote:
> Hi all,
> Please review the patch for tzdata2019a integration into jdk project.
> Webrev: http://cr.openjdk.java.net/~rpatil/8224560/webrev.00/
> Bugs: https://bugs.openjdk.java.net/browse/JDK-8224560
>