RE: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633

2019-03-26 Thread Langer, Christoph
Hi Deepak, > Thanks for review. I think Naoto and Ramanand are right, we do update the > copyright year when it is not a clean backport. Please find the updated > version of webrev. > > http://cr.openjdk.java.net/~rpatil/8042131_8210633/webrev.01/ Ok, you are right... Still wondering, whether

Re: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633

2019-03-25 Thread Naoto Sato
/8042131_8210633/webrev.01/ Regards, Deepak -Original Message- From: Ramanand Patil Sent: Monday, March 25, 2019 3:54 PM To: Langer, Christoph ; Deepak Kejriwal Cc: Naoto Sato ; core-libs-dev ; jdk8u-...@openjdk.java.net Subject: RE: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633 Hi

RE: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633

2019-03-25 Thread Deepak Kejriwal
- From: Ramanand Patil Sent: Monday, March 25, 2019 3:54 PM To: Langer, Christoph ; Deepak Kejriwal Cc: Naoto Sato ; core-libs-dev ; jdk8u-...@openjdk.java.net Subject: RE: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633 Hi Christoph, I have suggested the changes considering the fact

RE: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633

2019-03-25 Thread Ramanand Patil
. > -Original Message- > From: Langer, Christoph > Sent: Monday, March 25, 2019 12:42 PM > To: Deepak Kejriwal > Cc: Ramanand Patil ; Naoto Sato > ; core-libs-dev ; > jdk8u-...@openjdk.java.net > Subject: RE: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633 &

RE: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633

2019-03-25 Thread Langer, Christoph
z 2019 07:38 > To: Deepak Kejriwal ; Naoto Sato > ; core-libs-dev ; > jdk8u-...@openjdk.java.net > Subject: RE: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633 > > Hi Deepak, > > In particular, the test TestDateTimeFormatterBuilderWithLocale.java should > have only one copyri

RE: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633

2019-03-25 Thread Ramanand Patil
for JDK 8 Updates Project. Regards, Ramanand. > -Original Message- > From: Deepak Kejriwal > Sent: Monday, March 25, 2019 10:11 AM > To: Naoto Sato ; core-libs-dev d...@openjdk.java.net>; jdk8u-...@openjdk.java.net > Subject: RE: RFR: JDK8U Backport of JDK-8042131 and J

RE: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633

2019-03-24 Thread Deepak Kejriwal
Hi Naoto, Thanks for review. I will update the copyright information and push the changes. Regards, Deepak -Original Message- From: Naoto Sato Sent: Friday, March 22, 2019 10:59 PM To: Deepak Kejriwal ; core-libs-dev ; jdk8u-...@openjdk.java.net Subject: Re: RFR: JDK8U Backport

Re: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633

2019-03-22 Thread naoto . sato
Hi Deepak, Please modify the copyright year accordingly. Otherwise it looks good to me. Naoto On 3/22/19 8:51 AM, Deepak Kejriwal wrote: Hi All, Please review the back port of fix for JDK-8042131 and JDK-8210633 to 8u-dev:- JBS report: