Re: RFR(M) : 8211171 : move JarUtils to top-level testlibrary

Hi Roger, that's true, but due to layout of tests in jtreg test suites, it requires special configurations and still doesn't work in all cases. with that being said, in case of JarUtils methods, it should work fine. -- Igor > On Oct 11, 2018, at 12:14 PM, Roger Riggs wrote: > > Hi Igor, >

Re: RFR(M) : 8211171 : move JarUtils to top-level testlibrary

Hi Igor, The IDEs including IntelliJ can pretty easily search for usages of various methods whereever they occur in the source tree. And they can do the refactoring as well. $.02, Roger On 10/11/2018 02:55 PM, Igor Ignatyev wrote: Hi Max, we do have a plan to remove these deprecated

Re: RFR(M) : 8211171 : move JarUtils to top-level testlibrary

Hi Max, we do have a plan to remove these deprecated methods as part of 8211289[1]. I don't know if there a flag which you can use to get all classes which use deprecated methods. you can however analyze source or bytecode of tests, to see if they have dependency on these methods, but again I

Re: RFR(M) : 8211171 : move JarUtils to top-level testlibrary

Do we have a plan to move away from the deprecated methods? Is there a flag I can set to check how many classes are using them? --Max > On Sep 30, 2018, at 11:00 PM, Alan Bateman wrote: > > On 27/09/2018 00:38, Igor Ignatyev wrote: >> here is the webrevs w/ JarUtils from default package

Re: RFR(M) : 8211171 : move JarUtils to top-level testlibrary

Hi Alan, thanks for your review! -- Igor > On Sep 30, 2018, at 8:00 AM, Alan Bateman wrote: > > On 27/09/2018 00:38, Igor Ignatyev wrote: >> here is the webrevs w/ JarUtils from default package inserted into >> jdk.test.lib.util.JarUtils: >> whole patch: >>

Re: RFR(M) : 8211171 : move JarUtils to top-level testlibrary

On 27/09/2018 00:38, Igor Ignatyev wrote: here is the webrevs w/ JarUtils from default package inserted into jdk.test.lib.util.JarUtils: whole patch: http://cr.openjdk.java.net/~iignatyev//8211171/webrev.01/index.html 655

Re: RFR(M) : 8211171 : move JarUtils to top-level testlibrary

here is the webrevs w/ JarUtils from default package inserted into jdk.test.lib.util.JarUtils: whole patch: http://cr.openjdk.java.net/~iignatyev//8211171/webrev.01/index.html > 655 lines changed: 239 ins; 355 del; 61 mod;

Re: RFR(M) : 8211171 : move JarUtils to top-level testlibrary

Hi Alan, it appears that I have to put into a named package as the jaxp test which uses it is in a named package. although I don't want to group simple moving and more sophisticated test conversion for the sake of reviewers, also there is another "duplicate" of JarUtils in

Re: RFR(M) : 8211171 : move JarUtils to top-level testlibrary

On 26/09/2018 19:16, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8211171/webrev.00/index.html Looks good but maybe it should be put into a named package (see below). : please note, there is another version of JarUtils in jdk.test.lib.util package, but these two versions

RFR(M) : 8211171 : move JarUtils to top-level testlibrary

http://cr.openjdk.java.net/~iignatyev//8211171/webrev.00/index.html > 182 lines changed: 0 ins; 152 del; 30 mod; Hi all, could you please review this small and straightforward patch which moves JarUtils from jdk testlibrary to the top-level testlibrary, removes JarUtils from jaxp testlibrary,