I would prefer that JCE1.2 be pulled out completely in the Cipher*
classes. I will be sending you a separate note about JCE logistics.
Thanks for doing this cleanup.
Brad
On 6/20/2014 11:46 AM, Henry Jen wrote:
Hi,
Please review a trivial webrev to add JDK version to @since in a format
as
OK, I'll remove all @since JCE line, as the class already has @since 1.4
as Joe pointed out earlier.
Uodated webrev at
http://cr.openjdk.java.net/~henryjen/jdk9/8047721/2/webrev/
Cheers,
Henry
On 06/23/2014 10:04 AM, Bradford Wetmore wrote:
I would prefer that JCE1.2 be pulled out
Looks good to me; thanks,
-Joe
On 06/23/2014 01:50 PM, Henry Jen wrote:
OK, I'll remove all @since JCE line, as the class already has @since
1.4 as Joe pointed out earlier.
Uodated webrev at
http://cr.openjdk.java.net/~henryjen/jdk9/8047721/2/webrev/
Cheers,
Henry
On 06/23/2014 10:04 AM,
JCE (Cipher) changes look good to me.
Let me know if there's any problem with the point I mentioned in the
other email.
Brad
On 6/23/2014 1:50 PM, Henry Jen wrote:
OK, I'll remove all @since JCE line, as the class already has @since 1.4
as Joe pointed out earlier.
Uodated webrev at
What's the rationale for removing the secondary version? Or I guess the
question should really be: when are secondary versions useful? At least in
the EE specs, the EE version plus the spec version are listed in many
places like this.
Cheers,
Paul
On Mon, Jun 23, 2014 at 3:50 PM, Henry Jen
Except for these two classes, none of the JCE APIs ever contained @since
until the JCE was put into JDK 1.4 back in 2002. The unbundled JCE
hasn't been shipped in probably almost a decade. None of the unbundled
JSSE/JGSS should have them either.
Carrying around this old information is just
Hi,
Please review a trivial webrev to add JDK version to @since in a format
as Mark suggested[1].
http://cr.openjdk.java.net/~henryjen/jdk9/8047721/0/webrev/
[1] http://mail.openjdk.java.net/pipermail/jdk9-dev/2014-June/000806.html
Appened is the diff as in the webrev.
Cheers,
Henry
diff
Henry,
I think JCE1.2 should get the space to be JCE 1.2 so it matches other
secondary versions like JNDI 1.1 (last part of your patch). Or, you could
make that another cleanup in itself.
Cheers,
Paul
You are absolutely right, I should have fixed it as I did for the rest.
Updated webrev can be found at
http://cr.openjdk.java.net/~henryjen/jdk9/8047721/1/webrev/
Cheers,
Henry
On 06/20/2014 01:01 PM, Paul Benedict wrote:
Henry,
I think JCE1.2 should get the space to be JCE 1.2 so it
I assume the reason to have those @since JCE tag is somehow we want to
distinguish those APIs from the rest, thus I chose to preserve them.
If we agree it's not worth to keep, I can remove them.
Cheers,
Henry
On 06/20/2014 01:25 PM, Joe Darcy wrote:
Hi Henry,
For the Cipher{Input,
10 matches
Mail list logo
