Re: RFR: 8182992 Typo in DatagramPacket constructor API doc

2019-01-04 Thread Roger Calnan
d a couple more. I’ll file a bug to get them fixed, Thanks, Roger > From: Lance Andersen > Subject: Re: RFR: 8182992 Typo in DatagramPacket constructor API doc > Date: January 3, 2019 at 9:53:07 AM PST > To: Roger Calnan > Cc: core-libs-dev@openjdk.java.net >

Re: RFR: 8182992 Typo in DatagramPacket constructor API doc

2019-01-03 Thread Lance Andersen
Hi Roger, Please see below. I am not sure how much review the javadocs have gotten for the com/sun/rowset/internal classes > > > > JDK-8215911 Various Typos in SQL Method Documentation > https://bugs.openjdk.java.net/browse/JDK-8215911 >

Re: RFR: 8182992 Typo in DatagramPacket constructor API doc

2019-01-03 Thread Daniel Fuchs
Hi Roger, On 03/01/2019 17:51, Roger Calnan wrote: + * suitable for retrieving large{@code LONGVARCHAR} values. The JDBC driver will I believe there's still a space missing after `large` in the line above. best regards, -- daniel

Re: RFR: 8182992 Typo in DatagramPacket constructor API doc

2019-01-03 Thread Seán Coffey
Looks fine to me. We can update the bug summary to make it more general to affected classes. I can help sponsor this change if required. regards, Sean. On 03/01/2019 16:51, Roger Calnan wrote: I was looking at the fix for: https://bugs.openjdk.java.net/browse/JDK-8182992 Typo in

RFR: 8182992 Typo in DatagramPacket constructor API doc

2019-01-03 Thread Roger Calnan
I was looking at the fix for: https://bugs.openjdk.java.net/browse/JDK-8182992 Typo in DatagramPacket constructor API doc and searched around for other similar issues. I found: 4 in networking 2 in SQL 2 in client libs all of which are cases of missing spaces. I will ask for review