subject:"RFR\: 8249694 \- \[TestBug\] java\/lang\/StringBuffer\/HugeCapacity.java and j\/l\/StringBuilder\/HugeCapacity.java tests shouldn't be @ignore\-d"

Re: RFR: 8249694 - [TestBug] java/lang/StringBuffer/HugeCapacity.java and j/l/StringBuilder/HugeCapacity.java tests shouldn't be @ignore-d

2020-09-03 Thread Seán Coffey

Looks fine to me. regards, Sean. On 03/09/2020 11:40, Fernando Guallini wrote: Hi Sean, Right, it also applies for these tests, changes: --- a/test/jdk/java/lang/StringBuffer/HugeCapacity.java +++ b/test/jdk/java/lang/StringBuffer/HugeCapacity.java - * @requires os.maxMemory >= 6G + *

Re: RFR: 8249694 - [TestBug] java/lang/StringBuffer/HugeCapacity.java and j/l/StringBuilder/HugeCapacity.java tests shouldn't be @ignore-d

2020-09-03 Thread Fernando Guallini

Hi Sean, Right, it also applies for these tests, changes: --- a/test/jdk/java/lang/StringBuffer/HugeCapacity.java +++ b/test/jdk/java/lang/StringBuffer/HugeCapacity.java - * @requires os.maxMemory >= 6G + * @requires (sun.arch.data.model == "64" & os.maxMemory >= 6G) ---

Re: RFR: 8249694 - [TestBug] java/lang/StringBuffer/HugeCapacity.java and j/l/StringBuilder/HugeCapacity.java tests shouldn't be @ignore-d

2020-09-01 Thread Seán Coffey

Wouldn't you require the sun.arch.data.model == "64" jtreg config in these tests also ? regards, Sean. On 28/08/2020 19:13, Fernando Guallini wrote: Hi, May I please get reviews and a sponsor for this trivial change: webrev: http://cr.openjdk.java.net/~fguallini/8249694/webrev.00/

RFR: 8249694 - [TestBug] java/lang/StringBuffer/HugeCapacity.java and j/l/StringBuilder/HugeCapacity.java tests shouldn't be @ignore-d

2020-08-28 Thread Fernando Guallini

Hi, May I please get reviews and a sponsor for this trivial change: webrev: http://cr.openjdk.java.net/~fguallini/8249694/webrev.00/ Testbug: https://bugs.openjdk.java.net/browse/JDK-8249694 Tests do not need to have ‘@ignore' because with @requires os.maxMemory is enough to