On Thu, 12 May 2022 04:06:44 GMT, David Holmes wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @AlanBateman comments - remove thros IllegalArgumentException clause
>
> Nice cleanup! I checked back in JDK 7 and couldn't
On Thu, 12 May 2022 14:08:11 GMT, Alan Bateman wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @AlanBateman comments - remove thros IllegalArgumentException clause
>
>
> The API `jdk.internal.perf.Perf.::attach(String user, int lvmid)` is never
> used. It should be removed, and all the handling of a specified user name
> should be removed.
Ioi Lam has updated the pull request incrementally with one additional commit
since the last revision:
@AlanBateman
On Wed, 11 May 2022 23:08:32 GMT, Ioi Lam wrote:
> The API `jdk.internal.perf.Perf.::attach(String user, int lvmid)` is never
> used. It should be removed, and all the handling of a specified user name
> should be removed.
Marked as reviewed by alanb (Reviewer).
On Wed, 11 May 2022 23:08:32 GMT, Ioi Lam wrote:
> The API `jdk.internal.perf.Perf.::attach(String user, int lvmid)` is never
> used. It should be removed, and all the handling of a specified user name
> should be removed.
Nice cleanup! I checked back in JDK 7 and couldn't find any use of
The API `jdk.internal.perf.Perf.::attach(String user, int lvmid)` is never
used. It should be removed, and all the handling of a specified user name
should be removed.
-
Commit messages:
- more cleanup
- 8286560: Remove user parameter from jdk.internal.perf.Perf.attach()