Re: RFR: JDK-8046565: Platform Logger API and Service

(sorry for the delay. I realized just now that my reply is not sent … sigh) > On Oct 20, 2015, at 2:48 PM, Daniel Fuchs wrote: > > Hi Mandy, > > As we discussed I have also made LogManager.demandLoggerFor > package protected. As a result I also reverted the changes >

Re: RFR: JDK-8046565: Platform Logger API and Service

> On Oct 20, 2015, at 8:44 AM, Daniel Fuchs wrote: > > Hi Mandy, > > All feedback integrated - except those discussed below. Thanks. > > public URL content has been refreshed: > http://cr.openjdk.java.net/~dfuchs/8046565/proto.02/webrev/index.html >

Re: RFR: JDK-8046565: Platform Logger API and Service

> On Oct 19, 2015, at 11:18 AM, Daniel Fuchs wrote: > > webrev: > http://cr.openjdk.java.net/~dfuchs/8046565/proto.02/webrev/index.html Looks good in general. Some minor comments: Good to see limited privileges being used that limits the permissions when invoking

Re: RFR: JDK-8046565: Platform Logger API and Service

Hi Mandy, All feedback integrated - except those discussed below. public URL content has been refreshed: http://cr.openjdk.java.net/~dfuchs/8046565/proto.02/webrev/index.html http://cr.openjdk.java.net/~dfuchs/8046565/proto.02/specdiff-api/overview-summary.html sandbox branch

Re: RFR: JDK-8046565: Platform Logger API and Service

Hi Mandy, As we discussed I have also made LogManager.demandLoggerFor package protected. As a result I also reverted the changes to LoggingPermission - there's no reason for exposing a LoggingPermission("demandLogger", null) if LogManager.demandLoggerFor is no longer visible. I have refreshed

Re: RFR: JDK-8046565: Platform Logger API and Service

Hi Mandy, I have updated the links with the modifications we discussed last Friday: - I have removed the tag @apiNote from System.LoggerFinder - I have relaxed the constraint of what happens if several implementations of LoggerFinder are present - the specification no longer mandate

Re: RFR: JDK-8046565: Platform Logger API and Service

> On Oct 16, 2015, at 4:16 AM, Stephen Colebourne wrote: > > On 15 October 2015 at 17:31, Daniel Fuchs wrote: >>> I have a major concern that the class names 'Logger' and 'Level' >>> duplicate those of java.util.logging. While they are inner

Re: RFR: JDK-8046565: Platform Logger API and Service

On 15 October 2015 at 17:31, Daniel Fuchs wrote: >> I have a major concern that the class names 'Logger' and 'Level' >> duplicate those of java.util.logging. While they are inner classes as >> opposed to top level classes, both IntelliJ and Eclipse will find the >> inner

Re: RFR: JDK-8046565: Platform Logger API and Service

Hi Mandy, I have integrated most of your comments and updated the api specdiff and webrev (new links), and also pushed the corresponding changes to the sandbox. Thanks for working with me on the API doc! specdiff:

Re: RFR: JDK-8046565: Platform Logger API and Service

On 14 October 2015 at 12:20, Daniel Fuchs wrote: > On 14/10/15 07:21, Mandy Chung wrote: >> Several log methods throws NPE if the level is legible and the parameter >> is null. E.g. >> * @throws NullPointerException if {@code level} is {@code null}, or if the >> level >>

Re: RFR: JDK-8046565: Platform Logger API and Service

Hi Stephen, On 15/10/15 12:48, Stephen Colebourne wrote: On 14 October 2015 at 12:20, Daniel Fuchs wrote: On 14/10/15 07:21, Mandy Chung wrote: Several log methods throws NPE if the level is legible and the parameter is null. E.g. * @throws NullPointerException if

Re: RFR: JDK-8046565: Platform Logger API and Service

> On Oct 14, 2015, at 4:20 AM, Daniel Fuchs wrote: > > Hi Mandy, > > On 14/10/15 07:21, Mandy Chung wrote: >> >>> On Oct 8, 2015, at 5:26 AM, Daniel Fuchs wrote: >>> >>> webrev: >>>

Re: RFR: JDK-8046565: Platform Logger API and Service

On 14/10/15 18:13, Mandy Chung wrote: There are other methods having similar @throws that should be updated as well. Yes - sorry - I meant I would do it for the method that takes Object as well. When I started working on this I added a new LoggerPermission class similar to

Re: RFR: JDK-8046565: Platform Logger API and Service

Addiitional comments: JdkLoggerProvider.java - should the GC’ed referent entries in the application SharedLoggers map be occasionally drained? BootstrapLogger.java In the BootstrapExecutors::join(Runnable r) method: try { getExecutor().submit(r).get(); } catch

Re: RFR: JDK-8046565: Platform Logger API and Service

Hi Mandy, On 14/10/15 07:21, Mandy Chung wrote: On Oct 8, 2015, at 5:26 AM, Daniel Fuchs wrote: webrev: http://cr.openjdk.java.net/~dfuchs/8046565/proto.01/webrev.01/ System.Logger Several log methods throws NPE if the level is legible and the parameter is null.

Re: RFR: JDK-8046565: Platform Logger API and Service

> On Oct 8, 2015, at 5:26 AM, Daniel Fuchs wrote: > > webrev: > http://cr.openjdk.java.net/~dfuchs/8046565/proto.01/webrev.01/ System.Logger Several log methods throws NPE if the level is legible and the parameter is null. E.g. * @throws NullPointerException if

RFR: JDK-8046565: Platform Logger API and Service

Hi, Please find below the webrev for a first prototype of JEP 264 - Platform Logger API and Service. JEP: http://openjdk.java.net/jeps/264 https://bugs.openjdk.java.net/browse/JDK-8046565 specdiff: http://cr.openjdk.java.net/~dfuchs/8046565/proto.01/specdiff-api/overview-summary.html webrev: